Convert ImageReviewableView and RegionCommentBlockView to ES6.
Review Request #8214 — Created June 3, 2016 and submitted — Latest diff uploaded
This change does the basic conversion (let/const, member function sugar, fix up
and add documentation comments), but also consolidates the code a bit to remove
extra helper functions that were only called from one place and didn't help
structure the code any better.This is in preparation for the high-DPI image review feature.
- Ran unit tests.
- Used in conjunction with other changes.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.
orig
1
2
3
| reviewboard/staticbundles.py | ||
| reviewboard/static/rb/js/views/imageReviewableView.es6.js Was reviewboard/static/rb/js/views/imageReviewableView.js | ||
| reviewboard/static/rb/js/views/regionCommentBlockView.js | Deleted | |
| reviewboard/static/rb/js/views/regionCommentBlockView.es6.js |
| reviewboard/staticbundles.py |
|---|
| reviewboard/static/rb/js/views/imageReviewableView.js |
|---|
| reviewboard/static/rb/js/views/regionCommentBlockView.js |
|---|
| reviewboard/static/rb/js/views/regionCommentBlockView.es6.js |
|---|