Summary

Convert ImageReviewableView and RegionCommentBlockView to ES6.

Review Request #8214 — Created June 3, 2016 and submitted June 10, 2016, 11:34 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Blocks

8216, 8215

Commit

870eca9...

Reviewers

Groups

reviewboard

People

Description

This change does the basic conversion (let/const, member function sugar, fix up

and add documentation comments), but also consolidates the code a bit to remove

extra helper functions that were only called from one place and didn't help

structure the code any better.
This is in preparation for the high-DPI image review feature.

Testing Done


Ran unit tests.
Used in conjunction with other changes.

Issues

Description	From	Last Updated
Can we rename this to percentage?	brennie	June 9, 2016, 1:57 p.m.
This should maybe indicate the range is inclusive.	brennie	June 9, 2016, 1:58 p.m.
Should indicate range is inclusive.	brennie	June 9, 2016, 1:58 p.m.
Can we rename this to setSplitPercentage(percentage) ?	brennie	June 9, 2016, 1:57 p.m.
I would find ../${revisionTip}/ more readable here.	brennie	June 9, 2016, 1:58 p.m.
Likewise with ../${revisionBase}-${revisionTip}/	brennie	June 9, 2016, 1:58 p.m.
Blank line	brennie	June 9, 2016, 1:58 p.m.
This can be a single line.	brennie	June 9, 2016, 1:59 p.m.
The { and } are unnecessary.	brennie	June 9, 2016, 3:32 p.m.
Grammar?	brennie	June 9, 2016, 1:59 p.m.
No comma.	brennie	June 9, 2016, 1:59 p.m.
Can we reword this as: If not, the event was actually a ``click`` event and we call the superclass' click …	brennie	June 9, 2016, 2 p.m.
``true`` over "yes" ``click``	brennie	June 9, 2016, 2 p.m.
``e.target``	brennie	June 10, 2016, 9:33 a.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/regionCommentBlockView.js
    reviewboard/static/rb/js/views/imageReviewableView.es6.js
    reviewboard/static/rb/js/views/regionCommentBlockView.es6.js



Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/regionCommentBlockView.js
    reviewboard/static/rb/js/views/imageReviewableView.es6.js
    reviewboard/static/rb/js/views/regionCommentBlockView.es6.js

reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we rename this to percentage?
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
This should maybe indicate the range is inclusive.
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Should indicate range is inclusive.
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we rename this to setSplitPercentage(percentage) ?
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
I would find ../${revisionTip}/ more readable here.
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Likewise with ../${revisionBase}-${revisionTip}/
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line
```
reviewboard/static/rb/js/views/regionCommentBlockView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be a single line.
```
reviewboard/static/rb/js/views/regionCommentBlockView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Grammar?
```
reviewboard/static/rb/js/views/regionCommentBlockView.es6.js (Diff revision 1)
The issue has been dropped. Show all issues
```
No comma.
```
1. david June 9, 2016, 2 p.m.
  I disagree.

reviewboard/static/rb/js/views/regionCommentBlockView.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Can we reword this as:

If not, the event was actually a ``click`` event and we call the superclass' click handler.

reviewboard/static/rb/js/views/regionCommentBlockView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
``true`` over "yes"

``click``
```

Commit:

4016cbc5161823b1d8a1ba62686e16736a5a8745

dea5dd63871cc1915e1484d5a6e6304aa5c88ec0

Diff:

Revision 2 (+619 -615)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/views/imageReviewableView.js
	reviewboard/static/rb/js/views/regionCommentBlockView.js
	reviewboard/static/rb/js/views/regionCommentBlockView.es6.js

Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/regionCommentBlockView.js
    reviewboard/static/rb/js/views/imageReviewableView.es6.js
    reviewboard/static/rb/js/views/regionCommentBlockView.es6.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/regionCommentBlockView.js
    reviewboard/static/rb/js/views/imageReviewableView.es6.js
    reviewboard/static/rb/js/views/regionCommentBlockView.es6.js

Ship it!

reviewboard/static/rb/js/views/regionCommentBlockView.es6.js (Diff revisions 1 - 2)

The issue has been dropped. Show all issues

The { and } are unnecessary.

david June 9, 2016, 3:32 p.m.

They are, but when doing assigns inside of a fat arrow function I think it makes it more readable (and I believe Christian feels the same way).

reviewboard/static/rb/js/views/regionCommentBlockView.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
``e.target``
```

Commit:

dea5dd63871cc1915e1484d5a6e6304aa5c88ec0

870eca925257151e2d617952879b5f0d0b465eab

Diff:

Revision 3 (+619 -615)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/views/imageReviewableView.js
	reviewboard/static/rb/js/views/regionCommentBlockView.js
	reviewboard/static/rb/js/views/regionCommentBlockView.es6.js

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/regionCommentBlockView.js
    reviewboard/static/rb/js/views/imageReviewableView.es6.js
    reviewboard/static/rb/js/views/regionCommentBlockView.es6.js



Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/regionCommentBlockView.js
    reviewboard/static/rb/js/views/imageReviewableView.es6.js
    reviewboard/static/rb/js/views/regionCommentBlockView.es6.js

Status:: Completed
Change Summary:: Pushed to release-3.0.x (103579e)