Summary

Show a help link for accessing private GitHub org repositories

Review Request #8208 — Created June 1, 2016 and submitted June 7, 2016, 4:23 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

ec579e6...

Reviewers

Groups

reviewboard

People

Description

When a private organization repository cannot be linked, we know show a

help link to a knowledge base article on how to add access permissions

to the repository.
To facilitate this, HostingServiceErrors now accept a help link, which

will render in the repository form with the message and a HTML link to

the URL.

Testing Done


Ran unit tests.
Attempted to add a private organization repository that does not exist

  and got a message with the link.

Files

Issues

Description	From	Last Updated
Just saying "Help" is a little curt. Maybe something like "See help on granting access"?	david	June 2, 2016, 2:41 p.m.
I still think we should have some kind of verb in here on the link. "See how to grant access" …	david	June 6, 2016, 3:05 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/errors.py
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/forms.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/errors.py
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/forms.py

reviewboard/scmtools/forms.py (Diff revision 1)

The issue has been resolved. Show all issues

Just saying "Help" is a little curt. Maybe something like "See help on granting access"?

Change Summary:

Include help link text in error messages

Diff:

Revision 2 (+22 -2)

Show changes

	reviewboard/hostingsvcs/errors.py
	reviewboard/hostingsvcs/github.py
	reviewboard/scmtools/forms.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/errors.py
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/forms.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/errors.py
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/forms.py

Diff:

Revision 3 (+22 -2)

Show changes

	reviewboard/hostingsvcs/errors.py
	reviewboard/hostingsvcs/github.py
	reviewboard/scmtools/forms.py

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/errors.py
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/forms.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/errors.py
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/forms.py

reviewboard/hostingsvcs/github.py (Diff revision 3)

The issue has been resolved. Show all issues

I still think we should have some kind of verb in here on the link. "See how to grant access" or "Get help granting access"...

Change Summary:

Add a verb

Diff:

Revision 4 (+22 -2)

Show changes

	reviewboard/hostingsvcs/errors.py
	reviewboard/hostingsvcs/github.py
	reviewboard/scmtools/forms.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (0496b5e)

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/errors.py
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/forms.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/errors.py
    reviewboard/hostingsvcs/github.py
    reviewboard/scmtools/forms.py