• 
      

    Fix configuration forms not rendering JS config properly

    Review Request #8202 — Created May 31, 2016 and submitted

    Information

    Djblets
    release-0.8.x
    299267f...

    Reviewers

    Previously, there was an issue of the config forms having incorrectly
    rendered JS. That issue has been fixed, but there was also an issue of
    the wrong variable names being splatted and so the generated config was
    syntactically correct, albeit empty. This patch corrects that.

    This patch also adds some closing tags that were missing from the
    template.

    Used this with an upcoming change in Splat.

    Description From Last Updated

    I don't see anything in the patch about closing tags.

    daviddavid
    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          djblets/configforms/templates/configforms/config.html
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          djblets/configforms/templates/configforms/config.html
      
      
    2. 
        
    brennie
    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          djblets/configforms/templates/configforms/config.html
      
      
      
      Tool: Pyflakes
      Ignored Files:
          djblets/configforms/templates/configforms/config.html
      
      
    2. 
        
    david
    1. 
        
    2. Show all issues

      I don't see anything in the patch about closing tags.

      1. Accidentally posted without committing.

    3. 
        
    brennie
    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          djblets/configforms/templates/configforms/config.html
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          djblets/configforms/templates/configforms/config.html
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.8.x (35668b5)