Only animate the datagrid menu when it is not animating

Review Request #8198 — Created May 30, 2016 and submitted

Information

Djblets
release-0.9.x
e5bfd0e...

Reviewers

Previously, toggling the column menu for datagrids fast enough would
result in it breaking due to a variable being null. Now, we will only
trigger the menu opening/closing animation if the menu is not currently
being animated. The code has also been cleaned up a bit to use a flag
instead of a jQuery object to determine whether or not the menu is open.

Could not reproduce this issue with the patch applied.

Description From Last Updated

You added the .noseids file. Please remove it from this change.

daviddavid
reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        djblets/static/djblets/js/datagrid.js
        .noseids
    
    
    
    Tool: Pyflakes
    Ignored Files:
        djblets/static/djblets/js/datagrid.js
        .noseids
    
    
  2. 
      
david
  1. 
      
  2. Show all issues

    You added the .noseids file. Please remove it from this change.

  3. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        djblets/static/djblets/js/datagrid.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        djblets/static/djblets/js/datagrid.js
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.9.x (310d833)