Only animate the datagrid menu when it is not animating
Review Request #8198 — Created May 30, 2016 and submitted
Previously, toggling the column menu for datagrids fast enough would
result in it breaking due to a variable beingnull. Now, we will only
trigger the menu opening/closing animation if the menu is not currently
being animated. The code has also been cleaned up a bit to use a flag
instead of a jQuery object to determine whether or not the menu is open.
Could not reproduce this issue with the patch applied.
| Description | From | Last Updated |
|---|---|---|
|
You added the .noseids file. Please remove it from this change. |
|
Tool: PEP8 Style Checker Ignored Files: djblets/static/djblets/js/datagrid.js .noseids Tool: Pyflakes Ignored Files: djblets/static/djblets/js/datagrid.js .noseids