Fix regressions with use of arguments in fat arrow functions.

Review Request #8190 — Created May 26, 2016 and submitted

Information

Review Board
release-3.0.x
04c1003...

Reviewers

Fat arrow functions don't get the arguments object like normal functions do.
There were a few places in the recent ES6 conversion of the base resource model
that didn't account for this, and caused a regression. This change fixes those
up and adds some unit testing to make sure we're doing the right thing.

Ran js-tests.

reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
        reviewboard/static/rb/js/resources/models/draftResourceModelMixin.es6.js
        reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
        reviewboard/static/rb/js/resources/models/draftResourceModelMixin.es6.js
        reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    
    
  2. 
      
chipx86
  1. Looks good overall. Might be good to have tests for the other places where the callbacks are called, but I'd rather get this in now.

  2. 
      
david
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
        reviewboard/static/rb/js/resources/models/draftResourceModelMixin.es6.js
        reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/resources/models/baseResourceModel.es6.js
        reviewboard/static/rb/js/resources/models/draftResourceModelMixin.es6.js
        reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (e8a60cd)