• 
      

    Remove the workaround for the Codebase trailing newline bug.

    Review Request #8177 — Created May 23, 2016 and submitted

    Information

    Review Board
    release-2.0.x

    Reviewers

    The Codebase hosting service had a bug that stripped the final trailing
    newline. We had to work around this by adding a trailing newline on our
    end, which could cause problems with diffs. It seems that this bug is
    now fixed, so we need to remove the workaround we've added in order to
    prevent new problems from occurring.

    Unit tests pass.

    Tested manually against some real-world API results, which now all seem
    to have the trailing newline.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/hostingsvcs/codebasehq.py
          reviewboard/hostingsvcs/tests.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/hostingsvcs/codebasehq.py
          reviewboard/hostingsvcs/tests.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (a2d9a68)