No longer require an HttpRequest for avatars
Review Request #8165 — Created May 16, 2016 and submitted
Avatar services no longer require an
HttpRequest
to get the uncached
avatar URLs for a user. Previously, the Gravatar avatar service used the
HttpRequest
to determine whether or not HTTPS should be used for the
resulting URL. Now, we always use an HTTPS url as there is no reason not
to.The unit tests have been udpated to reflect these changes.
Ran unit tests.
Description | From | Last Updated |
---|---|---|
This is going to break backwards-compatibility. We We should keep the parameter btu work without it, make it None by … |
chipx86 | |
Should say "optional". |
chipx86 | |
Typo. |
chipx86 | |
No opening paren here. |
chipx86 | |
Should specify "optional." |
chipx86 | |
Should specify if this is in pixels. |
chipx86 | |
Typo. |
chipx86 | |
No opening paren. |
chipx86 | |
Should specify optional. |
chipx86 | |
Should specify that this is in pixels. |
chipx86 | |
Can we put parens around the computation? It'll help a bit with readability. |
chipx86 | |
Missing "optional". |
chipx86 | |
We can start the string on the warn( line. It's only one more space. |
chipx86 | |
Let's reference the argument name, like: 'The "email" argument cannot be None.' Might be worth just checking for truthiness, and … |
chipx86 | |
Missing "optional". |
chipx86 | |
Same comments as above. |
chipx86 |
-
Tool: PEP8 Style Checker Processed Files: djblets/gravatars/templatetags/tests.py djblets/avatars/services/gravatar.py djblets/avatars/services/base.py djblets/gravatars/templatetags/gravatars.py djblets/avatars/tests.py djblets/gravatars/__init__.py Ignored Files: docs/djblets/guides/avatars/writing-avatar-services.rst Tool: Pyflakes Processed Files: djblets/gravatars/templatetags/tests.py djblets/avatars/services/gravatar.py djblets/avatars/services/base.py djblets/gravatars/templatetags/gravatars.py djblets/avatars/tests.py djblets/gravatars/__init__.py Ignored Files: docs/djblets/guides/avatars/writing-avatar-services.rst
-
Tool: Pyflakes Processed Files: djblets/gravatars/templatetags/tests.py djblets/avatars/services/gravatar.py djblets/avatars/services/base.py djblets/gravatars/templatetags/gravatars.py djblets/avatars/tests.py djblets/gravatars/__init__.py Ignored Files: docs/djblets/guides/avatars/writing-avatar-services.rst Tool: PEP8 Style Checker Processed Files: djblets/gravatars/templatetags/tests.py djblets/avatars/services/gravatar.py djblets/avatars/services/base.py djblets/gravatars/templatetags/gravatars.py djblets/avatars/tests.py djblets/gravatars/__init__.py Ignored Files: docs/djblets/guides/avatars/writing-avatar-services.rst