Add DiffViewerDropdownActionHook Hook
Review Request #8157 — Created May 12, 2016 and discarded
Adding a DiffViewerDropdownActionHook will allow Review Board developer to add dropdown menus to the "diff view", much the way they can add dropdowns to the "review request view".
Added unit test like others.
| Description | From | Last Updated |
|---|---|---|
|
Pinging on this.... |
DA davidwalsh | |
|
Col: 32 E128 continuation line under-indented for visual indent |
 reviewbot
|
|
|
We're trying to flesh out our codebase docs. Can you have the docs correspond to our new guide? https://www.reviewboard.org/docs/codebase/dev/docs/writing-codebase-docs/ You … |
 chipx86
|
|
|
Single quotes for strings. |
chipx86
|
|
|
""" on the next line. (The others with """ on the same line are incorrect, and were missed during review.) |
chipx86
|
|
|
Can you switch this to single quotes for strings? |
chipx86
|
-
Tool: Pyflakes Processed Files: reviewboard/extensions/templatetags/rb_extensions.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: reviewboard/templates/diffviewer/view_diff.html docs/manual/extending/extensions/hooks/action-hooks.rst Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/templatetags/rb_extensions.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: reviewboard/templates/diffviewer/view_diff.html docs/manual/extending/extensions/hooks/action-hooks.rst
-
Hey David,
I want to give you a heads up that action registration is completely being rewritten for 3.0, and I'm going to be landing that shortly. We'll end up needing a counterpart for this for the release-3.0.x branch to go along with this change, so we can land that first and sanely merge this. I'll update you when that's in.
-
After looking at the 3.0.x branch, it looks as though
ReviewRequestDropdownActionHook'sapply_towould take the place of this new class. Am I reading the code properly?
-
Can you set the branch to indicate what version this applies to?
From what I can tell, this should be limited to 2.5, and that's good information to have in the description.
-
We're trying to flesh out our codebase docs. Can you have the docs correspond to our new guide? https://www.reviewboard.org/docs/codebase/dev/docs/writing-codebase-docs/
You can see an example of what we want at https://github.com/djblets/djblets/blob/master/djblets/util/templatetags/djblets_utils.py
-
-
"""on the next line.(The others with
"""on the same line are incorrect, and were missed during review.) -
Tool: Pyflakes Processed Files: reviewboard/extensions/templatetags/rb_extensions.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: reviewboard/templates/diffviewer/view_diff.html docs/manual/extending/extensions/hooks/action-hooks.rst Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/templatetags/rb_extensions.py reviewboard/extensions/hooks.py reviewboard/extensions/tests.py Ignored Files: reviewboard/templates/diffviewer/view_diff.html docs/manual/extending/extensions/hooks/action-hooks.rst