Summary

Fix a couple problems calling RB.BaseResource.prototype.defaults

Review Request #8148 — Created May 6, 2016 and submitted May 15, 2016, 1:17 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

f79893c...

Reviewers

Groups

reviewboard

People

Description

There were a couple places that used BaseResource.defaults as if it were
just an object rather than a function. This fixes those up.

Testing Done

Ran js-tests.

Issues

Description	From	Last Updated
This should be a method because it will have an object.	brennie	May 10, 2016, 10:03 a.m.
Likewise this.	brennie	May 10, 2016, 10:03 a.m.
And this.	brennie	May 10, 2016, 10:03 a.m.

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
    reviewboard/static/rb/js/models/userSessionModel.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
    reviewboard/static/rb/js/models/userSessionModel.js

reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 1)

The issue has been resolved. Show all issues

This should be a method because it will have an object.

reviewboard/static/rb/js/models/userSessionModel.js (Diff revision 1)
The issue has been resolved. Show all issues
```
Likewise this.
```
reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
And this.
```

Commit:

54dd2bb2018c692a0897bce9b5d489e405c11b55

f79893c1c115c18b2f21b2326af880ffdbb92c53

Diff:

Revision 2 (+89 -67)

Show changes

	reviewboard/static/rb/js/models/userSessionModel.js
	reviewboard/static/rb/js/resources/models/diffModel.es6.js
	reviewboard/static/rb/js/resources/models/fileAttachmentModel.es6.js
	reviewboard/static/rb/js/resources/models/fileDiffModel.es6.js
	reviewboard/static/rb/js/resources/models/repositoryBranchModel.es6.js
	reviewboard/static/rb/js/resources/models/repositoryCommitModel.es6.js
	reviewboard/static/rb/js/resources/models/repositoryModel.es6.js
	reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
	1 more

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/resources/models/screenshotModel.es6.js
    reviewboard/static/rb/js/resources/models/diffModel.es6.js
    reviewboard/static/rb/js/resources/models/repositoryCommitModel.es6.js
    reviewboard/static/rb/js/resources/models/repositoryBranchModel.es6.js
    reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
    reviewboard/static/rb/js/resources/models/fileDiffModel.es6.js
    reviewboard/static/rb/js/resources/models/repositoryModel.es6.js
    reviewboard/static/rb/js/resources/models/fileAttachmentModel.es6.js
    reviewboard/static/rb/js/models/userSessionModel.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/resources/models/screenshotModel.es6.js
    reviewboard/static/rb/js/resources/models/diffModel.es6.js
    reviewboard/static/rb/js/resources/models/repositoryCommitModel.es6.js
    reviewboard/static/rb/js/resources/models/repositoryBranchModel.es6.js
    reviewboard/static/rb/js/resources/models/reviewGroupModel.es6.js
    reviewboard/static/rb/js/resources/models/fileDiffModel.es6.js
    reviewboard/static/rb/js/resources/models/repositoryModel.es6.js
    reviewboard/static/rb/js/resources/models/fileAttachmentModel.es6.js
    reviewboard/static/rb/js/models/userSessionModel.js

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (b0476a5)