• 
      

    Switch out FILE_ALREADY_EXISTS for DUPLICATE_ITEM.

    Review Request #8137 — Created April 30, 2016 and submitted

    Information

    Review Board
    master
    1d0ebb1...

    Reviewers

    The original image dnd branch included a new API error for when a file
    attachment was a duplicate, but we now have a generic error in djblets for
    cases like this. This change swaps out the new error for the existing one.

    Ran unit tests.

    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/webapi/tests/test_user_file_attachment.py
          reviewboard/webapi/errors.py
          reviewboard/webapi/resources/user_file_attachment.py
      
      Ignored Files:
          docs/manual/webapi/2.0/errors/232-file-already-exists.rst
          docs/manual/webapi/2.0/errors/index.rst
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/webapi/tests/test_user_file_attachment.py
          reviewboard/webapi/errors.py
          reviewboard/webapi/resources/user_file_attachment.py
      
      Ignored Files:
          docs/manual/webapi/2.0/errors/232-file-already-exists.rst
          docs/manual/webapi/2.0/errors/index.rst
      
      
    2. 
        
    david
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/webapi/tests/test_user_file_attachment.py
          reviewboard/webapi/errors.py
          reviewboard/webapi/resources/user_file_attachment.py
      
      Ignored Files:
          docs/manual/webapi/2.0/errors/232-file-already-exists.rst
          docs/manual/webapi/2.0/errors/index.rst
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/webapi/tests/test_user_file_attachment.py
          reviewboard/webapi/errors.py
          reviewboard/webapi/resources/user_file_attachment.py
      
      Ignored Files:
          docs/manual/webapi/2.0/errors/232-file-already-exists.rst
          docs/manual/webapi/2.0/errors/index.rst
      
      
    2. 
        
    brennie
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to ucosp/dkus/dnd-inline-images (9e5432e)