Add signals and attributes for datagrid mobile mode
Review Request #8132 — Created April 27, 2016 and submitted
Datagrids now represent their current mobile state through the
data-datagrid-mobile-modeattribute. When the datagrid changes modes,
it will update that attribute and fire themobileModeTogglesignal with
an object that indicates wether it was enabled or disabled.
Tested this with an upcoming change in Splat.
| Description | From | Last Updated |
|---|---|---|
|
I think we should probably switch these, so a caller can always know what mode it's in by consulting the … |
 chipx86
|
-
-
I think we should probably switch these, so a caller can always know what mode it's in by consulting the attribute, if needed (something deeper into the callback handler that may not have the parameter passed).
I'm also thinking we shouldn't refer to this as the "mobile" mode, because we may want other views down the road. So instead, how about
datagrid-display-mode={mobile,desktop}for the attribute, anddatagridDisplayModeChangedfor the event?(The prefix on the event keeps it namespaced so there's never any risk of collisions on the element, slim though they may be.)
Tool: PEP8 Style Checker Ignored Files: djblets/static/djblets/js/datagrid.js Tool: Pyflakes Ignored Files: djblets/static/djblets/js/datagrid.js