Summary

[WIP] Custom review request fields

Review Request #8111 — Created April 10, 2016 and discarded Aug. 30, 2017, 10:06 a.m.

Information

Owner

imadueme

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

This is a WIP review request for the student project to add custom review request fields.

It does not have any salvagable parts, as of now it is all experiemental.
In the future I will be modifiying the BaseReviewRequest class to add initial values in the

data-raw-value attribute of the field. This will likely solve the problem of not being able

to load and publish custom fields.

Testing Done

None, yet. Still need to write unit test.

Files

Issues

Description	From	Last Updated
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 10, 2016, 10:08 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 12, 2016, 5:22 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 12, 2016, 5:22 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 25, 2016, 2:17 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 29, 2016, 8:23 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	April 29, 2016, 8:23 p.m.

Fix it!

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/fields.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/fields.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/reviews/fields.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```

Groups:: students

Change Summary:

Got publishing to work and added preliminary support for dropdowns.

Diff:

Revision 2 (+191 -45)

Show changes

	reviewboard/reviews/fields.py
	reviewboard/static/rb/js/views/reviewRequestEditorView.js

Fix it!

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/fields.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/fields.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/reviews/fields.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/reviews/fields.py (Diff revision 2)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```

Diff:

Revision 3 (+216 -45)

Show changes

	reviewboard/reviews/fields.py
	reviewboard/static/rb/js/views/reviewRequestEditorView.js

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/fields.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/fields.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

Diff:

Revision 4 (+428 -45)

Show changes

	reviewboard/reviews/fields.py
	reviewboard/static/rb/js/views/reviewRequestEditorView.js

Fix it!

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/fields.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/fields.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/reviews/fields.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```

Added Files:

Diff:

Revision 5 (+527 -45)

Show changes

	reviewboard/reviews/fields.py
	reviewboard/static/rb/js/views/reviewRequestEditorView.js

Fix it!

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/fields.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/fields.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/reviews/fields.py (Diff revision 5)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/reviews/fields.py (Diff revision 5)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```

Testing Done:: +
None, yet. Still need to write unit test.

Status:: Discarded