Summary

Add compatibility functions for most Django database/model/app operations.

Review Request #8107 — Created April 8, 2016 and submitted May 26, 2016, 2:30 a.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

master

Bugs

Depends On

~~8106~~

Commit

596bb68...

Reviewers

Groups

django-evolution

People

Description

As a precursor to adding support for newer versions of Django, this
change adds a new set of compatibility functions and imports that wrap
either deprecated or internal methods in Django, all of which have moved
or been replaced in newer versions.

Most of this is code movement, but there's a lot of it. The
django_evolution.compat module has a number of new sub-modules for
database operations, SQL generation, model/app manipulation and lookup,
and moved imports.

The various callers have been updated to call into these instead of
hard-coding access to the wrapped functions.

Along with this, I've improved the documentation for most of the
functions that have been updated.

Testing Done

Unit tests pass for SQLite, MySQL, and Postgres.

Issues

Description	From	Last Updated
'settings' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.
'get_model' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.
'get_models' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.
'logging' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.
'get_models' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.
local variable 'e' is assigned to but never used	reviewbot	April 8, 2016, 11:30 p.m.
'digest' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.
'supports_index_together' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.
local variable 'style' is assigned to but never used	reviewbot	April 8, 2016, 11:30 p.m.
local variable 'creation' is assigned to but never used	reviewbot	April 8, 2016, 11:30 p.m.
local variable 'creation' is assigned to but never used	reviewbot	April 8, 2016, 11:30 p.m.
local variable 'style' is assigned to but never used	reviewbot	April 8, 2016, 11:30 p.m.
local variable 'creation' is assigned to but never used	reviewbot	April 8, 2016, 11:30 p.m.
local variable 'style' is assigned to but never used	reviewbot	April 8, 2016, 11:30 p.m.
'get_rel_target_field' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.
'get_model' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.
'color' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.
'transaction' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.
'curry' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.
'clear_app_cache' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.
'apps' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.
'create_constraint_name' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.
'create_index_together_name' imported but unused	reviewbot	April 8, 2016, 11:30 p.m.

Tool: Pyflakes
Processed Files:
    django_evolution/mutations.py
    django_evolution/db/common.py
    django_evolution/compat/apps.py
    django_evolution/tests/db/postgresql.py
    django_evolution/compat/db.py
    django_evolution/diff.py
    django_evolution/utils.py
    django_evolution/tests/signature.py
    django_evolution/tests/utils.py
    django_evolution/compat/datastructures.py
    django_evolution/db/mysql.py
    django_evolution/management/commands/list-evolutions.py
    django_evolution/db/sqlite3.py
    django_evolution/db/postgresql.py
    django_evolution/tests/db/mysql.py
    django_evolution/tests/test_generics.py
    django_evolution/compat/models.py
    django_evolution/signature.py
    django_evolution/management/commands/evolve.py

django_evolution/compat/apps.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'settings' imported but unused
```
django_evolution/compat/apps.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'get_model' imported but unused
```
django_evolution/compat/apps.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'get_models' imported but unused
```
django_evolution/compat/db.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'logging' imported but unused
```
django_evolution/compat/db.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'get_models' imported but unused
```
django_evolution/compat/db.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'e' is assigned to but never used
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'digest' imported but unused
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'supports_index_together' imported but unused
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'style' is assigned to but never used
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'creation' is assigned to but never used
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'creation' is assigned to but never used
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'style' is assigned to but never used
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'creation' is assigned to but never used
```
django_evolution/db/common.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'style' is assigned to but never used
```
django_evolution/db/mysql.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'get_rel_target_field' imported but unused
```
django_evolution/db/mysql.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'get_model' imported but unused
```
django_evolution/db/sqlite3.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'color' imported but unused
```
django_evolution/tests/utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'transaction' imported but unused
```
django_evolution/tests/utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'curry' imported but unused
```
django_evolution/tests/utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'clear_app_cache' imported but unused
```
django_evolution/tests/utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'apps' imported but unused
```
django_evolution/tests/utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'create_constraint_name' imported but unused
```
django_evolution/tests/utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'create_index_together_name' imported but unused
```

Tool: PEP8 Style Checker
Processed Files:
    django_evolution/mutations.py
    django_evolution/db/common.py
    django_evolution/compat/apps.py
    django_evolution/tests/db/postgresql.py
    django_evolution/compat/db.py
    django_evolution/diff.py
    django_evolution/utils.py
    django_evolution/tests/signature.py
    django_evolution/tests/utils.py
    django_evolution/compat/datastructures.py
    django_evolution/db/mysql.py
    django_evolution/management/commands/list-evolutions.py
    django_evolution/db/sqlite3.py
    django_evolution/db/postgresql.py
    django_evolution/tests/db/mysql.py
    django_evolution/tests/test_generics.py
    django_evolution/compat/models.py
    django_evolution/signature.py
    django_evolution/management/commands/evolve.py

Change Summary:

Fixed unused imports and variable declarations.

Commit:

85ffc7ea117a36b4c280f6af662f219ab5d9f15e

596bb6869fae3992b407d279cec0a18bbf967a58

Diff:

Revision 2 (+1135 -233)

Show changes

	django_evolution/diff.py
	django_evolution/mutations.py
	django_evolution/signature.py
	django_evolution/utils.py
	django_evolution/compat/apps.py
	django_evolution/compat/datastructures.py
	django_evolution/compat/db.py
	django_evolution/compat/models.py
	11 more

Tool: Pyflakes
Processed Files:
    django_evolution/mutations.py
    django_evolution/db/common.py
    django_evolution/compat/apps.py
    django_evolution/tests/db/postgresql.py
    django_evolution/compat/db.py
    django_evolution/diff.py
    django_evolution/utils.py
    django_evolution/tests/signature.py
    django_evolution/tests/utils.py
    django_evolution/compat/datastructures.py
    django_evolution/db/mysql.py
    django_evolution/management/commands/list-evolutions.py
    django_evolution/db/sqlite3.py
    django_evolution/db/postgresql.py
    django_evolution/tests/db/mysql.py
    django_evolution/tests/test_generics.py
    django_evolution/compat/models.py
    django_evolution/signature.py
    django_evolution/management/commands/evolve.py

Tool: PEP8 Style Checker
Processed Files:
    django_evolution/mutations.py
    django_evolution/db/common.py
    django_evolution/compat/apps.py
    django_evolution/tests/db/postgresql.py
    django_evolution/compat/db.py
    django_evolution/diff.py
    django_evolution/utils.py
    django_evolution/tests/signature.py
    django_evolution/tests/utils.py
    django_evolution/compat/datastructures.py
    django_evolution/db/mysql.py
    django_evolution/management/commands/list-evolutions.py
    django_evolution/db/sqlite3.py
    django_evolution/db/postgresql.py
    django_evolution/tests/db/mysql.py
    django_evolution/tests/test_generics.py
    django_evolution/compat/models.py
    django_evolution/signature.py
    django_evolution/management/commands/evolve.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (eb820d1)