• 
      

    [WIP] Test cases for RBTools Shell

    Review Request #8079 — Created March 28, 2016 and discarded

    Information

    RBTools
    master

    Reviewers

    Incorporates all the changes from the RBTools shell command review request along with the proposed testing.

    Test if import functions really return the right modules
    Test if calls to functions can be blocked or traced

    Description From Last Updated

    'spy_on' imported but unused

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    undefined name 'dummy_import_int'

    reviewbotreviewbot

    undefined name 'dummy_import_string'

    reviewbotreviewbot

    undefined name 'dummy_import_bool'

    reviewbotreviewbot

    local variable 'ipython_module' is assigned to but never used

    reviewbotreviewbot

    undefined name 'dummy_import_int'

    reviewbotreviewbot

    undefined name 'dummy_import_string'

    reviewbotreviewbot

    undefined name 'dummy_import_bool'

    reviewbotreviewbot

    local variable 'bpython_module' is assigned to but never used

    reviewbotreviewbot

    undefined name 'dummy_import_module'

    reviewbotreviewbot

    local variable 'bpython_module' is assigned to but never used

    reviewbotreviewbot

    undefined name 'dummy_import_module'

    reviewbotreviewbot

    local variable 'ipython_module' is assigned to but never used

    reviewbotreviewbot

    undefined name 'dummy_import'

    reviewbotreviewbot

    local variable 'client' is assigned to but never used

    reviewbotreviewbot
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          rbtools/commands/shell.py
          rbtools/commands/tests.py
          setup.py
      
      Ignored Files:
          docs/rbtools/rbt/commands/shell.rst
      
      
      
      Tool: Pyflakes
      Processed Files:
          rbtools/commands/shell.py
          rbtools/commands/tests.py
          setup.py
      
      Ignored Files:
          docs/rbtools/rbt/commands/shell.rst
      
      
    2. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
       'spy_on' imported but unused
      
    3. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    4. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
       undefined name 'dummy_import_int'
      
    5. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
       undefined name 'dummy_import_string'
      
    6. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
       undefined name 'dummy_import_bool'
      
    7. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
       local variable 'ipython_module' is assigned to but never used
      
    8. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
       undefined name 'dummy_import_int'
      
    9. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
       undefined name 'dummy_import_string'
      
    10. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
       undefined name 'dummy_import_bool'
      
    11. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
       local variable 'bpython_module' is assigned to but never used
      
    12. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
       undefined name 'dummy_import_module'
      
    13. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
       local variable 'bpython_module' is assigned to but never used
      
    14. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
       undefined name 'dummy_import_module'
      
    15. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
       local variable 'ipython_module' is assigned to but never used
      
    16. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
       undefined name 'dummy_import'
      
    17. rbtools/commands/tests.py (Diff revision 1)
       
       
      Show all issues
       local variable 'client' is assigned to but never used
      
    18. 
        
    AQ
    Review request changed
    Status:
    Discarded