Summary

Add extensibility to the user infobox.

Review Request #8078 — Created March 27, 2016 and submitted April 21, 2016, 11:02 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

11ba755...

Reviewers

Groups

reviewboard

People

Description

This change adds a new extension hook, the UserInfoBoxHook, which allows
extensions to inject additional data into the infobox. This is shown in a new
panel below the existing information, so it doesn't screw up the existing
layout.

This also fixes up a couple bugs in my earlier redesign change that emerged as
I tested it with this.

Testing Done


Built a simple extension which lists a count of the users' incoming and

  outgoing review requests in the infobox and saw the correct results.
Ran unit tests.

Issues

Description	From	Last Updated
Remove this line.	brennie	March 28, 2016, 2:17 p.m.
'ChangeDescription' imported but unused	reviewbot	March 27, 2016, 11:23 p.m.
'ChangeDescription' imported but unused	reviewbot	March 28, 2016, 2:42 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/extensions/hooks.py
    reviewboard/extensions/tests.py

Ignored Files:
    reviewboard/static/rb/css/common.less
    reviewboard/templates/accounts/user_infobox.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/extensions/hooks.py
    reviewboard/extensions/tests.py

Ignored Files:
    reviewboard/static/rb/css/common.less
    reviewboard/templates/accounts/user_infobox.html

reviewboard/reviews/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'ChangeDescription' imported but unused
```

reviewboard/extensions/hooks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Remove this line.
```

Commit:

2f7f39e46fc27f2f4dd80b6d52596deefdb3a0c8

e83ae125661ca3fe4de310448aefc69ab49153d9

Diff:

Revision 2 (+167 -18)

Show changes

	reviewboard/extensions/hooks.py
	reviewboard/extensions/tests.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/common.less
	reviewboard/templates/accounts/user_infobox.html

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/extensions/hooks.py
    reviewboard/extensions/tests.py

Ignored Files:
    reviewboard/static/rb/css/common.less
    reviewboard/templates/accounts/user_infobox.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/extensions/hooks.py
    reviewboard/extensions/tests.py

Ignored Files:
    reviewboard/static/rb/css/common.less
    reviewboard/templates/accounts/user_infobox.html

reviewboard/reviews/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'ChangeDescription' imported but unused
```

Ship it!

```
Ship It!
```

Change Summary:

Update on top of latest infobox change.

Commit:

e83ae125661ca3fe4de310448aefc69ab49153d9

11ba7558873f50a648ad4aab3a68c49407d206b3

Diff:

Revision 3 (+156 -6)

Show changes

	reviewboard/extensions/hooks.py
	reviewboard/extensions/tests.py
	reviewboard/reviews/views.py
	reviewboard/static/rb/css/common.less
	reviewboard/templates/accounts/user_infobox.html

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/extensions/hooks.py
    reviewboard/extensions/tests.py

Ignored Files:
    reviewboard/static/rb/css/common.less
    reviewboard/templates/accounts/user_infobox.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/extensions/hooks.py
    reviewboard/extensions/tests.py

Ignored Files:
    reviewboard/static/rb/css/common.less
    reviewboard/templates/accounts/user_infobox.html

Status:: Completed
Change Summary:: Pushed to release-3.0.x (1fcc46d)