• 
      

    Support the modern METADATA file in extension packages.

    Review Request #8068 — Created March 21, 2016 and submitted

    Information

    Djblets
    release-0.8.x
    4329741...

    Reviewers

    Modern Python packages store metadata in a METADATA file, rather than in
    a PKG-INFO file. This updates our extension metadata parsing to try this
    file first, falling back on PKG-INFO. That gives us compatibility with
    any modern packages (particularly wheels), while retaining support for
    older packages (eggs).

    Tested this with an extension containing a METADATA file but not PKG-INFO.
    Successfully extracted metadata from the package for the extension.

    Description From Last Updated

    undefined name 'logging'

    reviewbotreviewbot
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          djblets/extensions/extension.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          djblets/extensions/extension.py
      
      
    2. djblets/extensions/extension.py (Diff revision 1)
       
       
      Show all issues
       undefined name 'logging'
      
    3. 
        
    mike_conley
    1. Modulo the logging problem that ReviewBot found, this looks good to me.

    2. 
        
    chipx86
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          djblets/extensions/extension.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          djblets/extensions/extension.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.8.x (4878341)