Work around OS X 10.11 bug with check_install()
Review Request #8058 — Created March 15, 2016 and submitted
This has been fixed upstream (http://bugs.python.org/issue26083) but who knows when Apple will update their version of Python they distribute so this change simply works around the issue by treating a ValueError to be the same as an OSError. This fix seems smaller/safer then switching to the subprocess32 package as it adds another external dependency an the documentation states that it hasn't been tested on Windows.
Before my fix, when running rbt post, I get: ValueError: insecure string pickle (I don't have tfs installed) After my fix, running rbt post works fine.
-
Hmm. It really scares me to switch to a third party library that advertises that it "has not been tested on Windows."
EL
- Change Summary:
-
No longer require subprocess32.
- Summary:
-
Switch from using stdlib subprocess module to external subprocess32 packageWork around OS X 10.11 bug with check_install()
- Description:
-
~ The subprocess32 package is better maintained on the Python 2.x branches
~ and specifically fixes a bug seen when running rbt on OS X 10.11. ~ See: http://bugs.python.org/issue26083 ~ This has been fixed upstream (http://bugs.python.org/issue26083) but who
~ knows when Apple will update their version of Python they distribute so ~ this change simply works around the issue by treating a ValueError to be + the same as an OSError. This fix seems smaller/safer then switching to + the subprocess32 package as it adds another external dependency an the + documentation states that it hasn't been tested on Windows. - Commit:
-
25b0427627dc0453eb8a6780962e891c26d80d0828be9b893efa7e8de53ab0eb82c5656f6ceeaf8e
- Diff:
-
Revision 2 (+5 -1)