Summary

Added an asynchronous each to the ExtensionHookModel

Review Request #8051 — Created March 10, 2016 and discarded Oct. 26, 2021, 12:16 p.m.

Information

Owner

imadueme

Repository

Djblets

Branch

release-0.9.x

Bugs

Depends On

Blocks

8052

Reviewers

Groups

djblets, students

People

Description

Added an asynchronous each to the ExtensionHookModel using jQuery Deferred Objects.
The addition of the new method allows client code to attach callback functions for
cases when the entire collection was successfully processed or cases when one or
more of the items in the collection failed to be processed.

This uses jQuery Deferred Objects so it should be compatible with non ES6 versions
of reviewboard/non-ES6 browsers.

Testing Done

Ensured that it worked with the new code added in the 'blocked' review requests to the right.
Exiting each still works.

Issues

Description	From	Last Updated
Can you rewrite this to use Args/Returns?	david	April 29, 2016, 9:32 p.m.
I think you should be able to just do return $.when(deferredObjs)	david	April 29, 2016, 9:11 p.m.

Tool: PEP8 Style Checker
Ignored Files:
    djblets/static/djblets/js/extensions/models/extensionHookModel.js



Tool: Pyflakes
Ignored Files:
    djblets/static/djblets/js/extensions/models/extensionHookModel.js

djblets/static/djblets/js/extensions/models/extensionHookModel.js (Diff revision 1)

The issue has been resolved. Show all issues

Can you rewrite this to use Args/Returns?

djblets/static/djblets/js/extensions/models/extensionHookModel.js (Diff revision 1)

The issue has been dropped. Show all issues

I think you should be able to just do return $.when(deferredObjs)

imadueme April 29, 2016, 10:19 p.m.

I actually thought so myself first, but, because $.when expects a variable number of deffered objects as parameters and defferedObjs is an array I used .apply to interpolate the array as many arguments rather than one.

Diff:

Revision 2 (+41)

Show changes

djblets/static/djblets/js/extensions/models/extensionHookModel.js

Tool: Pyflakes
Ignored Files:
    djblets/static/djblets/js/extensions/models/extensionHookModel.js



Tool: PEP8 Style Checker
Ignored Files:
    djblets/static/djblets/js/extensions/models/extensionHookModel.js

Status:: Discarded