Prevent webhooks being created with wildcard event and additional events
Review Request #8050 — Created March 10, 2016 and submitted
The admin form was supposed to prevent webhooks being created with an
events list that included the wildcard event and other events (because
they were covered by the wildcard event). However, the CSS selectors
used were incorrect. They have new been updated.Additionally, the webhook API endpoint to reflect this. Any webhook
created through the API with the wildcard event will have its events
limited to the wildcard event. Unit tests have been added to reflect
this new behaviour.
- Ran unit tests.
- Manually verified the admin form worked.
Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/tests/test_webhook.py reviewboard/notifications/forms.py Ignored Files: reviewboard/static/rb/js/webhooksAdmin/views/webhookFormView.js Tool: Pyflakes Processed Files: reviewboard/webapi/tests/test_webhook.py reviewboard/notifications/forms.py Ignored Files: reviewboard/static/rb/js/webhooksAdmin/views/webhookFormView.js