• 
      

    Convert js/ui to ES6

    Review Request #8049 — Created March 10, 2016 and submitted

    Information

    Review Board
    release-2.6.x
    31ef8ac...

    Reviewers

    This change converts the views in js/ui/views to ES6. While I was in here, I
    went through and updated our docstrings to the modern format.

    Ran js-tests.

    Description From Last Updated

    These methods could also be replaced with the methodName(args) sugar

    brenniebrennie

    Would you mind completing this doc comment?

    brenniebrennie
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/staticbundles.py
      
      Ignored Files:
          reviewboard/static/rb/js/ui/views/dialogView.es6.js
          reviewboard/static/rb/js/ui/views/dialogView.js
          reviewboard/static/rb/js/ui/views/splitButtonView.es6.js
          reviewboard/static/rb/js/ui/views/textEditorView.es6.js
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/staticbundles.py
      
      Ignored Files:
          reviewboard/static/rb/js/ui/views/dialogView.es6.js
          reviewboard/static/rb/js/ui/views/dialogView.js
          reviewboard/static/rb/js/ui/views/splitButtonView.es6.js
          reviewboard/static/rb/js/ui/views/textEditorView.es6.js
      
      
    2. 
        
    brennie
    1. Minor nit: "docstring" -> "doc comment' in your description.

    2. Show all issues

      These methods could also be replaced with the methodName(args) sugar

    3. Show all issues

      Would you mind completing this doc comment?

    4. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.6.x (ab0cdce)