Ensure only active users from a default reviewer instance are added to a review request.

Review Request #8048 — Created March 9, 2016 and submitted

Information

Review Board
master

Reviewers

When an inactive user belongs to a default reviewer instance, it does not
make sense to add that user to the reviewer list on a new review request.
This was previously not the case, and this bug is corrected here by
interrogating the user's active state to determine if they are eligible
to be added to the reviewer list.
Added a new unit test to exercise this condition.  Prior to the fix,
this test would fail.  With the fix it passes.
Description From Last Updated

local variable 'filediff' is assigned to but never used

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/models/base_review_request_details.py
        reviewboard/reviews/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/models/base_review_request_details.py
        reviewboard/reviews/tests.py
    
    
  2. reviewboard/reviews/tests.py (Diff revision 1)
     
     
    Show all issues
     local variable 'filediff' is assigned to but never used
    
  3. 
      
gmyers
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/models/base_review_request_details.py
        reviewboard/reviews/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/models/base_review_request_details.py
        reviewboard/reviews/tests.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
gmyers
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (8de3938)