• 
      

    Don't use filesystem encoding for interpreting XML from TFS.

    Review Request #8041 — Created March 8, 2016 and submitted

    Information

    RBTools
    release-0.7.x
    f5c0d69...

    Reviewers

    A few of the commands we run return XML results, which will always be utf-8,
    regardless of what the filesystem encoding is. In this case, we were decoding
    to mbcs, which would then fail when trying to interpret some special
    characters.

    • Ran unit tests.
    • Posted a few changes, including one whose parent had unicode in the commit
      message (which is what triggered the bug). Saw that everything worked as
      expected.
    Description From Last Updated

    Col: 33 E127 continuation line over-indented for visual indent

    reviewbotreviewbot
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/clients/tfs.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/clients/tfs.py
      
      
    2. rbtools/clients/tfs.py (Diff revision 1)
       
       
      Show all issues
      Col: 33
       E127 continuation line over-indented for visual indent
      
    3. 
        
    david
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          rbtools/clients/tfs.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          rbtools/clients/tfs.py
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.7.x (876fca1)