lehoangm got a fish trophy!

Summary

[OAuth2Provider][WIP] Enabling OAuth2 authorization on Web API

Review Request #7997 — Created Feb. 25, 2016 and discarded Sept. 7, 2017, 9 p.m.

Information

Owner

lehoangm

Repository

Djblets

Branch

master

Bugs

Depends On

~~7941~~, ~~7996~~

Blocks

7996

Reviewers

Groups

djblets

People

brennie, chipx86

Description

Prior to this commit, there is no mechanism to authorize resources using OAuth2
protocol. In this commit, OAuth2 authorization mechanism is added to
the current authorization mechanism for web API resources.
Services now can follow OAuth2 protocol, send a request with appropriate
authorization header to work with Djblet's resources. External services can
request a token with specify scope through OAuth2 protocol. When using Djblet's
API resource, the scope of a token is checked to make sure that the
external service has the right permission the resource.

This commit also adding unit tests for all current backend authentication:
the base authentication class, the basic authentication via username and
password, the api_token authentication, and the newly added oauth2
authentication backend.

Testing Done

Add test_base_auth_backend to test WebAPIAuthBackend
Add test_basic_auth_backend to test WebAPIBasicAuthBackend
Add test_api_auth_backend to test WebAPITokenAuthBackend
Add test_oauth2_auth_backend to test OAuth2TokenAuthBackend

There should be one more for ResourceOAuth2TokenMixin

Issues

Description	From	Last Updated
undefined name 'webapi_token'	reviewbot	Feb. 29, 2016, 6:52 p.m.
Col: 24 W292 no newline at end of file	reviewbot	Feb. 29, 2016, 6:52 p.m.
Col: 1 W391 blank line at end of file	reviewbot	Feb. 29, 2016, 7:05 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Feb. 29, 2016, 7:05 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Feb. 29, 2016, 7:05 p.m.
This should further elaborate (in a second paragraph) which fields (and types) would be required by this backend (looks like …	chipx86	April 1, 2016, 9:36 a.m.
Description must be on the next line. The type should be django.http.HttpRequest. (Some of our older classes don't provide the …	chipx86	March 11, 2016, 3:58 p.m.
What if it's 3? That'd be a different error.	chipx86	March 11, 2016, 4:25 p.m.
The type should be django.http.HttpRequest.	chipx86	March 11, 2016, 3:57 p.m.
Must just be tuple. You can document the None in the description.	chipx86	March 11, 2016, 3:56 p.m.
Must be aligned, or it'll result in syntax errors in the docs.	chipx86	March 11, 2016, 3:56 p.m.
Should be: result = super(OAuth2TokenAuthBackend, self).login_with_credentials( request, **credentials)	chipx86	March 11, 2016, 3:55 p.m.
call_method_view should go on the previous line, with arguments on the second.	chipx86	March 11, 2016, 3:55 p.m.
Like with the backend, this should document the fields and types required.	chipx86	April 1, 2016, 9:39 a.m.
This can be one statement.	chipx86	March 11, 2016, 3:53 p.m.
Try: return super(ResourceOAuth2TokenMixin, self).call_method_view( request, method, view, args, *kwargs)	chipx86	April 1, 2016, 9:39 a.m.
This needs to have Args and Returns sections.	chipx86	March 3, 2016, 1:51 a.m.
I don't see how this code works. resources_policy should be a list of strings, which shouldn't have .get().	chipx86	March 3, 2016, 1:51 a.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 11, 2016, 4:22 p.m.
Col: 1 W391 blank line at end of file	reviewbot	March 11, 2016, 4:23 p.m.
I don't know about this. The unit tests are supposed to be testing the new auth backend, but they're really …	chipx86	March 3, 2016, 1:51 a.m.
Missing period, and """ on the next line. Plus a blank line below. Same below.	chipx86	March 11, 2016, 3:52 p.m.
"Return". Missing period. Same below.	chipx86	April 1, 2016, 10:22 a.m.
Make sure to use the same format as other classes. Same below.	chipx86	April 1, 2016, 10:22 a.m.
Missing type. Same below.	chipx86	March 11, 2016, 3:51 p.m.
"Object" isn't a valid Python type.	chipx86	March 11, 2016, 3:50 p.m.
Must inherit from object. However, we should use a real User, not a mock.	chipx86	April 1, 2016, 10:21 a.m.
Can't align this way, or it'll break doc generation. Make sure to use the same format used by other classes.	chipx86	March 11, 2016, 3:48 p.m.
Make sure to follow the same exact format other tests use for docstrings.	chipx86	April 1, 2016, 10:25 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Feb. 29, 2016, 7:04 p.m.
Make sure to follow the correct format for these.	chipx86	April 1, 2016, 10:08 a.m.
Should have a trailing comma.	chipx86	March 11, 2016, 3:47 p.m.
validate_credentials should be on the previous line.	chipx86	March 11, 2016, 3:48 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	April 1, 2016, 10:40 a.m.
'BaseWebAPIToken' imported but unused	reviewbot	April 1, 2016, 10:40 a.m.
Col: 19 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.
Col: 17 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.
Col: 18 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.
Col: 20 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.
Col: 17 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.
Col: 19 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.
Col: 18 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.
Col: 20 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.
Col: 63 E231 missing whitespace after ','	reviewbot	April 1, 2016, 10:40 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	April 1, 2016, 10:40 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	April 1, 2016, 10:40 a.m.
'BaseWebAPIToken' imported but unused	reviewbot	April 1, 2016, 10:40 a.m.
Col: 17 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.
Col: 19 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.
Col: 18 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.
Col: 20 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.
Col: 17 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.
Col: 19 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.
Col: 18 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.
Col: 20 E251 unexpected spaces around keyword / parameter equals	reviewbot	April 1, 2016, 10:40 a.m.

Tool: PEP8 Style Checker
Processed Files:
    djblets/webapi/resources/mixins/oauth2_tokens.py
    djblets/webapi/resources/mixins/api_tokens.py
    djblets/webapi/auth/backends/oauth2_tokens.py



Tool: Pyflakes
Processed Files:
    djblets/webapi/resources/mixins/oauth2_tokens.py
    djblets/webapi/resources/mixins/api_tokens.py
    djblets/webapi/auth/backends/oauth2_tokens.py

djblets/webapi/resources/mixins/oauth2_tokens.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 undefined name 'webapi_token'
```
djblets/webapi/resources/mixins/oauth2_tokens.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 24
 W292 no newline at end of file
```

Change Summary:: Change commit wording to fit in Djblet's context
Summary:: [OAuth2Provider][WIP] Enabling OAuth2 authorization on Review Board Web API
[OAuth2Provider][WIP] Enabling OAuth2 authorization on Web API
Description:: ~
Prior to this commit. A user can manage list of all OAuth2 client applications
~
Prior to this commit, there is no mechanism to authorize resources using OAuth2
- and OAuth2 tokens but there is no mechanism to authorize resources using OAuth2
protocol. In this commit, OAuth2 authorization mechanism is added to
~ the current authorization mechanism for Review Board web API resources.
~ the current authorization mechanism for web API resources.
Services now can follow OAuth2 protocol, send a request with appropriate
~ authorization header to work with Review Board's resources. All the scopes
~ are loaded at RB start time, and external services can request a token with
~ specify scope through OAuth2 protocol. When using Review Board's API resource,
~ the scope of a token is checked to make sure that the external service has
~ authorization header to work with Djblet's resources. External services can
~ request a token with specify scope through OAuth2 protocol. When using Djblet's
~ API resource, the scope of a token is checked to make sure that the
~ external service has the right permission the resource.
- the right permission the resource. This commit affects both djblets and
- reviewboard files at the same time.

Change Summary:

Add WebAPIAuthBackend tests

Testing Done:

~		Manual test. Missing unit tests. I will be added latter
	~	Add test_base_auth_backend to test WebAPIAuthBackend
	+
	+	More will come

Diff:

Revision 2 (+522 -83)

Show changes

	.gitignore
	djblets/avatars/registry.py
	djblets/avatars/tests.py
	djblets/avatars/services/base.py
	djblets/markdown/tests.py
	djblets/static/djblets/css/config-forms.less
	djblets/static/djblets/css/defs.less
	djblets/static/djblets/css/mixins/markdown.less
	4 more

Tool: Pyflakes
Processed Files:
    djblets/markdown/tests.py
    djblets/webapi/resources/mixins/api_tokens.py
    djblets/webapi/auth/backends/oauth2_tokens.py
    djblets/webapi/resources/mixins/oauth2_tokens.py
    djblets/avatars/services/base.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py
    djblets/webapi/tests/test_base_auth_backend.py

Ignored Files:
    djblets/static/djblets/css/defs.less
    djblets/static/djblets/css/mixins/markdown.less
    djblets/static/djblets/css/config-forms.less
    .gitignore



Tool: PEP8 Style Checker
Processed Files:
    djblets/markdown/tests.py
    djblets/webapi/resources/mixins/api_tokens.py
    djblets/webapi/auth/backends/oauth2_tokens.py
    djblets/webapi/resources/mixins/oauth2_tokens.py
    djblets/avatars/services/base.py
    djblets/avatars/tests.py
    djblets/avatars/registry.py
    djblets/webapi/tests/test_base_auth_backend.py

Ignored Files:
    djblets/static/djblets/css/defs.less
    djblets/static/djblets/css/mixins/markdown.less
    djblets/static/djblets/css/config-forms.less
    .gitignore

djblets/webapi/resources/mixins/oauth2_tokens.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 1
 W391 blank line at end of file
```
djblets/webapi/resources/mixins/oauth2_tokens.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
djblets/webapi/tests/test_base_auth_backend.py (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```

Change Summary:

Rebase with master

Diff:

Revision 3 (+453 -1)

Show changes

	djblets/webapi/auth/backends/oauth2_tokens.py
	djblets/webapi/resources/mixins/api_tokens.py
	djblets/webapi/resources/mixins/oauth2_tokens.py
	djblets/webapi/tests/test_base_auth_backend.py

Tool: Pyflakes
Processed Files:
    djblets/webapi/resources/mixins/oauth2_tokens.py
    djblets/webapi/tests/test_base_auth_backend.py
    djblets/webapi/resources/mixins/api_tokens.py
    djblets/webapi/auth/backends/oauth2_tokens.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/webapi/resources/mixins/oauth2_tokens.py
    djblets/webapi/tests/test_base_auth_backend.py
    djblets/webapi/resources/mixins/api_tokens.py
    djblets/webapi/auth/backends/oauth2_tokens.py

djblets/webapi/resources/mixins/oauth2_tokens.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
djblets/webapi/resources/mixins/oauth2_tokens.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```
djblets/webapi/tests/test_base_auth_backend.py (Diff revision 3)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```

Fix it!

djblets/webapi/auth/backends/oauth2_tokens.py (Diff revision 3)

The issue has been resolved. Show all issues

This should further elaborate (in a second paragraph) which fields (and types) would be required by this backend (looks like it's token and user, basically?).

djblets/webapi/auth/backends/oauth2_tokens.py (Diff revision 3)

The issue has been resolved. Show all issues

Description must be on the next line.

The type should be django.http.HttpRequest. (Some of our older classes don't provide the full path, but new ones should.)

djblets/webapi/auth/backends/oauth2_tokens.py (Diff revision 3)
The issue has been resolved. Show all issues
```
What if it's 3? That'd be a different error.
```
djblets/webapi/auth/backends/oauth2_tokens.py (Diff revision 3)
The issue has been resolved. Show all issues
```
The type should be django.http.HttpRequest.
```
djblets/webapi/auth/backends/oauth2_tokens.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Must just be tuple. You can document the None in the description.
```
djblets/webapi/auth/backends/oauth2_tokens.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Must be aligned, or it'll result in syntax errors in the docs.
```

djblets/webapi/auth/backends/oauth2_tokens.py (Diff revision 3)

The issue has been resolved. Show all issues

Should be:

result = super(OAuth2TokenAuthBackend, self).login_with_credentials(
    request, **credentials)

djblets/webapi/resources/mixins/api_tokens.py (Diff revision 3)
The issue has been resolved. Show all issues
```
call_method_view should go on the previous line, with arguments on the second.
```
djblets/webapi/resources/mixins/oauth2_tokens.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Like with the backend, this should document the fields and types required.
```

djblets/webapi/resources/mixins/oauth2_tokens.py (Diff revision 3)

The issue has been resolved. Show all issues

This can be one statement.

djblets/webapi/resources/mixins/oauth2_tokens.py (Diff revision 3)

The issue has been resolved. Show all issues

Try:

return super(ResourceOAuth2TokenMixin, self).call_method_view(
    request, method, view, *args, **kwargs)

djblets/webapi/resources/mixins/oauth2_tokens.py (Diff revision 3)

An issue was opened. Show all issues

This needs to have Args and Returns sections.

lehoangm April 1, 2016, 10:40 a.m.

I am just copying and pasting here. I dont understand what _get_queryset does. Can you elaborate more on this

djblets/webapi/resources/mixins/oauth2_tokens.py (Diff revision 3)

An issue was opened. Show all issues

I don't see how this code works. resources_policy should be a list of strings, which shouldn't have .get().

LE

lehoangm April 1, 2016, 10:40 a.m.
```
Same as above
```

djblets/webapi/tests/test_base_auth_backend.py (Diff revision 3)

An issue was opened. Show all issues

I don't know about this. The unit tests are supposed to be testing the new auth backend, but they're really just testing this fake backend, right? If so, the new test backend isn't getting any real coverage, making the tests useless.

lehoangm April 1, 2016, 10:40 a.m.

My is that if the real backend functions as expected according to the interface then the base implementaion would work.
Also this make sure that there is no error on the base implementation so that somehow with an error in thel rea backend, everything goes undetected.

Also note that in the real backend, I also added an "integration test" to combine the base and the real backend

djblets/webapi/tests/test_base_auth_backend.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Missing period, and """ on the next line.
Plus a blank line below.
Same below.
```
djblets/webapi/tests/test_base_auth_backend.py (Diff revision 3)
The issue has been resolved. Show all issues
```
"Return".
Missing period.
Same below.
```
djblets/webapi/tests/test_base_auth_backend.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Make sure to use the same format as other classes.
Same below.
```
djblets/webapi/tests/test_base_auth_backend.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Missing type.
Same below.
```
djblets/webapi/tests/test_base_auth_backend.py (Diff revision 3)
The issue has been resolved. Show all issues
```
"Object" isn't a valid Python type.
```
djblets/webapi/tests/test_base_auth_backend.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Must inherit from object.
However, we should use a real User, not a mock.
```

djblets/webapi/tests/test_base_auth_backend.py (Diff revision 3)

The issue has been resolved. Show all issues

Can't align this way, or it'll break doc generation.

Make sure to use the same format used by other classes.

djblets/webapi/tests/test_base_auth_backend.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Make sure to follow the same exact format other tests use for docstrings.
```

djblets/webapi/tests/test_base_auth_backend.py (Diff revision 3)

The issue has been resolved. Show all issues

Make sure to follow the correct format for these.

djblets/webapi/tests/test_base_auth_backend.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Should have a trailing comma.
```
djblets/webapi/tests/test_base_auth_backend.py (Diff revision 3)
The issue has been resolved. Show all issues
```
validate_credentials should be on the previous line.
```

Change Summary:

Update CR; change description; adding testes

Description:

		Prior to this commit, there is no mechanism to authorize resources using OAuth2
		protocol. In this commit, OAuth2 authorization mechanism is added to
		the current authorization mechanism for web API resources.
		Services now can follow OAuth2 protocol, send a request with appropriate
~		authorization header to work with Djblet's resources. External services can
~		request a token with specify scope through OAuth2 protocol. When using Djblet's
~		API resource, the scope of a token is checked to make sure that the
	~	authorization header to work with Djblet's resources. External services can
	~	request a token with specify scope through OAuth2 protocol. When using Djblet's
	~	API resource, the scope of a token is checked to make sure that the
		external service has the right permission the resource.
	+
	+	This commit also adding unit tests for all current backend authentication:
	+	the base authentication class, the basic authentication via username and
	+	password, the api_token authentication, and the newly added oauth2
	+	authentication backend.

Testing Done:

~		Add test_base_auth_backend to test WebAPIAuthBackend
	~	Add test_base_auth_backend to test WebAPIAuthBackend
	+	Add test_basic_auth_backend to test WebAPIBasicAuthBackend
	+	Add test_api_auth_backend to test WebAPITokenAuthBackend
	+	Add test_oauth2_auth_backend to test OAuth2TokenAuthBackend

~		More will come
	~	There should be one more for ResourceOAuth2TokenMixin

Diff:

Revision 4 (+820 -2)

Show changes

	djblets/webapi/auth/backends/api_tokens.py
	djblets/webapi/auth/backends/oauth2_tokens.py
	djblets/webapi/resources/mixins/api_tokens.py
	djblets/webapi/resources/mixins/oauth2_tokens.py
	djblets/webapi/tests/test_api_auth_backend.py
	djblets/webapi/tests/test_base_auth_backend.py
	djblets/webapi/tests/test_basic_auth_backend.py
	djblets/webapi/tests/test_oauth2_auth_backend.py

Fix it!

Tool: Pyflakes
Processed Files:
    djblets/webapi/resources/mixins/api_tokens.py
    djblets/webapi/auth/backends/oauth2_tokens.py
    djblets/webapi/tests/test_oauth2_auth_backend.py
    djblets/webapi/resources/mixins/oauth2_tokens.py
    djblets/webapi/tests/test_basic_auth_backend.py
    djblets/webapi/tests/test_api_auth_backend.py
    djblets/webapi/tests/test_base_auth_backend.py
    djblets/webapi/auth/backends/api_tokens.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/webapi/resources/mixins/api_tokens.py
    djblets/webapi/auth/backends/oauth2_tokens.py
    djblets/webapi/tests/test_oauth2_auth_backend.py
    djblets/webapi/resources/mixins/oauth2_tokens.py
    djblets/webapi/tests/test_basic_auth_backend.py
    djblets/webapi/tests/test_api_auth_backend.py
    djblets/webapi/tests/test_base_auth_backend.py
    djblets/webapi/auth/backends/api_tokens.py

djblets/webapi/auth/backends/oauth2_tokens.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
djblets/webapi/tests/test_api_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
 'BaseWebAPIToken' imported but unused
```
djblets/webapi/tests/test_api_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 19
 E251 unexpected spaces around keyword / parameter equals
```
djblets/webapi/tests/test_api_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 17
 E251 unexpected spaces around keyword / parameter equals
```
djblets/webapi/tests/test_api_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 18
 E251 unexpected spaces around keyword / parameter equals
```
djblets/webapi/tests/test_api_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 20
 E251 unexpected spaces around keyword / parameter equals
```
djblets/webapi/tests/test_api_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 17
 E251 unexpected spaces around keyword / parameter equals
```
djblets/webapi/tests/test_api_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 19
 E251 unexpected spaces around keyword / parameter equals
```
djblets/webapi/tests/test_api_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 18
 E251 unexpected spaces around keyword / parameter equals
```
djblets/webapi/tests/test_api_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 20
 E251 unexpected spaces around keyword / parameter equals
```
djblets/webapi/tests/test_base_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 63
 E231 missing whitespace after ','
```
djblets/webapi/tests/test_basic_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
djblets/webapi/tests/test_basic_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
djblets/webapi/tests/test_oauth2_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
 'BaseWebAPIToken' imported but unused
```
djblets/webapi/tests/test_oauth2_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 17
 E251 unexpected spaces around keyword / parameter equals
```
djblets/webapi/tests/test_oauth2_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 19
 E251 unexpected spaces around keyword / parameter equals
```
djblets/webapi/tests/test_oauth2_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 18
 E251 unexpected spaces around keyword / parameter equals
```
djblets/webapi/tests/test_oauth2_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 20
 E251 unexpected spaces around keyword / parameter equals
```
djblets/webapi/tests/test_oauth2_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 17
 E251 unexpected spaces around keyword / parameter equals
```
djblets/webapi/tests/test_oauth2_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 19
 E251 unexpected spaces around keyword / parameter equals
```
djblets/webapi/tests/test_oauth2_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 18
 E251 unexpected spaces around keyword / parameter equals
```
djblets/webapi/tests/test_oauth2_auth_backend.py (Diff revision 4)
An issue was opened. Show all issues
```
Col: 20
 E251 unexpected spaces around keyword / parameter equals
```

Status:: Discarded

~		Prior to this commit. A user can manage list of all OAuth2 client applications
	~	Prior to this commit, there is no mechanism to authorize resources using OAuth2
-		and OAuth2 tokens but there is no mechanism to authorize resources using OAuth2
		protocol. In this commit, OAuth2 authorization mechanism is added to
~		the current authorization mechanism for Review Board web API resources.
	~	the current authorization mechanism for web API resources.
		Services now can follow OAuth2 protocol, send a request with appropriate
~		authorization header to work with Review Board's resources. All the scopes
~		are loaded at RB start time, and external services can request a token with
~		specify scope through OAuth2 protocol. When using Review Board's API resource,
~		the scope of a token is checked to make sure that the external service has
	~	authorization header to work with Djblet's resources. External services can
	~	request a token with specify scope through OAuth2 protocol. When using Djblet's
	~	API resource, the scope of a token is checked to make sure that the
	~	external service has the right permission the resource.
-		the right permission the resource. This commit affects both djblets and
-		reviewboard files at the same time.