Summary

[OAuth2Provider] Added API and resource in front end to manage OAuth2 client apps

Review Request #7993 — Created Feb. 23, 2016 and discarded Sept. 7, 2017, 9 p.m.

Information

Owner

lehoangm

Repository

Review Board

Branch

master

Bugs

Depends On

~~7941~~

Reviewers

Groups

reviewboard

People

brennie, chipx86

Description

This patch add full API support to get lists of OAuth2 client app,
get, update or delete a single app instance or create a new one.
User can also operate those operation through the webUI at My account
page.

Testing Done

Ran python ./tests/runtests.py reviewboard.webapi.tests.test_oauth2_client_app

Test DELETE, GET, PUT on single item
Test GET, POST on list endpoint

Issues

Description	From	Last Updated
These should probably be rolled up into the change introducing this code. Same with all other relevant code.	chipx86	March 6, 2016, 12:07 a.m.
Should be "number".	chipx86	March 6, 2016, 12:07 a.m.
Blank line between these.	chipx86	March 6, 2016, 12:07 a.m.
Should be "string".	chipx86	March 6, 2016, 12:09 a.m.
No trailing comma.	chipx86	March 6, 2016, 12:09 a.m.
Should be rolled up into the change that introduces this.	chipx86	March 6, 2016, 12:09 a.m.
No trailing comma.	chipx86	March 6, 2016, 1:05 a.m.
No need for this. Instead, pass a this parameter to ready, and you'll be able to use this within the …	chipx86	March 6, 2016, 1:05 a.m.
Space before {.	chipx86	March 6, 2016, 1:06 a.m.
Please make sure you're following the proper styles and types for all these.	chipx86	March 6, 2016, 1:35 a.m.
You can't call gettext() on a variable. Only on literal strings. The saveButtonText and title values passed in must use …	chipx86	March 6, 2016, 1:13 a.m.
Blank line between these.	chipx86	March 6, 2016, 1:36 a.m.
Space before ( and after ).	chipx86	March 6, 2016, 1:13 a.m.
No trailing comma.	chipx86	March 6, 2016, 1:14 a.m.
Can't call gettext() on a variable.	chipx86	March 6, 2016, 1:14 a.m.
You can just bind to this._cancel.	chipx86	March 6, 2016, 1:14 a.m.
Should be more descriptive, like _onConfirmCancelClicked. Also, callback handlers should go after any other private functions.	chipx86	March 6, 2016, 1:16 a.m.
Multi-line comments must be in the form of: /* * line * line */ Also, these are wrapping too early.	chipx86	March 6, 2016, 1:17 a.m.
Indentation is wrong on the secnod line. Must indent only 4 spaces. Same below.	chipx86	March 6, 2016, 1:35 a.m.
Should be _$clientIdField. No capital C.	chipx86	March 6, 2016, 1:18 a.m.
This is too long. Instead, wrap like: this._$authorizationGrantTypeField = this._$selectAUthorizationGrantType.bindProperty( ...);	chipx86	March 6, 2016, 1:19 a.m.
Space before (.	chipx86	March 6, 2016, 1:19 a.m.
Should be something like _onSaveAppClicked.	chipx86	March 6, 2016, 1:35 a.m.
Blank line between these.	chipx86	March 6, 2016, 1:20 a.m.
This should all be done directly in render.	chipx86	March 6, 2016, 1:21 a.m.
This should probably be rolled back into the change introducing this.	chipx86	March 6, 2016, 12:12 a.m.
No trailing comma.	chipx86	March 6, 2016, 1:21 a.m.
No trailing comma.	chipx86	March 6, 2016, 1:21 a.m.
No trailing comma.	chipx86	March 6, 2016, 1:22 a.m.
Col: 80 E501 line too long (84 > 79 characters)	reviewbot	March 6, 2016, 12:03 a.m.
Should all be in the same import group, in alphabetical order.	chipx86	March 6, 2016, 1:23 a.m.
These should not be in the same import group.	chipx86	March 6, 2016, 1:23 a.m.
'webapi_check_local_site' imported but unused	reviewbot	March 6, 2016, 12:03 a.m.
Blank line between these.	chipx86	March 6, 2016, 1:23 a.m.
Col: 80 E501 line too long (92 > 79 characters)	reviewbot	March 6, 2016, 12:04 a.m.
We probably want a has_list_access_permissions that prevents anyone but this user from accessing these apps.	chipx86	March 6, 2016, 1:25 a.m.
This should go into more detail about how to use this resource. This will be directly used in our online …	chipx86	March 11, 2016, 6:12 a.m.
Col: 27 E251 unexpected spaces around keyword / parameter equals	reviewbot	March 6, 2016, 12:04 a.m.
No comma, since this is a function call.	chipx86	March 6, 2016, 1:25 a.m.
"client" This should also go into further details on the kind of updates that are allowed.	chipx86	March 11, 2016, 6:12 a.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	March 6, 2016, 12:33 a.m.
Each keyword argument should actually be a keyword argument on the function, defaulting to None.	chipx86	March 6, 2016, 1:27 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 11, 2016, 6:11 a.m.
Missing docs.	chipx86	March 11, 2016, 6:11 a.m.
Blank line between these.	chipx86	March 6, 2016, 1:29 a.m.
Each keyword argument should actually be a keyword argument on the function.	chipx86	March 11, 2016, 6:11 a.m.
Blank line between these.	chipx86	March 6, 2016, 1:34 a.m.
Blank line between these.	chipx86	March 6, 2016, 1:34 a.m.
Blank line between these.	chipx86	March 6, 2016, 1:34 a.m.
'timezone' imported but unused	reviewbot	March 11, 2016, 7:30 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 11, 2016, 7:30 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 11, 2016, 7:30 a.m.
Col: 80 E501 line too long (85 > 79 characters)	reviewbot	March 11, 2016, 7:30 a.m.
Col: 80 E501 line too long (86 > 79 characters)	reviewbot	March 11, 2016, 7:30 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 11, 2016, 7:30 a.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	March 11, 2016, 7:30 a.m.
Col: 80 E501 line too long (86 > 79 characters)	reviewbot	March 11, 2016, 7:30 a.m.
Col: 5 E303 too many blank lines (2)	reviewbot	March 11, 2016, 7:30 a.m.
Col: 69 W292 no newline at end of file	reviewbot	March 11, 2016, 7:30 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 11, 2016, 3:45 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 11, 2016, 3:45 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 11, 2016, 3:45 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/accounts/forms/pages.py
    reviewboard/webapi/resources/oauth2_client_app.py

Ignored Files:
    reviewboard/templates/accounts/oauth2_client_application.html
    reviewboard/static/rb/js/resources/models/oauth2ClientAppModel.js
    reviewboard/static/rb/js/accountPrefsPage/views/oauth2ClientAppsView.js



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/accounts/forms/pages.py
    reviewboard/webapi/resources/oauth2_client_app.py

Ignored Files:
    reviewboard/templates/accounts/oauth2_client_application.html
    reviewboard/static/rb/js/resources/models/oauth2ClientAppModel.js
    reviewboard/static/rb/js/accountPrefsPage/views/oauth2ClientAppsView.js

reviewboard/webapi/resources/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (84 > 79 characters)
```
reviewboard/webapi/resources/oauth2_client_app.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'webapi_check_local_site' imported but unused
```
reviewboard/webapi/resources/oauth2_client_app.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (92 > 79 characters)
```
reviewboard/webapi/resources/oauth2_client_app.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 27
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/webapi/resources/oauth2_client_app.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/webapi/resources/oauth2_client_app.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```