Bump jasmine to 2.4.1.

 






 

 


  Review Request #7965
  —
  Created Feb. 15, 2016 and submitted 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-2.6.x
 









 
 

  
 









 
 

  
 









 
 

  384e1fb...
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change moves us over to a modern version of jasmine, which features

a nicer async mechanism and a bunch of arbitrarily renamed APIs.

 








  


 
 

  
Ran js-tests. Saw that everything passed.

 







 









 





  








 

  
  


   

    

     

     

     

    

   


   

  

 







 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
It seems odd having the describe with a it containing no description. Is that how the async stuff is supposed …

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
This is over the 80 char limit now. Can you rework this?

      		
      
       chipx86chipx86
      
      
       
      
     




     

      
       
       
Here, too.

      		
      
       chipx86chipx86
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/tests/diffReviewableModelTests.js
    reviewboard/static/rb/js/models/tests/reviewReplyEditorModelTests.js
    reviewboard/static/lib/js/jasmine-1.3.1.js
    reviewboard/static/rb/js/views/tests/screenshotThumbnailViewTests.js
    reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.js
    reviewboard/static/lib/js/jasmine-html-2.4.1.js
    reviewboard/static/rb/js/resources/collections/tests/repositoryCommitsCollectionTests.js
    reviewboard/static/rb/js/resources/models/tests/generalCommentModelTests.js
    reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.js
    reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
    reviewboard/static/rb/js/views/tests/reviewReplyEditorViewTests.js
    reviewboard/static/lib/css/jasmine-2.4.1.css
    reviewboard/static/rb/js/views/tests/reviewBoxViewTests.js
    reviewboard/static/rb/js/resources/models/tests/draftReviewModelTests.js
    reviewboard/static/rb/js/resources/models/tests/reviewRequestModelTests.js
    reviewboard/static/lib/js/jasmine-2.4.1.js
    reviewboard/static/rb/js/views/tests/diffFragmentQueueViewTests.js
    reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.js
    reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.js
    reviewboard/static/rb/js/views/tests/draftReviewBannerViewTests.js
    reviewboard/static/rb/js/views/tests/fileAttachmentThumbnailViewTests.js
    reviewboard/static/rb/js/resources/models/tests/fileAttachmentCommentModelTests.js
    reviewboard/static/rb/js/models/tests/userSessionModelTests.js
    reviewboard/static/rb/js/views/tests/reviewDialogViewTests.js
    reviewboard/static/rb/js/pages/views/tests/reviewablePageViewTests.js
    reviewboard/static/lib/js/jasmine-boot-2.4.1.js
    reviewboard/templates/js/tests.html
    reviewboard/static/rb/js/views/tests/reviewReplyDraftBannerViewTests.js
    reviewboard/static/rb/js/resources/models/tests/draftReviewRequestModelTests.js
    reviewboard/static/rb/js/views/tests/commentDialogViewTests.js
    reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js
    reviewboard/static/rb/js/resources/models/tests/screenshotCommentModelTests.js
    reviewboard/static/rb/js/resources/collections/tests/resourceCollectionTests.js
    reviewboard/static/rb/js/newReviewRequest/views/tests/postCommitViewTests.js
    reviewboard/static/lib/js/jasmine-html-1.3.1.js
    reviewboard/static/rb/js/views/tests/reviewBoxListViewTests.js
    reviewboard/static/rb/css/pages/js-tests.less
    reviewboard/static/rb/js/models/tests/commentEditorModelTests.js
    reviewboard/static/rb/js/resources/models/tests/diffCommentModelTests.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/tests/diffReviewableModelTests.js
    reviewboard/static/rb/js/models/tests/reviewReplyEditorModelTests.js
    reviewboard/static/lib/js/jasmine-1.3.1.js
    reviewboard/static/rb/js/views/tests/screenshotThumbnailViewTests.js
    reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.js
    reviewboard/static/lib/js/jasmine-html-2.4.1.js
    reviewboard/static/rb/js/resources/collections/tests/repositoryCommitsCollectionTests.js
    reviewboard/static/rb/js/resources/models/tests/generalCommentModelTests.js
    reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.js
    reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
    reviewboard/static/rb/js/views/tests/reviewReplyEditorViewTests.js
    reviewboard/static/lib/css/jasmine-2.4.1.css
    reviewboard/static/rb/js/views/tests/reviewBoxViewTests.js
    reviewboard/static/rb/js/resources/models/tests/draftReviewModelTests.js
    reviewboard/static/rb/js/resources/models/tests/reviewRequestModelTests.js
    reviewboard/static/lib/js/jasmine-2.4.1.js
    reviewboard/static/rb/js/views/tests/diffFragmentQueueViewTests.js
    reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.js
    reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.js
    reviewboard/static/rb/js/views/tests/draftReviewBannerViewTests.js
    reviewboard/static/rb/js/views/tests/fileAttachmentThumbnailViewTests.js
    reviewboard/static/rb/js/resources/models/tests/fileAttachmentCommentModelTests.js
    reviewboard/static/rb/js/models/tests/userSessionModelTests.js
    reviewboard/static/rb/js/views/tests/reviewDialogViewTests.js
    reviewboard/static/rb/js/pages/views/tests/reviewablePageViewTests.js
    reviewboard/static/lib/js/jasmine-boot-2.4.1.js
    reviewboard/templates/js/tests.html
    reviewboard/static/rb/js/views/tests/reviewReplyDraftBannerViewTests.js
    reviewboard/static/rb/js/resources/models/tests/draftReviewRequestModelTests.js
    reviewboard/static/rb/js/views/tests/commentDialogViewTests.js
    reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js
    reviewboard/static/rb/js/resources/models/tests/screenshotCommentModelTests.js
    reviewboard/static/rb/js/resources/collections/tests/resourceCollectionTests.js
    reviewboard/static/rb/js/newReviewRequest/views/tests/postCommitViewTests.js
    reviewboard/static/lib/js/jasmine-html-1.3.1.js
    reviewboard/static/rb/js/views/tests/reviewBoxListViewTests.js
    reviewboard/static/rb/css/pages/js-tests.less
    reviewboard/static/rb/js/models/tests/commentEditorModelTests.js
    reviewboard/static/rb/js/resources/models/tests/diffCommentModelTests.js


    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




brennie




   

   







  

 



 

  


   

   

    
 
brennie


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    The js-tests.less, iirc, had some hand-modified styles I put in. Before we nuke it, I want to make sure there's nothing missing in the styles. Can you show screenshots of how things look now?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Do you know what the modifications were?
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      I don't :/
      
 
      

      3. 


 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    It seems odd having the describe with a it containing no description. Is that how the async stuff is supposed to work now?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      The beforeEach, it, andafterEach methods all now take a "done" callback. This seemed to be the least invasive change to keep things working (and the tree still looks and links right). That said, I think I can make this better.
      
 
      

      2. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    This is over the 80 char limit now. Can you rework this?
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    Here, too.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    5. 




  5. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    6. 




  

 
















 



 

  

   




david




   

   

  

 



 















 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Tool: Pyflakes
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/tests/diffReviewableModelTests.js
    reviewboard/static/rb/js/models/tests/reviewReplyEditorModelTests.js
    reviewboard/static/lib/js/jasmine-1.3.1.js
    reviewboard/static/rb/js/views/tests/screenshotThumbnailViewTests.js
    reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.js
    reviewboard/static/lib/js/jasmine-html-2.4.1.js
    reviewboard/static/rb/js/resources/collections/tests/repositoryCommitsCollectionTests.js
    reviewboard/static/rb/js/resources/models/tests/generalCommentModelTests.js
    reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.js
    reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
    reviewboard/static/rb/js/views/tests/reviewReplyEditorViewTests.js
    reviewboard/static/lib/css/jasmine-2.4.1.css
    reviewboard/static/rb/js/views/tests/reviewBoxViewTests.js
    reviewboard/static/rb/js/resources/models/tests/draftReviewModelTests.js
    reviewboard/static/rb/js/resources/models/tests/reviewRequestModelTests.js
    reviewboard/static/lib/js/jasmine-2.4.1.js
    reviewboard/static/rb/js/views/tests/diffFragmentQueueViewTests.js
    reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.js
    reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.js
    reviewboard/static/rb/js/views/tests/draftReviewBannerViewTests.js
    reviewboard/static/rb/js/views/tests/fileAttachmentThumbnailViewTests.js
    reviewboard/static/rb/js/resources/models/tests/fileAttachmentCommentModelTests.js
    reviewboard/static/rb/js/models/tests/userSessionModelTests.js
    reviewboard/static/rb/js/views/tests/reviewDialogViewTests.js
    reviewboard/static/rb/js/pages/views/tests/reviewablePageViewTests.js
    reviewboard/static/lib/js/jasmine-boot-2.4.1.js
    reviewboard/templates/js/tests.html
    reviewboard/static/rb/js/views/tests/reviewReplyDraftBannerViewTests.js
    reviewboard/static/rb/js/resources/models/tests/draftReviewRequestModelTests.js
    reviewboard/static/rb/js/views/tests/commentDialogViewTests.js
    reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js
    reviewboard/static/rb/js/resources/models/tests/screenshotCommentModelTests.js
    reviewboard/static/rb/js/resources/collections/tests/resourceCollectionTests.js
    reviewboard/static/rb/js/newReviewRequest/views/tests/postCommitViewTests.js
    reviewboard/static/lib/js/jasmine-html-1.3.1.js
    reviewboard/static/rb/js/views/tests/reviewBoxListViewTests.js
    reviewboard/static/rb/css/pages/js-tests.less
    reviewboard/static/rb/js/models/tests/commentEditorModelTests.js
    reviewboard/static/rb/js/resources/models/tests/diffCommentModelTests.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/tests/diffReviewableModelTests.js
    reviewboard/static/rb/js/models/tests/reviewReplyEditorModelTests.js
    reviewboard/static/lib/js/jasmine-1.3.1.js
    reviewboard/static/rb/js/views/tests/screenshotThumbnailViewTests.js
    reviewboard/static/rb/js/resources/collections/tests/repositoryBranchesCollectionTests.js
    reviewboard/static/lib/js/jasmine-html-2.4.1.js
    reviewboard/static/rb/js/resources/collections/tests/repositoryCommitsCollectionTests.js
    reviewboard/static/rb/js/resources/models/tests/generalCommentModelTests.js
    reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.js
    reviewboard/static/rb/js/resources/models/tests/baseResourceModelTests.js
    reviewboard/static/rb/js/views/tests/reviewRequestEditorViewTests.js
    reviewboard/static/rb/js/views/tests/reviewReplyEditorViewTests.js
    reviewboard/static/lib/css/jasmine-2.4.1.css
    reviewboard/static/rb/js/views/tests/reviewBoxViewTests.js
    reviewboard/static/rb/js/resources/models/tests/draftReviewModelTests.js
    reviewboard/static/rb/js/resources/models/tests/reviewRequestModelTests.js
    reviewboard/static/lib/js/jasmine-2.4.1.js
    reviewboard/static/rb/js/views/tests/diffFragmentQueueViewTests.js
    reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.js
    reviewboard/static/rb/js/resources/models/tests/reviewGroupModelTests.js
    reviewboard/static/rb/js/views/tests/draftReviewBannerViewTests.js
    reviewboard/static/rb/js/views/tests/fileAttachmentThumbnailViewTests.js
    reviewboard/static/rb/js/resources/models/tests/fileAttachmentCommentModelTests.js
    reviewboard/static/rb/js/models/tests/userSessionModelTests.js
    reviewboard/static/rb/js/views/tests/reviewDialogViewTests.js
    reviewboard/static/rb/js/pages/views/tests/reviewablePageViewTests.js
    reviewboard/static/lib/js/jasmine-boot-2.4.1.js
    reviewboard/templates/js/tests.html
    reviewboard/static/rb/js/views/tests/reviewReplyDraftBannerViewTests.js
    reviewboard/static/rb/js/resources/models/tests/draftReviewRequestModelTests.js
    reviewboard/static/rb/js/views/tests/commentDialogViewTests.js
    reviewboard/static/rb/js/models/tests/reviewRequestEditorModelTests.js
    reviewboard/static/rb/js/resources/models/tests/screenshotCommentModelTests.js
    reviewboard/static/rb/js/resources/collections/tests/resourceCollectionTests.js
    reviewboard/static/rb/js/newReviewRequest/views/tests/postCommitViewTests.js
    reviewboard/static/lib/js/jasmine-html-1.3.1.js
    reviewboard/static/rb/js/views/tests/reviewBoxListViewTests.js
    reviewboard/static/rb/css/pages/js-tests.less
    reviewboard/static/rb/js/models/tests/commentEditorModelTests.js
    reviewboard/static/rb/js/resources/models/tests/diffCommentModelTests.js


    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to release-2.6.x (5fe9e64)