local variable 'server_url' is assigned to but never used

'GitDiffParser' imported but unused

Col: 1 E302 expected 2 blank lines, found 1

Col: 5 E265 block comment should start with '# '

Col: 9 E116 unexpected indentation (comment)

Col: 9 E116 unexpected indentation (comment)

Col: 9 E265 block comment should start with '# '

Col: 9 E265 block comment should start with '# '

Col: 9 E265 block comment should start with '# '

Col: 9 E265 block comment should start with '# '

Col: 9 E265 block comment should start with '# '

Col: 54 E221 multiple spaces before operator

Col: 13 E128 continuation line under-indented for visual indent

Col: 13 E128 continuation line under-indented for visual indent

Col: 13 E128 continuation line under-indented for visual indent

Col: 13 E128 continuation line under-indented for visual indent

Col: 13 E128 continuation line under-indented for visual indent

Col: 13 E128 continuation line under-indented for visual indent

Col: 20 E225 missing whitespace around operator

Col: 58 E225 missing whitespace around operator

Col: 9 E265 block comment should start with '# '

Col: 9 E265 block comment should start with '# '

Col: 9 E265 block comment should start with '# '

local variable 'server_url' is assigned to but never used

Col: 1 E302 expected 2 blank lines, found 1

Col: 5 E265 block comment should start with '# '

Col: 9 E116 unexpected indentation (comment)

Col: 9 E116 unexpected indentation (comment)

Col: 9 E265 block comment should start with '# '

Col: 9 E265 block comment should start with '# '

Col: 9 E265 block comment should start with '# '

Col: 9 E265 block comment should start with '# '

Col: 9 E265 block comment should start with '# '

Col: 54 E221 multiple spaces before operator

Col: 13 E128 continuation line under-indented for visual indent

Col: 13 E128 continuation line under-indented for visual indent

Col: 13 E128 continuation line under-indented for visual indent

Col: 13 E128 continuation line under-indented for visual indent

Col: 13 E128 continuation line under-indented for visual indent

Col: 13 E128 continuation line under-indented for visual indent

Col: 9 E265 block comment should start with '# '

Col: 9 E265 block comment should start with '# '

Col: 20 E225 missing whitespace around operator

Col: 58 E225 missing whitespace around operator

Col: 9 E265 block comment should start with '# '

Col: 9 E265 block comment should start with '# '

Col: 9 E265 block comment should start with '# '

local variable 'server_url' is assigned to but never used

Col: 1 E302 expected 2 blank lines, found 1

Col: 65 E226 missing whitespace around arithmetic operator

Col: 65 E226 missing whitespace around arithmetic operator

Col: 1 E302 expected 2 blank lines, found 1

Col: 65 E226 missing whitespace around arithmetic operator

Col: 1 E302 expected 2 blank lines, found 1

Col: 1 E302 expected 2 blank lines, found 1

Col: 1 E302 expected 2 blank lines, found 1

Col: 45 E226 missing whitespace around arithmetic operator

Col: 19 W292 no newline at end of file

'spy_on' imported but unused

Col: 80 E501 line too long (84 > 79 characters)

Col: 13 E128 continuation line under-indented for visual indent

Col: 13 E128 continuation line under-indented for visual indent

local variable 'response' is assigned to but never used

Col: 80 E501 line too long (81 > 79 characters)

Col: 23 E231 missing whitespace after ':'

'File' imported but unused

'DiffCompatVersion' imported but unused

'DiffSet' imported but unused

'FileDiff' imported but unused

'GitDiffParser' imported but unused

Col: 1 E302 expected 2 blank lines, found 1

Col: 17 E128 continuation line under-indented for visual indent

Col: 80 E501 line too long (80 > 79 characters)

Col: 17 E128 continuation line under-indented for visual indent

Col: 1 E302 expected 2 blank lines, found 1

Col: 1 E302 expected 2 blank lines, found 1

Col: 80 E501 line too long (82 > 79 characters)

Col: 18 E225 missing whitespace around operator

Col: 17 E225 missing whitespace around operator

Col: 35 E231 missing whitespace after ':'

Col: 80 E501 line too long (87 > 79 characters)

local variable 'diffset' is assigned to but never used

Col: 1 E302 expected 2 blank lines, found 1

Col: 1 E302 expected 2 blank lines, found 1

Col: 45 E226 missing whitespace around arithmetic operator

Col: 1 E302 expected 2 blank lines, found 1

Col: 17 W292 no newline at end of file

Col: 80 E501 line too long (113 > 79 characters)

Col: 13 E128 continuation line under-indented for visual indent

Col: 13 E128 continuation line under-indented for visual indent

Col: 13 E128 continuation line under-indented for visual indent

Col: 43 E231 missing whitespace after ':'

Col: 44 E203 whitespace before ','

Col: 45 E231 missing whitespace after ','

Col: 13 E128 continuation line under-indented for visual indent

Col: 80 E501 line too long (80 > 79 characters)

Col: 23 E231 missing whitespace after ':'

Col: 23 E231 missing whitespace after ':'

'urllib2' imported but unused

'HttpRequest' imported but unused

'File' imported but unused

'DiffCompatVersion' imported but unused

'DiffSet' imported but unused

'FileDiff' imported but unused

'GitDiffParser' imported but unused

Col: 13 E128 continuation line under-indented for visual indent

Col: 1 E302 expected 2 blank lines, found 1

Col: 17 E128 continuation line under-indented for visual indent

Col: 17 E128 continuation line under-indented for visual indent

Col: 80 E501 line too long (80 > 79 characters)

Col: 17 E128 continuation line under-indented for visual indent

Col: 1 E302 expected 2 blank lines, found 1

Col: 1 E302 expected 2 blank lines, found 1

Col: 9 E128 continuation line under-indented for visual indent

Col: 9 E128 continuation line under-indented for visual indent

Col: 26 E231 missing whitespace after ','

Col: 1 E302 expected 2 blank lines, found 1

Col: 1 E302 expected 2 blank lines, found 1

Col: 45 E226 missing whitespace around arithmetic operator

Col: 1 E302 expected 2 blank lines, found 1

Col: 1 E302 expected 2 blank lines, found 1

local variable 'token' is assigned to but never used

undefined name 'tkn'

Col: 9 E128 continuation line under-indented for visual indent

Col: 20 W292 no newline at end of file

Col: 80 E501 line too long (113 > 79 characters)

Col: 13 E128 continuation line under-indented for visual indent

Col: 13 E128 continuation line under-indented for visual indent

Col: 13 E128 continuation line under-indented for visual indent

Col: 43 E231 missing whitespace after ':'

Col: 44 E203 whitespace before ','

Col: 45 E231 missing whitespace after ','

Col: 13 E128 continuation line under-indented for visual indent

Col: 80 E501 line too long (80 > 79 characters)

Col: 23 E231 missing whitespace after ':'

Col: 23 E231 missing whitespace after ':'

Col: 80 E501 line too long (80 > 79 characters)

Col: 13 E128 continuation line under-indented for visual indent

Col: 45 E226 missing whitespace around arithmetic operator

Col: 80 E501 line too long (106 > 79 characters)

Col: 80 E501 line too long (90 > 79 characters)

Col: 13 E131 continuation line unaligned for hanging indent

Col: 1 E302 expected 2 blank lines, found 1

local variable 'response' is assigned to but never used

No blank line here.

This looks like leftover debug code?

Let's be explicit with the naming: "pull_request" and "pull-request", instead of "pr".

Needs a docstring. See https://www.reviewboard.org/docs/codebase/dev/docs/writing-codebase-docs/

This is only used in one place, so you can just inline review_request.repository in that place.

We don't use this form in our codebase. Should be: if review_request.approved: status = 'success' else: status = 'pending'

Leftover debugging.

_tag_branch (and most of these other methods) should be methods on the class, rather than being top-level functions.

No need for this return.

No blank line.

This should go into further detail on exactly what will be happening, from a high level. Also needs info on …

Leftover debugging.

Blank line between these.

Leftover debugging.

Blank line between these.

This is better formatted like: extra_data_dict = json.dumps({ 'id': ..., 'statuses_url': ..., ... })

Should be abbreviated "review_request", not "rr", for consistency with the rest of the codebase.

Instead of creating all this yourself, you should use ReviewRequest.objects.create(), which will do a bunch of important things that your …

No need to save the review request after adding the diffset. It doesn't affect the Review Request object.

No blank line here.

Comments should be in sentence casing and end with a period. This is also wrapping a bit early.

Leftover debugging.

Needs to follow the docstring conventions outlined in the guide above. Same with the other functions below.

Most of this should be inlined: return { 'repository': ..., 'summary': ..., ... }

Leftover debugging.

Since this is having to wrap a bit awkwardly, let's pull it out into its own variable.

Leftover debugging.

Blank line between these. Also, the logging.error should be a logging.exception. No need for exc_info=1 in this case.

Best not to abbreviate so much. "tkn" should be "token". Same everywhere else.

Indentation is a bit weird. Instead, I'd do: ghc.api_post( status_url, json.dumps({ ... }), headers={ 'Authorization': token, })

Everything should be in sentence casing and end with a period.

Leftover debugging.

Where does the -5 come from? If we have to use a number like this, we should document it.

Leftover debugging. Check the rest of the file for this as well.

Can be one statement.

This means we'll crash when someone issues a merge. Best to have a proper error instead.

Blank line between these.

Not sure what this is really trying to say.

Blank line between code and comments.

Typo.

Blank line between code and blocks.

We have a constant for this: ReviewRequest.CLOSE_SUBMITTED.

Blank line between these.

code is an integer. Also, there are constants you should compare against in httplib.

Blank line between these.

Must follow our docstring format. First line has to be a single-line summary, and we need parameter docs. See the …

Should only have a single from ... import per module. Use parens to wrap.

""" on the next line.

Should have a trailing comma.

Here, too.

Same here. Needs to check a flag. Also, it's assuming there's a hosting_service that isn't None, which is a bad …

Leftover debugging.

Unnecessary new blank line.

Same here about checking a capability and hosting_service None-ness. Blank line before and after the conditional block.

This code should never know about the specifics of the service being used. Instead, have a capability flag on the …

Col: 13 E131 continuation line unaligned for hanging indent

Since we want to move to using the API and not this, please make a note here with a big …

Col: 80 E501 line too long (81 > 79 characters)

undefined name '_get_auth_token'

undefined name 'statuses_url'

undefined name '_get_auth_token'

Col: 21 E222 multiple spaces after operator

Col: 80 E501 line too long (91 > 79 characters)

Col: 33 E128 continuation line under-indented for visual indent

Col: 32 E126 continuation line over-indented for hanging indent

Col: 33 E122 continuation line missing indentation or outdented

Col: 1 W391 blank line at end of file

Col: 9 E303 too many blank lines (2)

Col: 80 E501 line too long (88 > 79 characters)

'GitHub' imported but unused

undefined name 'merge_pull_request'

'DiffSetHistory' imported but unused

Col: 80 E501 line too long (81 > 79 characters)

'HostingServiceError' imported but unused

undefined name 'HostingServiceError'

Col: 36 E126 continuation line over-indented for hanging indent

Col: 33 E126 continuation line over-indented for hanging indent