• 
      

    Status API

    Review Request #7961 — Created Feb. 14, 2016 and discarded

    Information

    Review Board
    master

    Reviewers

    Basic GET/POST/PUT request handlers are done. The basic statuses has type Success(represented as "S"), Failure("F") and Pending("P").
    Unit tests are written for new features.
    UI for displaying statuses are created.

    A demo for latest version can be viewed at:
    https://drive.google.com/file/d/0B9f_D8xqWtODX01NMTFiZ2hfOG8/view?usp=sharing

    What to be done next:
    Statuses are referenced by internally generated status id. Should change to a unique client ID.
    Work with ReviewBot on grouping reviews of latest statuses.
    Add filter to whether the statuses are current for the latest change (should probably default to only showing for the latest change)

    It's best to start looking at webapi/resources/status.py and reviews/models/status.py for implementation.

    Some sample requests to be made are:
    Get all statuses on a review request:
    curl host/api/review-requests/1/statuss/

    GET request with some filter options:
    curl host/api/review-requests/1/statuss/?status_type=P
    curl host/api/review-requests/1/statuss/?time=YYYY-MM-DD-HH-MM-SS

    POST request (need authorization info):
    curl -X POST host/api/review-requests/1/statuss/ -d "context=Travis%20CI&label=Failed&progress=F&url=continuous-integration/travis&url_label=Build%20log" -A application/json

    PUT request (need authorization info):
    curl -X PUT host/api/review-requests/1/statuss/1/ -d "context=Unit%20Testing&label=Success&progress=S" -A application/json

    
     
    Description From Last Updated

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 63 W291 trailing whitespace

    reviewbotreviewbot

    Col: 60 W291 trailing whitespace

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 76 W291 trailing whitespace

    reviewbotreviewbot

    Col: 29 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 33 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 62 W291 trailing whitespace

    reviewbotreviewbot

    Col: 37 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 37 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 37 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 29 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 1 W391 blank line at end of file

    reviewbotreviewbot

    Col: 54 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 56 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 64 W291 trailing whitespace

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 18 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 20 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 53 W291 trailing whitespace

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 24 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 26 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 56 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 58 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 74 W291 trailing whitespace

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 59 W291 trailing whitespace

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 63 W291 trailing whitespace

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 76 W291 trailing whitespace

    reviewbotreviewbot

    Col: 29 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 33 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 62 W291 trailing whitespace

    reviewbotreviewbot

    Col: 37 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 37 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 37 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 29 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 1 W391 blank line at end of file

    reviewbotreviewbot

    Col: 58 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 60 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 76 W291 trailing whitespace

    reviewbotreviewbot

    Col: 17 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 22 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 24 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 65 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 67 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 26 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 28 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    'ObjectDoesNotExist' imported but unused

    reviewbotreviewbot

    'Q' imported but unused

    reviewbotreviewbot

    'webapi_response_errors' imported but unused

    reviewbotreviewbot

    'webapi_request_fields' imported but unused

    reviewbotreviewbot

    'webapi_login_required' imported but unused

    reviewbotreviewbot

    'resources' imported but unused

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 59 W291 trailing whitespace

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 63 W291 trailing whitespace

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 76 W291 trailing whitespace

    reviewbotreviewbot

    Col: 29 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 33 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 62 W291 trailing whitespace

    reviewbotreviewbot

    Col: 37 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 37 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 37 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 29 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 1 W391 blank line at end of file

    reviewbotreviewbot

    Col: 58 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 60 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 76 W291 trailing whitespace

    reviewbotreviewbot

    Col: 17 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 22 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 24 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 65 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 67 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 26 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 28 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    'webapi_check_local_site' imported but unused

    reviewbotreviewbot

    undefined name 'review'

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 63 W291 trailing whitespace

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 76 W291 trailing whitespace

    reviewbotreviewbot

    Col: 29 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 33 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 62 W291 trailing whitespace

    reviewbotreviewbot

    Col: 37 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 37 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 37 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 29 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 1 W391 blank line at end of file

    reviewbotreviewbot

    'randint' imported but unused

    reviewbotreviewbot

    Col: 78 W291 trailing whitespace

    reviewbotreviewbot

    Col: 80 E501 line too long (80 > 79 characters)

    reviewbotreviewbot

    Col: 80 W291 trailing whitespace

    reviewbotreviewbot

    Col: 77 W291 trailing whitespace

    reviewbotreviewbot

    Col: 41 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 39 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 25 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    'webapi_check_local_site' imported but unused

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 48 W291 trailing whitespace

    reviewbotreviewbot

    Col: 71 E502 the backslash is redundant between brackets

    reviewbotreviewbot

    Col: 71 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 21 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 28 E131 continuation line unaligned for hanging indent

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 59 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    undefined name 'PublishError'

    reviewbotreviewbot

    'mail' imported but unused

    reviewbotreviewbot

    'add_fixtures' imported but unused

    reviewbotreviewbot

    'PERMISSION_DENIED' imported but unused

    reviewbotreviewbot

    'DOES_NOT_EXIST' imported but unused

    reviewbotreviewbot

    'NOT_LOGGED_IN' imported but unused

    reviewbotreviewbot

    'ReviewRequestChildItemMixin' imported but unused

    reviewbotreviewbot

    'get_status_item_url' imported but unused

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 63 W291 trailing whitespace

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 9 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 76 W291 trailing whitespace

    reviewbotreviewbot

    Col: 29 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 33 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 62 W291 trailing whitespace

    reviewbotreviewbot

    Col: 37 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 37 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 37 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 29 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 1 W391 blank line at end of file

    reviewbotreviewbot

    'randint' imported but unused

    reviewbotreviewbot

    Col: 78 W291 trailing whitespace

    reviewbotreviewbot

    Col: 80 E501 line too long (80 > 79 characters)

    reviewbotreviewbot

    Col: 80 W291 trailing whitespace

    reviewbotreviewbot

    Col: 77 W291 trailing whitespace

    reviewbotreviewbot

    Col: 25 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 39 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 41 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 48 W291 trailing whitespace

    reviewbotreviewbot

    Col: 1 W293 blank line contains whitespace

    reviewbotreviewbot

    Col: 71 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 71 E502 the backslash is redundant between brackets

    reviewbotreviewbot

    Col: 21 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 28 E131 continuation line unaligned for hanging indent

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    undefined name 'PublishError'

    reviewbotreviewbot

    'mail' imported but unused

    reviewbotreviewbot

    'add_fixtures' imported but unused

    reviewbotreviewbot

    'NOT_LOGGED_IN' imported but unused

    reviewbotreviewbot

    'DOES_NOT_EXIST' imported but unused

    reviewbotreviewbot

    'ChangeDescription' imported but unused

    reviewbotreviewbot

    'PUBLISH_ERROR' imported but unused

    reviewbotreviewbot

    Col: 28 E131 continuation line unaligned for hanging indent

    reviewbotreviewbot

    Col: 80 E501 line too long (86 > 79 characters)

    reviewbotreviewbot

    Col: 17 E126 continuation line over-indented for hanging indent

    reviewbotreviewbot

    Col: 17 E126 continuation line over-indented for hanging indent

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 65 W291 trailing whitespace

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 13 E123 closing bracket does not match indentation of opening bracket's line

    reviewbotreviewbot

    Col: 65 W291 trailing whitespace

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 13 E123 closing bracket does not match indentation of opening bracket's line

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 72 W291 trailing whitespace

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 17 E126 continuation line over-indented for hanging indent

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 75 W291 trailing whitespace

    reviewbotreviewbot

    Col: 13 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 13 E123 closing bracket does not match indentation of opening bracket's line

    reviewbotreviewbot

    Col: 1 W391 blank line at end of file

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 68 E502 the backslash is redundant between brackets

    reviewbotreviewbot

    Col: 68 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 17 E126 continuation line over-indented for hanging indent

    reviewbotreviewbot

    Col: 17 E126 continuation line over-indented for hanging indent

    reviewbotreviewbot

    Col: 68 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 17 E126 continuation line over-indented for hanging indent

    reviewbotreviewbot

    Col: 17 E126 continuation line over-indented for hanging indent

    reviewbotreviewbot

    Since this is a status, do we really need "status label", "status progress" and "status description"? I imagine it should …

    mike_conleymike_conley

    We tend to use underscores in our variable names to break up multiple words. This should probably be num_failures. Also, …

    mike_conleymike_conley

    Maybe use count() here instead, unless there's a good reason not to (the only reason we might want len(), as …

    mike_conleymike_conley

    Nit - one space indentation for the HTML in templates. Same goes for the rest of your templates.

    mike_conleymike_conley

    If we can, we should probably avoid inline styling and put this in the CSS for review details instead.

    mike_conleymike_conley

    This needs to be a translatable string - see the "Change Summary:" translation being done on line 42.

    mike_conleymike_conley

    Same as above, re: inline styling. We can use either a class or an attribute to set the state, and …

    mike_conleymike_conley

    Please don't use inline styling if it can be avoided.

    mike_conleymike_conley

    Translate this too, please.

    mike_conleymike_conley

    These <br>'s can probably be avoided here and on line 44 with some margin CSS.

    mike_conleymike_conley

    More inline styles to switch to CSS.

    mike_conleymike_conley

    Can you add a comment about why we're skipping rendering this if there's at least one ChangeDescription? Is this because …

    mike_conleymike_conley

    I don't think this is going out in 2.6. This should probably be 3.0 or 4.0. Maybe ask Christian.

    mike_conleymike_conley

    Col: 80 E501 line too long (83 > 79 characters)

    reviewbotreviewbot

    Col: 65 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot

    Col: 65 E502 the backslash is redundant between brackets

    reviewbotreviewbot

    Col: 65 E251 unexpected spaces around keyword / parameter equals

    reviewbotreviewbot
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/reviews/models/status.py
          reviewboard/reviews/models/__init__.py
      
      Ignored Files:
          reviewboard/templates/reviews/boxes/review.html
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/reviews/models/status.py
          reviewboard/reviews/models/__init__.py
      
      Ignored Files:
          reviewboard/templates/reviews/boxes/review.html
      
      
      WARNING: Number of comments exceeded maximum, showing 30 of 33.
    2. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    3. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    4. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    5. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    6. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    7. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 63
       W291 trailing whitespace
      
    8. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 60
       W291 trailing whitespace
      
    9. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    10. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 76
       W291 trailing whitespace
      
    11. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 29
       E128 continuation line under-indented for visual indent
      
    12. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 33
       E128 continuation line under-indented for visual indent
      
    13. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 62
       W291 trailing whitespace
      
    14. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 37
       E128 continuation line under-indented for visual indent
      
    15. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 37
       E128 continuation line under-indented for visual indent
      
    16. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 37
       E128 continuation line under-indented for visual indent
      
    17. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 29
       E128 continuation line under-indented for visual indent
      
    18. reviewboard/reviews/models/status.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W391 blank line at end of file
      
    19. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
      Col: 54
       E251 unexpected spaces around keyword / parameter equals
      
    20. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
      Col: 56
       E251 unexpected spaces around keyword / parameter equals
      
    21. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
      Col: 64
       W291 trailing whitespace
      
    22. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    23. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
      Col: 18
       E251 unexpected spaces around keyword / parameter equals
      
    24. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
      Col: 20
       E251 unexpected spaces around keyword / parameter equals
      
    25. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
      Col: 53
       W291 trailing whitespace
      
    26. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    27. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
      Col: 24
       E251 unexpected spaces around keyword / parameter equals
      
    28. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
      Col: 26
       E251 unexpected spaces around keyword / parameter equals
      
    29. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
      Col: 56
       E251 unexpected spaces around keyword / parameter equals
      
    30. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
      Col: 58
       E251 unexpected spaces around keyword / parameter equals
      
    31. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
      Col: 74
       W291 trailing whitespace
      
    32. 
        
    SH
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/reviews/evolutions/status_url_label.py
          reviewboard/reviews/evolutions/__init__.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
      
      Ignored Files:
          reviewboard/templates/reviews/boxes/review.html
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/reviews/evolutions/status_url_label.py
          reviewboard/reviews/evolutions/__init__.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
      
      Ignored Files:
          reviewboard/templates/reviews/boxes/review.html
      
      
      WARNING: Number of comments exceeded maximum, showing 30 of 42.
    2. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    3. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    4. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 59
       W291 trailing whitespace
      
    5. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    6. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    7. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    8. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    9. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 63
       W291 trailing whitespace
      
    10. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    11. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    12. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    13. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 76
       W291 trailing whitespace
      
    14. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 29
       E128 continuation line under-indented for visual indent
      
    15. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 33
       E128 continuation line under-indented for visual indent
      
    16. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 62
       W291 trailing whitespace
      
    17. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 37
       E128 continuation line under-indented for visual indent
      
    18. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 37
       E128 continuation line under-indented for visual indent
      
    19. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 37
       E128 continuation line under-indented for visual indent
      
    20. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 29
       E128 continuation line under-indented for visual indent
      
    21. reviewboard/reviews/models/status.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W391 blank line at end of file
      
    22. reviewboard/reviews/views.py (Diff revision 2)
       
       
      Show all issues
      Col: 58
       E251 unexpected spaces around keyword / parameter equals
      
    23. reviewboard/reviews/views.py (Diff revision 2)
       
       
      Show all issues
      Col: 60
       E251 unexpected spaces around keyword / parameter equals
      
    24. reviewboard/reviews/views.py (Diff revision 2)
       
       
      Show all issues
      Col: 76
       W291 trailing whitespace
      
    25. reviewboard/reviews/views.py (Diff revision 2)
       
       
      Show all issues
      Col: 17
       E128 continuation line under-indented for visual indent
      
    26. reviewboard/reviews/views.py (Diff revision 2)
       
       
      Show all issues
      Col: 22
       E251 unexpected spaces around keyword / parameter equals
      
    27. reviewboard/reviews/views.py (Diff revision 2)
       
       
      Show all issues
      Col: 24
       E251 unexpected spaces around keyword / parameter equals
      
    28. reviewboard/reviews/views.py (Diff revision 2)
       
       
      Show all issues
      Col: 65
       E251 unexpected spaces around keyword / parameter equals
      
    29. reviewboard/reviews/views.py (Diff revision 2)
       
       
      Show all issues
      Col: 67
       E251 unexpected spaces around keyword / parameter equals
      
    30. reviewboard/reviews/views.py (Diff revision 2)
       
       
      Show all issues
      Col: 26
       E251 unexpected spaces around keyword / parameter equals
      
    31. reviewboard/reviews/views.py (Diff revision 2)
       
       
      Show all issues
      Col: 28
       E251 unexpected spaces around keyword / parameter equals
      
    32. reviewboard/webapi/resources/status.py (Diff revision 2)
       
       
      Show all issues
       'ObjectDoesNotExist' imported but unused
      
    33. reviewboard/webapi/resources/status.py (Diff revision 2)
       
       
      Show all issues
       'Q' imported but unused
      
    34. reviewboard/webapi/resources/status.py (Diff revision 2)
       
       
      Show all issues
       'webapi_response_errors' imported but unused
      
    35. reviewboard/webapi/resources/status.py (Diff revision 2)
       
       
      Show all issues
       'webapi_request_fields' imported but unused
      
    36. reviewboard/webapi/resources/status.py (Diff revision 2)
       
       
      Show all issues
       'webapi_login_required' imported but unused
      
    37. reviewboard/webapi/resources/status.py (Diff revision 2)
       
       
      Show all issues
       'resources' imported but unused
      
    38. 
        
    SH
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/reviews/evolutions/status_url_label.py
          reviewboard/reviews/evolutions/__init__.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
      
      Ignored Files:
          reviewboard/templates/reviews/boxes/review.html
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/reviews/evolutions/status_url_label.py
          reviewboard/reviews/evolutions/__init__.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
      
      Ignored Files:
          reviewboard/templates/reviews/boxes/review.html
      
      
      WARNING: Number of comments exceeded maximum, showing 30 of 44.
    2. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    3. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    4. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 59
       W291 trailing whitespace
      
    5. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    6. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    7. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    8. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    9. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 63
       W291 trailing whitespace
      
    10. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    11. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    12. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    13. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 76
       W291 trailing whitespace
      
    14. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 29
       E128 continuation line under-indented for visual indent
      
    15. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 33
       E128 continuation line under-indented for visual indent
      
    16. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 62
       W291 trailing whitespace
      
    17. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 37
       E128 continuation line under-indented for visual indent
      
    18. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 37
       E128 continuation line under-indented for visual indent
      
    19. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 37
       E128 continuation line under-indented for visual indent
      
    20. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 29
       E128 continuation line under-indented for visual indent
      
    21. reviewboard/reviews/models/status.py (Diff revision 3)
       
       
      Show all issues
      Col: 1
       W391 blank line at end of file
      
    22. reviewboard/reviews/views.py (Diff revision 3)
       
       
      Show all issues
      Col: 58
       E251 unexpected spaces around keyword / parameter equals
      
    23. reviewboard/reviews/views.py (Diff revision 3)
       
       
      Show all issues
      Col: 60
       E251 unexpected spaces around keyword / parameter equals
      
    24. reviewboard/reviews/views.py (Diff revision 3)
       
       
      Show all issues
      Col: 76
       W291 trailing whitespace
      
    25. reviewboard/reviews/views.py (Diff revision 3)
       
       
      Show all issues
      Col: 17
       E128 continuation line under-indented for visual indent
      
    26. reviewboard/reviews/views.py (Diff revision 3)
       
       
      Show all issues
      Col: 22
       E251 unexpected spaces around keyword / parameter equals
      
    27. reviewboard/reviews/views.py (Diff revision 3)
       
       
      Show all issues
      Col: 24
       E251 unexpected spaces around keyword / parameter equals
      
    28. reviewboard/reviews/views.py (Diff revision 3)
       
       
      Show all issues
      Col: 65
       E251 unexpected spaces around keyword / parameter equals
      
    29. reviewboard/reviews/views.py (Diff revision 3)
       
       
      Show all issues
      Col: 67
       E251 unexpected spaces around keyword / parameter equals
      
    30. reviewboard/reviews/views.py (Diff revision 3)
       
       
      Show all issues
      Col: 26
       E251 unexpected spaces around keyword / parameter equals
      
    31. reviewboard/reviews/views.py (Diff revision 3)
       
       
      Show all issues
      Col: 28
       E251 unexpected spaces around keyword / parameter equals
      
    32. reviewboard/webapi/resources/status.py (Diff revision 3)
       
       
      Show all issues
       'webapi_check_local_site' imported but unused
      
    33. reviewboard/webapi/resources/status.py (Diff revision 3)
       
       
      Show all issues
       undefined name 'review'
      
    34. 
        
    SH
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/boxes/review.html
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/boxes/review.html
      
      
      WARNING: Number of comments exceeded maximum, showing 30 of 38.
    2. reviewboard/reviews/models/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    3. reviewboard/reviews/models/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 63
       W291 trailing whitespace
      
    4. reviewboard/reviews/models/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    5. reviewboard/reviews/models/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    6. reviewboard/reviews/models/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    7. reviewboard/reviews/models/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 76
       W291 trailing whitespace
      
    8. reviewboard/reviews/models/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 29
       E128 continuation line under-indented for visual indent
      
    9. reviewboard/reviews/models/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 33
       E128 continuation line under-indented for visual indent
      
    10. reviewboard/reviews/models/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 62
       W291 trailing whitespace
      
    11. reviewboard/reviews/models/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 37
       E128 continuation line under-indented for visual indent
      
    12. reviewboard/reviews/models/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 37
       E128 continuation line under-indented for visual indent
      
    13. reviewboard/reviews/models/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 37
       E128 continuation line under-indented for visual indent
      
    14. reviewboard/reviews/models/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 29
       E128 continuation line under-indented for visual indent
      
    15. reviewboard/reviews/models/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 1
       W391 blank line at end of file
      
    16. reviewboard/reviews/views.py (Diff revision 4)
       
       
      Show all issues
       'randint' imported but unused
      
    17. reviewboard/reviews/views.py (Diff revision 4)
       
       
      Show all issues
      Col: 78
       W291 trailing whitespace
      
    18. reviewboard/reviews/views.py (Diff revision 4)
       
       
      Show all issues
      Col: 80
       E501 line too long (80 > 79 characters)
      
    19. reviewboard/reviews/views.py (Diff revision 4)
       
       
      Show all issues
      Col: 80
       W291 trailing whitespace
      
    20. reviewboard/reviews/views.py (Diff revision 4)
       
       
      Show all issues
      Col: 77
       W291 trailing whitespace
      
    21. reviewboard/reviews/views.py (Diff revision 4)
       
       
      Show all issues
      Col: 41
       E251 unexpected spaces around keyword / parameter equals
      
    22. reviewboard/reviews/views.py (Diff revision 4)
       
       
      Show all issues
      Col: 39
       E251 unexpected spaces around keyword / parameter equals
      
    23. reviewboard/reviews/views.py (Diff revision 4)
       
       
      Show all issues
      Col: 25
       E128 continuation line under-indented for visual indent
      
    24. reviewboard/webapi/resources/status.py (Diff revision 4)
       
       
      Show all issues
       'webapi_check_local_site' imported but unused
      
    25. reviewboard/webapi/resources/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    26. reviewboard/webapi/resources/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 48
       W291 trailing whitespace
      
    27. reviewboard/webapi/resources/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 71
       E502 the backslash is redundant between brackets
      
    28. reviewboard/webapi/resources/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 71
       E251 unexpected spaces around keyword / parameter equals
      
    29. reviewboard/webapi/resources/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 21
       E128 continuation line under-indented for visual indent
      
    30. reviewboard/webapi/resources/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 28
       E131 continuation line unaligned for hanging indent
      
    31. reviewboard/webapi/resources/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    32. reviewboard/webapi/resources/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    33. reviewboard/webapi/resources/status.py (Diff revision 4)
       
       
      Show all issues
      Col: 59
       E251 unexpected spaces around keyword / parameter equals
      
    34. reviewboard/webapi/resources/status.py (Diff revision 4)
       
       
      Show all issues
       undefined name 'PublishError'
      
    35. reviewboard/webapi/tests/test_status.py (Diff revision 4)
       
       
      Show all issues
       'mail' imported but unused
      
    36. reviewboard/webapi/tests/test_status.py (Diff revision 4)
       
       
      Show all issues
       'add_fixtures' imported but unused
      
    37. reviewboard/webapi/tests/test_status.py (Diff revision 4)
       
       
      Show all issues
       'PERMISSION_DENIED' imported but unused
      
    38. reviewboard/webapi/tests/test_status.py (Diff revision 4)
       
       
      Show all issues
       'DOES_NOT_EXIST' imported but unused
      
    39. reviewboard/webapi/tests/test_status.py (Diff revision 4)
       
       
      Show all issues
       'NOT_LOGGED_IN' imported but unused
      
    40. reviewboard/webapi/tests/test_status.py (Diff revision 4)
       
       
      Show all issues
       'ReviewRequestChildItemMixin' imported but unused
      
    41. reviewboard/webapi/tests/test_status.py (Diff revision 4)
       
       
      Show all issues
       'get_status_item_url' imported but unused
      
    42. 
        
    SH
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/boxes/review.html
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/boxes/review.html
      
      
      WARNING: Number of comments exceeded maximum, showing 30 of 52.
    2. reviewboard/reviews/models/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    3. reviewboard/reviews/models/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 63
       W291 trailing whitespace
      
    4. reviewboard/reviews/models/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    5. reviewboard/reviews/models/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    6. reviewboard/reviews/models/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 9
       E128 continuation line under-indented for visual indent
      
    7. reviewboard/reviews/models/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 76
       W291 trailing whitespace
      
    8. reviewboard/reviews/models/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 29
       E128 continuation line under-indented for visual indent
      
    9. reviewboard/reviews/models/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 33
       E128 continuation line under-indented for visual indent
      
    10. reviewboard/reviews/models/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 62
       W291 trailing whitespace
      
    11. reviewboard/reviews/models/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 37
       E128 continuation line under-indented for visual indent
      
    12. reviewboard/reviews/models/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 37
       E128 continuation line under-indented for visual indent
      
    13. reviewboard/reviews/models/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 37
       E128 continuation line under-indented for visual indent
      
    14. reviewboard/reviews/models/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 29
       E128 continuation line under-indented for visual indent
      
    15. reviewboard/reviews/models/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 1
       W391 blank line at end of file
      
    16. reviewboard/reviews/views.py (Diff revision 5)
       
       
      Show all issues
       'randint' imported but unused
      
    17. reviewboard/reviews/views.py (Diff revision 5)
       
       
      Show all issues
      Col: 78
       W291 trailing whitespace
      
    18. reviewboard/reviews/views.py (Diff revision 5)
       
       
      Show all issues
      Col: 80
       E501 line too long (80 > 79 characters)
      
    19. reviewboard/reviews/views.py (Diff revision 5)
       
       
      Show all issues
      Col: 80
       W291 trailing whitespace
      
    20. reviewboard/reviews/views.py (Diff revision 5)
       
       
      Show all issues
      Col: 77
       W291 trailing whitespace
      
    21. reviewboard/reviews/views.py (Diff revision 5)
       
       
      Show all issues
      Col: 25
       E128 continuation line under-indented for visual indent
      
    22. reviewboard/reviews/views.py (Diff revision 5)
       
       
      Show all issues
      Col: 39
       E251 unexpected spaces around keyword / parameter equals
      
    23. reviewboard/reviews/views.py (Diff revision 5)
       
       
      Show all issues
      Col: 41
       E251 unexpected spaces around keyword / parameter equals
      
    24. reviewboard/webapi/resources/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    25. reviewboard/webapi/resources/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 48
       W291 trailing whitespace
      
    26. reviewboard/webapi/resources/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 1
       W293 blank line contains whitespace
      
    27. reviewboard/webapi/resources/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 71
       E251 unexpected spaces around keyword / parameter equals
      
    28. reviewboard/webapi/resources/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 71
       E502 the backslash is redundant between brackets
      
    29. reviewboard/webapi/resources/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 21
       E128 continuation line under-indented for visual indent
      
    30. reviewboard/webapi/resources/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 28
       E131 continuation line unaligned for hanging indent
      
    31. reviewboard/webapi/resources/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    32. reviewboard/webapi/resources/status.py (Diff revision 5)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    33. reviewboard/webapi/resources/status.py (Diff revision 5)
       
       
      Show all issues
       undefined name 'PublishError'
      
    34. reviewboard/webapi/tests/test_status.py (Diff revision 5)
       
       
      Show all issues
       'mail' imported but unused
      
    35. reviewboard/webapi/tests/test_status.py (Diff revision 5)
       
       
      Show all issues
       'add_fixtures' imported but unused
      
    36. reviewboard/webapi/tests/test_status.py (Diff revision 5)
       
       
      Show all issues
       'NOT_LOGGED_IN' imported but unused
      
    37. reviewboard/webapi/tests/test_status.py (Diff revision 5)
       
       
      Show all issues
       'DOES_NOT_EXIST' imported but unused
      
    38. reviewboard/webapi/tests/test_status.py (Diff revision 5)
       
       
      Show all issues
       'ChangeDescription' imported but unused
      
    39. 
        
    SH
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/resources/base_review.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/boxes/review.html
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/resources/base_review.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/boxes/review.html
      
      
    2. reviewboard/webapi/resources/status.py (Diff revision 6)
       
       
      Show all issues
       'PUBLISH_ERROR' imported but unused
      
    3. reviewboard/webapi/resources/status.py (Diff revision 6)
       
       
      Show all issues
      Col: 28
       E131 continuation line unaligned for hanging indent
      
    4. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 80
       E501 line too long (86 > 79 characters)
      
    5. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 17
       E126 continuation line over-indented for hanging indent
      
    6. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 17
       E126 continuation line over-indented for hanging indent
      
    7. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    8. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 65
       W291 trailing whitespace
      
    9. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    10. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 13
       E123 closing bracket does not match indentation of opening bracket's line
      
    11. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 65
       W291 trailing whitespace
      
    12. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    13. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 13
       E123 closing bracket does not match indentation of opening bracket's line
      
    14. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    15. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 72
       W291 trailing whitespace
      
    16. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    17. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 17
       E126 continuation line over-indented for hanging indent
      
    18. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    19. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 75
       W291 trailing whitespace
      
    20. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 13
       E128 continuation line under-indented for visual indent
      
    21. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 13
       E123 closing bracket does not match indentation of opening bracket's line
      
    22. reviewboard/webapi/tests/test_status.py (Diff revision 6)
       
       
      Show all issues
      Col: 1
       W391 blank line at end of file
      
    23. reviewboard/webapi/tests/urls.py (Diff revision 6)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    24. 
        
    SH
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/resources/base_review.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/review_detail.html
          reviewboard/templates/reviews/boxes/status.html
          reviewboard/templates/reviews/boxes/change.html
      
      
    2. 
        
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/resources/base_review.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/review_detail.html
          reviewboard/templates/reviews/boxes/status.html
          reviewboard/templates/reviews/boxes/change.html
      
      
    2. reviewboard/reviews/views.py (Diff revision 7)
       
       
      Show all issues
      Col: 68
       E502 the backslash is redundant between brackets
      
    3. reviewboard/reviews/views.py (Diff revision 7)
       
       
      Show all issues
      Col: 68
       E251 unexpected spaces around keyword / parameter equals
      
    4. reviewboard/webapi/tests/test_status.py (Diff revision 7)
       
       
      Show all issues
      Col: 17
       E126 continuation line over-indented for hanging indent
      
    5. reviewboard/webapi/tests/test_status.py (Diff revision 7)
       
       
      Show all issues
      Col: 17
       E126 continuation line over-indented for hanging indent
      
    6. 
        
    SH
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/resources/base_review.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/review_detail.html
          reviewboard/templates/reviews/boxes/status.html
          reviewboard/templates/reviews/boxes/change.html
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/resources/base_review.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/review_detail.html
          reviewboard/templates/reviews/boxes/status.html
          reviewboard/templates/reviews/boxes/change.html
      
      
    2. reviewboard/reviews/views.py (Diff revision 8)
       
       
      Show all issues
      Col: 68
       E251 unexpected spaces around keyword / parameter equals
      
    3. reviewboard/webapi/tests/test_status.py (Diff revision 8)
       
       
      Show all issues
      Col: 17
       E126 continuation line over-indented for hanging indent
      
    4. reviewboard/webapi/tests/test_status.py (Diff revision 8)
       
       
      Show all issues
      Col: 17
       E126 continuation line over-indented for hanging indent
      
    5. 
        
    SH
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/resources/base_review.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/review_detail.html
          reviewboard/templates/reviews/boxes/status.html
          reviewboard/templates/reviews/boxes/change.html
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/resources/base_review.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/review_detail.html
          reviewboard/templates/reviews/boxes/status.html
          reviewboard/templates/reviews/boxes/change.html
      
      
    2. 
        
    mike_conley
    1. Very good stuff in here, Shuai. I have a few questions - see below.

    2. reviewboard/reviews/models/status.py (Diff revision 9)
       
       
       
      Show all issues

      Since this is a status, do we really need "status label", "status progress" and "status description"? I imagine it should be inferred that the "label" is for the Status itself.

    3. reviewboard/reviews/views.py (Diff revision 9)
       
       
      Show all issues

      We tend to use underscores in our variable names to break up multiple words. This should probably be num_failures.

      Also, maybe we should use .count() instead of len() here.

      Maybe I missed some context with you and ChipX86, but isn't there a ForeignKey relationship here we could take advantage of, via changedesc.statuses?

    4. reviewboard/reviews/views.py (Diff revision 9)
       
       
       
      Show all issues

      Maybe use count() here instead, unless there's a good reason not to (the only reason we might want len(), as far as I can tell, is because it might be able to avoid a second SQL query since we already retrieved all of the Status models for this review request).

    5. reviewboard/templates/reviews/boxes/change.html (Diff revision 9)
       
       
       
       
       
       
       
       
       
       
       
       
       
      Show all issues

      Nit - one space indentation for the HTML in templates.

      Same goes for the rest of your templates.

    6. Show all issues

      If we can, we should probably avoid inline styling and put this in the CSS for review details instead.

    7. Show all issues

      This needs to be a translatable string - see the "Change Summary:" translation being done on line 42.

    8. Show all issues

      Same as above, re: inline styling.

      We can use either a class or an attribute to set the state, and then apply colours and styling for that state in the CSS.

    9. Show all issues

      Please don't use inline styling if it can be avoided.

    10. Show all issues

      Translate this too, please.

    11. Show all issues

      These <br>'s can probably be avoided here and on line 44 with some margin CSS.

    12. reviewboard/templates/reviews/boxes/status.html (Diff revision 9)
       
       
       
       
      Show all issues

      More inline styles to switch to CSS.

    13. Show all issues

      Can you add a comment about why we're skipping rendering this if there's at least one ChangeDescription? Is this because we'll just end up making the status part of the latest ChangeDescription?

      Was it ever a design goal to display the most recent Status closer to the top of the review details page?

    14. Show all issues

      I don't think this is going out in 2.6. This should probably be 3.0 or 4.0. Maybe ask Christian.

    15. 
        
    SH
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/resources/base_review.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/review_detail.html
          reviewboard/templates/reviews/boxes/status.html
          reviewboard/templates/reviews/boxes/change.html
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/resources/base_review.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/review_detail.html
          reviewboard/templates/reviews/boxes/status.html
          reviewboard/templates/reviews/boxes/change.html
      
      
    2. reviewboard/reviews/views.py (Diff revision 10)
       
       
      Show all issues
      Col: 80
       E501 line too long (83 > 79 characters)
      
    3. 
        
    SH
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/resources/base_review.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/review_detail.html
          reviewboard/templates/reviews/boxes/status.html
          reviewboard/templates/reviews/boxes/change.html
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/resources/base_review.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/review_detail.html
          reviewboard/templates/reviews/boxes/status.html
          reviewboard/templates/reviews/boxes/change.html
      
      
    2. reviewboard/reviews/views.py (Diff revision 11)
       
       
      Show all issues
      Col: 65
       E251 unexpected spaces around keyword / parameter equals
      
    3. reviewboard/reviews/views.py (Diff revision 11)
       
       
      Show all issues
      Col: 65
       E502 the backslash is redundant between brackets
      
    4. 
        
    SH
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/resources/base_review.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/review_detail.html
          reviewboard/templates/reviews/boxes/status.html
          reviewboard/templates/reviews/boxes/change.html
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/testing/testcase.py
          reviewboard/webapi/resources/__init__.py
          reviewboard/webapi/tests/test_status.py
          reviewboard/reviews/models/__init__.py
          reviewboard/webapi/resources/review_request.py
          reviewboard/webapi/resources/status.py
          reviewboard/reviews/models/status.py
          reviewboard/webapi/resources/base_review.py
          reviewboard/webapi/tests/mimetypes.py
          reviewboard/webapi/tests/urls.py
      
      Ignored Files:
          reviewboard/templates/reviews/review_detail.html
          reviewboard/templates/reviews/boxes/status.html
          reviewboard/templates/reviews/boxes/change.html
      
      
    2. reviewboard/reviews/views.py (Diff revision 12)
       
       
      Show all issues
      Col: 65
       E251 unexpected spaces around keyword / parameter equals
      
    3. 
        
    SH
    david
    Review request changed
    Status:
    Discarded
    Change Summary:

    Prototype discarded in favor of new implementation.