Summary

Don't try asking for username/password when input is not a terminal

Review Request #7956 — Created Feb. 11, 2016 and submitted Feb. 16, 2016, 3:43 p.m.

Information

Owner

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This fixes a mysterious "hang" when running rbt using native Windows Python in
a Cygwin terminal emulator such as MinTTY: in this case, password entry doesn't
work correctly and even the prompt is not displayed.

I'm submitting this after wasting half an hour trying to diagnose the problem with "rbt post hanging" before realizing what it was really due to. This may seem to be an unusual case, but it's not the first time I run into it and IMHO it can't make things worse.

Also a question: there is very similar code in utils/users.py which I didn't modify as I don't quite understand when exactly it is used and so couldn't test it. But it probably should be modified in the same way, shouldn't it? Or, perhaps, it could be refactored to reuse the same code in both places?

Testing Done

Ran it from a "normal" DOS window and from MinTTY and got the expected prompt in the former case and the expected error in the latter.

Issues

Description	From	Last Updated
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	Feb. 11, 2016, 9:57 a.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	Feb. 11, 2016, 9:57 a.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	Feb. 11, 2016, 9:58 a.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Feb. 11, 2016, 10:02 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 11, 2016, 10:02 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 11, 2016, 10:02 a.m.
Col: 2 E101 indentation contains mixed spaces and tabs	reviewbot	Feb. 11, 2016, 10:02 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 11, 2016, 10:02 a.m.
Col: 2 E101 indentation contains mixed spaces and tabs	reviewbot	Feb. 11, 2016, 10:02 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 11, 2016, 10:02 a.m.
Col: 2 E101 indentation contains mixed spaces and tabs	reviewbot	Feb. 11, 2016, 10:02 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 11, 2016, 10:02 a.m.
Col: 2 E101 indentation contains mixed spaces and tabs	reviewbot	Feb. 11, 2016, 10:02 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 11, 2016, 10:02 a.m.
Col: 2 E101 indentation contains mixed spaces and tabs	reviewbot	Feb. 11, 2016, 10:02 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	Feb. 11, 2016, 10:02 a.m.
Col: 2 E101 indentation contains mixed spaces and tabs	reviewbot	Feb. 11, 2016, 10:02 a.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Feb. 11, 2016, 10:02 a.m.
flushed	brennie	Feb. 13, 2016, 3:09 a.m.

Tool: Pyflakes
Processed Files:
    rbtools/commands/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/__init__.py

rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```

Change Summary:

Fix line length (E501 checks).

Diff:

Revision 2 (+17)

Show changes

rbtools/commands/__init__.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/__init__.py

rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 2
 E101 indentation contains mixed spaces and tabs
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 2
 E101 indentation contains mixed spaces and tabs
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 2
 E101 indentation contains mixed spaces and tabs
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 2
 E101 indentation contains mixed spaces and tabs
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 2
 E101 indentation contains mixed spaces and tabs
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 2
 E101 indentation contains mixed spaces and tabs
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```

Change Summary:

Fixed TABs introduced while reflowing the comment to fix line length checks

Diff:

Revision 3 (+17)

Show changes

rbtools/commands/__init__.py

Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/__init__.py



Tool: Pyflakes
Processed Files:
    rbtools/commands/__init__.py

rbtools/commands/__init__.py (Diff revision 3)
The issue has been resolved. Show all issues
```
flushed
```
1. VZ
  
  VZ Feb. 13, 2016, 3:09 a.m.
  Oops, thanks for noticing.

Change Summary:

Fixed a typo in comment

Diff:

Revision 4 (+17)

Show changes

rbtools/commands/__init__.py

Tool: Pyflakes
Processed Files:
    rbtools/commands/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/commands/__init__.py

Ship it!

I'm going to push this with a couple small changes (one of which to add the same fix to utils/users.py). Thanks!

Status:: Completed
Change Summary:: Pushed to release-0.7.x (105f415)