Add local branch information to rbt status
Review Request #7951 — Created Feb. 8, 2016 and submitted — Latest diff uploaded
Modified
rbt postto append current local branch to the POST request, modified therbt statusto obtain the saved local branch from the GET request, and altered the formatting ofrbt statusto show the last local branch that was used to post the review request.
I tested both
rbt postandrbt statusmanually.
rbt post
- Create branches in both git and bzr repos and do
rbt postand ensure thatlocal_branchis added to the review request asextra_data - Create bookmark in hg repo and do
rbt postand ensure thatlocal_bookmarkis added to the review request asextra_data - Do an
rbt postin and hg repo without specifying a bookmark and ensure that nolocal_bookmarkis not added to the review request as extra data - Do an
rbt postwith an SCM that doesn't have branching/bookmarking capabilities (I used svn) and ensure no unintendedextra_datais being added
rbt status
- Run
rbt statusin repos that support branching (both git and bzr) and ensure that only the 'Branch' column shows up - Run
rbt statusin repos that support branching (hg) and ensure that only the 'Bookmark' column shows up - Run
rbt statusin a repo that don't support branching/bookmarking (I used svn) and ensure that neither 'Branch' nor 'Bookmark' columns show up - Run
rbt status --alland ensure that both the 'Branch' and 'Bookmark' columns show up, and also that each branch and bookmark shows up properly associated with the correct review request - Make terminal large enough to fit each record of the
rbt statusoutput in one line and ensure that it outputs properly - Shrink terminal small enough to require word wraps for various records in the
rbt statusoutput and ensure that it outputs properly