• 
      

    Add support for unix socket of memcached

    Review Request #7940 — Created Feb. 3, 2016 and submitted

    Information

    Review Board
    release-2.5.x

    Reviewers

    "python-memcached" supports unix sockets with "unix:/path/to/socket".
    So the cache_stats should support that scheme, too.

    Started memcached with:
    * memcached -l 127.0.0.1 -p 11211
    * memcached -s /tmp/socket

    Tried path "unix:/tmp/socket" and "localhost:11211" as the memcached
    connection in admin.

    "Cache Stats" in admin dashboard works correct and caching of diffs in reviews, too.

    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/admin/cache_stats.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/admin/cache_stats.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    misery
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (338e322)