Migrate to djblets.recaptcha for reCAPTCHA

Review Request #7938 — Created Feb. 1, 2016 and submitted

Information

Review Board
release-2.6.x

Reviewers

This patch migrates Review Board to use the djblets.recaptcha app for
handling the reCAPTCHA API version 2. The recaptcha-client library we
were using only supported API version 1, so we have dropped it as a
dependency.

  • Tested that registration worked with reCAPTCHA enabled.
  • Tested that reCAPTCHA can be disabled.
Description From Last Updated

'django_reset' imported but unused

reviewbotreviewbot

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot

'PIPELINE_CSS' imported but unused

reviewbotreviewbot

'PIPELINE_JS' imported but unused

reviewbotreviewbot

Does this need to happen at the top of the page or can we use scripts-post?

daviddavid

'django_reset' imported but unused

reviewbotreviewbot

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot

'PIPELINE_CSS' imported but unused

reviewbotreviewbot

'PIPELINE_JS' imported but unused

reviewbotreviewbot
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/accounts/forms/auth.py
        reviewboard/accounts/forms/registration.py
        reviewboard/settings.py
        setup.py
    
    Ignored Files:
        reviewboard/templates/accounts/register.html
        reviewboard/static/rb/css/common.less
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/accounts/forms/auth.py
        reviewboard/accounts/forms/registration.py
        reviewboard/settings.py
        setup.py
    
    Ignored Files:
        reviewboard/templates/accounts/register.html
        reviewboard/static/rb/css/common.less
    
    
  2. reviewboard/settings.py (Diff revision 1)
     
     
    Show all issues
     'django_reset' imported but unused
    
  3. reviewboard/settings.py (Diff revision 1)
     
     
    Show all issues
     'from settings_local import *' used; unable to detect undefined names
    
  4. reviewboard/settings.py (Diff revision 1)
     
     
    Show all issues
     'PIPELINE_CSS' imported but unused
    
  5. reviewboard/settings.py (Diff revision 1)
     
     
    Show all issues
     'PIPELINE_JS' imported but unused
    
  6. 
      
david
  1. 
      
  2. Show all issues

    Does this need to happen at the top of the page or can we use scripts-post?

    1. In the reCAPTCHA docs, it indicates it should go in <head>.

  3. 
      
david
  1. Ship It!
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/admin/siteconfig.py
        reviewboard/accounts/forms/auth.py
        reviewboard/accounts/forms/registration.py
        reviewboard/settings.py
        setup.py
    
    Ignored Files:
        reviewboard/templates/accounts/register.html
        reviewboard/static/rb/css/common.less
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/admin/siteconfig.py
        reviewboard/accounts/forms/auth.py
        reviewboard/accounts/forms/registration.py
        reviewboard/settings.py
        setup.py
    
    Ignored Files:
        reviewboard/templates/accounts/register.html
        reviewboard/static/rb/css/common.less
    
    
  2. reviewboard/settings.py (Diff revision 2)
     
     
    Show all issues
     'django_reset' imported but unused
    
  3. reviewboard/settings.py (Diff revision 2)
     
     
    Show all issues
     'from settings_local import *' used; unable to detect undefined names
    
  4. reviewboard/settings.py (Diff revision 2)
     
     
    Show all issues
     'PIPELINE_CSS' imported but unused
    
  5. reviewboard/settings.py (Diff revision 2)
     
     
    Show all issues
     'PIPELINE_JS' imported but unused
    
  6. 
      
brennie
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.6.x (1708a6a)