Summary

Migrate to djblets.recaptcha for reCAPTCHA

Review Request #7938 — Created Feb. 2, 2016 and submitted Feb. 19, 2016, 11:57 a.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.6.x

Bugs

Depends On

~~7937~~

Reviewers

Groups

reviewboard

People

Description

This patch migrates Review Board to use the djblets.recaptcha app for
handling the reCAPTCHA API version 2. The recaptcha-client library we
were using only supported API version 1, so we have dropped it as a
dependency.

Testing Done


Tested that registration worked with reCAPTCHA enabled.
Tested that reCAPTCHA can be disabled.

Issues

Description	From	Last Updated
'django_reset' imported but unused	reviewbot	Feb. 2, 2016, 6:46 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 2, 2016, 6:46 a.m.
'PIPELINE_CSS' imported but unused	reviewbot	Feb. 2, 2016, 6:46 a.m.
'PIPELINE_JS' imported but unused	reviewbot	Feb. 2, 2016, 6:46 a.m.
Does this need to happen at the top of the page or can we use scripts-post?	david	Feb. 3, 2016, 12:35 a.m.
'django_reset' imported but unused	reviewbot	Feb. 3, 2016, 1:38 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 3, 2016, 1:38 a.m.
'PIPELINE_CSS' imported but unused	reviewbot	Feb. 3, 2016, 1:38 a.m.
'PIPELINE_JS' imported but unused	reviewbot	Feb. 3, 2016, 1:38 a.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/forms/auth.py
    reviewboard/accounts/forms/registration.py
    reviewboard/settings.py
    setup.py

Ignored Files:
    reviewboard/templates/accounts/register.html
    reviewboard/static/rb/css/common.less



Tool: Pyflakes
Processed Files:
    reviewboard/accounts/forms/auth.py
    reviewboard/accounts/forms/registration.py
    reviewboard/settings.py
    setup.py

Ignored Files:
    reviewboard/templates/accounts/register.html
    reviewboard/static/rb/css/common.less

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

reviewboard/templates/accounts/register.html (Diff revision 1)

The issue has been dropped. Show all issues

Does this need to happen at the top of the page or can we use scripts-post?

brennie Feb. 3, 2016, 12:35 a.m.

In the reCAPTCHA docs, it indicates it should go in <head>.

Ship it!

```
Ship It!
```

Change Summary:

Rebase

Diff:

Revision 2 (+19 -83)

Show changes

	setup.py
	reviewboard/settings.py
	reviewboard/accounts/forms/auth.py
	reviewboard/accounts/forms/registration.py
	reviewboard/admin/siteconfig.py
	reviewboard/static/rb/css/common.less
	reviewboard/templates/accounts/register.html

Tool: Pyflakes
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/accounts/forms/auth.py
    reviewboard/accounts/forms/registration.py
    reviewboard/settings.py
    setup.py

Ignored Files:
    reviewboard/templates/accounts/register.html
    reviewboard/static/rb/css/common.less



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/accounts/forms/auth.py
    reviewboard/accounts/forms/registration.py
    reviewboard/settings.py
    setup.py

Ignored Files:
    reviewboard/templates/accounts/register.html
    reviewboard/static/rb/css/common.less

reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Depends On:: ~~7937 - Add the recaptcha module~~

Status:: Completed
Change Summary:: Pushed to release-2.6.x (1708a6a)