• 
      

    Add Extension testing framework in reviewboard

    Review Request #7934 — Created Jan. 31, 2016 and discarded

    Information

    Review Board
    release-2.6.x

    Reviewers

    Add Extension testing framework in reviewboard

    I have create a fake test in a real extension to enable target extension.
    I have add the document about the Extension Test Framework in docs/manual/extending/extensions/testing.rst.

    Description From Last Updated

    'pkg_resources' imported but unused

    reviewbotreviewbot

    'Mock' imported but unused

    reviewbotreviewbot

    'six' imported but unused

    reviewbotreviewbot

    'ExtensionInfo' imported but unused

    reviewbotreviewbot

    'RegisteredExtension' imported but unused

    reviewbotreviewbot

    'ExtensionHook' imported but unused

    reviewbotreviewbot

    'ExtensionHookPoint' imported but unused

    reviewbotreviewbot

    'ExtensionManager' imported but unused

    reviewbotreviewbot

    'Settings' imported but unused

    reviewbotreviewbot

    Col: 1 E303 too many blank lines (3)

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 3 E303 too many blank lines (2)

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 10 E101 indentation contains mixed spaces and tabs

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 3 E303 too many blank lines (2)

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 10 E101 indentation contains mixed spaces and tabs

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 42 E127 continuation line over-indented for visual indent

    reviewbotreviewbot

    Col: 29 E127 continuation line over-indented for visual indent

    reviewbotreviewbot

    Col: 41 E127 continuation line over-indented for visual indent

    reviewbotreviewbot

    Col: 50 E225 missing whitespace around operator

    reviewbotreviewbot

    Col: 49 E225 missing whitespace around operator

    reviewbotreviewbot

    Col: 80 E501 line too long (95 > 79 characters)

    reviewbotreviewbot

    Col: 50 W292 no newline at end of file

    reviewbotreviewbot

    Col: 53 E502 the backslash is redundant between brackets

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    local variable 'tests_module' is assigned to but never used

    reviewbotreviewbot

    Col: 80 E501 line too long (99 > 79 characters)

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 5 E303 too many blank lines (2)

    reviewbotreviewbot

    'primary_widgets' imported but unused

    reviewbotreviewbot

    'secondary_widgets' imported but unused

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    'TestModelsLoaderMixin' imported but unused

    reviewbotreviewbot

    'WebAPICapabilitiesHook' imported but unused

    reviewbotreviewbot

    Col: 62 E261 at least two spaces before inline comment

    reviewbotreviewbot

    'BaseWebAPITestCase' imported but unused

    reviewbotreviewbot

    Col: 5 E303 too many blank lines (2)

    reviewbotreviewbot

    Col: 80 E501 line too long (85 > 79 characters)

    reviewbotreviewbot

    Col: 43 E265 block comment should start with '# '

    reviewbotreviewbot

    Col: 80 E501 line too long (85 > 79 characters)

    reviewbotreviewbot

    'logging' imported but unused

    reviewbotreviewbot

    'nose' imported but unused

    reviewbotreviewbot

    'stat' imported but unused

    reviewbotreviewbot

    'warnings' imported but unused

    reviewbotreviewbot

    'import_module' imported but unused

    reviewbotreviewbot

    'Context' imported but unused

    reviewbotreviewbot

    'Template' imported but unused

    reviewbotreviewbot

    'ImproperlyConfigured' imported but unused

    reviewbotreviewbot

    'django_version' imported but unused

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    'Extension' imported but unused

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 1 E101 indentation contains mixed spaces and tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 E101 indentation contains mixed spaces and tabs

    reviewbotreviewbot

    Col: 38 E127 continuation line over-indented for visual indent

    reviewbotreviewbot

    'Context' imported but unused

    reviewbotreviewbot

    'Template' imported but unused

    reviewbotreviewbot

    'Extension' imported but unused

    reviewbotreviewbot

    'TestCase' imported but unused

    reviewbotreviewbot

    'get_hosting_service' imported but unused

    reviewbotreviewbot

    'HostingService' imported but unused

    reviewbotreviewbot

    'Widget' imported but unused

    reviewbotreviewbot

    'secondary_widgets' imported but unused

    reviewbotreviewbot

    'primary_widgets' imported but unused

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    undefined name 'TestExtension'

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 11 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 10 E101 indentation contains mixed spaces and tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 3 W292 no newline at end of file

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    'call_command' imported but unused

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 W191 indentation contains tabs

    reviewbotreviewbot

    Col: 1 E265 block comment should start with '# '

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 3 W292 no newline at end of file

    reviewbotreviewbot

    'settings' imported but unused

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    'call_command' imported but unused

    reviewbotreviewbot

    'BaseTestRunner' imported but unused

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    'run_tests' imported but unused

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    local variable 'mixin' is assigned to but never used

    reviewbotreviewbot

    Col: 71 E202 whitespace before ')'

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 3 W292 no newline at end of file

    reviewbotreviewbot

    'call_command' imported but unused

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    'run_tests' imported but unused

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    'get_extension_manager' imported but unused

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    local variable 'mixin' is assigned to but never used

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 5 E303 too many blank lines (2)

    reviewbotreviewbot

    undefined name 'RegisteredExtension'

    reviewbotreviewbot

    Col: 3 W292 no newline at end of file

    reviewbotreviewbot

    'call_command' imported but unused

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    'run_tests' imported but unused

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    'get_extension_manager' imported but unused

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    local variable 'mixin' is assigned to but never used

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 5 E303 too many blank lines (2)

    reviewbotreviewbot

    undefined name 'RegisteredExtension'

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Out of curiosity, why are you still hardcoding this to your TestExtension dummy extension?

    mike_conleymike_conley

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    undefined name 'RUNNING_TEST'

    reviewbotreviewbot

    undefined name 'REVIEWBOARD_ROOT'

    reviewbotreviewbot

    undefined name 'STATIC_ROOT'

    reviewbotreviewbot

    Col: 1 W391 blank line at end of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    'RegisteredExtension' imported but unused

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    'logging' imported but unused

    reviewbotreviewbot

    'sys' imported but unused

    reviewbotreviewbot

    'import_module' imported but unused

    reviewbotreviewbot

    'ImproperlyConfigured' imported but unused

    reviewbotreviewbot

    'Extension' imported but unused

    reviewbotreviewbot

    Col: 5 E303 too many blank lines (2)

    reviewbotreviewbot

    Col: 9 E303 too many blank lines (2)

    reviewbotreviewbot

    Col: 5 E303 too many blank lines (2)

    reviewbotreviewbot

    undefined name 'self'

    reviewbotreviewbot

    undefined name 'module_dir'

    reviewbotreviewbot

    Col: 26 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 9 E126 continuation line over-indented for hanging indent

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 80 E501 line too long (102 > 79 characters)

    reviewbotreviewbot

    undefined name 'HTDOCS_ROOT'

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 9 E126 continuation line over-indented for hanging indent

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 80 E501 line too long (102 > 79 characters)

    reviewbotreviewbot

    'djblets' imported but unused

    reviewbotreviewbot

    Col: 43 E127 continuation line over-indented for visual indent

    reviewbotreviewbot

    Col: 80 E501 line too long (91 > 79 characters)

    reviewbotreviewbot

    Col: 1 E265 block comment should start with '# '

    reviewbotreviewbot

    Col: 1 E265 block comment should start with '# '

    reviewbotreviewbot

    Col: 1 W391 blank line at end of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    'os' imported but unused

    reviewbotreviewbot

    'sys' imported but unused

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 80 E501 line too long (102 > 79 characters)

    reviewbotreviewbot

    Col: 80 E501 line too long (88 > 79 characters)

    reviewbotreviewbot

    Col: 41 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 80 E501 line too long (80 > 79 characters)

    reviewbotreviewbot

    Col: 1 W391 blank line at end of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E302 expected 2 blank lines, found 1

    reviewbotreviewbot

    Col: 80 E501 line too long (81 > 79 characters)

    reviewbotreviewbot

    Col: 45 E127 continuation line over-indented for visual indent

    reviewbotreviewbot

    Col: 41 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 29 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    'get_extension_manager' imported but unused

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 46 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 45 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 41 E128 continuation line under-indented for visual indent

    reviewbotreviewbot

    Col: 80 E501 line too long (91 > 79 characters)

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 43 E231 missing whitespace after ','

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    I think these are leftovers - they're unrelated to this patch.

    mike_conleymike_conley

    We might want to add something about "extension-test" to this database name string.

    mike_conleymike_conley

    One too many newlines?

    mike_conleymike_conley

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Can you quickly explain why you need to do the imports down here? I assume it's a legitimate reason, like …

    mike_conleymike_conley

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Can you please add a docstring to this?

    mike_conleymike_conley

    See my comment in /r/7932 re: test_labels. I'm not sure we need this.

    mike_conleymike_conley

    Can you quickly document why this is required?

    mike_conleymike_conley

    I think this mixin's responsibilities are a little different... it looks like it's responsible for taking care of the boilerplate …

    mike_conleymike_conley

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    'os' imported but unused

    reviewbotreviewbot

    'VERSION' imported but unused

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    'VERSION' imported but unused

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    I don't think this comment is very clear. Perhaps it should be something like: We need to do these imports …

    mike_conleymike_conley

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    I don't think "Mixin" needs to be capitalized here. Perhaps better wording: A mixin that helps tests to setup and …

    mike_conleymike_conley

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot

    Col: 1 E402 module level import not at top of file

    reviewbotreviewbot
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/testing/extensions.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/testing/extensions.py
      
      
      WARNING: Number of comments exceeded maximum, showing 30 of 72.
    2. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
       'pkg_resources' imported but unused
      
    3. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
       'Mock' imported but unused
      
    4. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
       'six' imported but unused
      
    5. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
       'ExtensionInfo' imported but unused
      
    6. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
       'RegisteredExtension' imported but unused
      
    7. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
       'ExtensionHook' imported but unused
      
    8. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
       'ExtensionHookPoint' imported but unused
      
    9. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
       'ExtensionManager' imported but unused
      
    10. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
       'Settings' imported but unused
      
    11. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       E303 too many blank lines (3)
      
    12. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    13. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    14. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    15. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    16. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    17. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    18. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    19. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    20. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    21. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    22. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    23. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    24. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    25. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    26. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    27. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    28. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    29. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    30. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    31. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    32. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    33. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    34. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    35. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    36. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 3
       E303 too many blank lines (2)
      
    37. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    38. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    39. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    40. reviewboard/testing/extensions.py (Diff revision 1)
       
       
      Show all issues
      Col: 10
       E101 indentation contains mixed spaces and tabs
      
    41. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/testing/extensions.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/testing/extensions.py
      
      
      WARNING: Number of comments exceeded maximum, showing 30 of 73.
    2. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    3. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    4. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    5. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    6. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    7. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    8. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    9. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    10. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    11. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    12. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    13. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    14. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    15. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    16. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    17. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    18. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    19. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    20. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    21. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    22. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    23. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    24. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    25. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    26. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    27. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 3
       E303 too many blank lines (2)
      
    28. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    29. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    30. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    31. reviewboard/testing/extensions.py (Diff revision 2)
       
       
      Show all issues
      Col: 10
       E101 indentation contains mixed spaces and tabs
      
    32. 
        
    WE
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/testing/extensions.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/testing/extensions.py
      
      
    2. reviewboard/testing/extensions.py (Diff revision 3)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    3. reviewboard/testing/extensions.py (Diff revision 3)
       
       
      Show all issues
      Col: 42
       E127 continuation line over-indented for visual indent
      
    4. reviewboard/testing/extensions.py (Diff revision 3)
       
       
      Show all issues
      Col: 29
       E127 continuation line over-indented for visual indent
      
    5. reviewboard/testing/extensions.py (Diff revision 3)
       
       
      Show all issues
      Col: 41
       E127 continuation line over-indented for visual indent
      
    6. reviewboard/testing/extensions.py (Diff revision 3)
       
       
      Show all issues
      Col: 50
       E225 missing whitespace around operator
      
    7. reviewboard/testing/extensions.py (Diff revision 3)
       
       
      Show all issues
      Col: 49
       E225 missing whitespace around operator
      
    8. reviewboard/testing/extensions.py (Diff revision 3)
       
       
      Show all issues
      Col: 80
       E501 line too long (95 > 79 characters)
      
    9. reviewboard/testing/extensions.py (Diff revision 3)
       
       
      Show all issues
      Col: 50
       W292 no newline at end of file
      
    10. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/testing/extensions.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/testing/extensions.py
      
      
    2. reviewboard/testing/extensions.py (Diff revision 4)
       
       
      Show all issues
      Col: 53
       E502 the backslash is redundant between brackets
      
    3. 
        
    WE
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/testing/extensions.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/testing/extensions.py
      
      
    2. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/testing/extensions.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/testing/extensions.py
      
      
    2. reviewboard/testing/extensions.py (Diff revision 6)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    3. reviewboard/testing/extensions.py (Diff revision 6)
       
       
      Show all issues
       local variable 'tests_module' is assigned to but never used
      
    4. reviewboard/testing/extensions.py (Diff revision 6)
       
       
      Show all issues
      Col: 80
       E501 line too long (99 > 79 characters)
      
    5. reviewboard/testing/extensions.py (Diff revision 6)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    6. reviewboard/testing/extensions.py (Diff revision 6)
       
       
      Show all issues
      Col: 5
       E303 too many blank lines (2)
      
    7. 
        
    WE
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/testing/extensions.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/testing/extensions.py
      
      
    2. 
        
    WE
    WE
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/testing/extensions.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/testing/extensions.py
      
      
    2. reviewboard/testing/extensions.py (Diff revision 8)
       
       
      Show all issues
       'primary_widgets' imported but unused
      
    3. reviewboard/testing/extensions.py (Diff revision 8)
       
       
      Show all issues
       'secondary_widgets' imported but unused
      
    4. reviewboard/testing/extensions.py (Diff revision 8)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    5. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/testing/extensions.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/testing/extensions.py
      
      
    2. reviewboard/testing/extensions.py (Diff revision 9)
       
       
      Show all issues
       'TestModelsLoaderMixin' imported but unused
      
    3. reviewboard/testing/extensions.py (Diff revision 9)
       
       
      Show all issues
       'WebAPICapabilitiesHook' imported but unused
      
    4. reviewboard/testing/extensions.py (Diff revision 9)
       
       
      Show all issues
      Col: 62
       E261 at least two spaces before inline comment
      
    5. reviewboard/testing/extensions.py (Diff revision 9)
       
       
      Show all issues
       'BaseWebAPITestCase' imported but unused
      
    6. reviewboard/testing/extensions.py (Diff revision 9)
       
       
      Show all issues
      Col: 5
       E303 too many blank lines (2)
      
    7. reviewboard/testing/extensions.py (Diff revision 9)
       
       
      Show all issues
      Col: 80
       E501 line too long (85 > 79 characters)
      
    8. 
        
    WE
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/testing/extensions.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/testing/extensions.py
      
      
    2. reviewboard/testing/extensions.py (Diff revision 10)
       
       
      Show all issues
      Col: 43
       E265 block comment should start with '# '
      
    3. reviewboard/testing/extensions.py (Diff revision 10)
       
       
      Show all issues
      Col: 80
       E501 line too long (85 > 79 characters)
      
    4. 
        
    WE
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
    2. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
       'logging' imported but unused
      
    3. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
       'nose' imported but unused
      
    4. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
       'stat' imported but unused
      
    5. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
       'warnings' imported but unused
      
    6. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
       'import_module' imported but unused
      
    7. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
       'Context' imported but unused
      
    8. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
       'Template' imported but unused
      
    9. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
       'ImproperlyConfigured' imported but unused
      
    10. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
       'django_version' imported but unused
      
    11. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    12. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
       'Extension' imported but unused
      
    13. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    14. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    15. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
      Col: 1
       E101 indentation contains mixed spaces and tabs
      
    16. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    17. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    18. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    19. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    20. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    21. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    22. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
      Col: 1
       E101 indentation contains mixed spaces and tabs
      
    23. reviewboard/extensions/testing/runner.py (Diff revision 11)
       
       
      Show all issues
      Col: 38
       E127 continuation line over-indented for visual indent
      
    24. reviewboard/testing/extensions.py (Diff revision 11)
       
       
      Show all issues
       'Context' imported but unused
      
    25. reviewboard/testing/extensions.py (Diff revision 11)
       
       
      Show all issues
       'Template' imported but unused
      
    26. reviewboard/testing/extensions.py (Diff revision 11)
       
       
      Show all issues
       'Extension' imported but unused
      
    27. reviewboard/testing/extensions.py (Diff revision 11)
       
       
      Show all issues
       'TestCase' imported but unused
      
    28. reviewboard/testing/extensions.py (Diff revision 11)
       
       
      Show all issues
       'get_hosting_service' imported but unused
      
    29. reviewboard/testing/extensions.py (Diff revision 11)
       
       
      Show all issues
       'HostingService' imported but unused
      
    30. reviewboard/testing/extensions.py (Diff revision 11)
       
       
      Show all issues
       'Widget' imported but unused
      
    31. reviewboard/testing/extensions.py (Diff revision 11)
       
       
      Show all issues
       'secondary_widgets' imported but unused
      
    32. reviewboard/testing/extensions.py (Diff revision 11)
       
       
      Show all issues
       'primary_widgets' imported but unused
      
    33. reviewboard/testing/extensions.py (Diff revision 11)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    34. reviewboard/testing/extensions.py (Diff revision 11)
       
       
      Show all issues
       undefined name 'TestExtension'
      
    35. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
    2. reviewboard/extensions/testing/runner.py (Diff revision 12)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    3. reviewboard/extensions/testing/runner.py (Diff revision 12)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    4. reviewboard/extensions/testing/runner.py (Diff revision 12)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    5. reviewboard/extensions/testing/runner.py (Diff revision 12)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    6. reviewboard/extensions/testing/runner.py (Diff revision 12)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    7. reviewboard/extensions/testing/runner.py (Diff revision 12)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    8. reviewboard/extensions/testing/runner.py (Diff revision 12)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    9. reviewboard/extensions/testing/runner.py (Diff revision 12)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    10. reviewboard/extensions/testing/runner.py (Diff revision 12)
       
       
      Show all issues
      Col: 11
       E128 continuation line under-indented for visual indent
      
    11. reviewboard/extensions/testing/runner.py (Diff revision 12)
       
       
      Show all issues
      Col: 10
       E101 indentation contains mixed spaces and tabs
      
    12. reviewboard/extensions/testing/runner.py (Diff revision 12)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    13. reviewboard/testing/extensions.py (Diff revision 12)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    14. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
    2. Show all issues
      Col: 3
       W292 no newline at end of file
      
    3. reviewboard/extensions/testing/runner.py (Diff revision 13)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    4. reviewboard/extensions/testing/runner.py (Diff revision 13)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    5. reviewboard/extensions/testing/runner.py (Diff revision 13)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    6. reviewboard/extensions/testing/runner.py (Diff revision 13)
       
       
      Show all issues
       'call_command' imported but unused
      
    7. reviewboard/extensions/testing/runner.py (Diff revision 13)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    8. reviewboard/extensions/testing/runner.py (Diff revision 13)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    9. reviewboard/extensions/testing/runner.py (Diff revision 13)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    10. reviewboard/extensions/testing/runner.py (Diff revision 13)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    11. reviewboard/extensions/testing/runner.py (Diff revision 13)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    12. reviewboard/extensions/testing/runner.py (Diff revision 13)
       
       
      Show all issues
      Col: 1
       W191 indentation contains tabs
      
    13. reviewboard/extensions/testing/runner.py (Diff revision 13)
       
       
      Show all issues
      Col: 1
       E265 block comment should start with '# '
      
    14. reviewboard/testing/extensions.py (Diff revision 13)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    15. 
        
    WE
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
    2. Show all issues
      Col: 3
       W292 no newline at end of file
      
    3. reviewboard/extensions/testing/runner.py (Diff revision 14)
       
       
      Show all issues
       'settings' imported but unused
      
    4. reviewboard/extensions/testing/runner.py (Diff revision 14)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    5. reviewboard/extensions/testing/runner.py (Diff revision 14)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    6. reviewboard/extensions/testing/runner.py (Diff revision 14)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    7. reviewboard/extensions/testing/runner.py (Diff revision 14)
       
       
      Show all issues
       'call_command' imported but unused
      
    8. reviewboard/extensions/testing/runner.py (Diff revision 14)
       
       
      Show all issues
       'BaseTestRunner' imported but unused
      
    9. reviewboard/extensions/testing/runner.py (Diff revision 14)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    10. reviewboard/extensions/testing/runner.py (Diff revision 14)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    11. reviewboard/extensions/testing/runner.py (Diff revision 14)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    12. reviewboard/extensions/testing/runner.py (Diff revision 14)
       
       
      Show all issues
       'run_tests' imported but unused
      
    13. reviewboard/extensions/testing/runner.py (Diff revision 14)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    14. reviewboard/extensions/testing/runner.py (Diff revision 14)
       
       
      Show all issues
       local variable 'mixin' is assigned to but never used
      
    15. reviewboard/extensions/testing/runner.py (Diff revision 14)
       
       
      Show all issues
      Col: 71
       E202 whitespace before ')'
      
    16. reviewboard/testing/extensions.py (Diff revision 14)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    17. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
    2. Show all issues
      Col: 3
       W292 no newline at end of file
      
    3. reviewboard/extensions/testing/runner.py (Diff revision 15)
       
       
      Show all issues
       'call_command' imported but unused
      
    4. reviewboard/extensions/testing/runner.py (Diff revision 15)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    5. reviewboard/extensions/testing/runner.py (Diff revision 15)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    6. reviewboard/extensions/testing/runner.py (Diff revision 15)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    7. reviewboard/extensions/testing/runner.py (Diff revision 15)
       
       
      Show all issues
       'run_tests' imported but unused
      
    8. reviewboard/extensions/testing/runner.py (Diff revision 15)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    9. reviewboard/extensions/testing/runner.py (Diff revision 15)
       
       
      Show all issues
       'get_extension_manager' imported but unused
      
    10. reviewboard/extensions/testing/runner.py (Diff revision 15)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    11. reviewboard/extensions/testing/runner.py (Diff revision 15)
       
       
      Show all issues
       local variable 'mixin' is assigned to but never used
      
    12. reviewboard/testing/extensions.py (Diff revision 15)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    13. reviewboard/testing/extensions.py (Diff revision 15)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    14. reviewboard/testing/extensions.py (Diff revision 15)
       
       
      Show all issues
      Col: 5
       E303 too many blank lines (2)
      
    15. reviewboard/testing/extensions.py (Diff revision 15)
       
       
      Show all issues
       undefined name 'RegisteredExtension'
      
    16. 
        
    WE
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
    2. Show all issues
      Col: 3
       W292 no newline at end of file
      
    3. reviewboard/extensions/testing/runner.py (Diff revision 16)
       
       
      Show all issues
       'call_command' imported but unused
      
    4. reviewboard/extensions/testing/runner.py (Diff revision 16)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    5. reviewboard/extensions/testing/runner.py (Diff revision 16)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    6. reviewboard/extensions/testing/runner.py (Diff revision 16)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    7. reviewboard/extensions/testing/runner.py (Diff revision 16)
       
       
      Show all issues
       'run_tests' imported but unused
      
    8. reviewboard/extensions/testing/runner.py (Diff revision 16)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    9. reviewboard/extensions/testing/runner.py (Diff revision 16)
       
       
      Show all issues
       'get_extension_manager' imported but unused
      
    10. reviewboard/extensions/testing/runner.py (Diff revision 16)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    11. reviewboard/extensions/testing/runner.py (Diff revision 16)
       
       
      Show all issues
       local variable 'mixin' is assigned to but never used
      
    12. reviewboard/testing/extensions.py (Diff revision 16)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    13. reviewboard/testing/extensions.py (Diff revision 16)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    14. reviewboard/testing/extensions.py (Diff revision 16)
       
       
      Show all issues
      Col: 5
       E303 too many blank lines (2)
      
    15. reviewboard/testing/extensions.py (Diff revision 16)
       
       
      Show all issues
       undefined name 'RegisteredExtension'
      
    16. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
    2. reviewboard/extensions/testing/runner.py (Diff revision 17)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    3. 
        
    mike_conley
    1. 
        
    2. reviewboard/testing/extensions.py (Diff revision 17)
       
       
      Show all issues

      Out of curiosity, why are you still hardcoding this to your TestExtension dummy extension?

    3. 
        
    WE
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
    2. Show all issues
      Col: 1
       E402 module level import not at top of file
      
    3. Show all issues
       undefined name 'RUNNING_TEST'
      
    4. Show all issues
       undefined name 'REVIEWBOARD_ROOT'
      
    5. Show all issues
       undefined name 'STATIC_ROOT'
      
    6. Show all issues
      Col: 1
       W391 blank line at end of file
      
    7. reviewboard/extensions/testing/runner.py (Diff revision 18)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    8. reviewboard/extensions/testing/runner.py (Diff revision 18)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    9. reviewboard/extensions/testing/runner.py (Diff revision 18)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    10. reviewboard/extensions/testing/runner.py (Diff revision 18)
       
       
      Show all issues
       'RegisteredExtension' imported but unused
      
    11. reviewboard/extensions/testing/runner.py (Diff revision 18)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    12. reviewboard/testing/extensions.py (Diff revision 18)
       
       
      Show all issues
       'logging' imported but unused
      
    13. reviewboard/testing/extensions.py (Diff revision 18)
       
       
      Show all issues
       'sys' imported but unused
      
    14. reviewboard/testing/extensions.py (Diff revision 18)
       
       
      Show all issues
       'import_module' imported but unused
      
    15. reviewboard/testing/extensions.py (Diff revision 18)
       
       
      Show all issues
       'ImproperlyConfigured' imported but unused
      
    16. reviewboard/testing/extensions.py (Diff revision 18)
       
       
      Show all issues
       'Extension' imported but unused
      
    17. reviewboard/testing/extensions.py (Diff revision 18)
       
       
      Show all issues
      Col: 5
       E303 too many blank lines (2)
      
    18. reviewboard/testing/extensions.py (Diff revision 18)
       
       
      Show all issues
      Col: 9
       E303 too many blank lines (2)
      
    19. reviewboard/testing/extensions.py (Diff revision 18)
       
       
      Show all issues
      Col: 5
       E303 too many blank lines (2)
      
    20. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
    2. Show all issues
       undefined name 'self'
      
    3. Show all issues
       undefined name 'module_dir'
      
    4. Show all issues
      Col: 26
       E128 continuation line under-indented for visual indent
      
    5. Show all issues
      Col: 1
       E402 module level import not at top of file
      
    6. Show all issues
      Col: 9
       E126 continuation line over-indented for hanging indent
      
    7. reviewboard/extensions/testing/runner.py (Diff revision 19)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    8. reviewboard/extensions/testing/runner.py (Diff revision 19)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    9. reviewboard/extensions/testing/runner.py (Diff revision 19)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    10. reviewboard/testing/extensions.py (Diff revision 19)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    11. reviewboard/testing/extensions.py (Diff revision 19)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    12. reviewboard/testing/extensions.py (Diff revision 19)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    13. reviewboard/testing/extensions.py (Diff revision 19)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    14. reviewboard/testing/extensions.py (Diff revision 19)
       
       
      Show all issues
      Col: 80
       E501 line too long (102 > 79 characters)
      
    15. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
    2. Show all issues
       undefined name 'HTDOCS_ROOT'
      
    3. Show all issues
      Col: 1
       E402 module level import not at top of file
      
    4. Show all issues
      Col: 9
       E126 continuation line over-indented for hanging indent
      
    5. reviewboard/extensions/testing/runner.py (Diff revision 20)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    6. reviewboard/extensions/testing/runner.py (Diff revision 20)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    7. reviewboard/extensions/testing/runner.py (Diff revision 20)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    8. reviewboard/testing/extensions.py (Diff revision 20)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    9. reviewboard/testing/extensions.py (Diff revision 20)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    10. reviewboard/testing/extensions.py (Diff revision 20)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    11. reviewboard/testing/extensions.py (Diff revision 20)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    12. reviewboard/testing/extensions.py (Diff revision 20)
       
       
      Show all issues
      Col: 80
       E501 line too long (102 > 79 characters)
      
    13. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
    2. Show all issues
       'djblets' imported but unused
      
    3. Show all issues
      Col: 43
       E127 continuation line over-indented for visual indent
      
    4. Show all issues
      Col: 80
       E501 line too long (91 > 79 characters)
      
    5. Show all issues
      Col: 1
       E265 block comment should start with '# '
      
    6. Show all issues
      Col: 1
       E265 block comment should start with '# '
      
    7. Show all issues
      Col: 1
       W391 blank line at end of file
      
    8. reviewboard/extensions/testing/runner.py (Diff revision 21)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    9. reviewboard/extensions/testing/runner.py (Diff revision 21)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    10. reviewboard/extensions/testing/runner.py (Diff revision 21)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    11. reviewboard/extensions/testing/runner.py (Diff revision 21)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    12. reviewboard/testing/extensions.py (Diff revision 21)
       
       
      Show all issues
       'os' imported but unused
      
    13. reviewboard/testing/extensions.py (Diff revision 21)
       
       
      Show all issues
       'sys' imported but unused
      
    14. reviewboard/testing/extensions.py (Diff revision 21)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    15. reviewboard/testing/extensions.py (Diff revision 21)
       
       
      Show all issues
      Col: 80
       E501 line too long (102 > 79 characters)
      
    16. reviewboard/testing/extensions.py (Diff revision 21)
       
       
      Show all issues
      Col: 80
       E501 line too long (88 > 79 characters)
      
    17. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
    2. Show all issues
      Col: 41
       E128 continuation line under-indented for visual indent
      
    3. Show all issues
      Col: 80
       E501 line too long (80 > 79 characters)
      
    4. Show all issues
      Col: 1
       W391 blank line at end of file
      
    5. reviewboard/extensions/testing/runner.py (Diff revision 22)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    6. reviewboard/extensions/testing/runner.py (Diff revision 22)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    7. reviewboard/extensions/testing/runner.py (Diff revision 22)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    8. reviewboard/testing/extensions.py (Diff revision 22)
       
       
      Show all issues
      Col: 1
       E302 expected 2 blank lines, found 1
      
    9. reviewboard/testing/extensions.py (Diff revision 22)
       
       
      Show all issues
      Col: 80
       E501 line too long (81 > 79 characters)
      
    10. reviewboard/testing/extensions.py (Diff revision 22)
       
       
      Show all issues
      Col: 45
       E127 continuation line over-indented for visual indent
      
    11. 
        
    WE
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
    2. Show all issues
      Col: 41
       E128 continuation line under-indented for visual indent
      
    3. Show all issues
      Col: 29
       E128 continuation line under-indented for visual indent
      
    4. reviewboard/extensions/testing/runner.py (Diff revision 23)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    5. reviewboard/extensions/testing/runner.py (Diff revision 23)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    6. reviewboard/extensions/testing/runner.py (Diff revision 23)
       
       
      Show all issues
       'get_extension_manager' imported but unused
      
    7. reviewboard/extensions/testing/runner.py (Diff revision 23)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    8. reviewboard/testing/extensions.py (Diff revision 23)
       
       
      Show all issues
      Col: 46
       E128 continuation line under-indented for visual indent
      
    9. reviewboard/testing/extensions.py (Diff revision 23)
       
       
      Show all issues
      Col: 45
       E128 continuation line under-indented for visual indent
      
    10. 
        
    WE
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
    2. Show all issues
      Col: 41
       E128 continuation line under-indented for visual indent
      
    3. Show all issues
      Col: 80
       E501 line too long (91 > 79 characters)
      
    4. reviewboard/extensions/testing/runner.py (Diff revision 24)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    5. reviewboard/extensions/testing/runner.py (Diff revision 24)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    6. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
    2. Show all issues
      Col: 43
       E231 missing whitespace after ','
      
    3. reviewboard/extensions/testing/runner.py (Diff revision 25)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    4. reviewboard/extensions/testing/runner.py (Diff revision 25)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    5. 
        
    WE
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
          .reviewboardrc
      
      
    2. reviewboard/extensions/testing/runner.py (Diff revision 26)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    3. reviewboard/extensions/testing/runner.py (Diff revision 26)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    4. 
        
    WE
    WE
    WE
    mike_conley
    1. 
        
    2. .reviewboardrc (Diff revision 26)
       
       
       
       
      Show all issues

      I think these are leftovers - they're unrelated to this patch.

    3. Show all issues

      We might want to add something about "extension-test" to this database name string.

      1. Should I write the os.path.join(ROOT_PATH,'extension-test.db') or just 'extension-test.db'

    4. Show all issues

      One too many newlines?

    5. reviewboard/extensions/testing/runner.py (Diff revision 26)
       
       
      Show all issues

      Can you quickly explain why you need to do the imports down here? I assume it's a legitimate reason, like the PATH munging you're doing needs to come before you import django.conf.settings...

      If so, can you please add a comment about why it's necessary to do these imports down here?

      1. I might need that to update the settings.TEST_PACKAGES = [extension name].

    6. reviewboard/extensions/testing/runner.py (Diff revision 26)
       
       
      Show all issues

      Can you please add a docstring to this?

    7. reviewboard/extensions/testing/runner.py (Diff revision 26)
       
       
      Show all issues

      See my comment in /r/7932 re: test_labels. I'm not sure we need this.

    8. reviewboard/testing/extensions.py (Diff revision 26)
       
       
      Show all issues

      Can you quickly document why this is required?

      1. sorry, that should be a part, I am not clean

    9. reviewboard/testing/extensions.py (Diff revision 26)
       
       
       
      Show all issues

      I think this mixin's responsibilities are a little different... it looks like it's responsible for taking care of the boilerplate for setting up and tearing down the Extension.

    10. 
        
    WE
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
    2. reviewboard/extensions/testing/runner.py (Diff revision 27)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    3. reviewboard/extensions/testing/runner.py (Diff revision 27)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    4. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
    2. Show all issues
       'os' imported but unused
      
    3. Show all issues
       'VERSION' imported but unused
      
    4. reviewboard/extensions/testing/runner.py (Diff revision 28)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    5. reviewboard/extensions/testing/runner.py (Diff revision 28)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    6. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
    2. reviewboard/extensions/testing/runner.py (Diff revision 29)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    3. reviewboard/extensions/testing/runner.py (Diff revision 29)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    4. 
        
    WE
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
    2. reviewboard/extensions/testing/runner.py (Diff revision 30)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    3. reviewboard/extensions/testing/runner.py (Diff revision 30)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    4. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
    2. Show all issues
       'VERSION' imported but unused
      
    3. reviewboard/extensions/testing/runner.py (Diff revision 31)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    4. reviewboard/extensions/testing/runner.py (Diff revision 31)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    5. 
        
    mike_conley
    1. 
        
    2. reviewboard/extensions/testing/runner.py (Diff revision 31)
       
       
      Show all issues

      I don't think this comment is very clear.

      Perhaps it should be something like:

      We need to do these imports after we set the DJANGO_SETTINGS_MODULE in order to make sure the tests get that change.
      

      Something along those lines, anyhow.

    3. reviewboard/testing/extensions.py (Diff revision 31)
       
       
      Show all issues

      I don't think "Mixin" needs to be capitalized here.

      Perhaps better wording:

      A mixin that helps tests to setup and teardown an extension.
      
    4. 
        
    WE
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/extensions/testing/runner.py
          reviewboard/extensions/testing/conf/settings_local.py
          reviewboard/testing/extensions.py
      
      Ignored Files:
          reviewboard/extensions/testing/__init__.py
      
      
    2. reviewboard/extensions/testing/runner.py (Diff revision 32)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    3. reviewboard/extensions/testing/runner.py (Diff revision 32)
       
       
      Show all issues
      Col: 1
       E402 module level import not at top of file
      
    4. 
        
    david
    Review request changed
    Status:
    Discarded
    Change Summary:

    A similar but separate implementation has been landed for Djblets 0.10