Add Extension testing framework in reviewboard
Review Request #7934 — Created Jan. 31, 2016 and discarded
Add Extension testing framework in reviewboard
I have create a fake test in a real extension to enable target extension.
I have add the document about the Extension Test Framework in docs/manual/extending/extensions/testing.rst.
Description | From | Last Updated |
---|---|---|
'pkg_resources' imported but unused |
reviewbot | |
'Mock' imported but unused |
reviewbot | |
'six' imported but unused |
reviewbot | |
'ExtensionInfo' imported but unused |
reviewbot | |
'RegisteredExtension' imported but unused |
reviewbot | |
'ExtensionHook' imported but unused |
reviewbot | |
'ExtensionHookPoint' imported but unused |
reviewbot | |
'ExtensionManager' imported but unused |
reviewbot | |
'Settings' imported but unused |
reviewbot | |
Col: 1 E303 too many blank lines (3) |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 3 E303 too many blank lines (2) |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 10 E101 indentation contains mixed spaces and tabs |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 3 E303 too many blank lines (2) |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 10 E101 indentation contains mixed spaces and tabs |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 42 E127 continuation line over-indented for visual indent |
reviewbot | |
Col: 29 E127 continuation line over-indented for visual indent |
reviewbot | |
Col: 41 E127 continuation line over-indented for visual indent |
reviewbot | |
Col: 50 E225 missing whitespace around operator |
reviewbot | |
Col: 49 E225 missing whitespace around operator |
reviewbot | |
Col: 80 E501 line too long (95 > 79 characters) |
reviewbot | |
Col: 50 W292 no newline at end of file |
reviewbot | |
Col: 53 E502 the backslash is redundant between brackets |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
local variable 'tests_module' is assigned to but never used |
reviewbot | |
Col: 80 E501 line too long (99 > 79 characters) |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 5 E303 too many blank lines (2) |
reviewbot | |
'primary_widgets' imported but unused |
reviewbot | |
'secondary_widgets' imported but unused |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
'TestModelsLoaderMixin' imported but unused |
reviewbot | |
'WebAPICapabilitiesHook' imported but unused |
reviewbot | |
Col: 62 E261 at least two spaces before inline comment |
reviewbot | |
'BaseWebAPITestCase' imported but unused |
reviewbot | |
Col: 5 E303 too many blank lines (2) |
reviewbot | |
Col: 80 E501 line too long (85 > 79 characters) |
reviewbot | |
Col: 43 E265 block comment should start with '# ' |
reviewbot | |
Col: 80 E501 line too long (85 > 79 characters) |
reviewbot | |
'logging' imported but unused |
reviewbot | |
'nose' imported but unused |
reviewbot | |
'stat' imported but unused |
reviewbot | |
'warnings' imported but unused |
reviewbot | |
'import_module' imported but unused |
reviewbot | |
'Context' imported but unused |
reviewbot | |
'Template' imported but unused |
reviewbot | |
'ImproperlyConfigured' imported but unused |
reviewbot | |
'django_version' imported but unused |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
'Extension' imported but unused |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 1 E101 indentation contains mixed spaces and tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 E101 indentation contains mixed spaces and tabs |
reviewbot | |
Col: 38 E127 continuation line over-indented for visual indent |
reviewbot | |
'Context' imported but unused |
reviewbot | |
'Template' imported but unused |
reviewbot | |
'Extension' imported but unused |
reviewbot | |
'TestCase' imported but unused |
reviewbot | |
'get_hosting_service' imported but unused |
reviewbot | |
'HostingService' imported but unused |
reviewbot | |
'Widget' imported but unused |
reviewbot | |
'secondary_widgets' imported but unused |
reviewbot | |
'primary_widgets' imported but unused |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
undefined name 'TestExtension' |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 11 E128 continuation line under-indented for visual indent |
reviewbot | |
Col: 10 E101 indentation contains mixed spaces and tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 3 W292 no newline at end of file |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
'call_command' imported but unused |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 W191 indentation contains tabs |
reviewbot | |
Col: 1 E265 block comment should start with '# ' |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 3 W292 no newline at end of file |
reviewbot | |
'settings' imported but unused |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
'call_command' imported but unused |
reviewbot | |
'BaseTestRunner' imported but unused |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
'run_tests' imported but unused |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
local variable 'mixin' is assigned to but never used |
reviewbot | |
Col: 71 E202 whitespace before ')' |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 3 W292 no newline at end of file |
reviewbot | |
'call_command' imported but unused |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
'run_tests' imported but unused |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
'get_extension_manager' imported but unused |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
local variable 'mixin' is assigned to but never used |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 5 E303 too many blank lines (2) |
reviewbot | |
undefined name 'RegisteredExtension' |
reviewbot | |
Col: 3 W292 no newline at end of file |
reviewbot | |
'call_command' imported but unused |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
'run_tests' imported but unused |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
'get_extension_manager' imported but unused |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
local variable 'mixin' is assigned to but never used |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 5 E303 too many blank lines (2) |
reviewbot | |
undefined name 'RegisteredExtension' |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Out of curiosity, why are you still hardcoding this to your TestExtension dummy extension? |
mike_conley | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
undefined name 'RUNNING_TEST' |
reviewbot | |
undefined name 'REVIEWBOARD_ROOT' |
reviewbot | |
undefined name 'STATIC_ROOT' |
reviewbot | |
Col: 1 W391 blank line at end of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
'RegisteredExtension' imported but unused |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
'logging' imported but unused |
reviewbot | |
'sys' imported but unused |
reviewbot | |
'import_module' imported but unused |
reviewbot | |
'ImproperlyConfigured' imported but unused |
reviewbot | |
'Extension' imported but unused |
reviewbot | |
Col: 5 E303 too many blank lines (2) |
reviewbot | |
Col: 9 E303 too many blank lines (2) |
reviewbot | |
Col: 5 E303 too many blank lines (2) |
reviewbot | |
undefined name 'self' |
reviewbot | |
undefined name 'module_dir' |
reviewbot | |
Col: 26 E128 continuation line under-indented for visual indent |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 9 E126 continuation line over-indented for hanging indent |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 80 E501 line too long (102 > 79 characters) |
reviewbot | |
undefined name 'HTDOCS_ROOT' |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 9 E126 continuation line over-indented for hanging indent |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 80 E501 line too long (102 > 79 characters) |
reviewbot | |
'djblets' imported but unused |
reviewbot | |
Col: 43 E127 continuation line over-indented for visual indent |
reviewbot | |
Col: 80 E501 line too long (91 > 79 characters) |
reviewbot | |
Col: 1 E265 block comment should start with '# ' |
reviewbot | |
Col: 1 E265 block comment should start with '# ' |
reviewbot | |
Col: 1 W391 blank line at end of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
'os' imported but unused |
reviewbot | |
'sys' imported but unused |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 80 E501 line too long (102 > 79 characters) |
reviewbot | |
Col: 80 E501 line too long (88 > 79 characters) |
reviewbot | |
Col: 41 E128 continuation line under-indented for visual indent |
reviewbot | |
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot | |
Col: 1 W391 blank line at end of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot | |
Col: 45 E127 continuation line over-indented for visual indent |
reviewbot | |
Col: 41 E128 continuation line under-indented for visual indent |
reviewbot | |
Col: 29 E128 continuation line under-indented for visual indent |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
'get_extension_manager' imported but unused |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 46 E128 continuation line under-indented for visual indent |
reviewbot | |
Col: 45 E128 continuation line under-indented for visual indent |
reviewbot | |
Col: 41 E128 continuation line under-indented for visual indent |
reviewbot | |
Col: 80 E501 line too long (91 > 79 characters) |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 43 E231 missing whitespace after ',' |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
I think these are leftovers - they're unrelated to this patch. |
mike_conley | |
We might want to add something about "extension-test" to this database name string. |
mike_conley | |
One too many newlines? |
mike_conley | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Can you quickly explain why you need to do the imports down here? I assume it's a legitimate reason, like … |
mike_conley | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Can you please add a docstring to this? |
mike_conley | |
See my comment in /r/7932 re: test_labels. I'm not sure we need this. |
mike_conley | |
Can you quickly document why this is required? |
mike_conley | |
I think this mixin's responsibilities are a little different... it looks like it's responsible for taking care of the boilerplate … |
mike_conley | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
'os' imported but unused |
reviewbot | |
'VERSION' imported but unused |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
'VERSION' imported but unused |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
I don't think this comment is very clear. Perhaps it should be something like: We need to do these imports … |
mike_conley | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
I don't think "Mixin" needs to be capitalized here. Perhaps better wording: A mixin that helps tests to setup and … |
mike_conley | |
Col: 1 E402 module level import not at top of file |
reviewbot | |
Col: 1 E402 module level import not at top of file |
reviewbot |
-
Tool: Pyflakes Processed Files: reviewboard/testing/extensions.py Tool: PEP8 Style Checker Processed Files: reviewboard/testing/extensions.py WARNING: Number of comments exceeded maximum, showing 30 of 73.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Tool: PEP8 Style Checker Processed Files: reviewboard/testing/extensions.py Tool: Pyflakes Processed Files: reviewboard/testing/extensions.py
-
-
-
-
-
-
-
-
-
Tool: PEP8 Style Checker Processed Files: reviewboard/testing/extensions.py Tool: Pyflakes Processed Files: reviewboard/testing/extensions.py
-
Tool: Pyflakes Processed Files: reviewboard/testing/extensions.py Tool: PEP8 Style Checker Processed Files: reviewboard/testing/extensions.py
-
-
-
-
-
-
Tool: PEP8 Style Checker Processed Files: reviewboard/testing/extensions.py Tool: Pyflakes Processed Files: reviewboard/testing/extensions.py
-
Tool: Pyflakes Processed Files: reviewboard/testing/extensions.py Tool: PEP8 Style Checker Processed Files: reviewboard/testing/extensions.py
-
-
-
-
-
-
-
Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py
-
-
-
-
-
-
-
-
-
-
-
-
-
Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc
-
-
Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc
-
-
-
-
-
-
-
-
-
-
-
-
Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc
-
-
-
-
-
-
-
-
-
-
Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc
-
-
-
-
-
-
-
-
-
Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc
-
-
-
-
-
Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc
-
-
-
-
Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py .reviewboardrc
-
-
- Summary:
-
[WIP]add Extension testing framework in reviewboardAdd Extension testing framework in reviewboard
- Description:
-
~ [WIP]add Extension testing framework in reviewboard
~ Add Extension testing framework in reviewboard
- Testing Done:
-
~ command Line: ./reviewboard/manage.py test -- testing.extensions
~ I have create a fake test in a real extension to enable target extension.
- for test
- Depends On:
-
-
-
-
-
Can you quickly explain why you need to do the imports down here? I assume it's a legitimate reason, like the PATH munging you're doing needs to come before you import django.conf.settings...
If so, can you please add a comment about why it's necessary to do these imports down here?
-
-
-
-
I think this mixin's responsibilities are a little different... it looks like it's responsible for taking care of the boilerplate for setting up and tearing down the Extension.
-
Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py
-
-
-
Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py
-
-
-
-
-
Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py
-
-
-
Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py
-
-
-
Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py
-
-
-
-
-
I don't think this comment is very clear.
Perhaps it should be something like:
We need to do these imports after we set the DJANGO_SETTINGS_MODULE in order to make sure the tests get that change.
Something along those lines, anyhow.
-
I don't think "Mixin" needs to be capitalized here.
Perhaps better wording:
A mixin that helps tests to setup and teardown an extension.
-
Tool: Pyflakes Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py Tool: PEP8 Style Checker Processed Files: reviewboard/extensions/testing/runner.py reviewboard/extensions/testing/conf/settings_local.py reviewboard/testing/extensions.py Ignored Files: reviewboard/extensions/testing/__init__.py
-
-