Fixed permission failure with status message update

Review Request #7922 — Created Jan. 30, 2016 and discarded — Latest diff uploaded

Information

Review Board
release-2.0.x

Reviewers

When users with the "can_change_status" permission try to edit the close message, a permission error occurs. This is because when checking for permission, users with no modify permission are all excluded.
Code is changed to include the case of "can_change_status" permission.
Added test case to cover case where user with "can_change_status" permission but no modify permission should get permission error when trying to edit changenum; the case where user with "can_change_status" permission but no modify permission should get permission error when trying to add extra data; the case where user with "can_edit_reviewrequest" permission but no status mutation permission should get permission error when trying to modify status.

Manual testing and Review Board Unit Testing

Diff Revision 2

This is not the most recent revision of the diff. The latest diff is revision 8. See what's changed.

orig
1
2
3
4
5
6
7
8
reviewboard/webapi/resources/review_request.py
Loading...