• 
      

    Improve styling of mobile elements on some themes.

    Review Request #7883 — Created Jan. 16, 2016 and submitted

    Information

    Review Board
    release-2.5.x

    Reviewers

    When in mobile mode for a page, the product name is now vertically
    centered in relation to the logo, instead of being aligned to the top,
    creating a nicer look.
    
    The hamburger menu on the left is no longer hard-coded as black, but
    instead will match the text color. This allows a page to have a dark
    background without making the menu invisible.

    Saw that the "Review Board" text was more correct. (This manifested
    even better for RBCommons.)

    Tested on a page with a black header bar for the theme, and white text.
    Saw the hamburger menu.

    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/css/pages/base.less
          reviewboard/static/rb/css/mixins/theme.less
      
      
      
      Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/css/pages/base.less
          reviewboard/static/rb/css/mixins/theme.less
      
      
    2. 
        
    david
    1. Screenshots?

      1. I can supply them, but really the only visual is a couple pixels of vertical spacing on RBCommons, making it line up, and not seeing black on black on a test page.

    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.5.x (3230eb6)