Summary

Improve styling of mobile elements on some themes.

Review Request #7883 — Created Jan. 16, 2016 and submitted Feb. 8, 2016, 1:20 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

When in mobile mode for a page, the product name is now vertically
centered in relation to the logo, instead of being aligned to the top,
creating a nicer look.

The hamburger menu on the left is no longer hard-coded as black, but
instead will match the text color. This allows a page to have a dark
background without making the menu invisible.

Testing Done

Saw that the "Review Board" text was more correct. (This manifested
even better for RBCommons.)

Tested on a page with a black header bar for the theme, and white text.
Saw the hamburger menu.

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/css/pages/base.less
    reviewboard/static/rb/css/mixins/theme.less



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/css/pages/base.less
    reviewboard/static/rb/css/mixins/theme.less

Screenshots?

chipx86 Feb. 7, 2016, 1:50 p.m.

I can supply them, but really the only visual is a couple pixels of vertical spacing on RBCommons, making it line up, and not seeing black on black on a test page.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (3230eb6)