diff --git a/reviewboard/hostingsvcs/tests.py b/reviewboard/hostingsvcs/tests.py deleted file mode 100644 index 6b02c6a8547167563e78691de1a54ba86e9f8c55..0000000000000000000000000000000000000000 --- a/reviewboard/hostingsvcs/tests.py +++ /dev/null @@ -1,3824 +0,0 @@ -from __future__ import print_function, unicode_literals - -import hashlib -import hmac -import json -from hashlib import md5 -from textwrap import dedent - -from django.conf.urls import patterns, url -from django.core.exceptions import ObjectDoesNotExist -from django.core.urlresolvers import NoReverseMatch -from django.http import HttpResponse -from django.utils import six -from django.utils.six.moves import cStringIO as StringIO -from django.utils.six.moves.urllib.error import HTTPError -from django.utils.six.moves.urllib.parse import urlparse -from djblets.testing.decorators import add_fixtures -from kgb import SpyAgency - -from reviewboard.hostingsvcs.errors import (AuthorizationError, - RepositoryError) -from reviewboard.hostingsvcs.models import HostingServiceAccount -from reviewboard.hostingsvcs.repository import RemoteRepository -from reviewboard.hostingsvcs.service import (get_hosting_service, - HostingService, - register_hosting_service, - unregister_hosting_service) -from reviewboard.reviews.models import ReviewRequest -from reviewboard.scmtools.core import Branch -from reviewboard.scmtools.crypto_utils import encrypt_password -from reviewboard.scmtools.errors import FileNotFoundError, SCMError -from reviewboard.scmtools.models import Repository, Tool -from reviewboard.site.models import LocalSite -from reviewboard.site.urlresolvers import local_site_reverse -from reviewboard.testing import TestCase - - -class ServiceTests(SpyAgency, TestCase): - service_name = None - - def __init__(self, *args, **kwargs): - super(ServiceTests, self).__init__(*args, **kwargs) - - self.assertNotEqual(self.service_name, None) - self.service_class = get_hosting_service(self.service_name) - - def setUp(self): - super(ServiceTests, self).setUp() - self.assertNotEqual(self.service_class, None) - - def _get_repository_info(self, field, plan=None): - if plan: - self.assertNotEqual(self.service_class.plans, None) - result = None - - for plan_type, info in self.service_class.plans: - if plan_type == plan: - result = info[field] - break - - self.assertNotEqual(result, None) - return result - else: - self.assertEqual(self.service_class.plans, None) - self.assertTrue(hasattr(self.service_class, field)) - - return getattr(self.service_class, field) - - def _get_form(self, plan=None, fields={}): - form = self._get_repository_info('form', plan) - self.assertNotEqual(form, None) - - form = form(fields) - self.assertTrue(form.is_valid()) - - return form - - def _get_hosting_account(self, use_url=False, local_site=None): - if use_url: - hosting_url = 'https://example.com' - else: - hosting_url = None - - return HostingServiceAccount(service_name=self.service_name, - username='myuser', - hosting_url=hosting_url, - local_site=local_site) - - def _get_service(self): - return self._get_hosting_account().service - - def _get_repository_fields(self, tool_name, fields, plan=None, - with_url=False): - form = self._get_form(plan, fields) - account = self._get_hosting_account(with_url) - service = account.service - self.assertNotEqual(service, None) - - return service.get_repository_fields(username=account.username, - hosting_url='https://example.com', - plan=plan, - tool_name=tool_name, - field_vars=form.clean()) - - -class AssemblaTests(ServiceTests): - """Unit tests for the Assembla hosting service.""" - - service_name = 'assembla' - fixtures = ['test_scmtools'] - - def test_service_support(self): - """Testing Assembla service support capabilities""" - self.assertTrue(self.service_class.needs_authorization) - self.assertTrue(self.service_class.supports_bug_trackers) - self.assertTrue(self.service_class.supports_repositories) - self.assertEqual(self.service_class.supported_scmtools, - ['Perforce', 'Subversion']) - - def test_repo_field_values_perforce(self): - """Testing Assembla repository field values for Perforce""" - fields = self._get_repository_fields('Perforce', fields={ - 'assembla_project_id': 'myproject', - }) - self.assertEqual(fields['path'], 'perforce.assembla.com:1666') - self.assertNotIn('mirror_path', fields) - self.assertIn('encoding', fields) - self.assertEqual(fields['encoding'], 'utf8') - - def test_repo_field_values_subversion(self): - """Testing Assembla repository field values for Subversion""" - fields = self._get_repository_fields('Subversion', fields={ - 'assembla_project_id': 'myproject', - 'assembla_repo_name': 'myrepo', - }) - self.assertEqual(fields['path'], - 'https://subversion.assembla.com/svn/myproject/') - self.assertNotIn('mirror_path', fields) - self.assertNotIn('encoding', fields) - - def test_save_form_perforce(self): - """Testing Assembla configuration form with Perforce""" - account = self._get_hosting_account() - service = account.service - service.authorize('myuser', 'abc123', None) - - repository = Repository(hosting_account=account, - tool=Tool.objects.get(name='Perforce')) - - form = self._get_form(fields={'assembla_project_id': 'myproject'}) - form.save(repository) - - self.assertIn('use_ticket_auth', repository.extra_data) - self.assertTrue(repository.extra_data['use_ticket_auth']) - self.assertIn('p4_host', repository.extra_data) - self.assertEqual(repository.extra_data['p4_host'], 'myproject') - - def test_save_form_subversion(self): - """Testing Assembla configuration form with Subversion""" - account = self._get_hosting_account() - service = account.service - service.authorize('myuser', 'abc123', None) - - repository = Repository(path='https://svn.example.com/', - hosting_account=account, - tool=Tool.objects.get(name='Subversion')) - - form = self._get_form(fields={'assembla_project_id': 'myproject'}) - form.save(repository) - - self.assertNotIn('use_ticket_auth', repository.extra_data) - self.assertNotIn('p4_host', repository.extra_data) - - def test_authorize(self): - """Testing Assembla authorization password storage""" - account = self._get_hosting_account() - service = account.service - - self.assertFalse(service.is_authorized()) - - service.authorize('myuser', 'abc123', None) - - self.assertIn('password', account.data) - self.assertNotEqual(account.data['password'], 'abc123') - self.assertTrue(service.is_authorized()) - - def test_check_repository_perforce(self): - """Testing Assembla check_repository with Perforce""" - account = self._get_hosting_account() - service = account.service - - service.authorize('myuser', 'abc123', None) - - repository = Repository(hosting_account=account, - tool=Tool.objects.get(name='Perforce')) - scmtool = repository.get_scmtool() - self.spy_on(scmtool.check_repository, call_original=False) - - service.check_repository(path='mypath', - username='myusername', - password='mypassword', - scmtool_class=scmtool.__class__, - local_site_name=None, - assembla_project_id='myproject') - - self.assertTrue(scmtool.check_repository.called) - self.assertIn('p4_host', scmtool.check_repository.last_call.kwargs) - self.assertEqual(scmtool.check_repository.last_call.kwargs['p4_host'], - 'myproject') - - def test_check_repository_subversion(self): - """Testing Assembla check_repository with Subversion""" - account = self._get_hosting_account() - service = account.service - - service.authorize('myuser', 'abc123', None) - - repository = Repository(path='https://svn.example.com/', - hosting_account=account, - tool=Tool.objects.get(name='Subversion')) - scmtool = repository.get_scmtool() - self.spy_on(scmtool.check_repository, call_original=False) - - service.check_repository(path='https://svn.example.com/', - username='myusername', - password='mypassword', - scmtool_class=scmtool.__class__, - local_site_name=None) - - self.assertTrue(scmtool.check_repository.called) - self.assertNotIn('p4_host', scmtool.check_repository.last_call.kwargs) - - -class BeanstalkTests(ServiceTests): - """Unit tests for the Beanstalk hosting service.""" - service_name = 'beanstalk' - fixtures = ['test_scmtools'] - - def test_service_support(self): - """Testing Beanstalk service support capabilities""" - self.assertFalse(self.service_class.supports_bug_trackers) - self.assertTrue(self.service_class.supports_repositories) - - def test_repo_field_values_git(self): - """Testing Beanstalk repository field values for Git""" - fields = self._get_repository_fields('Git', fields={ - 'beanstalk_account_domain': 'mydomain', - 'beanstalk_repo_name': 'myrepo', - }) - self.assertEqual( - fields['path'], - 'git@mydomain.beanstalkapp.com:/mydomain/myrepo.git') - self.assertEqual( - fields['mirror_path'], - 'https://mydomain.git.beanstalkapp.com/myrepo.git') - - def test_repo_field_values_subversion(self): - """Testing Beanstalk repository field values for Subversion""" - fields = self._get_repository_fields('Subversion', fields={ - 'beanstalk_account_domain': 'mydomain', - 'beanstalk_repo_name': 'myrepo', - }) - self.assertEqual( - fields['path'], - 'https://mydomain.svn.beanstalkapp.com/myrepo/') - self.assertNotIn('mirror_path', fields) - - def test_authorize(self): - """Testing Beanstalk authorization password storage""" - account = self._get_hosting_account() - service = account.service - - self.assertFalse(service.is_authorized()) - - service.authorize('myuser', 'abc123', None) - - self.assertIn('password', account.data) - self.assertNotEqual(account.data['password'], 'abc123') - self.assertTrue(service.is_authorized()) - - def test_check_repository(self): - """Testing Beanstalk check_repository""" - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://mydomain.beanstalkapp.com/api/repositories/' - 'myrepo.json') - return '{}', {} - - account = self._get_hosting_account() - service = account.service - - service.authorize('myuser', 'abc123', None) - - self.spy_on(service.client.http_get, call_fake=_http_get) - - service.check_repository(beanstalk_account_domain='mydomain', - beanstalk_repo_name='myrepo') - self.assertTrue(service.client.http_get.called) - - def test_get_file_with_svn_and_base_commit_id(self): - """Testing Beanstalk get_file with Subversion and base commit ID""" - self._test_get_file( - tool_name='Subversion', - revision='123', - base_commit_id='456', - expected_revision='123') - - def test_get_file_with_svn_and_revision(self): - """Testing Beanstalk get_file with Subversion and revision""" - self._test_get_file( - tool_name='Subversion', - revision='123', - base_commit_id=None, - expected_revision='123') - - def test_get_file_with_git_and_base_commit_id(self): - """Testing Beanstalk get_file with Git and base commit ID""" - self._test_get_file( - tool_name='Git', - revision='123', - base_commit_id='456', - expected_revision='123') - - def test_get_file_with_git_and_revision(self): - """Testing Beanstalk get_file with Git and revision""" - self._test_get_file( - tool_name='Git', - revision='123', - base_commit_id=None, - expected_revision='123') - - def test_get_file_exists_with_svn_and_base_commit_id(self): - """Testing Beanstalk get_file_exists with Subversion and base commit ID - """ - self._test_get_file_exists( - tool_name='Subversion', - revision='123', - base_commit_id='456', - expected_revision='123', - expected_found=True) - - def test_get_file_exists_with_svn_and_revision(self): - """Testing Beanstalk get_file_exists with Subversion and revision""" - self._test_get_file_exists( - tool_name='Subversion', - revision='123', - base_commit_id=None, - expected_revision='123', - expected_found=True) - - def test_get_file_exists_with_git_and_base_commit_id(self): - """Testing Beanstalk get_file_exists with Git and base commit ID""" - self._test_get_file_exists( - tool_name='Git', - revision='123', - base_commit_id='456', - expected_revision='456', - expected_found=True) - - def test_get_file_exists_with_git_and_revision(self): - """Testing Beanstalk get_file_exists with Git and revision""" - self._test_get_file_exists( - tool_name='Git', - revision='123', - base_commit_id=None, - expected_revision='123', - expected_found=True) - - def _test_get_file(self, tool_name, revision, base_commit_id, - expected_revision): - def _http_get(service, url, *args, **kwargs): - if tool_name == 'Git': - self.assertEqual( - url, - 'https://mydomain.beanstalkapp.com/api/repositories/' - 'myrepo/blob?id=%s&name=path' - % expected_revision) - payload = b'My data' - else: - self.assertEqual( - url, - 'https://mydomain.beanstalkapp.com/api/repositories/' - 'myrepo/node.json?path=/path&revision=%s&contents=1' - % expected_revision) - payload = b'{"contents": "My data"}' - - return payload, {} - - account = self._get_hosting_account() - service = account.service - repository = Repository(hosting_account=account, - tool=Tool.objects.get(name=tool_name)) - repository.extra_data = { - 'beanstalk_account_domain': 'mydomain', - 'beanstalk_repo_name': 'myrepo', - } - - service.authorize('myuser', 'abc123', None) - - self.spy_on(service.client.http_get, call_fake=_http_get) - - result = service.get_file(repository, '/path', revision, - base_commit_id) - self.assertTrue(service.client.http_get.called) - self.assertEqual(result, 'My data') - - def _test_get_file_exists(self, tool_name, revision, base_commit_id, - expected_revision, expected_found): - def _http_get(service, url, *args, **kwargs): - expected_url = ('https://mydomain.beanstalkapp.com/api/' - 'repositories/myrepo/') - - if not base_commit_id and tool_name == 'Git': - expected_url += 'blob?id=%s&name=path' % expected_revision - else: - expected_url += ('node.json?path=/path&revision=%s' - % expected_revision) - - self.assertEqual(url, expected_url) - - if expected_found: - return b'{}', {} - else: - raise HTTPError() - - account = self._get_hosting_account() - service = account.service - repository = Repository(hosting_account=account, - tool=Tool.objects.get(name=tool_name)) - repository.extra_data = { - 'beanstalk_account_domain': 'mydomain', - 'beanstalk_repo_name': 'myrepo', - } - - service.authorize('myuser', 'abc123', None) - - self.spy_on(service.client.http_get, call_fake=_http_get) - - result = service.get_file_exists(repository, '/path', revision, - base_commit_id) - self.assertTrue(service.client.http_get.called) - self.assertEqual(result, expected_found) - - -class BitbucketTests(ServiceTests): - """Unit tests for the Bitbucket hosting service.""" - service_name = 'bitbucket' - fixtures = ['test_scmtools'] - - def test_service_support(self): - """Testing Bitbucket service support capabilities""" - self.assertTrue(self.service_class.supports_bug_trackers) - self.assertTrue(self.service_class.supports_repositories) - - def test_personal_repo_field_values_git(self): - """Testing Bitbucket personal repository field values for Git""" - fields = self._get_repository_fields( - 'Git', - fields={ - 'bitbucket_repo_name': 'myrepo', - }, - plan='personal') - self.assertEqual(fields['path'], - 'git@bitbucket.org:myuser/myrepo.git') - self.assertEqual(fields['mirror_path'], - 'https://myuser@bitbucket.org/myuser/myrepo.git') - - def test_personal_repo_field_values_mercurial(self): - """Testing Bitbucket personal repository field values for Mercurial""" - fields = self._get_repository_fields( - 'Mercurial', - fields={ - 'bitbucket_repo_name': 'myrepo', - }, - plan='personal') - self.assertEqual(fields['path'], - 'https://myuser@bitbucket.org/myuser/myrepo') - self.assertEqual(fields['mirror_path'], - 'ssh://hg@bitbucket.org/myuser/myrepo') - - def test_personal_bug_tracker_field(self): - """Testing Bitbucket personal bug tracker field values""" - self.assertTrue(self.service_class.get_bug_tracker_requires_username( - plan='personal')) - self.assertEqual( - self.service_class.get_bug_tracker_field( - 'personal', - { - 'bitbucket_repo_name': 'myrepo', - 'hosting_account_username': 'myuser', - }), - 'https://bitbucket.org/myuser/myrepo/issue/%s/') - - def test_personal_check_repository(self): - """Testing Bitbucket personal check_repository""" - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://bitbucket.org/api/1.0/repositories/myuser/myrepo') - return b'{}', {} - - account = self._get_hosting_account() - account.data['password'] = encrypt_password('abc123') - service = account.service - - self.spy_on(service.client.http_get, call_fake=_http_get) - - service.check_repository(bitbucket_repo_name='myrepo', - plan='personal') - self.assertTrue(service.client.http_get.called) - - def test_team_repo_field_values_git(self): - """Testing Bitbucket team repository field values for Git""" - fields = self._get_repository_fields( - 'Git', - fields={ - 'bitbucket_team_name': 'myteam', - 'bitbucket_team_repo_name': 'myrepo', - }, - plan='team') - self.assertEqual(fields['path'], - 'git@bitbucket.org:myteam/myrepo.git') - self.assertEqual(fields['mirror_path'], - 'https://myuser@bitbucket.org/myteam/myrepo.git') - - def test_team_repo_field_values_mercurial(self): - """Testing Bitbucket team repository field values for Mercurial""" - fields = self._get_repository_fields( - 'Mercurial', - fields={ - 'bitbucket_team_name': 'myteam', - 'bitbucket_team_repo_name': 'myrepo', - }, - plan='team') - self.assertEqual(fields['path'], - 'https://myuser@bitbucket.org/myteam/myrepo') - self.assertEqual(fields['mirror_path'], - 'ssh://hg@bitbucket.org/myteam/myrepo') - - def test_team_bug_tracker_field(self): - """Testing Bitbucket team bug tracker field values""" - self.assertFalse(self.service_class.get_bug_tracker_requires_username( - plan='team')) - self.assertEqual( - self.service_class.get_bug_tracker_field( - 'team', - { - 'bitbucket_team_name': 'myteam', - 'bitbucket_team_repo_name': 'myrepo', - }), - 'https://bitbucket.org/myteam/myrepo/issue/%s/') - - def test_team_check_repository(self): - """Testing Bitbucket team check_repository""" - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://bitbucket.org/api/1.0/repositories/myteam/myrepo') - return b'{}', {} - - account = self._get_hosting_account() - service = account.service - - account.data['password'] = encrypt_password('abc123') - - self.spy_on(service.client.http_get, call_fake=_http_get) - - service.check_repository(bitbucket_team_name='myteam', - bitbucket_team_repo_name='myrepo', - plan='team') - self.assertTrue(service.client.http_get.called) - - def test_check_repository_with_slash(self): - """Testing Bitbucket check_repository with /""" - account = self._get_hosting_account() - account.data['password'] = encrypt_password('abc123') - service = account.service - - self.assertRaisesMessage( - RepositoryError, - 'Please specify just the name of the repository, not a path.', - lambda: service.check_repository( - bitbucket_team_name='myteam', - bitbucket_team_repo_name='myteam/myrepo', - plan='team')) - - def test_check_repository_with_dot_git(self): - """Testing Bitbucket check_repository with .git""" - account = self._get_hosting_account() - account.data['password'] = encrypt_password('abc123') - service = account.service - - self.assertRaisesMessage( - RepositoryError, - 'Please specify just the name of the repository without ".git".', - lambda: service.check_repository( - bitbucket_team_name='myteam', - bitbucket_team_repo_name='myrepo.git', - plan='team')) - - def test_authorize(self): - """Testing Bitbucket authorization""" - def _http_get(self, *args, **kwargs): - return '{}', {} - - account = self._get_hosting_account() - service = account.service - - self.spy_on(service.client.http_get, call_fake=_http_get) - - self.assertFalse(service.is_authorized()) - - service.authorize('myuser', 'abc123', None) - - self.assertIn('password', account.data) - self.assertNotEqual(account.data['password'], 'abc123') - self.assertTrue(service.is_authorized()) - - def test_authorize_with_bad_credentials(self): - """Testing Bitbucket authorization with bad credentials""" - def _http_get(service, url, *args, **kwargs): - raise HTTPError(url, 401, '', {}, StringIO('')) - - account = self._get_hosting_account() - service = account.service - - self.spy_on(service.client.http_get, call_fake=_http_get) - - self.assertFalse(service.is_authorized()) - - self.assertRaisesMessage( - AuthorizationError, - 'Invalid Bitbucket username or password', - lambda: service.authorize('myuser', 'abc123', None)) - - self.assertNotIn('password', account.data) - self.assertFalse(service.is_authorized()) - - def test_get_file_with_mercurial_and_base_commit_id(self): - """Testing Bitbucket get_file with Mercurial and base commit ID""" - self._test_get_file( - tool_name='Mercurial', - revision='123', - base_commit_id='456', - expected_revision='456') - - def test_get_file_with_mercurial_and_revision(self): - """Testing Bitbucket get_file with Mercurial and revision""" - self._test_get_file( - tool_name='Mercurial', - revision='123', - base_commit_id=None, - expected_revision='123') - - def test_get_file_with_git_and_base_commit_id(self): - """Testing Bitbucket get_file with Git and base commit ID""" - self._test_get_file( - tool_name='Git', - revision='123', - base_commit_id='456', - expected_revision='456') - - def test_get_file_with_git_and_revision(self): - """Testing Bitbucket get_file with Git and revision""" - self.assertRaises( - FileNotFoundError, - self._test_get_file, - tool_name='Git', - revision='123', - base_commit_id=None, - expected_revision='123') - - def test_get_file_exists_with_mercurial_and_base_commit_id(self): - """Testing Bitbucket get_file_exists with Mercurial and base commit ID - """ - self._test_get_file_exists( - tool_name='Mercurial', - revision='123', - base_commit_id='456', - expected_revision='456', - expected_found=True) - - def test_get_file_exists_with_mercurial_and_revision(self): - """Testing Bitbucket get_file_exists with Mercurial and revision""" - self._test_get_file_exists( - tool_name='Mercurial', - revision='123', - base_commit_id=None, - expected_revision='123', - expected_found=True) - - def test_get_file_exists_with_git_and_base_commit_id(self): - """Testing Bitbucket get_file_exists with Git and base commit ID""" - self._test_get_file_exists( - tool_name='Git', - revision='123', - base_commit_id='456', - expected_revision='456', - expected_found=True) - - def test_get_file_exists_with_git_and_revision(self): - """Testing Bitbucket get_file_exists with Git and revision""" - self._test_get_file_exists( - tool_name='Git', - revision='123', - base_commit_id=None, - expected_revision='123', - expected_found=False, - expected_http_called=False) - - def test_get_file_exists_with_git_and_404(self): - """Testing BitBucket get_file_exists with Git and a 404 error""" - self._test_get_file_exists( - tool_name='Git', - revision='123', - base_commit_id='456', - expected_revision='456', - expected_found=False) - - @add_fixtures(['test_users', 'test_scmtools']) - def test_close_submitted_hook(self): - """Testing BitBucket close_submitted hook""" - self._test_post_commit_hook() - - @add_fixtures(['test_site', 'test_users', 'test_scmtools']) - def test_close_submitted_hook_with_local_site(self): - """Testing BitBucket close_submitted hook with a Local Site""" - self._test_post_commit_hook( - LocalSite.objects.get(name=self.local_site_name)) - - @add_fixtures(['test_users', 'test_scmtools']) - def test_close_submitted_hook_with_invalid_repo(self): - """Testing BitBucket close_submitted hook with invalid repository""" - repository = self.create_repository() - - review_request = self.create_review_request(repository=repository, - publish=True) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'bitbucket-hooks-close-submitted', - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'bitbucket', - 'hooks_uuid': repository.get_or_create_hooks_uuid(), - }) - - response = self._post_commit_hook_payload(url, review_request) - self.assertEqual(response.status_code, 404) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - self.assertEqual(review_request.changedescs.count(), 0) - - @add_fixtures(['test_site', 'test_users', 'test_scmtools']) - def test_close_submitted_hook_with_invalid_site(self): - """Testing BitBucket close_submitted hook with invalid Local Site""" - local_site = LocalSite.objects.get(name=self.local_site_name) - account = self._get_hosting_account(local_site=local_site) - account.save() - - repository = self.create_repository(hosting_account=account, - local_site=local_site) - - review_request = self.create_review_request(repository=repository, - publish=True) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'bitbucket-hooks-close-submitted', - local_site_name='badsite', - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'bitbucket', - 'hooks_uuid': repository.get_or_create_hooks_uuid(), - }) - - response = self._post_commit_hook_payload(url, review_request) - self.assertEqual(response.status_code, 404) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - self.assertEqual(review_request.changedescs.count(), 0) - - @add_fixtures(['test_users', 'test_scmtools']) - def test_close_submitted_hook_with_invalid_service_id(self): - """Testing BitBucket close_submitted hook with invalid hosting - service ID - """ - # We'll test against GitHub for this test. - account = self._get_hosting_account() - account.service_name = 'github' - account.save() - repository = self.create_repository(hosting_account=account) - - review_request = self.create_review_request(repository=repository, - publish=True) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'bitbucket-hooks-close-submitted', - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'bitbucket', - 'hooks_uuid': repository.get_or_create_hooks_uuid(), - }) - - response = self._post_commit_hook_payload(url, review_request) - self.assertEqual(response.status_code, 404) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - self.assertEqual(review_request.changedescs.count(), 0) - - def _test_post_commit_hook(self, local_site=None): - account = self._get_hosting_account(local_site=local_site) - account.save() - - repository = self.create_repository(hosting_account=account, - local_site=local_site) - - review_request = self.create_review_request(repository=repository, - local_site=local_site, - publish=True) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'bitbucket-hooks-close-submitted', - local_site=local_site, - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'bitbucket', - 'hooks_uuid': repository.get_or_create_hooks_uuid(), - }) - - self._post_commit_hook_payload(url, review_request) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.SUBMITTED) - self.assertEqual(review_request.changedescs.count(), 1) - - changedesc = review_request.changedescs.get() - self.assertEqual(changedesc.text, 'Pushed to master (1c44b46)') - - def _post_commit_hook_payload(self, url, review_request): - return self.client.post( - url, - data={ - 'payload': json.dumps({ - # NOTE: This payload only contains the content we make - # use of in the hook. - 'commits': [ - { - 'raw_node': '1c44b461cebe5874a857c51a4a13a84' - '9a4d1e52d', - 'branch': 'master', - 'message': 'This is my fancy commit\n' - '\n' - 'Reviewed at http://example.com%s' - % review_request.get_absolute_url(), - }, - ] - }), - }) - - def _test_get_file(self, tool_name, revision, base_commit_id, - expected_revision): - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://bitbucket.org/api/1.0/repositories/' - 'myuser/myrepo/raw/%s/path' - % expected_revision) - return b'My data', {} - - account = self._get_hosting_account() - service = account.service - repository = Repository(hosting_account=account, - tool=Tool.objects.get(name=tool_name)) - repository.extra_data = { - 'bitbucket_repo_name': 'myrepo', - } - - account.data['password'] = encrypt_password('abc123') - - self.spy_on(service.client.http_get, call_fake=_http_get) - - result = service.get_file(repository, 'path', revision, - base_commit_id) - self.assertTrue(service.client.http_get.called) - self.assertEqual(result, 'My data') - - def _test_get_file_exists(self, tool_name, revision, base_commit_id, - expected_revision, expected_found, - expected_http_called=True): - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://bitbucket.org/api/1.0/repositories/' - 'myuser/myrepo/raw/%s/path' - % expected_revision) - - if expected_found: - return b'{}', {} - else: - error = HTTPError(url, 404, 'Not Found', {}, None) - error.read = lambda: error.reason - raise error - - account = self._get_hosting_account() - service = account.service - repository = Repository(hosting_account=account, - tool=Tool.objects.get(name=tool_name)) - repository.extra_data = { - 'bitbucket_repo_name': 'myrepo', - } - - account.data['password'] = encrypt_password('abc123') - - self.spy_on(service.client.http_get, call_fake=_http_get) - - result = service.get_file_exists(repository, 'path', revision, - base_commit_id) - self.assertEqual(service.client.http_get.called, expected_http_called) - self.assertEqual(result, expected_found) - - -class BugzillaTests(ServiceTests): - """Unit tests for the Bugzilla hosting service.""" - service_name = 'bugzilla' - fixtures = ['test_scmtools'] - - def test_service_support(self): - """Testing the Bugzilla service support capabilities""" - self.assertTrue(self.service_class.supports_bug_trackers) - self.assertFalse(self.service_class.supports_repositories) - - def test_bug_tracker_field(self): - """Testing the Bugzilla bug tracker field value""" - self.assertFalse( - self.service_class.get_bug_tracker_requires_username()) - self.assertEqual( - self.service_class.get_bug_tracker_field(None, { - 'bugzilla_url': 'http://bugzilla.example.com', - }), - 'http://bugzilla.example.com/show_bug.cgi?id=%s') - - -class CodebaseHQTests(ServiceTests): - """Unit tests for the Codebase HQ hosting service.""" - service_name = 'codebasehq' - - def test_service_support(self): - """Testing the Codebase HQ service support capabilities""" - self.assertFalse(self.service_class.supports_bug_trackers) - self.assertTrue(self.service_class.supports_repositories) - - def test_repo_field_values(self): - """Testing the Codebase HQ repository field values""" - fields = self._get_repository_fields('Git', fields={ - 'codebasehq_project_name': 'myproj', - 'codebasehq_group_name': 'mygroup', - 'codebasehq_repo_name': 'myrepo', - 'codebasehq_api_username': 'myapiuser', - 'codebasehq_api_key': 'myapikey', - }) - self.assertEqual(fields['username'], 'myapiuser') - self.assertEqual(fields['password'], 'myapikey') - self.assertEqual(fields['path'], - 'git@codebasehq.com:mygroup/myproj/myrepo.git') - self.assertEqual(fields['raw_file_url'], - 'https://api3.codebasehq.com/myproj/myrepo/blob/' - '') - - -class FedoraHosted(ServiceTests): - """Unit tests for the Fedora Hosted hosting service.""" - service_name = 'fedorahosted' - - def test_service_support(self): - """Testing the Fedora Hosted service support capabilities""" - self.assertTrue(self.service_class.supports_bug_trackers) - self.assertTrue(self.service_class.supports_repositories) - - def test_repo_field_values_git(self): - """Testing the Fedora Hosted repository field values for Git""" - fields = self._get_repository_fields('Git', fields={ - 'fedorahosted_repo_name': 'myrepo', - }) - self.assertEqual(fields['path'], - 'git://git.fedorahosted.org/git/myrepo.git') - self.assertEqual(fields['raw_file_url'], - 'http://git.fedorahosted.org/cgit/myrepo.git/' - 'blob/?id=') - - def test_repo_field_values_mercurial(self): - """Testing the Fedora Hosted repository field values for Mercurial""" - fields = self._get_repository_fields('Mercurial', fields={ - 'fedorahosted_repo_name': 'myrepo', - }) - self.assertEqual(fields['path'], - 'http://hg.fedorahosted.org/hg/myrepo/') - self.assertEqual(fields['mirror_path'], - 'https://hg.fedorahosted.org/hg/myrepo/') - - def test_repo_field_values_svn(self): - """Testing the Fedora Hosted repository field values for Subversion""" - fields = self._get_repository_fields('Subversion', fields={ - 'fedorahosted_repo_name': 'myrepo', - }) - self.assertEqual(fields['path'], - 'http://svn.fedorahosted.org/svn/myrepo/') - self.assertEqual(fields['mirror_path'], - 'https://svn.fedorahosted.org/svn/myrepo/') - - def test_bug_tracker_field(self): - """Testing the Fedora Hosted bug tracker field value""" - self.assertFalse( - self.service_class.get_bug_tracker_requires_username()) - self.assertEqual( - self.service_class.get_bug_tracker_field(None, { - 'fedorahosted_repo_name': 'myrepo', - }), - 'https://fedorahosted.org/myrepo/ticket/%s') - - -class FogBugzTests(ServiceTests): - """Unit tests for the FogBugz hosting service.""" - service_name = 'fogbugz' - fixtures = ['test_scmtools'] - - def test_service_support(self): - """Testing the FogBugz service support capabilities""" - self.assertTrue(self.service_class.supports_bug_trackers) - self.assertFalse(self.service_class.supports_repositories) - - def test_bug_tracker_field(self): - """Testing the FogBugz bug tracker field value""" - self.assertFalse( - self.service_class.get_bug_tracker_requires_username()) - self.assertEqual( - self.service_class.get_bug_tracker_field(None, { - 'fogbugz_account_domain': 'mydomain', - }), - 'https://mydomain.fogbugz.com/f/cases/%s') - - -class GitHubTests(ServiceTests): - """Unit tests for the GitHub hosting service.""" - service_name = 'github' - - def test_service_support(self): - """Testing the GitHub service support capabilities""" - self.assertTrue(self.service_class.supports_bug_trackers) - self.assertTrue(self.service_class.supports_repositories) - self.assertFalse(self.service_class.supports_ssh_key_association) - - def test_public_field_values(self): - """Testing the GitHub public plan repository field values""" - fields = self._get_repository_fields('Git', plan='public', fields={ - 'github_public_repo_name': 'myrepo', - }) - self.assertEqual(fields['path'], 'git://github.com/myuser/myrepo.git') - self.assertEqual(fields['mirror_path'], - 'git@github.com:myuser/myrepo.git') - - def test_public_repo_api_url(self): - """Testing the GitHub public repository API URL""" - url = self._get_repo_api_url('public', { - 'github_public_repo_name': 'testrepo', - }) - self.assertEqual(url, 'https://api.github.com/repos/myuser/testrepo') - - def test_public_bug_tracker_field(self): - """Testing the GitHub public repository bug tracker field value""" - self.assertTrue( - self.service_class.get_bug_tracker_requires_username('public')) - self.assertEqual( - self.service_class.get_bug_tracker_field('public', { - 'github_public_repo_name': 'myrepo', - 'hosting_account_username': 'myuser', - }), - 'http://github.com/myuser/myrepo/issues#issue/%s') - - def test_public_org_field_values(self): - """Testing the GitHub public-org plan repository field values""" - fields = self._get_repository_fields('Git', plan='public-org', fields={ - 'github_public_org_repo_name': 'myrepo', - 'github_public_org_name': 'myorg', - }) - self.assertEqual(fields['path'], 'git://github.com/myorg/myrepo.git') - self.assertEqual(fields['mirror_path'], - 'git@github.com:myorg/myrepo.git') - - def test_public_org_repo_api_url(self): - """Testing the GitHub public-org repository API URL""" - url = self._get_repo_api_url('public-org', { - 'github_public_org_name': 'myorg', - 'github_public_org_repo_name': 'testrepo', - }) - self.assertEqual(url, 'https://api.github.com/repos/myorg/testrepo') - - def test_public_org_bug_tracker_field(self): - """Testing the GitHub public-org repository bug tracker field value""" - self.assertFalse( - self.service_class.get_bug_tracker_requires_username('public-org')) - self.assertEqual( - self.service_class.get_bug_tracker_field('public-org', { - 'github_public_org_name': 'myorg', - 'github_public_org_repo_name': 'myrepo', - }), - 'http://github.com/myorg/myrepo/issues#issue/%s') - - def test_private_field_values(self): - """Testing the GitHub private plan repository field values""" - fields = self._get_repository_fields('Git', plan='private', fields={ - 'github_private_repo_name': 'myrepo', - }) - self.assertEqual(fields['path'], 'git@github.com:myuser/myrepo.git') - self.assertEqual(fields['mirror_path'], '') - - def test_private_repo_api_url(self): - """Testing the GitHub private repository API URL""" - url = self._get_repo_api_url('private', { - 'github_private_repo_name': 'testrepo', - }) - self.assertEqual(url, 'https://api.github.com/repos/myuser/testrepo') - - def test_private_bug_tracker_field(self): - """Testing the GitHub private repository bug tracker field value""" - self.assertTrue( - self.service_class.get_bug_tracker_requires_username('private')) - self.assertEqual( - self.service_class.get_bug_tracker_field('private', { - 'github_private_repo_name': 'myrepo', - 'hosting_account_username': 'myuser', - }), - 'http://github.com/myuser/myrepo/issues#issue/%s') - - def test_private_org_field_values(self): - """Testing the GitHub private-org plan repository field values""" - fields = self._get_repository_fields( - 'Git', plan='private-org', fields={ - 'github_private_org_repo_name': 'myrepo', - 'github_private_org_name': 'myorg', - }) - self.assertEqual(fields['path'], 'git@github.com:myorg/myrepo.git') - self.assertEqual(fields['mirror_path'], '') - - def test_private_org_repo_api_url(self): - """Testing the GitHub private-org repository API URL""" - url = self._get_repo_api_url('private-org', { - 'github_private_org_name': 'myorg', - 'github_private_org_repo_name': 'testrepo', - }) - self.assertEqual(url, 'https://api.github.com/repos/myorg/testrepo') - - def test_private_org_bug_tracker_field(self): - """Testing the GitHub private-org repository bug tracker field value""" - self.assertFalse(self.service_class.get_bug_tracker_requires_username( - 'private-org')) - self.assertEqual( - self.service_class.get_bug_tracker_field('private-org', { - 'github_private_org_name': 'myorg', - 'github_private_org_repo_name': 'myrepo', - }), - 'http://github.com/myorg/myrepo/issues#issue/%s') - - def test_check_repository_public(self): - """Testing GitHub check_repository with public repository""" - self._test_check_repository(plan='public', - github_public_repo_name='myrepo') - - def test_check_repository_private(self): - """Testing GitHub check_repository with private repository""" - self._test_check_repository(plan='private', - github_private_repo_name='myrepo') - - def test_check_repository_public_org(self): - """Testing GitHub check_repository with public org repository""" - self._test_check_repository(plan='public-org', - github_public_org_name='myorg', - github_public_org_repo_name='myrepo', - expected_user='myorg') - - def test_check_repository_private_org(self): - """Testing GitHub check_repository with private org repository""" - self._test_check_repository(plan='private-org', - github_private_org_name='myorg', - github_private_org_repo_name='myrepo', - expected_user='myorg') - - def test_check_repository_public_not_found(self): - """Testing GitHub check_repository with not found error and public - repository""" - self._test_check_repository_error( - plan='public', - github_public_repo_name='myrepo', - http_status=404, - payload=b'{"message": "Not Found"}', - expected_error='A repository with this name was not found, ' - 'or your user may not own it.') - - def test_check_repository_private_not_found(self): - """Testing GitHub check_repository with not found error and private - repository""" - self._test_check_repository_error( - plan='private', - github_private_repo_name='myrepo', - http_status=404, - payload=b'{"message": "Not Found"}', - expected_error='A repository with this name was not found, ' - 'or your user may not own it.') - - def test_check_repository_public_org_not_found(self): - """Testing GitHub check_repository with not found error and - public organization repository""" - self._test_check_repository_error( - plan='public-org', - github_public_org_name='myorg', - github_public_org_repo_name='myrepo', - http_status=404, - payload=b'{"message": "Not Found"}', - expected_error='A repository with this organization or name ' - 'was not found.') - - def test_check_repository_private_org_not_found(self): - """Testing GitHub check_repository with not found error and - private organization repository""" - self._test_check_repository_error( - plan='private-org', - github_private_org_name='myorg', - github_private_org_repo_name='myrepo', - http_status=404, - payload=b'{"message": "Not Found"}', - expected_error='A repository with this organization or name ' - 'was not found, or your user may not have access ' - 'to it.') - - def test_check_repository_public_plan_private_repo(self): - """Testing GitHub check_repository with public plan and - private repository""" - self._test_check_repository_error( - plan='public', - github_public_repo_name='myrepo', - http_status=200, - payload=b'{"private": true}', - expected_error='This is a private repository, but you have ' - 'selected a public plan.') - - def test_check_repository_private_plan_public_repo(self): - """Testing GitHub check_repository with private plan and - public repository""" - self._test_check_repository_error( - plan='private', - github_private_repo_name='myrepo', - http_status=200, - payload=b'{"private": false}', - expected_error='This is a public repository, but you have ' - 'selected a private plan.') - - def test_check_repository_public_org_plan_private_repo(self): - """Testing GitHub check_repository with public organization plan and - private repository""" - self._test_check_repository_error( - plan='public-org', - github_public_org_name='myorg', - github_public_org_repo_name='myrepo', - http_status=200, - payload=b'{"private": true}', - expected_error='This is a private repository, but you have ' - 'selected a public plan.') - - def test_check_repository_private_org_plan_public_repo(self): - """Testing GitHub check_repository with private organization plan and - public repository""" - self._test_check_repository_error( - plan='private-org', - github_private_org_name='myorg', - github_private_org_repo_name='myrepo', - http_status=200, - payload=b'{"private": false}', - expected_error='This is a public repository, but you have ' - 'selected a private plan.') - - def test_authorization(self): - """Testing that GitHub account authorization sends expected data""" - http_post_data = {} - - def _http_post(self, *args, **kwargs): - http_post_data['args'] = args - http_post_data['kwargs'] = kwargs - - return json.dumps({ - 'id': 1, - 'url': 'https://api.github.com/authorizations/1', - 'scopes': ['user', 'repo'], - 'token': 'abc123', - 'note': '', - 'note_url': '', - 'updated_at': '2012-05-04T03:30:00Z', - 'created_at': '2012-05-04T03:30:00Z', - }), {} - - account = HostingServiceAccount(service_name=self.service_name, - username='myuser') - service = account.service - - self.spy_on(service.client.http_post, call_fake=_http_post) - - self.assertFalse(account.is_authorized) - - service.authorize('myuser', 'mypass', None) - self.assertTrue(account.is_authorized) - - self.assertEqual(http_post_data['kwargs']['url'], - 'https://api.github.com/authorizations') - self.assertEqual(http_post_data['kwargs']['username'], 'myuser') - self.assertEqual(http_post_data['kwargs']['password'], 'mypass') - - def test_authorization_with_client_info(self): - """Testing that GitHub account authorization with registered client - info - """ - http_post_data = {} - client_id = '' - client_secret = '' - - def _http_post(self, *args, **kwargs): - http_post_data['args'] = args - http_post_data['kwargs'] = kwargs - - return json.dumps({ - 'id': 1, - 'url': 'https://api.github.com/authorizations/1', - 'scopes': ['user', 'repo'], - 'token': 'abc123', - 'note': '', - 'note_url': '', - 'updated_at': '2012-05-04T03:30:00Z', - 'created_at': '2012-05-04T03:30:00Z', - }), {} - - account = HostingServiceAccount(service_name=self.service_name, - username='myuser') - service = account.service - - self.spy_on(service.client.http_post, call_fake=_http_post) - - self.assertFalse(account.is_authorized) - - with self.settings(GITHUB_CLIENT_ID=client_id, - GITHUB_CLIENT_SECRET=client_secret): - service.authorize('myuser', 'mypass', None) - - self.assertTrue(account.is_authorized) - - body = json.loads(http_post_data['kwargs']['body']) - self.assertEqual(body['client_id'], client_id) - self.assertEqual(body['client_secret'], client_secret) - - def test_get_branches(self): - """Testing GitHub get_branches implementation""" - branches_api_response = json.dumps([ - { - 'ref': 'refs/heads/master', - 'object': { - 'sha': '859d4e148ce3ce60bbda6622cdbe5c2c2f8d9817', - } - }, - { - 'ref': 'refs/heads/release-1.7.x', - 'object': { - 'sha': '92463764015ef463b4b6d1a1825fee7aeec8cb15', - } - }, - { - 'ref': 'refs/heads/some-component/fix', - 'object': { - 'sha': '764015ef492c8cb1546363b45fee7ab6d1a182ee', - } - }, - { - 'ref': 'refs/tags/release-1.7.11', - 'object': { - 'sha': 'f5a35f1d8a8dcefb336a8e3211334f1f50ea7792', - } - }, - ]) - - def _http_get(self, *args, **kwargs): - return branches_api_response, None - - account = self._get_hosting_account() - account.data['authorization'] = {'token': 'abc123'} - - repository = Repository(hosting_account=account) - repository.extra_data = { - 'repository_plan': 'public', - 'github_public_repo_name': 'myrepo', - } - - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - - branches = service.get_branches(repository) - - self.assertTrue(service.client.http_get.called) - - self.assertEqual(len(branches), 3) - self.assertEqual( - branches, - [ - Branch(id='master', - commit='859d4e148ce3ce60bbda6622cdbe5c2c2f8d9817', - default=True), - Branch(id='release-1.7.x', - commit='92463764015ef463b4b6d1a1825fee7aeec8cb15', - default=False), - Branch(id='some-component/fix', - commit='764015ef492c8cb1546363b45fee7ab6d1a182ee', - default=False), - ]) - - def test_get_commits(self): - """Testing GitHub get_commits implementation""" - commits_api_response = json.dumps([ - { - 'commit': { - 'author': {'name': 'Christian Hammond'}, - 'committer': {'date': '2013-06-25T23:31:22Z'}, - 'message': 'Fixed the bug number for the ' - 'blacktriangledown bug.', - }, - 'sha': '859d4e148ce3ce60bbda6622cdbe5c2c2f8d9817', - 'parents': [ - {'sha': '92463764015ef463b4b6d1a1825fee7aeec8cb15'} - ], - }, - { - 'commit': { - 'author': {'name': 'Christian Hammond'}, - 'committer': {'date': '2013-06-25T23:30:59Z'}, - 'message': "Merge branch 'release-1.7.x'", - }, - 'sha': '92463764015ef463b4b6d1a1825fee7aeec8cb15', - 'parents': [ - {'sha': 'f5a35f1d8a8dcefb336a8e3211334f1f50ea7792'}, - {'sha': '6c5f3465da5ed03dca8128bb3dd03121bd2cddb2'}, - ], - }, - { - 'commit': { - 'author': {'name': 'David Trowbridge'}, - 'committer': {'date': '2013-06-25T22:41:09Z'}, - 'message': 'Add DIFF_PARSE_ERROR to the ' - 'ValidateDiffResource.create error list.', - }, - 'sha': 'f5a35f1d8a8dcefb336a8e3211334f1f50ea7792', - 'parents': [], - } - ]) - - def _http_get(self, *args, **kwargs): - return commits_api_response, None - - account = self._get_hosting_account() - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - - account.data['authorization'] = {'token': 'abc123'} - - repository = Repository(hosting_account=account) - repository.extra_data = { - 'repository_plan': 'public', - 'github_public_repo_name': 'myrepo', - } - - commits = service.get_commits( - repository, start='859d4e148ce3ce60bbda6622cdbe5c2c2f8d9817') - - self.assertTrue(service.client.http_get.called) - - self.assertEqual(len(commits), 3) - self.assertEqual(commits[0].parent, commits[1].id) - self.assertEqual(commits[1].parent, commits[2].id) - self.assertEqual(commits[0].date, '2013-06-25T23:31:22Z') - self.assertEqual(commits[1].id, - '92463764015ef463b4b6d1a1825fee7aeec8cb15') - self.assertEqual(commits[2].author_name, 'David Trowbridge') - self.assertEqual(commits[2].parent, '') - - def test_get_change(self): - """Testing GitHub get_change implementation""" - commit_sha = '1c44b461cebe5874a857c51a4a13a849a4d1e52d' - parent_sha = '44568f7d33647d286691517e6325fea5c7a21d5e' - tree_sha = '56e25e58380daf9b4dfe35677ae6043fe1743922' - - commits_api_response = json.dumps([ - { - 'commit': { - 'author': {'name': 'David Trowbridge'}, - 'committer': {'date': '2013-06-25T23:31:22Z'}, - 'message': 'Move .clearfix to defs.less', - }, - 'sha': commit_sha, - 'parents': [{'sha': parent_sha}], - }, - ]) - - compare_api_response = json.dumps({ - 'base_commit': { - 'commit': { - 'tree': {'sha': tree_sha}, - }, - }, - 'files': [ - { - 'sha': '4344b3ad41b171ea606e88e9665c34cca602affb', - 'filename': 'reviewboard/static/rb/css/defs.less', - 'status': 'modified', - 'patch': dedent("""\ - @@ -182,4 +182,23 @@ - } - - - +/* Add a rule for clearing floats, */ - +.clearfix { - + display: inline-block; - + - + &:after { - + clear: both; - + content: \".\"; - + display: block; - + height: 0; - + visibility: hidden; - + } - +} - + - +/* Hides from IE-mac \\*/ - +* html .clearfix {height: 1%;} - +.clearfix {display: block;} - +/* End hide from IE-mac */ - + - + - // vim: set et ts=2 sw=2:"""), - }, - { - 'sha': '8e3129277b018b169cb8d13771433fbcd165a17c', - 'filename': 'reviewboard/static/rb/css/reviews.less', - 'status': 'modified', - 'patch': dedent("""\ - @@ -1311,24 +1311,6 @@ - .border-radius(8px); - } - - -/* Add a rule for clearing floats, */ - -.clearfix { - - display: inline-block; - - - - &:after { - - clear: both; - - content: \".\"; - - display: block; - - height: 0; - - visibility: hidden; - - } - -} - - - -/* Hides from IE-mac \\*/ - -* html .clearfix {height: 1%;} - -.clearfix {display: block;} - -/* End hide from IE-mac */ - - - - /**************************************************** - * Issue Summary"""), - }, - ] - }) - - trees_api_response = json.dumps({ - 'tree': [ - { - 'path': 'reviewboard/static/rb/css/defs.less', - 'sha': '830a40c3197223c6a0abb3355ea48891a1857bfd', - }, - { - 'path': 'reviewboard/static/rb/css/reviews.less', - 'sha': '535cd2c4211038d1bb8ab6beaed504e0db9d7e62', - }, - ], - }) - - # This has to be a list to avoid python's hinky treatment of scope of - # variables assigned within a closure. - step = [1] - - def _http_get(service, url, *args, **kwargs): - parsed = urlparse(url) - if parsed.path == '/repos/myuser/myrepo/commits': - self.assertEqual(step[0], 1) - step[0] += 1 - - query = parsed.query.split('&') - self.assertIn(('sha=%s' % commit_sha), query) - - return commits_api_response, None - elif parsed.path.startswith('/repos/myuser/myrepo/compare/'): - self.assertEqual(step[0], 2) - step[0] += 1 - - revs = parsed.path.split('/')[-1].split('...') - self.assertEqual(revs[0], parent_sha) - self.assertEqual(revs[1], commit_sha) - - return compare_api_response, None - elif parsed.path.startswith('/repos/myuser/myrepo/git/trees/'): - self.assertEqual(step[0], 3) - step[0] += 1 - - self.assertEqual(parsed.path.split('/')[-1], tree_sha) - - return trees_api_response, None - else: - print(parsed) - self.fail('Got an unexpected GET request') - - account = self._get_hosting_account() - account.data['authorization'] = {'token': 'abc123'} - - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - - repository = Repository(hosting_account=account) - repository.extra_data = { - 'repository_plan': 'public', - 'github_public_repo_name': 'myrepo', - } - - change = service.get_change(repository, commit_sha) - - self.assertTrue(service.client.http_get.called) - - self.assertEqual(change.message, 'Move .clearfix to defs.less') - self.assertEqual(md5(change.diff.encode('utf-8')).hexdigest(), - '0dd1bde0a60c0a7bb92c27b50f51fcb6') - - def test_get_change_exception(self): - """Testing GitHub get_change exception types""" - def _http_get(service, url, *args, **kwargs): - raise Exception('Not Found') - - account = self._get_hosting_account() - account.data['authorization'] = {'token': 'abc123'} - - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - - repository = Repository(hosting_account=account) - repository.extra_data = { - 'repository_plan': 'public', - 'github_public_repo_name': 'myrepo', - } - - service = account.service - commit_sha = '1c44b461cebe5874a857c51a4a13a849a4d1e52d' - self.assertRaisesMessage( - SCMError, 'Not Found', - lambda: service.get_change(repository, commit_sha)) - - def test_get_remote_repositories_with_owner(self, **kwargs): - """Testing GitHub.get_remote_repositories with requesting - authenticated user's repositories - """ - repos1 = [ - { - 'id': 1, - 'owner': { - 'login': 'myuser', - }, - 'name': 'myrepo', - 'clone_url': 'myrepo_path', - 'mirror_url': 'myrepo_mirror', - 'private': 'false' - } - ] - - repos2 = [ - { - 'id': 2, - 'owner': { - 'login': 'myuser', - }, - 'name': 'myrepo2', - 'clone_url': 'myrepo_path2', - 'mirror_url': 'myrepo_mirror2', - 'private': 'true' - } - ] - - def _http_get(service, url, *args, **kwargs): - base_url = 'https://api.github.com/user/repos?access_token=123' - self.assertIn(url, [base_url, '%s&page=2' % base_url]) - - if url == base_url: - return json.dumps(repos1), { - 'Link': '<%s&page=2>; rel="next"' % base_url, - } - else: - return json.dumps(repos2), { - 'Link': '<%s&page=1>; rel="prev"' % base_url, - } - - account = self._get_hosting_account() - account.data['authorization'] = { - 'token': '123', - } - - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - - paginator = service.get_remote_repositories('myuser') - - # Check the first result. - self.assertEqual(len(paginator.page_data), 1) - self.assertFalse(paginator.has_prev) - self.assertTrue(paginator.has_next) - repo = paginator.page_data[0] - - self.assertIsInstance(repo, RemoteRepository) - self.assertEqual(repo.id, 'myuser/myrepo') - self.assertEqual(repo.owner, 'myuser') - self.assertEqual(repo.name, 'myrepo') - self.assertEqual(repo.scm_type, 'Git') - self.assertEqual(repo.path, 'myrepo_path') - self.assertEqual(repo.mirror_path, 'myrepo_mirror') - - # Check the second result. - paginator.next() - self.assertEqual(len(paginator.page_data), 1) - self.assertTrue(paginator.has_prev) - self.assertFalse(paginator.has_next) - repo = paginator.page_data[0] - - self.assertIsInstance(repo, RemoteRepository) - self.assertEqual(repo.id, 'myuser/myrepo2') - self.assertEqual(repo.owner, 'myuser') - self.assertEqual(repo.name, 'myrepo2') - self.assertEqual(repo.scm_type, 'Git') - self.assertEqual(repo.path, 'myrepo_path2') - self.assertEqual(repo.mirror_path, 'myrepo_mirror2') - - def test_get_remote_repositories_with_other_user(self, **kwargs): - """Testing GitHub.get_remote_repositories with requesting - user's repositories - """ - repos1 = [ - { - 'id': 1, - 'owner': { - 'login': 'other', - }, - 'name': 'myrepo', - 'clone_url': 'myrepo_path', - 'mirror_url': 'myrepo_mirror', - 'private': 'false' - } - ] - repos2 = [] - - def _http_get(service, url, *args, **kwargs): - base_url = ('https://api.github.com/users/other/repos' - '?access_token=123') - - self.assertIn(url, [base_url, '%s&page=2' % base_url]) - - if url == base_url: - next_url = '<%s&page=2>; rel="next"' % base_url - return json.dumps(repos1), {'Link': next_url} - else: - return json.dumps(repos2), {} - - account = self._get_hosting_account() - account.data['authorization'] = { - 'token': '123', - } - - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - - paginator = service.get_remote_repositories('other') - - self.assertEqual(len(paginator.page_data), 1) - public_repo = paginator.page_data[0] - self.assertIsInstance(public_repo, RemoteRepository) - self.assertEqual(public_repo.id, 'other/myrepo') - self.assertEqual(public_repo.owner, 'other') - self.assertEqual(public_repo.name, 'myrepo') - self.assertEqual(public_repo.scm_type, 'Git') - self.assertEqual(public_repo.path, 'myrepo_path') - self.assertEqual(public_repo.mirror_path, 'myrepo_mirror') - - def test_get_remote_repositories_with_org(self, **kwargs): - """Testing GitHub.get_remote_repositories with requesting - organization's repositories - """ - repos = [ - { - 'id': 1, - 'owner': { - 'login': 'myorg', - }, - 'name': 'myrepo', - 'clone_url': 'myrepo_path', - 'mirror_url': 'myrepo_mirror', - 'private': 'false' - }, - { - 'id': 2, - 'owner': { - 'login': 'myuser', - }, - 'name': 'myrepo2', - 'clone_url': 'myrepo_path2', - 'mirror_url': 'myrepo_mirror2', - 'private': 'true' - } - ] - - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://api.github.com/orgs/myorg/repos?access_token=123') - return json.dumps(repos), {} - - account = self._get_hosting_account() - account.data['authorization'] = { - 'token': '123', - } - - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - - paginator = service.get_remote_repositories('myorg', 'organization') - self.assertEqual(len(paginator.page_data), 2) - public_repo, private_repo = paginator.page_data - - self.assertIsInstance(public_repo, RemoteRepository) - self.assertEqual(public_repo.id, 'myorg/myrepo') - self.assertEqual(public_repo.owner, 'myorg') - self.assertEqual(public_repo.name, 'myrepo') - self.assertEqual(public_repo.scm_type, 'Git') - self.assertEqual(public_repo.path, 'myrepo_path') - self.assertEqual(public_repo.mirror_path, 'myrepo_mirror') - - self.assertIsInstance(private_repo, RemoteRepository) - self.assertEqual(private_repo.id, 'myuser/myrepo2') - self.assertEqual(private_repo.owner, 'myuser') - self.assertEqual(private_repo.name, 'myrepo2') - self.assertEqual(private_repo.scm_type, 'Git') - self.assertEqual(private_repo.path, 'myrepo_path2') - self.assertEqual(private_repo.mirror_path, 'myrepo_mirror2') - - def test_get_remote_repositories_with_defaults(self, **kwargs): - """Testing GitHub.get_remote_repositories with default values""" - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://api.github.com/user/repos?access_token=123') - - return b'{}', {} - - account = self._get_hosting_account() - account.data['authorization'] = { - 'token': '123', - } - - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - - service.get_remote_repositories() - - def test_get_remote_repositories_with_filter(self, **kwargs): - """Testing GitHub.get_remote_repositories with ?filter-type=""" - def _http_get(service, url, *args, **kwargs): - self.assertEqual(url, - 'https://api.github.com/user/repos' - '?access_token=123&type=private') - - return json.dumps([]), {} - - account = self._get_hosting_account() - account.data['authorization'] = { - 'token': '123', - } - - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - - service.get_remote_repositories('myuser', filter_type='private') - - def test_get_remote_repository(self, **kwargs): - """Testing GitHub.get_remote_repository""" - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://api.github.com/repos/myuser/myrepo' - '?access_token=123') - - repo_data = { - 'id': 1, - 'owner': { - 'login': 'myuser', - }, - 'name': 'myrepo', - 'clone_url': 'myrepo_path', - 'mirror_url': 'myrepo_mirror', - 'private': 'false' - } - - return json.dumps(repo_data), {} - - account = self._get_hosting_account() - account.data['authorization'] = { - 'token': '123', - } - - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - - remote_repository = service.get_remote_repository('myuser/myrepo') - - self.assertIsInstance(remote_repository, RemoteRepository) - self.assertEqual(remote_repository.id, 'myuser/myrepo') - self.assertEqual(remote_repository.owner, 'myuser') - self.assertEqual(remote_repository.name, 'myrepo') - self.assertEqual(remote_repository.scm_type, 'Git') - self.assertEqual(remote_repository.path, 'myrepo_path') - self.assertEqual(remote_repository.mirror_path, 'myrepo_mirror') - - def test_get_remote_repository_invalid(self, **kwargs): - """Testing GitHub.get_remote_repository with invalid repository ID""" - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://api.github.com/repos/myuser/invalid' - '?access_token=123') - - payload = { - 'message': 'Not Found', - } - - raise HTTPError(url, 404, '', {}, StringIO(json.dumps(payload))) - - account = self._get_hosting_account() - account.data['authorization'] = { - 'token': '123', - } - - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - - self.assertRaises(ObjectDoesNotExist, - service.get_remote_repository, 'myuser/invalid') - - @add_fixtures(['test_users', 'test_scmtools']) - def test_close_submitted_hook(self): - """Testing GitHub close_submitted hook""" - self._test_post_commit_hook() - - @add_fixtures(['test_site', 'test_users', 'test_scmtools']) - def test_close_submitted_hook_with_local_site(self): - """Testing GitHub close_submitted hook with a Local Site""" - self._test_post_commit_hook( - LocalSite.objects.get(name=self.local_site_name)) - - @add_fixtures(['test_site', 'test_users', 'test_scmtools']) - def test_close_submitted_hook_with_unpublished_review_request(self): - """Testing GitHub close_submitted hook with an un-published review - request - """ - self._test_post_commit_hook(publish=False) - - @add_fixtures(['test_users', 'test_scmtools']) - def test_close_submitted_hook_ping(self): - """Testing GitHub close_submitted hook ping""" - account = self._get_hosting_account() - account.save() - - repository = self.create_repository(hosting_account=account) - - review_request = self.create_review_request(repository=repository, - publish=True) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'github-hooks-close-submitted', - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'github', - }) - - response = self._post_commit_hook_payload( - url, review_request, repository.get_or_create_hooks_uuid(), - event='ping') - self.assertEqual(response.status_code, 200) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - self.assertEqual(review_request.changedescs.count(), 0) - - @add_fixtures(['test_users', 'test_scmtools']) - def test_close_submitted_hook_with_invalid_repo(self): - """Testing GitHub close_submitted hook with invalid repository""" - repository = self.create_repository() - - review_request = self.create_review_request(repository=repository, - publish=True) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'github-hooks-close-submitted', - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'github', - }) - - response = self._post_commit_hook_payload( - url, review_request, repository.get_or_create_hooks_uuid()) - self.assertEqual(response.status_code, 404) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - self.assertEqual(review_request.changedescs.count(), 0) - - @add_fixtures(['test_users', 'test_scmtools']) - def test_close_submitted_hook_with_invalid_site(self): - """Testing GitHub close_submitted hook with invalid Local Site""" - repository = self.create_repository() - - review_request = self.create_review_request(repository=repository, - publish=True) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'github-hooks-close-submitted', - local_site_name='badsite', - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'github', - }) - - response = self._post_commit_hook_payload( - url, review_request, repository.get_or_create_hooks_uuid()) - self.assertEqual(response.status_code, 404) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - self.assertEqual(review_request.changedescs.count(), 0) - - @add_fixtures(['test_users', 'test_scmtools']) - def test_close_submitted_hook_with_invalid_service_id(self): - """Testing GitHub close_submitted hook with invalid hosting service ID - """ - # We'll test against Bitbucket for this test. - account = self._get_hosting_account() - account.service_name = 'bitbucket' - account.save() - repository = self.create_repository(hosting_account=account) - - review_request = self.create_review_request(repository=repository, - publish=True) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'github-hooks-close-submitted', - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'github', - }) - - response = self._post_commit_hook_payload( - url, review_request, repository.get_or_create_hooks_uuid()) - self.assertEqual(response.status_code, 404) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - self.assertEqual(review_request.changedescs.count(), 0) - - @add_fixtures(['test_users', 'test_scmtools']) - def test_close_submitted_hook_with_invalid_event(self): - """Testing GitHub close_submitted hook with non-push event""" - account = self._get_hosting_account() - account.save() - - repository = self.create_repository(hosting_account=account) - review_request = self.create_review_request(repository=repository, - publish=True) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'github-hooks-close-submitted', - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'github', - }) - - response = self._post_commit_hook_payload( - url, review_request, repository.get_or_create_hooks_uuid(), - event='foo') - self.assertEqual(response.status_code, 400) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - self.assertEqual(review_request.changedescs.count(), 0) - - @add_fixtures(['test_users', 'test_scmtools']) - def test_close_submitted_hook_with_invalid_signature(self): - """Testing GitHub close_submitted hook with invalid signature""" - account = self._get_hosting_account() - account.save() - - repository = self.create_repository(hosting_account=account) - review_request = self.create_review_request(repository=repository, - publish=True) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'github-hooks-close-submitted', - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'github', - }) - - response = self._post_commit_hook_payload( - url, review_request, 'bad-secret') - self.assertEqual(response.status_code, 400) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - self.assertEqual(review_request.changedescs.count(), 0) - - def _test_post_commit_hook(self, local_site=None, publish=True): - account = self._get_hosting_account(local_site=local_site) - account.save() - - repository = self.create_repository(hosting_account=account, - local_site=local_site) - - review_request = self.create_review_request(repository=repository, - local_site=local_site, - publish=publish) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'github-hooks-close-submitted', - local_site=local_site, - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'github', - }) - - response = self._post_commit_hook_payload( - url, review_request, repository.get_or_create_hooks_uuid()) - self.assertEqual(response.status_code, 200) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.SUBMITTED) - self.assertEqual(review_request.changedescs.count(), 1) - - changedesc = review_request.changedescs.get() - self.assertEqual(changedesc.text, 'Pushed to master (1c44b46)') - - def _post_commit_hook_payload(self, url, review_request, secret, - event='push'): - payload = json.dumps({ - # NOTE: This payload only contains the content we make - # use of in the hook. - 'ref': 'refs/heads/master', - 'commits': [ - { - 'id': '1c44b461cebe5874a857c51a4a13a849a4d1e52d', - 'message': 'This is my fancy commit\n' - '\n' - 'Reviewed at http://example.com%s' - % review_request.get_absolute_url(), - }, - ] - }) - - m = hmac.new(bytes(secret), payload, hashlib.sha1) - - return self.client.post( - url, - payload, - content_type='application/json', - HTTP_X_GITHUB_EVENT=event, - HTTP_X_HUB_SIGNATURE='sha1=%s' % m.hexdigest()) - - def _test_check_repository(self, expected_user='myuser', **kwargs): - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://api.github.com/repos/%s/myrepo?access_token=123' - % expected_user) - return b'{}', {} - - account = self._get_hosting_account() - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - account.data['authorization'] = { - 'token': '123', - } - - service.check_repository(**kwargs) - self.assertTrue(service.client.http_get.called) - - def _test_check_repository_error(self, http_status, payload, - expected_error, **kwargs): - def _http_get(service, url, *args, **kwargs): - if http_status == 200: - return payload, {} - else: - raise HTTPError(url, http_status, '', {}, StringIO(payload)) - - account = self._get_hosting_account() - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - account.data['authorization'] = { - 'token': '123', - } - - try: - service.check_repository(**kwargs) - saw_exception = False - except Exception as e: - self.assertEqual(six.text_type(e), expected_error) - saw_exception = True - - self.assertTrue(saw_exception) - - def _get_repo_api_url(self, plan, fields): - account = self._get_hosting_account() - service = account.service - self.assertNotEqual(service, None) - - repository = Repository(hosting_account=account) - repository.extra_data['repository_plan'] = plan - - form = self._get_form(plan, fields) - form.save(repository) - - return service._get_repo_api_url(repository) - - -class GitLabTests(ServiceTests): - """Unit tests for the GitLab hosting service.""" - service_name = 'gitlab' - - def test_service_support(self): - """Testing the GitLab service support capabilities""" - self.assertTrue(self.service_class.supports_bug_trackers) - self.assertTrue(self.service_class.supports_repositories) - self.assertFalse(self.service_class.supports_ssh_key_association) - - def test_personal_field_values(self): - """Testing the GitLab personal plan repository field values""" - fields = self._get_repository_fields('Git', plan='personal', fields={ - 'hosting_url': 'https://example.com', - 'gitlab_personal_repo_name': 'myrepo', - }) - self.assertEqual(fields['path'], - 'git@example.com:myuser/myrepo.git') - self.assertEqual(fields['mirror_path'], - 'https://example.com/myuser/myrepo.git') - - def test_personal_bug_tracker_field(self): - """Testing the GitLab personal repository bug tracker field value""" - self.assertTrue( - self.service_class.get_bug_tracker_requires_username('personal')) - self.assertEqual( - self.service_class.get_bug_tracker_field('personal', { - 'hosting_url': 'https://example.com', - 'gitlab_personal_repo_name': 'myrepo', - 'hosting_account_username': 'myuser', - }), - 'https://example.com/myuser/myrepo/issues/%s') - - def test_group_field_values(self): - """Testing the GitLab group plan repository field values""" - fields = self._get_repository_fields('Git', plan='group', fields={ - 'hosting_url': 'https://example.com', - 'gitlab_group_repo_name': 'myrepo', - 'gitlab_group_name': 'mygroup', - }) - self.assertEqual(fields['path'], - 'git@example.com:mygroup/myrepo.git') - self.assertEqual(fields['mirror_path'], - 'https://example.com/mygroup/myrepo.git') - - def test_group_bug_tracker_field(self): - """Testing the GitLab group repository bug tracker field value""" - self.assertFalse( - self.service_class.get_bug_tracker_requires_username('group')) - self.assertEqual( - self.service_class.get_bug_tracker_field('group', { - 'hosting_url': 'https://example.com', - 'gitlab_group_name': 'mygroup', - 'gitlab_group_repo_name': 'myrepo', - }), - 'https://example.com/mygroup/myrepo/issues/%s') - - def test_check_repository_personal(self): - """Testing GitLab check_repository with personal repository""" - self._test_check_repository(plan='personal', - gitlab_personal_repo_name='myrepo') - - def test_check_repository_group(self): - """Testing GitLab check_repository with group repository""" - self._test_check_repository(plan='group', - gitlab_group_name='mygroup', - gitlab_group_repo_name='myrepo', - expected_user='mygroup') - - def test_check_repository_personal_not_found(self): - """Testing GitLab check_repository with not found error and personal - repository""" - self._test_check_repository_error( - plan='personal', - gitlab_personal_repo_name='myrepo', - expected_error='A repository with this name was not found, ' - 'or your user may not own it.') - - def test_check_repository_group_repo_not_found(self): - """Testing GitLab check_repository with not found error and - group repository""" - self._test_check_repository_error( - plan='group', - gitlab_group_name='mygroup', - gitlab_group_repo_name='badrepo', - expected_error='A repository with this name was not found on ' - 'this group, or your user may not have access ' - 'to it.') - - def test_check_repository_group_not_found(self): - """Testing GitLab check_repository with an incorrect group name""" - self._test_check_repository_error( - plan='group', - gitlab_group_name='badgroup', - gitlab_group_repo_name='myrepo', - expected_error='A group with this name was not found, or your ' - 'user may not have access to it.') - - def test_authorization(self): - """Testing that GitLab account authorization sends expected data""" - http_post_data = {} - - def _http_post(self, *args, **kwargs): - http_post_data['args'] = args - http_post_data['kwargs'] = kwargs - - return json.dumps({ - 'id': 1, - 'private_token': 'abc123', - }), {} - - account = HostingServiceAccount(service_name=self.service_name, - username='myuser') - service = account.service - - self.spy_on(service.client.http_post, call_fake=_http_post) - - self.assertFalse(account.is_authorized) - - service.authorize('myuser', 'mypass', - hosting_url='https://example.com') - self.assertTrue(account.is_authorized) - - self.assertEqual(http_post_data['kwargs']['url'], - 'https://example.com/api/v3/session') - self.assertIn('fields', http_post_data['kwargs']) - - fields = http_post_data['kwargs']['fields'] - self.assertEqual(fields['login'], 'myuser') - self.assertEqual(fields['password'], 'mypass') - - def test_get_branches(self): - """Testing GitLab get_branches implementation""" - branches_api_response = json.dumps([ - { - 'name': 'master', - 'commit': { - 'id': 'ed899a2f4b50b4370feeea94676502b42383c746' - } - }, - { - 'name': 'branch1', - 'commit': { - 'id': '6104942438c14ec7bd21c6cd5bd995272b3faff6' - } - }, - { - 'name': 'branch2', - 'commit': { - 'id': '21b3bcabcff2ab3dc3c9caa172f783aad602c0b0' - } - }, - { - 'branch-name': 'branch3', - 'commit': { - 'id': 'd5a3ff139356ce33e37e73add446f16869741b50' - } - } - ]) - - def _http_get(self, *args, **kwargs): - return branches_api_response, None - - account = self._get_hosting_account(use_url=True) - account.data['private_token'] = encrypt_password('abc123') - - service = account.service - - repository = Repository(hosting_account=account) - repository.extra_data = {'gitlab_project_id': 123456} - - self.spy_on(service.client.http_get, call_fake=_http_get) - - branches = service.get_branches(repository) - - self.assertTrue(service.client.http_get.called) - self.assertEqual(len(branches), 3) - self.assertEqual( - branches, - [ - Branch(id='master', - commit='ed899a2f4b50b4370feeea94676502b42383c746', - default=True), - Branch(id='branch1', - commit='6104942438c14ec7bd21c6cd5bd995272b3faff6', - default=False), - Branch(id='branch2', - commit='21b3bcabcff2ab3dc3c9caa172f783aad602c0b0', - default=False) - ]) - - def test_get_commits(self): - """Testing GitLab get_commits implementation""" - commits_api_response = json.dumps([ - { - 'id': 'ed899a2f4b50b4370feeea94676502b42383c746', - 'author_name': 'Chester Li', - 'created_at': '2015-03-10T11:50:22+03:00', - 'message': 'Replace sanitize with escape once' - }, - { - 'id': '6104942438c14ec7bd21c6cd5bd995272b3faff6', - 'author_name': 'Chester Li', - 'created_at': '2015-03-10T09:06:12+03:00', - 'message': 'Sanitize for network graph' - }, - { - 'id': '21b3bcabcff2ab3dc3c9caa172f783aad602c0b0', - 'author_name': 'East Coast', - 'created_at': '2015-03-04T15:31:18.000-04:00', - 'message': 'Add a timer to test file' - } - ]) - - def _http_get(self, *args, **kargs): - return commits_api_response, None - - account = self._get_hosting_account(use_url=True) - account.data['private_token'] = encrypt_password('abc123') - - service = account.service - - repository = Repository(hosting_account=account) - repository.extra_data = {'gitlab_project_id': 123456} - - self.spy_on(service.client.http_get, call_fake=_http_get) - - commits = service.get_commits( - repository, start='ed899a2f4b50b4370feeea94676502b42383c746') - - self.assertTrue(service.client.http_get.called) - self.assertEqual(len(commits), 3) - self.assertEqual(commits[0].id, - 'ed899a2f4b50b4370feeea94676502b42383c746') - self.assertNotEqual(commits[0].author_name, 'East Coast') - self.assertEqual(commits[1].date, '2015-03-10T09:06:12+03:00') - self.assertNotEqual(commits[1].message, - 'Replace sanitize with escape once') - self.assertEqual(commits[2].author_name, 'East Coast') - - def test_get_change(self): - """Testing GitLab get_change implementation""" - commit_id = 'ed899a2f4b50b4370feeea94676502b42383c746' - - commit_api_response = json.dumps( - { - 'author_name': 'Chester Li', - 'id': commit_id, - 'created_at': '2015-03-10T11:50:22+03:00', - 'message': 'Replace sanitize with escape once', - 'parent_ids': ['ae1d9fb46aa2b07ee9836d49862ec4e2c46fbbba'] - } - ) - - path_api_response = json.dumps( - { - 'path_with_namespace': 'username/project_name' - } - ) - - diff = dedent(b'''\ - --- - f1 | 1 + - f2 | 1 + - 2 files changed, 2 insertions(+), 0 deletions(-) - - diff --git a/f1 b/f1 - index 11ac561..3ea0691 100644 - --- a/f1 - +++ b/f1 - @@ -1 +1,2 @@ - this is f1 - +add one line to f1 - diff --git a/f2 b/f2 - index c837441..9302ecd 100644 - --- a/f2 - +++ b/f2 - @@ -1 +1,2 @@ - this is f2 - +add one line to f2 - ''') - - def _http_get(service, url, *args, **kwargs): - parsed = urlparse(url) - if parsed.path.startswith( - '/api/v3/projects/123456/repository/commits'): - # If the url is commit_api_url. - return commit_api_response, None - elif parsed.path == '/api/v3/projects/123456': - # If the url is path_api_url. - return path_api_response, None - elif parsed.path.endswith('.diff'): - # If the url is diff_url. - return diff, None - else: - print(parsed) - self.fail('Got an unexpected GET request') - - account = self._get_hosting_account(use_url=True) - account.data['private_token'] = encrypt_password('abc123') - - service = account.service - - repository = Repository(hosting_account=account) - repository.extra_data = {'gitlab_project_id': 123456} - - self.spy_on(service.client.http_get, call_fake=_http_get) - - commit = service.get_change(repository, commit_id) - - self.assertTrue(service.client.http_get.called) - self.assertEqual(commit.date, '2015-03-10T11:50:22+03:00') - self.assertEqual(commit.diff, diff) - self.assertNotEqual(commit.parent, '') - - def _test_check_repository(self, expected_user='myuser', **kwargs): - def _http_get(service, url, *args, **kwargs): - if url == 'https://example.com/api/v3/projects?per_page=100': - payload = [ - { - 'id': 1, - 'path': 'myrepo', - 'namespace': { - 'path': expected_user, - }, - } - ] - elif url == 'https://example.com/api/v3/groups?per_page=100': - payload = [ - { - 'id': 1, - 'name': 'mygroup', - } - ] - elif url == 'https://example.com/api/v3/projects/1': - # We don't care about the contents. Just that it exists. - payload = {} - elif url == 'https://example.com/api/v3/groups/1': - payload = { - 'projects': [ - { - 'id': 1, - 'name': 'myrepo', - }, - ], - } - else: - self.fail('Unexpected URL %s' % url) - - return json.dumps(payload), {} - - account = self._get_hosting_account(use_url=True) - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - account.data['private_token'] = encrypt_password('abc123') - - service.check_repository(**kwargs) - self.assertTrue(service.client.http_get.called) - - def _test_check_repository_error(self, expected_error, **kwargs): - def _http_get(service, url, *args, **kwargs): - if url == 'https://example.com/api/v3/groups?per_page=100': - payload = [ - { - 'id': 1, - 'name': 'mygroup', - } - ] - elif url == 'https://example.com/api/v3/groups/1': - payload = { - 'projects': [ - { - 'id': 1, - 'name': 'myrepo', - }, - ], - } - else: - payload = [] - - return json.dumps(payload), {} - - account = self._get_hosting_account(use_url=True) - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - account.data['private_token'] = encrypt_password('abc123') - - try: - service.check_repository(**kwargs) - saw_exception = False - except Exception as e: - self.assertEqual(six.text_type(e), expected_error) - saw_exception = True - - self.assertTrue(saw_exception) - - def _get_repo_api_url(self, plan, fields): - account = self._get_hosting_account(use_url=True) - service = account.service - self.assertNotEqual(service, None) - - repository = Repository(hosting_account=account) - repository.extra_data['repository_plan'] = plan - - form = self._get_form(plan, fields) - form.save(repository) - - return service._get_repo_api_url(repository) - - -class GitoriousTests(ServiceTests): - """Unit tests for the Gitorious hosting service.""" - service_name = 'gitorious' - - def test_service_support(self): - """Testing the Gitorious service support capabilities""" - self.assertFalse(self.service_class.supports_bug_trackers) - self.assertTrue(self.service_class.supports_repositories) - - def test_repo_field_values(self): - """Testing the Gitorious repository field values""" - fields = self._get_repository_fields('Git', fields={ - 'gitorious_project_name': 'myproj', - 'gitorious_repo_name': 'myrepo', - }) - self.assertEqual(fields['path'], - 'git://gitorious.org/myproj/myrepo.git') - self.assertEqual(fields['mirror_path'], - 'https://gitorious.org/myproj/myrepo.git') - self.assertEqual(fields['raw_file_url'], - 'https://gitorious.org/myproj/myrepo/blobs/raw/' - '') - - -class GoogleCodeTests(ServiceTests): - """Unit tests for the Google Code hosting service.""" - service_name = 'googlecode' - - def test_service_support(self): - """Testing the Google Code service support capabilities""" - self.assertTrue(self.service_class.supports_bug_trackers) - self.assertTrue(self.service_class.supports_repositories) - - def test_repo_field_values_mercurial(self): - """Testing the Google Code repository field values for Mercurial""" - fields = self._get_repository_fields('Mercurial', fields={ - 'googlecode_project_name': 'myproj', - }) - self.assertEqual(fields['path'], 'http://myproj.googlecode.com/hg') - self.assertEqual(fields['mirror_path'], - 'https://myproj.googlecode.com/hg') - - def test_repo_field_values_svn(self): - """Testing the Google Code repository field values for Subversion""" - fields = self._get_repository_fields('Subversion', fields={ - 'googlecode_project_name': 'myproj', - }) - self.assertEqual(fields['path'], 'http://myproj.googlecode.com/svn') - self.assertEqual(fields['mirror_path'], - 'https://myproj.googlecode.com/svn') - - @add_fixtures(['test_users', 'test_scmtools']) - def test_close_submitted_hook(self): - """Testing Google Code close_submitted hook""" - self._test_post_commit_hook() - - @add_fixtures(['test_site', 'test_users', 'test_scmtools']) - def test_close_submitted_hook_with_local_site(self): - """Testing Google Code close_submitted hook with a Local Site""" - self._test_post_commit_hook( - LocalSite.objects.get(name=self.local_site_name)) - - @add_fixtures(['test_users', 'test_scmtools']) - def test_close_submitted_hook_with_invalid_repo(self): - """Testing Google Code close_submitted hook with invalid repository""" - repository = self.create_repository() - - review_request = self.create_review_request(repository=repository, - publish=True) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'googlecode-hooks-close-submitted', - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'googlecode', - 'hooks_uuid': repository.get_or_create_hooks_uuid(), - }) - - response = self._post_commit_hook_payload(url, review_request) - self.assertEqual(response.status_code, 404) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - self.assertEqual(review_request.changedescs.count(), 0) - - @add_fixtures(['test_users', 'test_scmtools']) - def test_close_submitted_hook_with_invalid_site(self): - """Testing Google Code close_submitted hook with invalid Local Site""" - repository = self.create_repository() - - review_request = self.create_review_request(repository=repository, - publish=True) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'googlecode-hooks-close-submitted', - local_site_name='badsite', - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'googlecode', - 'hooks_uuid': repository.get_or_create_hooks_uuid(), - }) - - response = self._post_commit_hook_payload(url, review_request) - self.assertEqual(response.status_code, 404) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - self.assertEqual(review_request.changedescs.count(), 0) - - @add_fixtures(['test_users', 'test_scmtools']) - def test_close_submitted_hook_with_invalid_service_id(self): - """Testing Google Code close_submitted hook with invalid hosting service ID - """ - # We'll test against Bitbucket for this test. - account = self._get_hosting_account() - account.service_name = 'bitbucket' - account.save() - repository = self.create_repository(hosting_account=account) - - review_request = self.create_review_request(repository=repository, - publish=True) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'googlecode-hooks-close-submitted', - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'googlecode', - 'hooks_uuid': repository.get_or_create_hooks_uuid(), - }) - - response = self._post_commit_hook_payload(url, review_request) - self.assertEqual(response.status_code, 404) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - self.assertEqual(review_request.changedescs.count(), 0) - - @add_fixtures(['test_users', 'test_scmtools']) - def test_close_submitted_hook_with_invalid_hooks_uuid(self): - """Testing Google Code close_submitted hook with invalid hooks UUID""" - account = self._get_hosting_account() - account.save() - repository = self.create_repository(hosting_account=account) - - review_request = self.create_review_request(repository=repository, - publish=True) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'googlecode-hooks-close-submitted', - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'googlecode', - 'hooks_uuid': 'abc123', - }) - - response = self._post_commit_hook_payload(url, review_request) - self.assertEqual(response.status_code, 404) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - self.assertEqual(review_request.changedescs.count(), 0) - - def _test_post_commit_hook(self, local_site=None): - account = self._get_hosting_account(local_site=local_site) - account.save() - - repository = self.create_repository(hosting_account=account, - local_site=local_site) - - review_request = self.create_review_request(repository=repository, - local_site=local_site, - publish=True) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.PENDING_REVIEW) - - url = local_site_reverse( - 'googlecode-hooks-close-submitted', - local_site=local_site, - kwargs={ - 'repository_id': repository.pk, - 'hosting_service_id': 'googlecode', - 'hooks_uuid': repository.get_or_create_hooks_uuid(), - }) - - response = self._post_commit_hook_payload(url, review_request) - self.assertEqual(response.status_code, 200) - - review_request = ReviewRequest.objects.get(pk=review_request.pk) - self.assertTrue(review_request.public) - self.assertEqual(review_request.status, review_request.SUBMITTED) - self.assertEqual(review_request.changedescs.count(), 1) - - changedesc = review_request.changedescs.get() - self.assertEqual(changedesc.text, 'Pushed to master (1c44b46)') - - def _post_commit_hook_payload(self, url, review_request): - return self.client.post( - url, - json.dumps({ - # NOTE: This payload only contains the content we make - # use of in the hook. - 'repository_path': 'master', - 'revisions': [ - { - 'revision': '1c44b461cebe5874a857c51a4a13a849a4d1e52d', - 'message': 'This is my fancy commit\n' - '\n' - 'Reviewed at http://example.com%s' - % review_request.get_absolute_url(), - }, - ] - }), - content_type='application/json') - - -class KilnTests(ServiceTests): - """Unit tests for the Kiln hosting service.""" - service_name = 'kiln' - fixtures = ['test_scmtools'] - - def test_service_support(self): - """Testing Kiln service support capabilities""" - self.assertTrue(self.service_class.supports_repositories) - self.assertTrue(self.service_class.needs_authorization) - self.assertFalse(self.service_class.supports_bug_trackers) - self.assertFalse(self.service_class.supports_post_commit) - self.assertFalse(self.service_class.supports_two_factor_auth) - - def test_repo_field_values_git(self): - """Testing Kiln repository field values for Git""" - fields = self._get_repository_fields('Git', fields={ - 'kiln_account_domain': 'mydomain', - 'kiln_project_name': 'myproject', - 'kiln_group_name': 'mygroup', - 'kiln_repo_name': 'myrepo', - }) - self.assertEqual( - fields['path'], - 'https://mydomain.kilnhg.com/Code/myproject/mygroup/myrepo.git') - self.assertEqual( - fields['mirror_path'], - 'ssh://mydomain@mydomain.kilnhg.com/myproject/mygroup/myrepo') - - def test_repo_field_values_mercurial(self): - """Testing Kiln repository field values for Mercurial""" - fields = self._get_repository_fields('Mercurial', fields={ - 'kiln_account_domain': 'mydomain', - 'kiln_project_name': 'myproject', - 'kiln_group_name': 'mygroup', - 'kiln_repo_name': 'myrepo', - }) - self.assertEqual( - fields['path'], - 'https://mydomain.kilnhg.com/Code/myproject/mygroup/myrepo') - self.assertEqual( - fields['mirror_path'], - 'ssh://mydomain@mydomain.kilnhg.com/myproject/mygroup/myrepo') - - def test_authorize(self): - """Testing Kiln authorization token storage""" - def _http_post(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://mydomain.kilnhg.com/Api/1.0/Auth/Login') - return '"my-token"', {} - - account = self._get_hosting_account() - service = account.service - - self.assertFalse(service.is_authorized()) - - self.spy_on(service.client.http_post, call_fake=_http_post) - - service.authorize('myuser', 'abc123', - kiln_account_domain='mydomain') - - self.assertIn('auth_token', account.data) - self.assertEqual(account.data['auth_token'], 'my-token') - self.assertTrue(service.is_authorized()) - - def test_check_repository(self): - """Testing Kiln check_repository""" - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://mydomain.kilnhg.com/Api/1.0/Project?token=my-token') - - data = json.dumps([{ - 'sSlug': 'myproject', - 'repoGroups': [{ - 'sSlug': 'mygroup', - 'repos': [{ - 'sSlug': 'myrepo', - }] - }] - }]) - - return data, {} - - account = self._get_hosting_account() - service = account.service - account.data.update({ - 'auth_token': 'my-token', - 'kiln_account_domain': 'mydomain', - }) - - self.spy_on(service.client.http_get, call_fake=_http_get) - - service.check_repository(kiln_account_domain='mydomain', - kiln_project_name='myproject', - kiln_group_name='mygroup', - kiln_repo_name='myrepo', - tool_name='Mercurial') - self.assertTrue(service.client.http_get.called) - - def test_check_repository_with_incorrect_repo_info(self): - """Testing Kiln check_repository with incorrect repo info""" - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://mydomain.kilnhg.com/Api/1.0/Project?token=my-token') - - data = json.dumps([{ - 'sSlug': 'otherproject', - 'repoGroups': [{ - 'sSlug': 'othergroup', - 'repos': [{ - 'sSlug': 'otherrepo', - }] - }] - }]) - - return data, {} - - account = self._get_hosting_account() - service = account.service - account.data.update({ - 'auth_token': 'my-token', - 'kiln_account_domain': 'mydomain', - }) - - self.spy_on(service.client.http_get, call_fake=_http_get) - - self.assertRaises( - RepositoryError, - lambda: service.check_repository( - kiln_account_domain='mydomain', - kiln_project_name='myproject', - kiln_group_name='mygroup', - kiln_repo_name='myrepo', - tool_name='Mercurial')) - self.assertTrue(service.client.http_get.called) - - def test_get_file(self): - """Testing Kiln get_file""" - def _http_get(service, url, *args, **kwargs): - if url == ('https://mydomain.kilnhg.com/Api/1.0/Project' - '?token=my-token'): - data = json.dumps([{ - 'sSlug': 'myproject', - 'repoGroups': [{ - 'sSlug': 'mygroup', - 'repos': [{ - 'sSlug': 'myrepo', - 'ixRepo': 123, - }] - }] - }]) - else: - self.assertEqual( - url, - 'https://mydomain.kilnhg.com/Api/1.0/Repo/123/Raw/File/' - '%s?rev=%s&token=my-token' - % (encoded_path, revision)) - - data = 'My data' - - return data, {} - - path = '/path' - encoded_path = '2F70617468' - revision = 123 - - account = self._get_hosting_account() - service = account.service - repository = Repository(hosting_account=account, - tool=Tool.objects.get(name='Mercurial')) - repository.extra_data = { - 'kiln_account_domain': 'mydomain', - 'kiln_project_name': 'myproject', - 'kiln_group_name': 'mygroup', - 'kiln_repo_name': 'myrepo', - } - repository.save() - - account.data.update({ - 'auth_token': 'my-token', - 'kiln_account_domain': 'mydomain', - }) - - self.spy_on(service.client.http_get, call_fake=_http_get) - - result = service.get_file(repository, path, revision) - self.assertTrue(service.client.http_get.called) - self.assertEqual(result, 'My data') - - def test_get_file_exists(self): - """Testing Kiln get_file_exists""" - def _http_get(service, url, *args, **kwargs): - if url == ('https://mydomain.kilnhg.com/Api/1.0/Project' - '?token=my-token'): - data = json.dumps([{ - 'sSlug': 'myproject', - 'repoGroups': [{ - 'sSlug': 'mygroup', - 'repos': [{ - 'sSlug': 'myrepo', - 'ixRepo': 123, - }] - }] - }]) - else: - self.assertEqual( - url, - 'https://mydomain.kilnhg.com/Api/1.0/Repo/123/Raw/File/' - '%s?rev=%s&token=my-token' - % (encoded_path, revision)) - - data = 'My data' - - return data, {} - - path = '/path' - encoded_path = '2F70617468' - revision = 123 - - account = self._get_hosting_account() - service = account.service - repository = Repository(hosting_account=account, - tool=Tool.objects.get(name='Mercurial')) - repository.extra_data = { - 'kiln_account_domain': 'mydomain', - 'kiln_project_name': 'myproject', - 'kiln_group_name': 'mygroup', - 'kiln_repo_name': 'myrepo', - } - repository.save() - - account.data.update({ - 'auth_token': 'my-token', - 'kiln_account_domain': 'mydomain', - }) - - self.spy_on(service.client.http_get, call_fake=_http_get) - - result = service.get_file_exists(repository, path, revision) - self.assertTrue(service.client.http_get.called) - self.assertTrue(result) - - -class RedmineTests(ServiceTests): - """Unit tests for the Redmine hosting service.""" - service_name = 'redmine' - fixtures = ['test_scmtools'] - - def test_service_support(self): - """Testing the Redmine service support capabilities""" - self.assertTrue(self.service_class.supports_bug_trackers) - self.assertFalse(self.service_class.supports_repositories) - - def test_bug_tracker_field(self): - """Testing the Redmine bug tracker field value""" - self.assertFalse( - self.service_class.get_bug_tracker_requires_username()) - self.assertEqual( - self.service_class.get_bug_tracker_field(None, { - 'redmine_url': 'http://redmine.example.com', - }), - 'http://redmine.example.com/issues/%s') - - -class SourceForgeTests(ServiceTests): - """Unit tests for the SourceForge hosting service.""" - service_name = 'sourceforge' - - def test_service_support(self): - """Testing the SourceForge service support capabilities""" - self.assertTrue(self.service_class.supports_bug_trackers) - self.assertTrue(self.service_class.supports_repositories) - - def test_repo_field_values_bazaar(self): - """Testing the SourceForge repository field values for Bazaar""" - fields = self._get_repository_fields('Bazaar', fields={ - 'sourceforge_project_name': 'myproj', - }) - self.assertEqual(fields['path'], - 'bzr://myproj.bzr.sourceforge.net/bzrroot/myproj') - self.assertEqual(fields['mirror_path'], - 'bzr+ssh://myproj.bzr.sourceforge.net/bzrroot/' - 'myproj') - - def test_repo_field_values_cvs(self): - """Testing the SourceForge repository field values for CVS""" - fields = self._get_repository_fields('CVS', fields={ - 'sourceforge_project_name': 'myproj', - }) - self.assertEqual(fields['path'], - ':pserver:anonymous@myproj.cvs.sourceforge.net:' - '/cvsroot/myproj') - self.assertEqual(fields['mirror_path'], - 'myproj.cvs.sourceforge.net/cvsroot/myproj') - - def test_repo_field_values_mercurial(self): - """Testing the SourceForge repository field values for Mercurial""" - fields = self._get_repository_fields('Mercurial', fields={ - 'sourceforge_project_name': 'myproj', - }) - self.assertEqual(fields['path'], - 'http://myproj.hg.sourceforge.net:8000/hgroot/myproj') - self.assertEqual(fields['mirror_path'], - 'ssh://myproj.hg.sourceforge.net/hgroot/myproj') - - def test_repo_field_values_svn(self): - """Testing the SourceForge repository field values for Subversion""" - fields = self._get_repository_fields('Subversion', fields={ - 'sourceforge_project_name': 'myproj', - }) - self.assertEqual(fields['path'], - 'http://myproj.svn.sourceforge.net/svnroot/myproj') - self.assertEqual(fields['mirror_path'], - 'https://myproj.svn.sourceforge.net/svnroot/myproj') - - -class TracTests(ServiceTests): - """Unit tests for the Trac hosting service.""" - service_name = 'trac' - fixtures = ['test_scmtools'] - - def test_service_support(self): - """Testing the Trac service support capabilities""" - self.assertTrue(self.service_class.supports_bug_trackers) - self.assertFalse(self.service_class.supports_repositories) - - def test_bug_tracker_field(self): - """Testing the Trac bug tracker field value""" - self.assertFalse( - self.service_class.get_bug_tracker_requires_username()) - self.assertEqual( - self.service_class.get_bug_tracker_field(None, { - 'trac_url': 'http://trac.example.com', - }), - 'http://trac.example.com/ticket/%s') - - -class UnfuddleTests(ServiceTests): - """Unit tests for the Unfuddle hosting service.""" - service_name = 'unfuddle' - fixtures = ['test_scmtools'] - - def test_service_support(self): - """Testing Unfuddle service support capabilities""" - self.assertTrue(self.service_class.supports_bug_trackers) - self.assertTrue(self.service_class.supports_repositories) - - def test_repo_field_values_git(self): - """Testing Unfuddle repository field values for Git""" - fields = self._get_repository_fields('Git', fields={ - 'unfuddle_account_domain': 'mydomain', - 'unfuddle_project_id': 1, - 'unfuddle_repo_name': 'myrepo', - }) - self.assertEqual( - fields['path'], - 'git@mydomain.unfuddle.com:mydomain/myrepo.git') - self.assertEqual( - fields['mirror_path'], - 'https://mydomain.unfuddle.com/git/mydomain_myrepo/') - - def test_repo_field_values_subversion(self): - """Testing Unfuddle repository field values for Subversion""" - fields = self._get_repository_fields('Subversion', fields={ - 'unfuddle_account_domain': 'mydomain', - 'unfuddle_project_id': 1, - 'unfuddle_repo_name': 'myrepo', - }) - self.assertEqual( - fields['path'], - 'https://mydomain.unfuddle.com/svn/mydomain_myrepo') - self.assertEqual( - fields['mirror_path'], - 'http://mydomain.unfuddle.com/svn/mydomain_myrepo') - - def test_authorize(self): - """Testing Unfuddle authorization password storage""" - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://mydomain.unfuddle.com/api/v1/account/') - return '{}', {} - - account = self._get_hosting_account() - service = account.service - - self.assertFalse(service.is_authorized()) - - self.spy_on(service.client.http_get, call_fake=_http_get) - - service.authorize('myuser', 'abc123', - unfuddle_account_domain='mydomain') - - self.assertIn('password', account.data) - self.assertNotEqual(account.data['password'], 'abc123') - self.assertTrue(service.is_authorized()) - - def test_check_repository(self): - """Testing Unfuddle check_repository""" - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://mydomain.unfuddle.com/api/v1/repositories/') - - return '[{"id": 2, "abbreviation": "myrepo", "system": "git"}]', {} - - account = self._get_hosting_account() - service = account.service - account.data['password'] = encrypt_password('password') - - self.spy_on(service.client.http_get, call_fake=_http_get) - - service.check_repository(unfuddle_account_domain='mydomain', - unfuddle_repo_name='myrepo', - tool_name='Git') - self.assertTrue(service.client.http_get.called) - - def test_check_repository_with_wrong_repo_type(self): - """Testing Unfuddle check_repository with wrong repo type""" - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://mydomain.unfuddle.com/api/v1/repositories/') - - return '[{"id": 1, "abbreviation": "myrepo", "system": "svn"}]', {} - - account = self._get_hosting_account() - service = account.service - account.data['password'] = encrypt_password('password') - - self.spy_on(service.client.http_get, call_fake=_http_get) - - self.assertRaises( - RepositoryError, - lambda: service.check_repository( - unfuddle_account_domain='mydomain', - unfuddle_repo_name='myrepo', - tool_name='Git')) - self.assertTrue(service.client.http_get.called) - - def test_get_file_with_svn_and_base_commit_id(self): - """Testing Unfuddle get_file with Subversion and base commit ID""" - self._test_get_file( - tool_name='Subversion', - revision='123', - base_commit_id='456', - expected_revision='456') - - def test_get_file_with_svn_and_revision(self): - """Testing Unfuddle get_file with Subversion and revision""" - self._test_get_file( - tool_name='Subversion', - revision='123', - base_commit_id=None, - expected_revision='123') - - def test_get_file_with_git_and_base_commit_id(self): - """Testing Unfuddle get_file with Git and base commit ID""" - self._test_get_file( - tool_name='Git', - revision='123', - base_commit_id='456', - expected_revision='456') - - def test_get_file_with_git_and_revision(self): - """Testing Unfuddle get_file with Git and revision""" - self._test_get_file( - tool_name='Git', - revision='123', - base_commit_id=None, - expected_revision=None, - expected_error=True) - - def test_get_file_exists_with_svn_and_base_commit_id(self): - """Testing Unfuddle get_file_exists with Subversion and base commit ID - """ - self._test_get_file_exists( - tool_name='Subversion', - revision='123', - base_commit_id='456', - expected_revision='456', - expected_found=True) - - def test_get_file_exists_with_svn_and_revision(self): - """Testing Unfuddle get_file_exists with Subversion and revision""" - self._test_get_file_exists( - tool_name='Subversion', - revision='123', - base_commit_id=None, - expected_revision='123', - expected_found=True) - - def test_get_file_exists_with_git_and_base_commit_id(self): - """Testing Unfuddle get_file_exists with Git and base commit ID""" - self._test_get_file_exists( - tool_name='Git', - revision='123', - base_commit_id='456', - expected_revision='456', - expected_found=True) - - def test_get_file_exists_with_git_and_revision(self): - """Testing Unfuddle get_file_exists with Git and revision""" - self._test_get_file_exists( - tool_name='Git', - revision='123', - base_commit_id=None, - expected_revision=None, - expected_found=False, - expected_error=True) - - def _test_get_file(self, tool_name, revision, base_commit_id, - expected_revision, expected_error=False): - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://mydomain.unfuddle.com/api/v1/repositories/2/' - 'download/?path=%s&commit=%s' - % (path, expected_revision)) - return 'My data', {} - - path = '/path' - account = self._get_hosting_account() - service = account.service - repository = Repository(hosting_account=account, - tool=Tool.objects.get(name=tool_name)) - repository.extra_data = { - 'unfuddle_account_domain': 'mydomain', - 'unfuddle_project_id': 1, - 'unfuddle_repo_id': 2, - 'unfuddle_repo_name': 'myrepo', - } - - account.data['password'] = encrypt_password('password') - - self.spy_on(service.client.http_get, call_fake=_http_get) - - if expected_error: - self.assertRaises( - FileNotFoundError, - lambda: service.get_file(repository, path, revision, - base_commit_id)) - self.assertFalse(service.client.http_get.called) - else: - result = service.get_file(repository, path, revision, - base_commit_id) - self.assertTrue(service.client.http_get.called) - self.assertEqual(result, 'My data') - - def _test_get_file_exists(self, tool_name, revision, base_commit_id, - expected_revision, expected_found=True, - expected_error=False): - def _http_get(service, url, *args, **kwargs): - self.assertEqual( - url, - 'https://mydomain.unfuddle.com/api/v1/repositories/2/' - 'history/?path=/path&commit=%s&count=0' - % expected_revision) - - if expected_found: - return '{}', {} - else: - raise HTTPError() - - account = self._get_hosting_account() - service = account.service - repository = Repository(hosting_account=account, - tool=Tool.objects.get(name=tool_name)) - repository.extra_data = { - 'unfuddle_account_domain': 'mydomain', - 'unfuddle_project_id': 1, - 'unfuddle_repo_id': 2, - 'unfuddle_repo_name': 'myrepo', - } - - account.data['password'] = encrypt_password('password') - - self.spy_on(service.client.http_get, call_fake=_http_get) - - result = service.get_file_exists(repository, '/path', revision, - base_commit_id) - - if expected_error: - self.assertFalse(service.client.http_get.called) - self.assertFalse(result) - else: - self.assertTrue(service.client.http_get.called) - self.assertEqual(result, expected_found) - - -class VersionOneTests(ServiceTests): - """Unit tests for the VersionOne hosting service.""" - service_name = 'versionone' - fixtures = ['test_scmtools'] - - def test_service_support(self): - """Testing the VersionOne service support capabilities""" - self.assertTrue(self.service_class.supports_bug_trackers) - self.assertFalse(self.service_class.supports_repositories) - - def test_bug_tracker_field(self): - """Testing the VersionOne bug tracker field value""" - self.assertFalse( - self.service_class.get_bug_tracker_requires_username()) - self.assertEqual( - self.service_class.get_bug_tracker_field(None, { - 'versionone_url': 'http://versionone.example.com', - }), - 'http://versionone.example.com/assetdetail.v1?Number=%s') - - -class ReviewBoardGatewayTests(ServiceTests): - """Unit tests for the ReviewBoardGateway hosting service.""" - - service_name = 'rbgateway' - - def test_service_support(self): - """Testing the ReviewBoardGateway service support capabilities""" - self.assertTrue(self.service_class.supports_repositories) - self.assertTrue(self.service_class.supports_post_commit) - self.assertFalse(self.service_class.supports_bug_trackers) - self.assertFalse(self.service_class.supports_ssh_key_association) - - def test_repo_field_values(self): - """Testing the ReviewBoardGateway repository field values""" - fields = self._get_repository_fields('Git', fields={ - 'hosting_url': 'https://example.com', - 'rbgateway_repo_name': 'myrepo', - }) - self.assertEqual(fields['path'], - 'https://example.com/repos/myrepo/path') - - def test_authorization(self): - """Testing that ReviewBoardGateway authorization sends expected data""" - http_post_data = {} - - def _http_post(self, *args, **kwargs): - http_post_data['args'] = args - http_post_data['kwargs'] = kwargs - - return json.dumps({ - 'private_token': 'abc123' - }), {} - - self.service_class._http_post = _http_post - - account = HostingServiceAccount(service_name=self.service_name, - username='myuser') - service = account.service - - self.spy_on(service.client.http_post, call_fake=_http_post) - - self.assertFalse(account.is_authorized) - - service.authorize('myuser', 'mypass', - hosting_url='https://example.com') - self.assertTrue(account.is_authorized) - - self.assertEqual(http_post_data['kwargs']['url'], - 'https://example.com/session') - self.assertIn('username', http_post_data['kwargs']) - self.assertIn('password', http_post_data['kwargs']) - - def test_check_repository(self): - """Testing that ReviewBoardGateway can find the repository""" - def _http_get(service, url, *args, **kwargs): - self.assertEqual(url, 'https://example.com/repos/myrepo/path') - return '{}', {} - - account = self._get_hosting_account(use_url=True) - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - account.data['private_token'] = encrypt_password('abc123') - - service.check_repository(path='https://example.com/repos/myrepo/path') - self.assertTrue(service.client.http_get.called) - - def test_get_branches(self): - """Testing ReviewBoardGateway get_branches implementation""" - branches_api_response = json.dumps([ - { - 'name': 'master', - 'id': 'c272edcac05b00e15440d6274723b639e3acbd7c', - }, - { - 'name': 'im_a_branch', - 'id': '83904e6acb60e7ec0dcaae6c09a579ab44d0cf38', - } - ]) - - def _http_get(self, *args, **kwargs): - return branches_api_response, None - - account = self._get_hosting_account() - account.data['private_token'] = encrypt_password('abc123') - - repository = Repository(hosting_account=account) - repository.extra_data = { - 'rbgateway_repo_name': 'myrepo', - } - - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - - branches = service.get_branches(repository) - - self.assertTrue(service.client.http_get.called) - - self.assertEqual(len(branches), 2) - - self.assertEqual( - branches, - [ - Branch(id='master', - commit='c272edcac05b00e15440d6274723b639e3acbd7c', - default=True), - Branch(id='im_a_branch', - commit='83904e6acb60e7ec0dcaae6c09a579ab44d0cf38', - default=False) - ]) - - def test_get_commits(self): - """Testing ReviewBoardGateway get_commits implementation""" - commits_api_response = json.dumps([ - { - 'author': 'myname', - 'id': 'bfdde95432b3af879af969bd2377dc3e55ee46e6', - 'date': '2015-02-13 22:34:01 -0700 -0700', - 'message': 'mymessage', - 'parent_id': '304c53c163aedfd0c0e0933776f09c24b87f5944', - }, - { - 'author': 'myname', - 'id': '304c53c163aedfd0c0e0933776f09c24b87f5944', - 'date': '2015-02-13 22:32:42 -0700 -0700', - 'message': 'mymessage', - 'parent_id': 'fa1330719893098ae397356e8125c2aa45b49221', - }, - { - 'author': 'anothername', - 'id': 'fa1330719893098ae397356e8125c2aa45b49221', - 'date': '2015-02-12 16:01:48 -0700 -0700', - 'message': 'mymessage', - 'parent_id': '', - } - ]) - - def _http_get(self, *args, **kwargs): - return commits_api_response, None - - account = self._get_hosting_account() - account.data['private_token'] = encrypt_password('abc123') - - repository = Repository(hosting_account=account) - repository.extra_data = { - 'rbgateway_repo_name': 'myrepo', - } - - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - - commits = service.get_commits( - repository, branch='bfdde95432b3af879af969bd2377dc3e55ee46e6') - - self.assertTrue(service.client.http_get.called) - - self.assertEqual(len(commits), 3) - self.assertEqual(commits[0].parent, commits[1].id) - self.assertEqual(commits[1].parent, commits[2].id) - self.assertEqual(commits[0].date, '2015-02-13 22:34:01 -0700 -0700') - self.assertEqual(commits[1].id, - '304c53c163aedfd0c0e0933776f09c24b87f5944') - self.assertEqual(commits[2].author_name, 'anothername') - self.assertEqual(commits[2].parent, '') - - def test_get_change(self): - """Testing ReviewBoardGateway get_change implementation""" - diff = (b'diff --git a/test b/test\n' - 'index 9daeafb9864cf43055ae93beb0afd6c7d144bfa4..' - 'dced80a85fe1e8f13dd5ea19923e5d2e8680020d 100644\n' - '--- a/test\n+++ b/test\n@@ -1 +1,3 @@\n test\n+\n+test\n') - - diff_encoding = md5(diff.encode('utf-8')).hexdigest() - - change_api_response = json.dumps( - { - 'author': 'myname', - 'id': 'bfdde95432b3af879af969bd2377dc3e55ee46e6', - 'date': '2015-02-13 22:34:01 -0700 -0700', - 'message': 'mymessage', - 'parent_id': '304c53c163aedfd0c0e0933776f09c24b87f5944', - 'diff': diff - } - ) - - def _http_get(self, *args, **kwargs): - return change_api_response, None - - account = self._get_hosting_account() - account.data['private_token'] = encrypt_password('abc123') - - repository = Repository(hosting_account=account) - repository.extra_data = { - 'rbgateway_repo_name': 'myrepo', - } - - service = account.service - self.spy_on(service.client.http_get, call_fake=_http_get) - - change = service.get_change( - repository, 'bfdde95432b3af879af969bd2377dc3e55ee46e6') - - self.assertTrue(service.client.http_get.called) - - self.assertEqual(change.message, 'mymessage') - self.assertEqual(md5(change.diff.encode('utf-8')).hexdigest(), - diff_encoding) - - -def hosting_service_url_test_view(request, repo_id): - """View to test URL pattern addition when registering a hosting service""" - return HttpResponse(str(repo_id)) - - -class HostingServiceRegistrationTests(TestCase): - """Unit tests for Hosting Service registration.""" - class DummyService(HostingService): - name = 'DummyService' - - class DummyServiceWithURLs(HostingService): - name = 'DummyServiceWithURLs' - - repository_url_patterns = patterns( - '', - - url(r'^hooks/pre-commit/$', hosting_service_url_test_view, - name='dummy-service-post-commit-hook'), - ) - - def tearDown(self): - super(HostingServiceRegistrationTests, self).tearDown() - - # Unregister the service, going back to a default state. It's okay - # if it fails. - # - # This will match whichever service we added for testing. - try: - unregister_hosting_service('dummy-service') - except KeyError: - pass - - def test_register_without_urls(self): - """Testing HostingService registration""" - register_hosting_service('dummy-service', self.DummyService) - - with self.assertRaises(KeyError): - register_hosting_service('dummy-service', self.DummyService) - - def test_unregister(self): - """Testing HostingService unregistration""" - register_hosting_service('dummy-service', self.DummyService) - unregister_hosting_service('dummy-service') - - def test_registration_with_urls(self): - """Testing HostingService registration with URLs""" - register_hosting_service('dummy-service', self.DummyServiceWithURLs) - - self.assertEqual( - local_site_reverse( - 'dummy-service-post-commit-hook', - kwargs={ - 'repository_id': 1, - 'hosting_service_id': 'dummy-service', - }), - '/repos/1/dummy-service/hooks/pre-commit/') - - self.assertEqual( - local_site_reverse( - 'dummy-service-post-commit-hook', - local_site_name='test-site', - kwargs={ - 'repository_id': 1, - 'hosting_service_id': 'dummy-service', - }), - '/s/test-site/repos/1/dummy-service/hooks/pre-commit/') - - # Once registered, should not be able to register again - with self.assertRaises(KeyError): - register_hosting_service('dummy-service', - self.DummyServiceWithURLs) - - def test_unregistration_with_urls(self): - """Testing HostingService unregistration with URLs""" - register_hosting_service('dummy-service', self.DummyServiceWithURLs) - unregister_hosting_service('dummy-service') - - with self.assertRaises(NoReverseMatch): - local_site_reverse( - 'dummy-service-post-commit-hook', - kwargs={ - 'repository_id': 1, - 'hosting_service_id': 'dummy-service', - }), - - # Once unregistered, should not be able to unregister again - with self.assertRaises(KeyError): - unregister_hosting_service('dummy-service') diff --git a/reviewboard/hostingsvcs/tests/__init__.py b/reviewboard/hostingsvcs/tests/__init__.py new file mode 100644 index 0000000000000000000000000000000000000000..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 diff --git a/reviewboard/hostingsvcs/tests/test_assembla.py b/reviewboard/hostingsvcs/tests/test_assembla.py new file mode 100644 index 0000000000000000000000000000000000000000..00ec759df1d212a3c6f1567b0edf41414de9604d --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_assembla.py @@ -0,0 +1,132 @@ +from __future__ import unicode_literals + +from reviewboard.hostingsvcs.tests.testcases import ServiceTests +from reviewboard.scmtools.models import Repository, Tool + + +class AssemblaTests(ServiceTests): + """Unit tests for the Assembla hosting service.""" + + service_name = 'assembla' + fixtures = ['test_scmtools'] + + def test_service_support(self): + """Testing Assembla service support capabilities""" + self.assertTrue(self.service_class.needs_authorization) + self.assertTrue(self.service_class.supports_bug_trackers) + self.assertTrue(self.service_class.supports_repositories) + self.assertEqual(self.service_class.supported_scmtools, + ['Perforce', 'Subversion']) + + def test_repo_field_values_perforce(self): + """Testing Assembla repository field values for Perforce""" + fields = self._get_repository_fields('Perforce', fields={ + 'assembla_project_id': 'myproject', + }) + self.assertEqual(fields['path'], 'perforce.assembla.com:1666') + self.assertNotIn('mirror_path', fields) + self.assertIn('encoding', fields) + self.assertEqual(fields['encoding'], 'utf8') + + def test_repo_field_values_subversion(self): + """Testing Assembla repository field values for Subversion""" + fields = self._get_repository_fields('Subversion', fields={ + 'assembla_project_id': 'myproject', + 'assembla_repo_name': 'myrepo', + }) + self.assertEqual(fields['path'], + 'https://subversion.assembla.com/svn/myproject/') + self.assertNotIn('mirror_path', fields) + self.assertNotIn('encoding', fields) + + def test_save_form_perforce(self): + """Testing Assembla configuration form with Perforce""" + account = self._get_hosting_account() + service = account.service + service.authorize('myuser', 'abc123', None) + + repository = Repository(hosting_account=account, + tool=Tool.objects.get(name='Perforce')) + + form = self._get_form(fields={'assembla_project_id': 'myproject'}) + form.save(repository) + + self.assertIn('use_ticket_auth', repository.extra_data) + self.assertTrue(repository.extra_data['use_ticket_auth']) + self.assertIn('p4_host', repository.extra_data) + self.assertEqual(repository.extra_data['p4_host'], 'myproject') + + def test_save_form_subversion(self): + """Testing Assembla configuration form with Subversion""" + account = self._get_hosting_account() + service = account.service + service.authorize('myuser', 'abc123', None) + + repository = Repository(path='https://svn.example.com/', + hosting_account=account, + tool=Tool.objects.get(name='Subversion')) + + form = self._get_form(fields={'assembla_project_id': 'myproject'}) + form.save(repository) + + self.assertNotIn('use_ticket_auth', repository.extra_data) + self.assertNotIn('p4_host', repository.extra_data) + + def test_authorize(self): + """Testing Assembla authorization password storage""" + account = self._get_hosting_account() + service = account.service + + self.assertFalse(service.is_authorized()) + + service.authorize('myuser', 'abc123', None) + + self.assertIn('password', account.data) + self.assertNotEqual(account.data['password'], 'abc123') + self.assertTrue(service.is_authorized()) + + def test_check_repository_perforce(self): + """Testing Assembla check_repository with Perforce""" + account = self._get_hosting_account() + service = account.service + + service.authorize('myuser', 'abc123', None) + + repository = Repository(hosting_account=account, + tool=Tool.objects.get(name='Perforce')) + scmtool = repository.get_scmtool() + self.spy_on(scmtool.check_repository, call_original=False) + + service.check_repository(path='mypath', + username='myusername', + password='mypassword', + scmtool_class=scmtool.__class__, + local_site_name=None, + assembla_project_id='myproject') + + self.assertTrue(scmtool.check_repository.called) + self.assertIn('p4_host', scmtool.check_repository.last_call.kwargs) + self.assertEqual(scmtool.check_repository.last_call.kwargs['p4_host'], + 'myproject') + + def test_check_repository_subversion(self): + """Testing Assembla check_repository with Subversion""" + account = self._get_hosting_account() + service = account.service + + service.authorize('myuser', 'abc123', None) + + repository = Repository(path='https://svn.example.com/', + hosting_account=account, + tool=Tool.objects.get(name='Subversion')) + scmtool = repository.get_scmtool() + self.spy_on(scmtool.check_repository, call_original=False) + + service.check_repository(path='https://svn.example.com/', + username='myusername', + password='mypassword', + scmtool_class=scmtool.__class__, + local_site_name=None) + + self.assertTrue(scmtool.check_repository.called) + self.assertNotIn('p4_host', scmtool.check_repository.last_call.kwargs) diff --git a/reviewboard/hostingsvcs/tests/test_beanstalk.py b/reviewboard/hostingsvcs/tests/test_beanstalk.py new file mode 100644 index 0000000000000000000000000000000000000000..301de297a07a5f0c9bf62440ca1b5134348ba3bc --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_beanstalk.py @@ -0,0 +1,219 @@ +from __future__ import unicode_literals + +from django.utils.six.moves.urllib.error import HTTPError + +from reviewboard.hostingsvcs.tests.testcases import ServiceTests +from reviewboard.scmtools.models import Repository, Tool + + +class BeanstalkTests(ServiceTests): + """Unit tests for the Beanstalk hosting service.""" + + service_name = 'beanstalk' + fixtures = ['test_scmtools'] + + def test_service_support(self): + """Testing Beanstalk service support capabilities""" + self.assertFalse(self.service_class.supports_bug_trackers) + self.assertTrue(self.service_class.supports_repositories) + + def test_repo_field_values_git(self): + """Testing Beanstalk repository field values for Git""" + fields = self._get_repository_fields('Git', fields={ + 'beanstalk_account_domain': 'mydomain', + 'beanstalk_repo_name': 'myrepo', + }) + self.assertEqual( + fields['path'], + 'git@mydomain.beanstalkapp.com:/mydomain/myrepo.git') + self.assertEqual( + fields['mirror_path'], + 'https://mydomain.git.beanstalkapp.com/myrepo.git') + + def test_repo_field_values_subversion(self): + """Testing Beanstalk repository field values for Subversion""" + fields = self._get_repository_fields('Subversion', fields={ + 'beanstalk_account_domain': 'mydomain', + 'beanstalk_repo_name': 'myrepo', + }) + self.assertEqual( + fields['path'], + 'https://mydomain.svn.beanstalkapp.com/myrepo/') + self.assertNotIn('mirror_path', fields) + + def test_authorize(self): + """Testing Beanstalk authorization password storage""" + account = self._get_hosting_account() + service = account.service + + self.assertFalse(service.is_authorized()) + + service.authorize('myuser', 'abc123', None) + + self.assertIn('password', account.data) + self.assertNotEqual(account.data['password'], 'abc123') + self.assertTrue(service.is_authorized()) + + def test_check_repository(self): + """Testing Beanstalk check_repository""" + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://mydomain.beanstalkapp.com/api/repositories/' + 'myrepo.json') + return '{}', {} + + account = self._get_hosting_account() + service = account.service + + service.authorize('myuser', 'abc123', None) + + self.spy_on(service.client.http_get, call_fake=_http_get) + + service.check_repository(beanstalk_account_domain='mydomain', + beanstalk_repo_name='myrepo') + self.assertTrue(service.client.http_get.called) + + def test_get_file_with_svn_and_base_commit_id(self): + """Testing Beanstalk get_file with Subversion and base commit ID""" + self._test_get_file( + tool_name='Subversion', + revision='123', + base_commit_id='456', + expected_revision='123') + + def test_get_file_with_svn_and_revision(self): + """Testing Beanstalk get_file with Subversion and revision""" + self._test_get_file( + tool_name='Subversion', + revision='123', + base_commit_id=None, + expected_revision='123') + + def test_get_file_with_git_and_base_commit_id(self): + """Testing Beanstalk get_file with Git and base commit ID""" + self._test_get_file( + tool_name='Git', + revision='123', + base_commit_id='456', + expected_revision='123') + + def test_get_file_with_git_and_revision(self): + """Testing Beanstalk get_file with Git and revision""" + self._test_get_file( + tool_name='Git', + revision='123', + base_commit_id=None, + expected_revision='123') + + def test_get_file_exists_with_svn_and_base_commit_id(self): + """Testing Beanstalk get_file_exists with Subversion and base commit ID + """ + self._test_get_file_exists( + tool_name='Subversion', + revision='123', + base_commit_id='456', + expected_revision='123', + expected_found=True) + + def test_get_file_exists_with_svn_and_revision(self): + """Testing Beanstalk get_file_exists with Subversion and revision""" + self._test_get_file_exists( + tool_name='Subversion', + revision='123', + base_commit_id=None, + expected_revision='123', + expected_found=True) + + def test_get_file_exists_with_git_and_base_commit_id(self): + """Testing Beanstalk get_file_exists with Git and base commit ID""" + self._test_get_file_exists( + tool_name='Git', + revision='123', + base_commit_id='456', + expected_revision='456', + expected_found=True) + + def test_get_file_exists_with_git_and_revision(self): + """Testing Beanstalk get_file_exists with Git and revision""" + self._test_get_file_exists( + tool_name='Git', + revision='123', + base_commit_id=None, + expected_revision='123', + expected_found=True) + + def _test_get_file(self, tool_name, revision, base_commit_id, + expected_revision): + def _http_get(service, url, *args, **kwargs): + if tool_name == 'Git': + self.assertEqual( + url, + 'https://mydomain.beanstalkapp.com/api/repositories/' + 'myrepo/blob?id=%s&name=path' + % expected_revision) + payload = b'My data' + else: + self.assertEqual( + url, + 'https://mydomain.beanstalkapp.com/api/repositories/' + 'myrepo/node.json?path=/path&revision=%s&contents=1' + % expected_revision) + payload = b'{"contents": "My data"}' + + return payload, {} + + account = self._get_hosting_account() + service = account.service + repository = Repository(hosting_account=account, + tool=Tool.objects.get(name=tool_name)) + repository.extra_data = { + 'beanstalk_account_domain': 'mydomain', + 'beanstalk_repo_name': 'myrepo', + } + + service.authorize('myuser', 'abc123', None) + + self.spy_on(service.client.http_get, call_fake=_http_get) + + result = service.get_file(repository, '/path', revision, + base_commit_id) + self.assertTrue(service.client.http_get.called) + self.assertEqual(result, 'My data') + + def _test_get_file_exists(self, tool_name, revision, base_commit_id, + expected_revision, expected_found): + def _http_get(service, url, *args, **kwargs): + expected_url = ('https://mydomain.beanstalkapp.com/api/' + 'repositories/myrepo/') + + if not base_commit_id and tool_name == 'Git': + expected_url += 'blob?id=%s&name=path' % expected_revision + else: + expected_url += ('node.json?path=/path&revision=%s' + % expected_revision) + + self.assertEqual(url, expected_url) + + if expected_found: + return b'{}', {} + else: + raise HTTPError() + + account = self._get_hosting_account() + service = account.service + repository = Repository(hosting_account=account, + tool=Tool.objects.get(name=tool_name)) + repository.extra_data = { + 'beanstalk_account_domain': 'mydomain', + 'beanstalk_repo_name': 'myrepo', + } + + service.authorize('myuser', 'abc123', None) + + self.spy_on(service.client.http_get, call_fake=_http_get) + + result = service.get_file_exists(repository, '/path', revision, + base_commit_id) + self.assertTrue(service.client.http_get.called) + self.assertEqual(result, expected_found) diff --git a/reviewboard/hostingsvcs/tests/test_bitbucket.py b/reviewboard/hostingsvcs/tests/test_bitbucket.py new file mode 100644 index 0000000000000000000000000000000000000000..12026cd2dae8c72297fa7919c1ff7ae5c846aeb2 --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_bitbucket.py @@ -0,0 +1,509 @@ +from __future__ import unicode_literals + +import json + +from django.utils.six.moves import cStringIO as StringIO +from django.utils.six.moves.urllib.error import HTTPError +from djblets.testing.decorators import add_fixtures + +from reviewboard.hostingsvcs.errors import (AuthorizationError, + RepositoryError) +from reviewboard.hostingsvcs.tests.testcases import ServiceTests +from reviewboard.reviews.models import ReviewRequest +from reviewboard.scmtools.crypto_utils import encrypt_password +from reviewboard.scmtools.errors import FileNotFoundError +from reviewboard.scmtools.models import Repository, Tool +from reviewboard.site.models import LocalSite +from reviewboard.site.urlresolvers import local_site_reverse + + +class BitbucketTests(ServiceTests): + """Unit tests for the Bitbucket hosting service.""" + + service_name = 'bitbucket' + fixtures = ['test_scmtools'] + + def test_service_support(self): + """Testing Bitbucket service support capabilities""" + self.assertTrue(self.service_class.supports_bug_trackers) + self.assertTrue(self.service_class.supports_repositories) + + def test_personal_repo_field_values_git(self): + """Testing Bitbucket personal repository field values for Git""" + fields = self._get_repository_fields( + 'Git', + fields={ + 'bitbucket_repo_name': 'myrepo', + }, + plan='personal') + self.assertEqual(fields['path'], + 'git@bitbucket.org:myuser/myrepo.git') + self.assertEqual(fields['mirror_path'], + 'https://myuser@bitbucket.org/myuser/myrepo.git') + + def test_personal_repo_field_values_mercurial(self): + """Testing Bitbucket personal repository field values for Mercurial""" + fields = self._get_repository_fields( + 'Mercurial', + fields={ + 'bitbucket_repo_name': 'myrepo', + }, + plan='personal') + self.assertEqual(fields['path'], + 'https://myuser@bitbucket.org/myuser/myrepo') + self.assertEqual(fields['mirror_path'], + 'ssh://hg@bitbucket.org/myuser/myrepo') + + def test_personal_bug_tracker_field(self): + """Testing Bitbucket personal bug tracker field values""" + self.assertTrue(self.service_class.get_bug_tracker_requires_username( + plan='personal')) + self.assertEqual( + self.service_class.get_bug_tracker_field( + 'personal', + { + 'bitbucket_repo_name': 'myrepo', + 'hosting_account_username': 'myuser', + }), + 'https://bitbucket.org/myuser/myrepo/issue/%s/') + + def test_personal_check_repository(self): + """Testing Bitbucket personal check_repository""" + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://bitbucket.org/api/1.0/repositories/myuser/myrepo') + return b'{}', {} + + account = self._get_hosting_account() + account.data['password'] = encrypt_password('abc123') + service = account.service + + self.spy_on(service.client.http_get, call_fake=_http_get) + + service.check_repository(bitbucket_repo_name='myrepo', + plan='personal') + self.assertTrue(service.client.http_get.called) + + def test_team_repo_field_values_git(self): + """Testing Bitbucket team repository field values for Git""" + fields = self._get_repository_fields( + 'Git', + fields={ + 'bitbucket_team_name': 'myteam', + 'bitbucket_team_repo_name': 'myrepo', + }, + plan='team') + self.assertEqual(fields['path'], + 'git@bitbucket.org:myteam/myrepo.git') + self.assertEqual(fields['mirror_path'], + 'https://myuser@bitbucket.org/myteam/myrepo.git') + + def test_team_repo_field_values_mercurial(self): + """Testing Bitbucket team repository field values for Mercurial""" + fields = self._get_repository_fields( + 'Mercurial', + fields={ + 'bitbucket_team_name': 'myteam', + 'bitbucket_team_repo_name': 'myrepo', + }, + plan='team') + self.assertEqual(fields['path'], + 'https://myuser@bitbucket.org/myteam/myrepo') + self.assertEqual(fields['mirror_path'], + 'ssh://hg@bitbucket.org/myteam/myrepo') + + def test_team_bug_tracker_field(self): + """Testing Bitbucket team bug tracker field values""" + self.assertFalse(self.service_class.get_bug_tracker_requires_username( + plan='team')) + self.assertEqual( + self.service_class.get_bug_tracker_field( + 'team', + { + 'bitbucket_team_name': 'myteam', + 'bitbucket_team_repo_name': 'myrepo', + }), + 'https://bitbucket.org/myteam/myrepo/issue/%s/') + + def test_team_check_repository(self): + """Testing Bitbucket team check_repository""" + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://bitbucket.org/api/1.0/repositories/myteam/myrepo') + return b'{}', {} + + account = self._get_hosting_account() + service = account.service + + account.data['password'] = encrypt_password('abc123') + + self.spy_on(service.client.http_get, call_fake=_http_get) + + service.check_repository(bitbucket_team_name='myteam', + bitbucket_team_repo_name='myrepo', + plan='team') + self.assertTrue(service.client.http_get.called) + + def test_check_repository_with_slash(self): + """Testing Bitbucket check_repository with /""" + account = self._get_hosting_account() + account.data['password'] = encrypt_password('abc123') + service = account.service + + self.assertRaisesMessage( + RepositoryError, + 'Please specify just the name of the repository, not a path.', + lambda: service.check_repository( + bitbucket_team_name='myteam', + bitbucket_team_repo_name='myteam/myrepo', + plan='team')) + + def test_check_repository_with_dot_git(self): + """Testing Bitbucket check_repository with .git""" + account = self._get_hosting_account() + account.data['password'] = encrypt_password('abc123') + service = account.service + + self.assertRaisesMessage( + RepositoryError, + 'Please specify just the name of the repository without ".git".', + lambda: service.check_repository( + bitbucket_team_name='myteam', + bitbucket_team_repo_name='myrepo.git', + plan='team')) + + def test_authorize(self): + """Testing Bitbucket authorization""" + def _http_get(self, *args, **kwargs): + return '{}', {} + + account = self._get_hosting_account() + service = account.service + + self.spy_on(service.client.http_get, call_fake=_http_get) + + self.assertFalse(service.is_authorized()) + + service.authorize('myuser', 'abc123', None) + + self.assertIn('password', account.data) + self.assertNotEqual(account.data['password'], 'abc123') + self.assertTrue(service.is_authorized()) + + def test_authorize_with_bad_credentials(self): + """Testing Bitbucket authorization with bad credentials""" + def _http_get(service, url, *args, **kwargs): + raise HTTPError(url, 401, '', {}, StringIO('')) + + account = self._get_hosting_account() + service = account.service + + self.spy_on(service.client.http_get, call_fake=_http_get) + + self.assertFalse(service.is_authorized()) + + self.assertRaisesMessage( + AuthorizationError, + 'Invalid Bitbucket username or password', + lambda: service.authorize('myuser', 'abc123', None)) + + self.assertNotIn('password', account.data) + self.assertFalse(service.is_authorized()) + + def test_get_file_with_mercurial_and_base_commit_id(self): + """Testing Bitbucket get_file with Mercurial and base commit ID""" + self._test_get_file( + tool_name='Mercurial', + revision='123', + base_commit_id='456', + expected_revision='456') + + def test_get_file_with_mercurial_and_revision(self): + """Testing Bitbucket get_file with Mercurial and revision""" + self._test_get_file( + tool_name='Mercurial', + revision='123', + base_commit_id=None, + expected_revision='123') + + def test_get_file_with_git_and_base_commit_id(self): + """Testing Bitbucket get_file with Git and base commit ID""" + self._test_get_file( + tool_name='Git', + revision='123', + base_commit_id='456', + expected_revision='456') + + def test_get_file_with_git_and_revision(self): + """Testing Bitbucket get_file with Git and revision""" + self.assertRaises( + FileNotFoundError, + self._test_get_file, + tool_name='Git', + revision='123', + base_commit_id=None, + expected_revision='123') + + def test_get_file_exists_with_mercurial_and_base_commit_id(self): + """Testing Bitbucket get_file_exists with Mercurial and base commit ID + """ + self._test_get_file_exists( + tool_name='Mercurial', + revision='123', + base_commit_id='456', + expected_revision='456', + expected_found=True) + + def test_get_file_exists_with_mercurial_and_revision(self): + """Testing Bitbucket get_file_exists with Mercurial and revision""" + self._test_get_file_exists( + tool_name='Mercurial', + revision='123', + base_commit_id=None, + expected_revision='123', + expected_found=True) + + def test_get_file_exists_with_git_and_base_commit_id(self): + """Testing Bitbucket get_file_exists with Git and base commit ID""" + self._test_get_file_exists( + tool_name='Git', + revision='123', + base_commit_id='456', + expected_revision='456', + expected_found=True) + + def test_get_file_exists_with_git_and_revision(self): + """Testing Bitbucket get_file_exists with Git and revision""" + self._test_get_file_exists( + tool_name='Git', + revision='123', + base_commit_id=None, + expected_revision='123', + expected_found=False, + expected_http_called=False) + + def test_get_file_exists_with_git_and_404(self): + """Testing BitBucket get_file_exists with Git and a 404 error""" + self._test_get_file_exists( + tool_name='Git', + revision='123', + base_commit_id='456', + expected_revision='456', + expected_found=False) + + @add_fixtures(['test_users', 'test_scmtools']) + def test_close_submitted_hook(self): + """Testing BitBucket close_submitted hook""" + self._test_post_commit_hook() + + @add_fixtures(['test_site', 'test_users', 'test_scmtools']) + def test_close_submitted_hook_with_local_site(self): + """Testing BitBucket close_submitted hook with a Local Site""" + self._test_post_commit_hook( + LocalSite.objects.get(name=self.local_site_name)) + + @add_fixtures(['test_users', 'test_scmtools']) + def test_close_submitted_hook_with_invalid_repo(self): + """Testing BitBucket close_submitted hook with invalid repository""" + repository = self.create_repository() + + review_request = self.create_review_request(repository=repository, + publish=True) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'bitbucket-hooks-close-submitted', + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'bitbucket', + 'hooks_uuid': repository.get_or_create_hooks_uuid(), + }) + + response = self._post_commit_hook_payload(url, review_request) + self.assertEqual(response.status_code, 404) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + self.assertEqual(review_request.changedescs.count(), 0) + + @add_fixtures(['test_site', 'test_users', 'test_scmtools']) + def test_close_submitted_hook_with_invalid_site(self): + """Testing BitBucket close_submitted hook with invalid Local Site""" + local_site = LocalSite.objects.get(name=self.local_site_name) + account = self._get_hosting_account(local_site=local_site) + account.save() + + repository = self.create_repository(hosting_account=account, + local_site=local_site) + + review_request = self.create_review_request(repository=repository, + publish=True) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'bitbucket-hooks-close-submitted', + local_site_name='badsite', + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'bitbucket', + 'hooks_uuid': repository.get_or_create_hooks_uuid(), + }) + + response = self._post_commit_hook_payload(url, review_request) + self.assertEqual(response.status_code, 404) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + self.assertEqual(review_request.changedescs.count(), 0) + + @add_fixtures(['test_users', 'test_scmtools']) + def test_close_submitted_hook_with_invalid_service_id(self): + """Testing BitBucket close_submitted hook with invalid hosting + service ID + """ + # We'll test against GitHub for this test. + account = self._get_hosting_account() + account.service_name = 'github' + account.save() + repository = self.create_repository(hosting_account=account) + + review_request = self.create_review_request(repository=repository, + publish=True) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'bitbucket-hooks-close-submitted', + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'bitbucket', + 'hooks_uuid': repository.get_or_create_hooks_uuid(), + }) + + response = self._post_commit_hook_payload(url, review_request) + self.assertEqual(response.status_code, 404) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + self.assertEqual(review_request.changedescs.count(), 0) + + def _test_post_commit_hook(self, local_site=None): + account = self._get_hosting_account(local_site=local_site) + account.save() + + repository = self.create_repository(hosting_account=account, + local_site=local_site) + + review_request = self.create_review_request(repository=repository, + local_site=local_site, + publish=True) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'bitbucket-hooks-close-submitted', + local_site=local_site, + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'bitbucket', + 'hooks_uuid': repository.get_or_create_hooks_uuid(), + }) + + self._post_commit_hook_payload(url, review_request) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.SUBMITTED) + self.assertEqual(review_request.changedescs.count(), 1) + + changedesc = review_request.changedescs.get() + self.assertEqual(changedesc.text, 'Pushed to master (1c44b46)') + + def _post_commit_hook_payload(self, url, review_request): + return self.client.post( + url, + data={ + 'payload': json.dumps({ + # NOTE: This payload only contains the content we make + # use of in the hook. + 'commits': [ + { + 'raw_node': '1c44b461cebe5874a857c51a4a13a84' + '9a4d1e52d', + 'branch': 'master', + 'message': 'This is my fancy commit\n' + '\n' + 'Reviewed at http://example.com%s' + % review_request.get_absolute_url(), + }, + ] + }), + }) + + def _test_get_file(self, tool_name, revision, base_commit_id, + expected_revision): + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://bitbucket.org/api/1.0/repositories/' + 'myuser/myrepo/raw/%s/path' + % expected_revision) + return b'My data', {} + + account = self._get_hosting_account() + service = account.service + repository = Repository(hosting_account=account, + tool=Tool.objects.get(name=tool_name)) + repository.extra_data = { + 'bitbucket_repo_name': 'myrepo', + } + + account.data['password'] = encrypt_password('abc123') + + self.spy_on(service.client.http_get, call_fake=_http_get) + + result = service.get_file(repository, 'path', revision, + base_commit_id) + self.assertTrue(service.client.http_get.called) + self.assertEqual(result, 'My data') + + def _test_get_file_exists(self, tool_name, revision, base_commit_id, + expected_revision, expected_found, + expected_http_called=True): + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://bitbucket.org/api/1.0/repositories/' + 'myuser/myrepo/raw/%s/path' + % expected_revision) + + if expected_found: + return b'{}', {} + else: + error = HTTPError(url, 404, 'Not Found', {}, None) + error.read = lambda: error.reason + raise error + + account = self._get_hosting_account() + service = account.service + repository = Repository(hosting_account=account, + tool=Tool.objects.get(name=tool_name)) + repository.extra_data = { + 'bitbucket_repo_name': 'myrepo', + } + + account.data['password'] = encrypt_password('abc123') + + self.spy_on(service.client.http_get, call_fake=_http_get) + + result = service.get_file_exists(repository, 'path', revision, + base_commit_id) + self.assertEqual(service.client.http_get.called, expected_http_called) + self.assertEqual(result, expected_found) diff --git a/reviewboard/hostingsvcs/tests/test_bugzilla.py b/reviewboard/hostingsvcs/tests/test_bugzilla.py new file mode 100644 index 0000000000000000000000000000000000000000..6ff19e2429d953ba1c4d003dbf92847c27eeea2e --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_bugzilla.py @@ -0,0 +1,24 @@ +from __future__ import unicode_literals + +from reviewboard.hostingsvcs.tests.testcases import ServiceTests + + +class BugzillaTests(ServiceTests): + """Unit tests for the Bugzilla hosting service.""" + service_name = 'bugzilla' + fixtures = ['test_scmtools'] + + def test_service_support(self): + """Testing the Bugzilla service support capabilities""" + self.assertTrue(self.service_class.supports_bug_trackers) + self.assertFalse(self.service_class.supports_repositories) + + def test_bug_tracker_field(self): + """Testing the Bugzilla bug tracker field value""" + self.assertFalse( + self.service_class.get_bug_tracker_requires_username()) + self.assertEqual( + self.service_class.get_bug_tracker_field(None, { + 'bugzilla_url': 'http://bugzilla.example.com', + }), + 'http://bugzilla.example.com/show_bug.cgi?id=%s') diff --git a/reviewboard/hostingsvcs/tests/test_codebasehq.py b/reviewboard/hostingsvcs/tests/test_codebasehq.py new file mode 100644 index 0000000000000000000000000000000000000000..0d8d515a11344a581780bfe6806c511461df2d0e --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_codebasehq.py @@ -0,0 +1,31 @@ +from __future__ import unicode_literals + +from reviewboard.hostingsvcs.tests.testcases import ServiceTests + + +class CodebaseHQTests(ServiceTests): + """Unit tests for the Codebase HQ hosting service.""" + + service_name = 'codebasehq' + + def test_service_support(self): + """Testing the Codebase HQ service support capabilities""" + self.assertFalse(self.service_class.supports_bug_trackers) + self.assertTrue(self.service_class.supports_repositories) + + def test_repo_field_values(self): + """Testing the Codebase HQ repository field values""" + fields = self._get_repository_fields('Git', fields={ + 'codebasehq_project_name': 'myproj', + 'codebasehq_group_name': 'mygroup', + 'codebasehq_repo_name': 'myrepo', + 'codebasehq_api_username': 'myapiuser', + 'codebasehq_api_key': 'myapikey', + }) + self.assertEqual(fields['username'], 'myapiuser') + self.assertEqual(fields['password'], 'myapikey') + self.assertEqual(fields['path'], + 'git@codebasehq.com:mygroup/myproj/myrepo.git') + self.assertEqual(fields['raw_file_url'], + 'https://api3.codebasehq.com/myproj/myrepo/blob/' + '') diff --git a/reviewboard/hostingsvcs/tests/test_fedora_hosted.py b/reviewboard/hostingsvcs/tests/test_fedora_hosted.py new file mode 100644 index 0000000000000000000000000000000000000000..aeb8f54378bc6abff5ce4e9c741c9295298cf92c --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_fedora_hosted.py @@ -0,0 +1,55 @@ +from __future__ import unicode_literals + +from reviewboard.hostingsvcs.tests.testcases import ServiceTests + + +class FedoraHosted(ServiceTests): + """Unit tests for the Fedora Hosted hosting service.""" + + service_name = 'fedorahosted' + + def test_service_support(self): + """Testing the Fedora Hosted service support capabilities""" + self.assertTrue(self.service_class.supports_bug_trackers) + self.assertTrue(self.service_class.supports_repositories) + + def test_repo_field_values_git(self): + """Testing the Fedora Hosted repository field values for Git""" + fields = self._get_repository_fields('Git', fields={ + 'fedorahosted_repo_name': 'myrepo', + }) + self.assertEqual(fields['path'], + 'git://git.fedorahosted.org/git/myrepo.git') + self.assertEqual(fields['raw_file_url'], + 'http://git.fedorahosted.org/cgit/myrepo.git/' + 'blob/?id=') + + def test_repo_field_values_mercurial(self): + """Testing the Fedora Hosted repository field values for Mercurial""" + fields = self._get_repository_fields('Mercurial', fields={ + 'fedorahosted_repo_name': 'myrepo', + }) + self.assertEqual(fields['path'], + 'http://hg.fedorahosted.org/hg/myrepo/') + self.assertEqual(fields['mirror_path'], + 'https://hg.fedorahosted.org/hg/myrepo/') + + def test_repo_field_values_svn(self): + """Testing the Fedora Hosted repository field values for Subversion""" + fields = self._get_repository_fields('Subversion', fields={ + 'fedorahosted_repo_name': 'myrepo', + }) + self.assertEqual(fields['path'], + 'http://svn.fedorahosted.org/svn/myrepo/') + self.assertEqual(fields['mirror_path'], + 'https://svn.fedorahosted.org/svn/myrepo/') + + def test_bug_tracker_field(self): + """Testing the Fedora Hosted bug tracker field value""" + self.assertFalse( + self.service_class.get_bug_tracker_requires_username()) + self.assertEqual( + self.service_class.get_bug_tracker_field(None, { + 'fedorahosted_repo_name': 'myrepo', + }), + 'https://fedorahosted.org/myrepo/ticket/%s') diff --git a/reviewboard/hostingsvcs/tests/test_fogbugz.py b/reviewboard/hostingsvcs/tests/test_fogbugz.py new file mode 100644 index 0000000000000000000000000000000000000000..af764578753b415968b506f43acc18c83d825de4 --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_fogbugz.py @@ -0,0 +1,25 @@ +from __future__ import unicode_literals + +from reviewboard.hostingsvcs.tests.testcases import ServiceTests + + +class FogBugzTests(ServiceTests): + """Unit tests for the FogBugz hosting service.""" + + service_name = 'fogbugz' + fixtures = ['test_scmtools'] + + def test_service_support(self): + """Testing the FogBugz service support capabilities""" + self.assertTrue(self.service_class.supports_bug_trackers) + self.assertFalse(self.service_class.supports_repositories) + + def test_bug_tracker_field(self): + """Testing the FogBugz bug tracker field value""" + self.assertFalse( + self.service_class.get_bug_tracker_requires_username()) + self.assertEqual( + self.service_class.get_bug_tracker_field(None, { + 'fogbugz_account_domain': 'mydomain', + }), + 'https://mydomain.fogbugz.com/f/cases/%s') diff --git a/reviewboard/hostingsvcs/tests/test_github.py b/reviewboard/hostingsvcs/tests/test_github.py new file mode 100644 index 0000000000000000000000000000000000000000..ca553ce591d1f2eee0e2e303dc03353f2a1c9693 --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_github.py @@ -0,0 +1,1246 @@ +from __future__ import unicode_literals + +import hashlib +import hmac +import json +from hashlib import md5 +from textwrap import dedent + +from django.core.exceptions import ObjectDoesNotExist +from django.utils import six +from django.utils.six.moves import cStringIO as StringIO +from django.utils.six.moves.urllib.error import HTTPError +from django.utils.six.moves.urllib.parse import urlparse +from djblets.testing.decorators import add_fixtures + +from reviewboard.scmtools.core import Branch +from reviewboard.hostingsvcs.models import HostingServiceAccount +from reviewboard.hostingsvcs.repository import RemoteRepository +from reviewboard.hostingsvcs.tests.testcases import ServiceTests +from reviewboard.reviews.models import ReviewRequest +from reviewboard.scmtools.errors import SCMError +from reviewboard.scmtools.models import Repository +from reviewboard.site.models import LocalSite +from reviewboard.site.urlresolvers import local_site_reverse + + +class GitHubTests(ServiceTests): + """Unit tests for the GitHub hosting service.""" + service_name = 'github' + + def test_service_support(self): + """Testing the GitHub service support capabilities""" + self.assertTrue(self.service_class.supports_bug_trackers) + self.assertTrue(self.service_class.supports_repositories) + self.assertFalse(self.service_class.supports_ssh_key_association) + + def test_public_field_values(self): + """Testing the GitHub public plan repository field values""" + fields = self._get_repository_fields('Git', plan='public', fields={ + 'github_public_repo_name': 'myrepo', + }) + self.assertEqual(fields['path'], 'git://github.com/myuser/myrepo.git') + self.assertEqual(fields['mirror_path'], + 'git@github.com:myuser/myrepo.git') + + def test_public_repo_api_url(self): + """Testing the GitHub public repository API URL""" + url = self._get_repo_api_url('public', { + 'github_public_repo_name': 'testrepo', + }) + self.assertEqual(url, 'https://api.github.com/repos/myuser/testrepo') + + def test_public_bug_tracker_field(self): + """Testing the GitHub public repository bug tracker field value""" + self.assertTrue( + self.service_class.get_bug_tracker_requires_username('public')) + self.assertEqual( + self.service_class.get_bug_tracker_field('public', { + 'github_public_repo_name': 'myrepo', + 'hosting_account_username': 'myuser', + }), + 'http://github.com/myuser/myrepo/issues#issue/%s') + + def test_public_org_field_values(self): + """Testing the GitHub public-org plan repository field values""" + fields = self._get_repository_fields('Git', plan='public-org', fields={ + 'github_public_org_repo_name': 'myrepo', + 'github_public_org_name': 'myorg', + }) + self.assertEqual(fields['path'], 'git://github.com/myorg/myrepo.git') + self.assertEqual(fields['mirror_path'], + 'git@github.com:myorg/myrepo.git') + + def test_public_org_repo_api_url(self): + """Testing the GitHub public-org repository API URL""" + url = self._get_repo_api_url('public-org', { + 'github_public_org_name': 'myorg', + 'github_public_org_repo_name': 'testrepo', + }) + self.assertEqual(url, 'https://api.github.com/repos/myorg/testrepo') + + def test_public_org_bug_tracker_field(self): + """Testing the GitHub public-org repository bug tracker field value""" + self.assertFalse( + self.service_class.get_bug_tracker_requires_username('public-org')) + self.assertEqual( + self.service_class.get_bug_tracker_field('public-org', { + 'github_public_org_name': 'myorg', + 'github_public_org_repo_name': 'myrepo', + }), + 'http://github.com/myorg/myrepo/issues#issue/%s') + + def test_private_field_values(self): + """Testing the GitHub private plan repository field values""" + fields = self._get_repository_fields('Git', plan='private', fields={ + 'github_private_repo_name': 'myrepo', + }) + self.assertEqual(fields['path'], 'git@github.com:myuser/myrepo.git') + self.assertEqual(fields['mirror_path'], '') + + def test_private_repo_api_url(self): + """Testing the GitHub private repository API URL""" + url = self._get_repo_api_url('private', { + 'github_private_repo_name': 'testrepo', + }) + self.assertEqual(url, 'https://api.github.com/repos/myuser/testrepo') + + def test_private_bug_tracker_field(self): + """Testing the GitHub private repository bug tracker field value""" + self.assertTrue( + self.service_class.get_bug_tracker_requires_username('private')) + self.assertEqual( + self.service_class.get_bug_tracker_field('private', { + 'github_private_repo_name': 'myrepo', + 'hosting_account_username': 'myuser', + }), + 'http://github.com/myuser/myrepo/issues#issue/%s') + + def test_private_org_field_values(self): + """Testing the GitHub private-org plan repository field values""" + fields = self._get_repository_fields( + 'Git', plan='private-org', fields={ + 'github_private_org_repo_name': 'myrepo', + 'github_private_org_name': 'myorg', + }) + self.assertEqual(fields['path'], 'git@github.com:myorg/myrepo.git') + self.assertEqual(fields['mirror_path'], '') + + def test_private_org_repo_api_url(self): + """Testing the GitHub private-org repository API URL""" + url = self._get_repo_api_url('private-org', { + 'github_private_org_name': 'myorg', + 'github_private_org_repo_name': 'testrepo', + }) + self.assertEqual(url, 'https://api.github.com/repos/myorg/testrepo') + + def test_private_org_bug_tracker_field(self): + """Testing the GitHub private-org repository bug tracker field value""" + self.assertFalse(self.service_class.get_bug_tracker_requires_username( + 'private-org')) + self.assertEqual( + self.service_class.get_bug_tracker_field('private-org', { + 'github_private_org_name': 'myorg', + 'github_private_org_repo_name': 'myrepo', + }), + 'http://github.com/myorg/myrepo/issues#issue/%s') + + def test_check_repository_public(self): + """Testing GitHub check_repository with public repository""" + self._test_check_repository(plan='public', + github_public_repo_name='myrepo') + + def test_check_repository_private(self): + """Testing GitHub check_repository with private repository""" + self._test_check_repository(plan='private', + github_private_repo_name='myrepo') + + def test_check_repository_public_org(self): + """Testing GitHub check_repository with public org repository""" + self._test_check_repository(plan='public-org', + github_public_org_name='myorg', + github_public_org_repo_name='myrepo', + expected_user='myorg') + + def test_check_repository_private_org(self): + """Testing GitHub check_repository with private org repository""" + self._test_check_repository(plan='private-org', + github_private_org_name='myorg', + github_private_org_repo_name='myrepo', + expected_user='myorg') + + def test_check_repository_public_not_found(self): + """Testing GitHub check_repository with not found error and public + repository""" + self._test_check_repository_error( + plan='public', + github_public_repo_name='myrepo', + http_status=404, + payload=b'{"message": "Not Found"}', + expected_error='A repository with this name was not found, ' + 'or your user may not own it.') + + def test_check_repository_private_not_found(self): + """Testing GitHub check_repository with not found error and private + repository""" + self._test_check_repository_error( + plan='private', + github_private_repo_name='myrepo', + http_status=404, + payload=b'{"message": "Not Found"}', + expected_error='A repository with this name was not found, ' + 'or your user may not own it.') + + def test_check_repository_public_org_not_found(self): + """Testing GitHub check_repository with not found error and + public organization repository""" + self._test_check_repository_error( + plan='public-org', + github_public_org_name='myorg', + github_public_org_repo_name='myrepo', + http_status=404, + payload=b'{"message": "Not Found"}', + expected_error='A repository with this organization or name ' + 'was not found.') + + def test_check_repository_private_org_not_found(self): + """Testing GitHub check_repository with not found error and + private organization repository""" + self._test_check_repository_error( + plan='private-org', + github_private_org_name='myorg', + github_private_org_repo_name='myrepo', + http_status=404, + payload=b'{"message": "Not Found"}', + expected_error='A repository with this organization or name ' + 'was not found, or your user may not have access ' + 'to it.') + + def test_check_repository_public_plan_private_repo(self): + """Testing GitHub check_repository with public plan and + private repository""" + self._test_check_repository_error( + plan='public', + github_public_repo_name='myrepo', + http_status=200, + payload=b'{"private": true}', + expected_error='This is a private repository, but you have ' + 'selected a public plan.') + + def test_check_repository_private_plan_public_repo(self): + """Testing GitHub check_repository with private plan and + public repository""" + self._test_check_repository_error( + plan='private', + github_private_repo_name='myrepo', + http_status=200, + payload=b'{"private": false}', + expected_error='This is a public repository, but you have ' + 'selected a private plan.') + + def test_check_repository_public_org_plan_private_repo(self): + """Testing GitHub check_repository with public organization plan and + private repository""" + self._test_check_repository_error( + plan='public-org', + github_public_org_name='myorg', + github_public_org_repo_name='myrepo', + http_status=200, + payload=b'{"private": true}', + expected_error='This is a private repository, but you have ' + 'selected a public plan.') + + def test_check_repository_private_org_plan_public_repo(self): + """Testing GitHub check_repository with private organization plan and + public repository""" + self._test_check_repository_error( + plan='private-org', + github_private_org_name='myorg', + github_private_org_repo_name='myrepo', + http_status=200, + payload=b'{"private": false}', + expected_error='This is a public repository, but you have ' + 'selected a private plan.') + + def test_authorization(self): + """Testing that GitHub account authorization sends expected data""" + http_post_data = {} + + def _http_post(self, *args, **kwargs): + http_post_data['args'] = args + http_post_data['kwargs'] = kwargs + + return json.dumps({ + 'id': 1, + 'url': 'https://api.github.com/authorizations/1', + 'scopes': ['user', 'repo'], + 'token': 'abc123', + 'note': '', + 'note_url': '', + 'updated_at': '2012-05-04T03:30:00Z', + 'created_at': '2012-05-04T03:30:00Z', + }), {} + + account = HostingServiceAccount(service_name=self.service_name, + username='myuser') + service = account.service + + self.spy_on(service.client.http_post, call_fake=_http_post) + + self.assertFalse(account.is_authorized) + + service.authorize('myuser', 'mypass', None) + self.assertTrue(account.is_authorized) + + self.assertEqual(http_post_data['kwargs']['url'], + 'https://api.github.com/authorizations') + self.assertEqual(http_post_data['kwargs']['username'], 'myuser') + self.assertEqual(http_post_data['kwargs']['password'], 'mypass') + + def test_authorization_with_client_info(self): + """Testing that GitHub account authorization with registered client + info + """ + http_post_data = {} + client_id = '' + client_secret = '' + + def _http_post(self, *args, **kwargs): + http_post_data['args'] = args + http_post_data['kwargs'] = kwargs + + return json.dumps({ + 'id': 1, + 'url': 'https://api.github.com/authorizations/1', + 'scopes': ['user', 'repo'], + 'token': 'abc123', + 'note': '', + 'note_url': '', + 'updated_at': '2012-05-04T03:30:00Z', + 'created_at': '2012-05-04T03:30:00Z', + }), {} + + account = HostingServiceAccount(service_name=self.service_name, + username='myuser') + service = account.service + + self.spy_on(service.client.http_post, call_fake=_http_post) + + self.assertFalse(account.is_authorized) + + with self.settings(GITHUB_CLIENT_ID=client_id, + GITHUB_CLIENT_SECRET=client_secret): + service.authorize('myuser', 'mypass', None) + + self.assertTrue(account.is_authorized) + + body = json.loads(http_post_data['kwargs']['body']) + self.assertEqual(body['client_id'], client_id) + self.assertEqual(body['client_secret'], client_secret) + + def test_get_branches(self): + """Testing GitHub get_branches implementation""" + branches_api_response = json.dumps([ + { + 'ref': 'refs/heads/master', + 'object': { + 'sha': '859d4e148ce3ce60bbda6622cdbe5c2c2f8d9817', + } + }, + { + 'ref': 'refs/heads/release-1.7.x', + 'object': { + 'sha': '92463764015ef463b4b6d1a1825fee7aeec8cb15', + } + }, + { + 'ref': 'refs/heads/some-component/fix', + 'object': { + 'sha': '764015ef492c8cb1546363b45fee7ab6d1a182ee', + } + }, + { + 'ref': 'refs/tags/release-1.7.11', + 'object': { + 'sha': 'f5a35f1d8a8dcefb336a8e3211334f1f50ea7792', + } + }, + ]) + + def _http_get(self, *args, **kwargs): + return branches_api_response, None + + account = self._get_hosting_account() + account.data['authorization'] = {'token': 'abc123'} + + repository = Repository(hosting_account=account) + repository.extra_data = { + 'repository_plan': 'public', + 'github_public_repo_name': 'myrepo', + } + + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + + branches = service.get_branches(repository) + + self.assertTrue(service.client.http_get.called) + + self.assertEqual(len(branches), 3) + self.assertEqual( + branches, + [ + Branch(id='master', + commit='859d4e148ce3ce60bbda6622cdbe5c2c2f8d9817', + default=True), + Branch(id='release-1.7.x', + commit='92463764015ef463b4b6d1a1825fee7aeec8cb15', + default=False), + Branch(id='some-component/fix', + commit='764015ef492c8cb1546363b45fee7ab6d1a182ee', + default=False), + ]) + + def test_get_commits(self): + """Testing GitHub get_commits implementation""" + commits_api_response = json.dumps([ + { + 'commit': { + 'author': {'name': 'Christian Hammond'}, + 'committer': {'date': '2013-06-25T23:31:22Z'}, + 'message': 'Fixed the bug number for the ' + 'blacktriangledown bug.', + }, + 'sha': '859d4e148ce3ce60bbda6622cdbe5c2c2f8d9817', + 'parents': [ + {'sha': '92463764015ef463b4b6d1a1825fee7aeec8cb15'} + ], + }, + { + 'commit': { + 'author': {'name': 'Christian Hammond'}, + 'committer': {'date': '2013-06-25T23:30:59Z'}, + 'message': "Merge branch 'release-1.7.x'", + }, + 'sha': '92463764015ef463b4b6d1a1825fee7aeec8cb15', + 'parents': [ + {'sha': 'f5a35f1d8a8dcefb336a8e3211334f1f50ea7792'}, + {'sha': '6c5f3465da5ed03dca8128bb3dd03121bd2cddb2'}, + ], + }, + { + 'commit': { + 'author': {'name': 'David Trowbridge'}, + 'committer': {'date': '2013-06-25T22:41:09Z'}, + 'message': 'Add DIFF_PARSE_ERROR to the ' + 'ValidateDiffResource.create error list.', + }, + 'sha': 'f5a35f1d8a8dcefb336a8e3211334f1f50ea7792', + 'parents': [], + } + ]) + + def _http_get(self, *args, **kwargs): + return commits_api_response, None + + account = self._get_hosting_account() + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + + account.data['authorization'] = {'token': 'abc123'} + + repository = Repository(hosting_account=account) + repository.extra_data = { + 'repository_plan': 'public', + 'github_public_repo_name': 'myrepo', + } + + commits = service.get_commits( + repository, start='859d4e148ce3ce60bbda6622cdbe5c2c2f8d9817') + + self.assertTrue(service.client.http_get.called) + + self.assertEqual(len(commits), 3) + self.assertEqual(commits[0].parent, commits[1].id) + self.assertEqual(commits[1].parent, commits[2].id) + self.assertEqual(commits[0].date, '2013-06-25T23:31:22Z') + self.assertEqual(commits[1].id, + '92463764015ef463b4b6d1a1825fee7aeec8cb15') + self.assertEqual(commits[2].author_name, 'David Trowbridge') + self.assertEqual(commits[2].parent, '') + + def test_get_change(self): + """Testing GitHub get_change implementation""" + commit_sha = '1c44b461cebe5874a857c51a4a13a849a4d1e52d' + parent_sha = '44568f7d33647d286691517e6325fea5c7a21d5e' + tree_sha = '56e25e58380daf9b4dfe35677ae6043fe1743922' + + commits_api_response = json.dumps([ + { + 'commit': { + 'author': {'name': 'David Trowbridge'}, + 'committer': {'date': '2013-06-25T23:31:22Z'}, + 'message': 'Move .clearfix to defs.less', + }, + 'sha': commit_sha, + 'parents': [{'sha': parent_sha}], + }, + ]) + + compare_api_response = json.dumps({ + 'base_commit': { + 'commit': { + 'tree': {'sha': tree_sha}, + }, + }, + 'files': [ + { + 'sha': '4344b3ad41b171ea606e88e9665c34cca602affb', + 'filename': 'reviewboard/static/rb/css/defs.less', + 'status': 'modified', + 'patch': dedent("""\ + @@ -182,4 +182,23 @@ + } + + + +/* Add a rule for clearing floats, */ + +.clearfix { + + display: inline-block; + + + + &:after { + + clear: both; + + content: \".\"; + + display: block; + + height: 0; + + visibility: hidden; + + } + +} + + + +/* Hides from IE-mac \\*/ + +* html .clearfix {height: 1%;} + +.clearfix {display: block;} + +/* End hide from IE-mac */ + + + + + // vim: set et ts=2 sw=2:"""), + }, + { + 'sha': '8e3129277b018b169cb8d13771433fbcd165a17c', + 'filename': 'reviewboard/static/rb/css/reviews.less', + 'status': 'modified', + 'patch': dedent("""\ + @@ -1311,24 +1311,6 @@ + .border-radius(8px); + } + + -/* Add a rule for clearing floats, */ + -.clearfix { + - display: inline-block; + - + - &:after { + - clear: both; + - content: \".\"; + - display: block; + - height: 0; + - visibility: hidden; + - } + -} + - + -/* Hides from IE-mac \\*/ + -* html .clearfix {height: 1%;} + -.clearfix {display: block;} + -/* End hide from IE-mac */ + - + + /**************************************************** + * Issue Summary"""), + }, + ] + }) + + trees_api_response = json.dumps({ + 'tree': [ + { + 'path': 'reviewboard/static/rb/css/defs.less', + 'sha': '830a40c3197223c6a0abb3355ea48891a1857bfd', + }, + { + 'path': 'reviewboard/static/rb/css/reviews.less', + 'sha': '535cd2c4211038d1bb8ab6beaed504e0db9d7e62', + }, + ], + }) + + # This has to be a list to avoid python's hinky treatment of scope of + # variables assigned within a closure. + step = [1] + + def _http_get(service, url, *args, **kwargs): + parsed = urlparse(url) + if parsed.path == '/repos/myuser/myrepo/commits': + self.assertEqual(step[0], 1) + step[0] += 1 + + query = parsed.query.split('&') + self.assertIn(('sha=%s' % commit_sha), query) + + return commits_api_response, None + elif parsed.path.startswith('/repos/myuser/myrepo/compare/'): + self.assertEqual(step[0], 2) + step[0] += 1 + + revs = parsed.path.split('/')[-1].split('...') + self.assertEqual(revs[0], parent_sha) + self.assertEqual(revs[1], commit_sha) + + return compare_api_response, None + elif parsed.path.startswith('/repos/myuser/myrepo/git/trees/'): + self.assertEqual(step[0], 3) + step[0] += 1 + + self.assertEqual(parsed.path.split('/')[-1], tree_sha) + + return trees_api_response, None + else: + print(parsed) + self.fail('Got an unexpected GET request') + + account = self._get_hosting_account() + account.data['authorization'] = {'token': 'abc123'} + + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + + repository = Repository(hosting_account=account) + repository.extra_data = { + 'repository_plan': 'public', + 'github_public_repo_name': 'myrepo', + } + + change = service.get_change(repository, commit_sha) + + self.assertTrue(service.client.http_get.called) + + self.assertEqual(change.message, 'Move .clearfix to defs.less') + self.assertEqual(md5(change.diff.encode('utf-8')).hexdigest(), + '0dd1bde0a60c0a7bb92c27b50f51fcb6') + + def test_get_change_exception(self): + """Testing GitHub get_change exception types""" + def _http_get(service, url, *args, **kwargs): + raise Exception('Not Found') + + account = self._get_hosting_account() + account.data['authorization'] = {'token': 'abc123'} + + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + + repository = Repository(hosting_account=account) + repository.extra_data = { + 'repository_plan': 'public', + 'github_public_repo_name': 'myrepo', + } + + service = account.service + commit_sha = '1c44b461cebe5874a857c51a4a13a849a4d1e52d' + self.assertRaisesMessage( + SCMError, 'Not Found', + lambda: service.get_change(repository, commit_sha)) + + def test_get_remote_repositories_with_owner(self, **kwargs): + """Testing GitHub.get_remote_repositories with requesting + authenticated user's repositories + """ + repos1 = [ + { + 'id': 1, + 'owner': { + 'login': 'myuser', + }, + 'name': 'myrepo', + 'clone_url': 'myrepo_path', + 'mirror_url': 'myrepo_mirror', + 'private': 'false' + } + ] + + repos2 = [ + { + 'id': 2, + 'owner': { + 'login': 'myuser', + }, + 'name': 'myrepo2', + 'clone_url': 'myrepo_path2', + 'mirror_url': 'myrepo_mirror2', + 'private': 'true' + } + ] + + def _http_get(service, url, *args, **kwargs): + base_url = 'https://api.github.com/user/repos?access_token=123' + self.assertIn(url, [base_url, '%s&page=2' % base_url]) + + if url == base_url: + return json.dumps(repos1), { + 'Link': '<%s&page=2>; rel="next"' % base_url, + } + else: + return json.dumps(repos2), { + 'Link': '<%s&page=1>; rel="prev"' % base_url, + } + + account = self._get_hosting_account() + account.data['authorization'] = { + 'token': '123', + } + + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + + paginator = service.get_remote_repositories('myuser') + + # Check the first result. + self.assertEqual(len(paginator.page_data), 1) + self.assertFalse(paginator.has_prev) + self.assertTrue(paginator.has_next) + repo = paginator.page_data[0] + + self.assertIsInstance(repo, RemoteRepository) + self.assertEqual(repo.id, 'myuser/myrepo') + self.assertEqual(repo.owner, 'myuser') + self.assertEqual(repo.name, 'myrepo') + self.assertEqual(repo.scm_type, 'Git') + self.assertEqual(repo.path, 'myrepo_path') + self.assertEqual(repo.mirror_path, 'myrepo_mirror') + + # Check the second result. + paginator.next() + self.assertEqual(len(paginator.page_data), 1) + self.assertTrue(paginator.has_prev) + self.assertFalse(paginator.has_next) + repo = paginator.page_data[0] + + self.assertIsInstance(repo, RemoteRepository) + self.assertEqual(repo.id, 'myuser/myrepo2') + self.assertEqual(repo.owner, 'myuser') + self.assertEqual(repo.name, 'myrepo2') + self.assertEqual(repo.scm_type, 'Git') + self.assertEqual(repo.path, 'myrepo_path2') + self.assertEqual(repo.mirror_path, 'myrepo_mirror2') + + def test_get_remote_repositories_with_other_user(self, **kwargs): + """Testing GitHub.get_remote_repositories with requesting + user's repositories + """ + repos1 = [ + { + 'id': 1, + 'owner': { + 'login': 'other', + }, + 'name': 'myrepo', + 'clone_url': 'myrepo_path', + 'mirror_url': 'myrepo_mirror', + 'private': 'false' + } + ] + repos2 = [] + + def _http_get(service, url, *args, **kwargs): + base_url = ('https://api.github.com/users/other/repos' + '?access_token=123') + + self.assertIn(url, [base_url, '%s&page=2' % base_url]) + + if url == base_url: + next_url = '<%s&page=2>; rel="next"' % base_url + return json.dumps(repos1), {'Link': next_url} + else: + return json.dumps(repos2), {} + + account = self._get_hosting_account() + account.data['authorization'] = { + 'token': '123', + } + + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + + paginator = service.get_remote_repositories('other') + + self.assertEqual(len(paginator.page_data), 1) + public_repo = paginator.page_data[0] + self.assertIsInstance(public_repo, RemoteRepository) + self.assertEqual(public_repo.id, 'other/myrepo') + self.assertEqual(public_repo.owner, 'other') + self.assertEqual(public_repo.name, 'myrepo') + self.assertEqual(public_repo.scm_type, 'Git') + self.assertEqual(public_repo.path, 'myrepo_path') + self.assertEqual(public_repo.mirror_path, 'myrepo_mirror') + + def test_get_remote_repositories_with_org(self, **kwargs): + """Testing GitHub.get_remote_repositories with requesting + organization's repositories + """ + repos = [ + { + 'id': 1, + 'owner': { + 'login': 'myorg', + }, + 'name': 'myrepo', + 'clone_url': 'myrepo_path', + 'mirror_url': 'myrepo_mirror', + 'private': 'false' + }, + { + 'id': 2, + 'owner': { + 'login': 'myuser', + }, + 'name': 'myrepo2', + 'clone_url': 'myrepo_path2', + 'mirror_url': 'myrepo_mirror2', + 'private': 'true' + } + ] + + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://api.github.com/orgs/myorg/repos?access_token=123') + return json.dumps(repos), {} + + account = self._get_hosting_account() + account.data['authorization'] = { + 'token': '123', + } + + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + + paginator = service.get_remote_repositories('myorg', 'organization') + self.assertEqual(len(paginator.page_data), 2) + public_repo, private_repo = paginator.page_data + + self.assertIsInstance(public_repo, RemoteRepository) + self.assertEqual(public_repo.id, 'myorg/myrepo') + self.assertEqual(public_repo.owner, 'myorg') + self.assertEqual(public_repo.name, 'myrepo') + self.assertEqual(public_repo.scm_type, 'Git') + self.assertEqual(public_repo.path, 'myrepo_path') + self.assertEqual(public_repo.mirror_path, 'myrepo_mirror') + + self.assertIsInstance(private_repo, RemoteRepository) + self.assertEqual(private_repo.id, 'myuser/myrepo2') + self.assertEqual(private_repo.owner, 'myuser') + self.assertEqual(private_repo.name, 'myrepo2') + self.assertEqual(private_repo.scm_type, 'Git') + self.assertEqual(private_repo.path, 'myrepo_path2') + self.assertEqual(private_repo.mirror_path, 'myrepo_mirror2') + + def test_get_remote_repositories_with_defaults(self, **kwargs): + """Testing GitHub.get_remote_repositories with default values""" + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://api.github.com/user/repos?access_token=123') + + return b'{}', {} + + account = self._get_hosting_account() + account.data['authorization'] = { + 'token': '123', + } + + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + + service.get_remote_repositories() + + def test_get_remote_repositories_with_filter(self, **kwargs): + """Testing GitHub.get_remote_repositories with ?filter-type=""" + def _http_get(service, url, *args, **kwargs): + self.assertEqual(url, + 'https://api.github.com/user/repos' + '?access_token=123&type=private') + + return json.dumps([]), {} + + account = self._get_hosting_account() + account.data['authorization'] = { + 'token': '123', + } + + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + + service.get_remote_repositories('myuser', filter_type='private') + + def test_get_remote_repository(self, **kwargs): + """Testing GitHub.get_remote_repository""" + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://api.github.com/repos/myuser/myrepo' + '?access_token=123') + + repo_data = { + 'id': 1, + 'owner': { + 'login': 'myuser', + }, + 'name': 'myrepo', + 'clone_url': 'myrepo_path', + 'mirror_url': 'myrepo_mirror', + 'private': 'false' + } + + return json.dumps(repo_data), {} + + account = self._get_hosting_account() + account.data['authorization'] = { + 'token': '123', + } + + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + + remote_repository = service.get_remote_repository('myuser/myrepo') + + self.assertIsInstance(remote_repository, RemoteRepository) + self.assertEqual(remote_repository.id, 'myuser/myrepo') + self.assertEqual(remote_repository.owner, 'myuser') + self.assertEqual(remote_repository.name, 'myrepo') + self.assertEqual(remote_repository.scm_type, 'Git') + self.assertEqual(remote_repository.path, 'myrepo_path') + self.assertEqual(remote_repository.mirror_path, 'myrepo_mirror') + + def test_get_remote_repository_invalid(self, **kwargs): + """Testing GitHub.get_remote_repository with invalid repository ID""" + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://api.github.com/repos/myuser/invalid' + '?access_token=123') + + payload = { + 'message': 'Not Found', + } + + raise HTTPError(url, 404, '', {}, StringIO(json.dumps(payload))) + + account = self._get_hosting_account() + account.data['authorization'] = { + 'token': '123', + } + + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + + self.assertRaises(ObjectDoesNotExist, + service.get_remote_repository, 'myuser/invalid') + + @add_fixtures(['test_users', 'test_scmtools']) + def test_close_submitted_hook(self): + """Testing GitHub close_submitted hook""" + self._test_post_commit_hook() + + @add_fixtures(['test_site', 'test_users', 'test_scmtools']) + def test_close_submitted_hook_with_local_site(self): + """Testing GitHub close_submitted hook with a Local Site""" + self._test_post_commit_hook( + LocalSite.objects.get(name=self.local_site_name)) + + @add_fixtures(['test_site', 'test_users', 'test_scmtools']) + def test_close_submitted_hook_with_unpublished_review_request(self): + """Testing GitHub close_submitted hook with an un-published review + request + """ + self._test_post_commit_hook(publish=False) + + @add_fixtures(['test_users', 'test_scmtools']) + def test_close_submitted_hook_ping(self): + """Testing GitHub close_submitted hook ping""" + account = self._get_hosting_account() + account.save() + + repository = self.create_repository(hosting_account=account) + + review_request = self.create_review_request(repository=repository, + publish=True) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'github-hooks-close-submitted', + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'github', + }) + + response = self._post_commit_hook_payload( + url, review_request, repository.get_or_create_hooks_uuid(), + event='ping') + self.assertEqual(response.status_code, 200) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + self.assertEqual(review_request.changedescs.count(), 0) + + @add_fixtures(['test_users', 'test_scmtools']) + def test_close_submitted_hook_with_invalid_repo(self): + """Testing GitHub close_submitted hook with invalid repository""" + repository = self.create_repository() + + review_request = self.create_review_request(repository=repository, + publish=True) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'github-hooks-close-submitted', + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'github', + }) + + response = self._post_commit_hook_payload( + url, review_request, repository.get_or_create_hooks_uuid()) + self.assertEqual(response.status_code, 404) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + self.assertEqual(review_request.changedescs.count(), 0) + + @add_fixtures(['test_users', 'test_scmtools']) + def test_close_submitted_hook_with_invalid_site(self): + """Testing GitHub close_submitted hook with invalid Local Site""" + repository = self.create_repository() + + review_request = self.create_review_request(repository=repository, + publish=True) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'github-hooks-close-submitted', + local_site_name='badsite', + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'github', + }) + + response = self._post_commit_hook_payload( + url, review_request, repository.get_or_create_hooks_uuid()) + self.assertEqual(response.status_code, 404) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + self.assertEqual(review_request.changedescs.count(), 0) + + @add_fixtures(['test_users', 'test_scmtools']) + def test_close_submitted_hook_with_invalid_service_id(self): + """Testing GitHub close_submitted hook with invalid hosting service ID + """ + # We'll test against Bitbucket for this test. + account = self._get_hosting_account() + account.service_name = 'bitbucket' + account.save() + repository = self.create_repository(hosting_account=account) + + review_request = self.create_review_request(repository=repository, + publish=True) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'github-hooks-close-submitted', + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'github', + }) + + response = self._post_commit_hook_payload( + url, review_request, repository.get_or_create_hooks_uuid()) + self.assertEqual(response.status_code, 404) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + self.assertEqual(review_request.changedescs.count(), 0) + + @add_fixtures(['test_users', 'test_scmtools']) + def test_close_submitted_hook_with_invalid_event(self): + """Testing GitHub close_submitted hook with non-push event""" + account = self._get_hosting_account() + account.save() + + repository = self.create_repository(hosting_account=account) + review_request = self.create_review_request(repository=repository, + publish=True) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'github-hooks-close-submitted', + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'github', + }) + + response = self._post_commit_hook_payload( + url, review_request, repository.get_or_create_hooks_uuid(), + event='foo') + self.assertEqual(response.status_code, 400) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + self.assertEqual(review_request.changedescs.count(), 0) + + @add_fixtures(['test_users', 'test_scmtools']) + def test_close_submitted_hook_with_invalid_signature(self): + """Testing GitHub close_submitted hook with invalid signature""" + account = self._get_hosting_account() + account.save() + + repository = self.create_repository(hosting_account=account) + review_request = self.create_review_request(repository=repository, + publish=True) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'github-hooks-close-submitted', + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'github', + }) + + response = self._post_commit_hook_payload( + url, review_request, 'bad-secret') + self.assertEqual(response.status_code, 400) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + self.assertEqual(review_request.changedescs.count(), 0) + + def _test_post_commit_hook(self, local_site=None, publish=True): + account = self._get_hosting_account(local_site=local_site) + account.save() + + repository = self.create_repository(hosting_account=account, + local_site=local_site) + + review_request = self.create_review_request(repository=repository, + local_site=local_site, + publish=publish) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'github-hooks-close-submitted', + local_site=local_site, + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'github', + }) + + response = self._post_commit_hook_payload( + url, review_request, repository.get_or_create_hooks_uuid()) + self.assertEqual(response.status_code, 200) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.SUBMITTED) + self.assertEqual(review_request.changedescs.count(), 1) + + changedesc = review_request.changedescs.get() + self.assertEqual(changedesc.text, 'Pushed to master (1c44b46)') + + def _post_commit_hook_payload(self, url, review_request, secret, + event='push'): + payload = json.dumps({ + # NOTE: This payload only contains the content we make + # use of in the hook. + 'ref': 'refs/heads/master', + 'commits': [ + { + 'id': '1c44b461cebe5874a857c51a4a13a849a4d1e52d', + 'message': 'This is my fancy commit\n' + '\n' + 'Reviewed at http://example.com%s' + % review_request.get_absolute_url(), + }, + ] + }) + + m = hmac.new(bytes(secret), payload, hashlib.sha1) + + return self.client.post( + url, + payload, + content_type='application/json', + HTTP_X_GITHUB_EVENT=event, + HTTP_X_HUB_SIGNATURE='sha1=%s' % m.hexdigest()) + + def _test_check_repository(self, expected_user='myuser', **kwargs): + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://api.github.com/repos/%s/myrepo?access_token=123' + % expected_user) + return b'{}', {} + + account = self._get_hosting_account() + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + account.data['authorization'] = { + 'token': '123', + } + + service.check_repository(**kwargs) + self.assertTrue(service.client.http_get.called) + + def _test_check_repository_error(self, http_status, payload, + expected_error, **kwargs): + def _http_get(service, url, *args, **kwargs): + if http_status == 200: + return payload, {} + else: + raise HTTPError(url, http_status, '', {}, StringIO(payload)) + + account = self._get_hosting_account() + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + account.data['authorization'] = { + 'token': '123', + } + + try: + service.check_repository(**kwargs) + saw_exception = False + except Exception as e: + self.assertEqual(six.text_type(e), expected_error) + saw_exception = True + + self.assertTrue(saw_exception) + + def _get_repo_api_url(self, plan, fields): + account = self._get_hosting_account() + service = account.service + self.assertNotEqual(service, None) + + repository = Repository(hosting_account=account) + repository.extra_data['repository_plan'] = plan + + form = self._get_form(plan, fields) + form.save(repository) + + return service._get_repo_api_url(repository) diff --git a/reviewboard/hostingsvcs/tests/test_gitlab.py b/reviewboard/hostingsvcs/tests/test_gitlab.py new file mode 100644 index 0000000000000000000000000000000000000000..9202ef49cb4102e3feb57a5a67ee9f43ed6d4edf --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_gitlab.py @@ -0,0 +1,424 @@ +from __future__ import unicode_literals + +import json +from textwrap import dedent + +from django.utils import six +from django.utils.six.moves.urllib.parse import urlparse + +from reviewboard.hostingsvcs.models import HostingServiceAccount +from reviewboard.hostingsvcs.tests.testcases import ServiceTests +from reviewboard.scmtools.core import Branch +from reviewboard.scmtools.crypto_utils import encrypt_password +from reviewboard.scmtools.models import Repository + + +class GitLabTests(ServiceTests): + """Unit tests for the GitLab hosting service.""" + + service_name = 'gitlab' + + def test_service_support(self): + """Testing the GitLab service support capabilities""" + self.assertTrue(self.service_class.supports_bug_trackers) + self.assertTrue(self.service_class.supports_repositories) + self.assertFalse(self.service_class.supports_ssh_key_association) + + def test_personal_field_values(self): + """Testing the GitLab personal plan repository field values""" + fields = self._get_repository_fields('Git', plan='personal', fields={ + 'hosting_url': 'https://example.com', + 'gitlab_personal_repo_name': 'myrepo', + }) + self.assertEqual(fields['path'], + 'git@example.com:myuser/myrepo.git') + self.assertEqual(fields['mirror_path'], + 'https://example.com/myuser/myrepo.git') + + def test_personal_bug_tracker_field(self): + """Testing the GitLab personal repository bug tracker field value""" + self.assertTrue( + self.service_class.get_bug_tracker_requires_username('personal')) + self.assertEqual( + self.service_class.get_bug_tracker_field('personal', { + 'hosting_url': 'https://example.com', + 'gitlab_personal_repo_name': 'myrepo', + 'hosting_account_username': 'myuser', + }), + 'https://example.com/myuser/myrepo/issues/%s') + + def test_group_field_values(self): + """Testing the GitLab group plan repository field values""" + fields = self._get_repository_fields('Git', plan='group', fields={ + 'hosting_url': 'https://example.com', + 'gitlab_group_repo_name': 'myrepo', + 'gitlab_group_name': 'mygroup', + }) + self.assertEqual(fields['path'], + 'git@example.com:mygroup/myrepo.git') + self.assertEqual(fields['mirror_path'], + 'https://example.com/mygroup/myrepo.git') + + def test_group_bug_tracker_field(self): + """Testing the GitLab group repository bug tracker field value""" + self.assertFalse( + self.service_class.get_bug_tracker_requires_username('group')) + self.assertEqual( + self.service_class.get_bug_tracker_field('group', { + 'hosting_url': 'https://example.com', + 'gitlab_group_name': 'mygroup', + 'gitlab_group_repo_name': 'myrepo', + }), + 'https://example.com/mygroup/myrepo/issues/%s') + + def test_check_repository_personal(self): + """Testing GitLab check_repository with personal repository""" + self._test_check_repository(plan='personal', + gitlab_personal_repo_name='myrepo') + + def test_check_repository_group(self): + """Testing GitLab check_repository with group repository""" + self._test_check_repository(plan='group', + gitlab_group_name='mygroup', + gitlab_group_repo_name='myrepo', + expected_user='mygroup') + + def test_check_repository_personal_not_found(self): + """Testing GitLab check_repository with not found error and personal + repository""" + self._test_check_repository_error( + plan='personal', + gitlab_personal_repo_name='myrepo', + expected_error='A repository with this name was not found, ' + 'or your user may not own it.') + + def test_check_repository_group_repo_not_found(self): + """Testing GitLab check_repository with not found error and + group repository""" + self._test_check_repository_error( + plan='group', + gitlab_group_name='mygroup', + gitlab_group_repo_name='badrepo', + expected_error='A repository with this name was not found on ' + 'this group, or your user may not have access ' + 'to it.') + + def test_check_repository_group_not_found(self): + """Testing GitLab check_repository with an incorrect group name""" + self._test_check_repository_error( + plan='group', + gitlab_group_name='badgroup', + gitlab_group_repo_name='myrepo', + expected_error='A group with this name was not found, or your ' + 'user may not have access to it.') + + def test_authorization(self): + """Testing that GitLab account authorization sends expected data""" + http_post_data = {} + + def _http_post(self, *args, **kwargs): + http_post_data['args'] = args + http_post_data['kwargs'] = kwargs + + return json.dumps({ + 'id': 1, + 'private_token': 'abc123', + }), {} + + account = HostingServiceAccount(service_name=self.service_name, + username='myuser') + service = account.service + + self.spy_on(service.client.http_post, call_fake=_http_post) + + self.assertFalse(account.is_authorized) + + service.authorize('myuser', 'mypass', + hosting_url='https://example.com') + self.assertTrue(account.is_authorized) + + self.assertEqual(http_post_data['kwargs']['url'], + 'https://example.com/api/v3/session') + self.assertIn('fields', http_post_data['kwargs']) + + fields = http_post_data['kwargs']['fields'] + self.assertEqual(fields['login'], 'myuser') + self.assertEqual(fields['password'], 'mypass') + + def test_get_branches(self): + """Testing GitLab get_branches implementation""" + branches_api_response = json.dumps([ + { + 'name': 'master', + 'commit': { + 'id': 'ed899a2f4b50b4370feeea94676502b42383c746' + } + }, + { + 'name': 'branch1', + 'commit': { + 'id': '6104942438c14ec7bd21c6cd5bd995272b3faff6' + } + }, + { + 'name': 'branch2', + 'commit': { + 'id': '21b3bcabcff2ab3dc3c9caa172f783aad602c0b0' + } + }, + { + 'branch-name': 'branch3', + 'commit': { + 'id': 'd5a3ff139356ce33e37e73add446f16869741b50' + } + } + ]) + + def _http_get(self, *args, **kwargs): + return branches_api_response, None + + account = self._get_hosting_account(use_url=True) + account.data['private_token'] = encrypt_password('abc123') + + service = account.service + + repository = Repository(hosting_account=account) + repository.extra_data = {'gitlab_project_id': 123456} + + self.spy_on(service.client.http_get, call_fake=_http_get) + + branches = service.get_branches(repository) + + self.assertTrue(service.client.http_get.called) + self.assertEqual(len(branches), 3) + self.assertEqual( + branches, + [ + Branch(id='master', + commit='ed899a2f4b50b4370feeea94676502b42383c746', + default=True), + Branch(id='branch1', + commit='6104942438c14ec7bd21c6cd5bd995272b3faff6', + default=False), + Branch(id='branch2', + commit='21b3bcabcff2ab3dc3c9caa172f783aad602c0b0', + default=False) + ]) + + def test_get_commits(self): + """Testing GitLab get_commits implementation""" + commits_api_response = json.dumps([ + { + 'id': 'ed899a2f4b50b4370feeea94676502b42383c746', + 'author_name': 'Chester Li', + 'created_at': '2015-03-10T11:50:22+03:00', + 'message': 'Replace sanitize with escape once' + }, + { + 'id': '6104942438c14ec7bd21c6cd5bd995272b3faff6', + 'author_name': 'Chester Li', + 'created_at': '2015-03-10T09:06:12+03:00', + 'message': 'Sanitize for network graph' + }, + { + 'id': '21b3bcabcff2ab3dc3c9caa172f783aad602c0b0', + 'author_name': 'East Coast', + 'created_at': '2015-03-04T15:31:18.000-04:00', + 'message': 'Add a timer to test file' + } + ]) + + def _http_get(self, *args, **kargs): + return commits_api_response, None + + account = self._get_hosting_account(use_url=True) + account.data['private_token'] = encrypt_password('abc123') + + service = account.service + + repository = Repository(hosting_account=account) + repository.extra_data = {'gitlab_project_id': 123456} + + self.spy_on(service.client.http_get, call_fake=_http_get) + + commits = service.get_commits( + repository, start='ed899a2f4b50b4370feeea94676502b42383c746') + + self.assertTrue(service.client.http_get.called) + self.assertEqual(len(commits), 3) + self.assertEqual(commits[0].id, + 'ed899a2f4b50b4370feeea94676502b42383c746') + self.assertNotEqual(commits[0].author_name, 'East Coast') + self.assertEqual(commits[1].date, '2015-03-10T09:06:12+03:00') + self.assertNotEqual(commits[1].message, + 'Replace sanitize with escape once') + self.assertEqual(commits[2].author_name, 'East Coast') + + def test_get_change(self): + """Testing GitLab get_change implementation""" + commit_id = 'ed899a2f4b50b4370feeea94676502b42383c746' + + commit_api_response = json.dumps( + { + 'author_name': 'Chester Li', + 'id': commit_id, + 'created_at': '2015-03-10T11:50:22+03:00', + 'message': 'Replace sanitize with escape once', + 'parent_ids': ['ae1d9fb46aa2b07ee9836d49862ec4e2c46fbbba'] + } + ) + + path_api_response = json.dumps( + { + 'path_with_namespace': 'username/project_name' + } + ) + + diff = dedent(b'''\ + --- + f1 | 1 + + f2 | 1 + + 2 files changed, 2 insertions(+), 0 deletions(-) + + diff --git a/f1 b/f1 + index 11ac561..3ea0691 100644 + --- a/f1 + +++ b/f1 + @@ -1 +1,2 @@ + this is f1 + +add one line to f1 + diff --git a/f2 b/f2 + index c837441..9302ecd 100644 + --- a/f2 + +++ b/f2 + @@ -1 +1,2 @@ + this is f2 + +add one line to f2 + ''') + + def _http_get(service, url, *args, **kwargs): + parsed = urlparse(url) + if parsed.path.startswith( + '/api/v3/projects/123456/repository/commits'): + # If the url is commit_api_url. + return commit_api_response, None + elif parsed.path == '/api/v3/projects/123456': + # If the url is path_api_url. + return path_api_response, None + elif parsed.path.endswith('.diff'): + # If the url is diff_url. + return diff, None + else: + print(parsed) + self.fail('Got an unexpected GET request') + + account = self._get_hosting_account(use_url=True) + account.data['private_token'] = encrypt_password('abc123') + + service = account.service + + repository = Repository(hosting_account=account) + repository.extra_data = {'gitlab_project_id': 123456} + + self.spy_on(service.client.http_get, call_fake=_http_get) + + commit = service.get_change(repository, commit_id) + + self.assertTrue(service.client.http_get.called) + self.assertEqual(commit.date, '2015-03-10T11:50:22+03:00') + self.assertEqual(commit.diff, diff) + self.assertNotEqual(commit.parent, '') + + def _test_check_repository(self, expected_user='myuser', **kwargs): + def _http_get(service, url, *args, **kwargs): + if url == 'https://example.com/api/v3/projects?per_page=100': + payload = [ + { + 'id': 1, + 'path': 'myrepo', + 'namespace': { + 'path': expected_user, + }, + } + ] + elif url == 'https://example.com/api/v3/groups?per_page=100': + payload = [ + { + 'id': 1, + 'name': 'mygroup', + } + ] + elif url == 'https://example.com/api/v3/projects/1': + # We don't care about the contents. Just that it exists. + payload = {} + elif url == 'https://example.com/api/v3/groups/1': + payload = { + 'projects': [ + { + 'id': 1, + 'name': 'myrepo', + }, + ], + } + else: + self.fail('Unexpected URL %s' % url) + + return json.dumps(payload), {} + + account = self._get_hosting_account(use_url=True) + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + account.data['private_token'] = encrypt_password('abc123') + + service.check_repository(**kwargs) + self.assertTrue(service.client.http_get.called) + + def _test_check_repository_error(self, expected_error, **kwargs): + def _http_get(service, url, *args, **kwargs): + if url == 'https://example.com/api/v3/groups?per_page=100': + payload = [ + { + 'id': 1, + 'name': 'mygroup', + } + ] + elif url == 'https://example.com/api/v3/groups/1': + payload = { + 'projects': [ + { + 'id': 1, + 'name': 'myrepo', + }, + ], + } + else: + payload = [] + + return json.dumps(payload), {} + + account = self._get_hosting_account(use_url=True) + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + account.data['private_token'] = encrypt_password('abc123') + + try: + service.check_repository(**kwargs) + saw_exception = False + except Exception as e: + self.assertEqual(six.text_type(e), expected_error) + saw_exception = True + + self.assertTrue(saw_exception) + + def _get_repo_api_url(self, plan, fields): + account = self._get_hosting_account(use_url=True) + service = account.service + self.assertNotEqual(service, None) + + repository = Repository(hosting_account=account) + repository.extra_data['repository_plan'] = plan + + form = self._get_form(plan, fields) + form.save(repository) + + return service._get_repo_api_url(repository) diff --git a/reviewboard/hostingsvcs/tests/test_gitorious.py b/reviewboard/hostingsvcs/tests/test_gitorious.py new file mode 100644 index 0000000000000000000000000000000000000000..662a285c46cd6f9d6f42168fa96957ffc9effaff --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_gitorious.py @@ -0,0 +1,28 @@ +from __future__ import unicode_literals + +from reviewboard.hostingsvcs.tests.testcases import ServiceTests + + +class GitoriousTests(ServiceTests): + """Unit tests for the Gitorious hosting service.""" + + service_name = 'gitorious' + + def test_service_support(self): + """Testing the Gitorious service support capabilities""" + self.assertFalse(self.service_class.supports_bug_trackers) + self.assertTrue(self.service_class.supports_repositories) + + def test_repo_field_values(self): + """Testing the Gitorious repository field values""" + fields = self._get_repository_fields('Git', fields={ + 'gitorious_project_name': 'myproj', + 'gitorious_repo_name': 'myrepo', + }) + self.assertEqual(fields['path'], + 'git://gitorious.org/myproj/myrepo.git') + self.assertEqual(fields['mirror_path'], + 'https://gitorious.org/myproj/myrepo.git') + self.assertEqual(fields['raw_file_url'], + 'https://gitorious.org/myproj/myrepo/blobs/raw/' + '') diff --git a/reviewboard/hostingsvcs/tests/test_google_code.py b/reviewboard/hostingsvcs/tests/test_google_code.py new file mode 100644 index 0000000000000000000000000000000000000000..d12a8c900d5b554eee678a941d22df54f3e6b7a6 --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_google_code.py @@ -0,0 +1,214 @@ +from __future__ import unicode_literals + +import json + +from djblets.testing.decorators import add_fixtures + +from reviewboard.hostingsvcs.tests.testcases import ServiceTests +from reviewboard.reviews.models import ReviewRequest +from reviewboard.site.models import LocalSite +from reviewboard.site.urlresolvers import local_site_reverse + + +class GoogleCodeTests(ServiceTests): + """Unit tests for the Google Code hosting service.""" + + service_name = 'googlecode' + + def test_service_support(self): + """Testing the Google Code service support capabilities""" + self.assertTrue(self.service_class.supports_bug_trackers) + self.assertTrue(self.service_class.supports_repositories) + + def test_repo_field_values_mercurial(self): + """Testing the Google Code repository field values for Mercurial""" + fields = self._get_repository_fields('Mercurial', fields={ + 'googlecode_project_name': 'myproj', + }) + self.assertEqual(fields['path'], 'http://myproj.googlecode.com/hg') + self.assertEqual(fields['mirror_path'], + 'https://myproj.googlecode.com/hg') + + def test_repo_field_values_svn(self): + """Testing the Google Code repository field values for Subversion""" + fields = self._get_repository_fields('Subversion', fields={ + 'googlecode_project_name': 'myproj', + }) + self.assertEqual(fields['path'], 'http://myproj.googlecode.com/svn') + self.assertEqual(fields['mirror_path'], + 'https://myproj.googlecode.com/svn') + + @add_fixtures(['test_users', 'test_scmtools']) + def test_close_submitted_hook(self): + """Testing Google Code close_submitted hook""" + self._test_post_commit_hook() + + @add_fixtures(['test_site', 'test_users', 'test_scmtools']) + def test_close_submitted_hook_with_local_site(self): + """Testing Google Code close_submitted hook with a Local Site""" + self._test_post_commit_hook( + LocalSite.objects.get(name=self.local_site_name)) + + @add_fixtures(['test_users', 'test_scmtools']) + def test_close_submitted_hook_with_invalid_repo(self): + """Testing Google Code close_submitted hook with invalid repository""" + repository = self.create_repository() + + review_request = self.create_review_request(repository=repository, + publish=True) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'googlecode-hooks-close-submitted', + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'googlecode', + 'hooks_uuid': repository.get_or_create_hooks_uuid(), + }) + + response = self._post_commit_hook_payload(url, review_request) + self.assertEqual(response.status_code, 404) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + self.assertEqual(review_request.changedescs.count(), 0) + + @add_fixtures(['test_users', 'test_scmtools']) + def test_close_submitted_hook_with_invalid_site(self): + """Testing Google Code close_submitted hook with invalid Local Site""" + repository = self.create_repository() + + review_request = self.create_review_request(repository=repository, + publish=True) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'googlecode-hooks-close-submitted', + local_site_name='badsite', + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'googlecode', + 'hooks_uuid': repository.get_or_create_hooks_uuid(), + }) + + response = self._post_commit_hook_payload(url, review_request) + self.assertEqual(response.status_code, 404) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + self.assertEqual(review_request.changedescs.count(), 0) + + @add_fixtures(['test_users', 'test_scmtools']) + def test_close_submitted_hook_with_invalid_service_id(self): + """Testing Google Code close_submitted hook with invalid hosting service ID + """ + # We'll test against Bitbucket for this test. + account = self._get_hosting_account() + account.service_name = 'bitbucket' + account.save() + repository = self.create_repository(hosting_account=account) + + review_request = self.create_review_request(repository=repository, + publish=True) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'googlecode-hooks-close-submitted', + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'googlecode', + 'hooks_uuid': repository.get_or_create_hooks_uuid(), + }) + + response = self._post_commit_hook_payload(url, review_request) + self.assertEqual(response.status_code, 404) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + self.assertEqual(review_request.changedescs.count(), 0) + + @add_fixtures(['test_users', 'test_scmtools']) + def test_close_submitted_hook_with_invalid_hooks_uuid(self): + """Testing Google Code close_submitted hook with invalid hooks UUID""" + account = self._get_hosting_account() + account.save() + repository = self.create_repository(hosting_account=account) + + review_request = self.create_review_request(repository=repository, + publish=True) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'googlecode-hooks-close-submitted', + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'googlecode', + 'hooks_uuid': 'abc123', + }) + + response = self._post_commit_hook_payload(url, review_request) + self.assertEqual(response.status_code, 404) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + self.assertEqual(review_request.changedescs.count(), 0) + + def _test_post_commit_hook(self, local_site=None): + account = self._get_hosting_account(local_site=local_site) + account.save() + + repository = self.create_repository(hosting_account=account, + local_site=local_site) + + review_request = self.create_review_request(repository=repository, + local_site=local_site, + publish=True) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.PENDING_REVIEW) + + url = local_site_reverse( + 'googlecode-hooks-close-submitted', + local_site=local_site, + kwargs={ + 'repository_id': repository.pk, + 'hosting_service_id': 'googlecode', + 'hooks_uuid': repository.get_or_create_hooks_uuid(), + }) + + response = self._post_commit_hook_payload(url, review_request) + self.assertEqual(response.status_code, 200) + + review_request = ReviewRequest.objects.get(pk=review_request.pk) + self.assertTrue(review_request.public) + self.assertEqual(review_request.status, review_request.SUBMITTED) + self.assertEqual(review_request.changedescs.count(), 1) + + changedesc = review_request.changedescs.get() + self.assertEqual(changedesc.text, 'Pushed to master (1c44b46)') + + def _post_commit_hook_payload(self, url, review_request): + return self.client.post( + url, + json.dumps({ + # NOTE: This payload only contains the content we make + # use of in the hook. + 'repository_path': 'master', + 'revisions': [ + { + 'revision': '1c44b461cebe5874a857c51a4a13a849a4d1e52d', + 'message': 'This is my fancy commit\n' + '\n' + 'Reviewed at http://example.com%s' + % review_request.get_absolute_url(), + }, + ] + }), + content_type='application/json') diff --git a/reviewboard/hostingsvcs/tests/test_kiln.py b/reviewboard/hostingsvcs/tests/test_kiln.py new file mode 100644 index 0000000000000000000000000000000000000000..e3dd8ba8ab9d47f758e21545421546e97d7be7bc --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_kiln.py @@ -0,0 +1,253 @@ +from __future__ import unicode_literals + +import json + +from reviewboard.hostingsvcs.errors import RepositoryError +from reviewboard.hostingsvcs.tests.testcases import ServiceTests +from reviewboard.scmtools.models import Repository, Tool + + +class KilnTests(ServiceTests): + """Unit tests for the Kiln hosting service.""" + + service_name = 'kiln' + fixtures = ['test_scmtools'] + + def test_service_support(self): + """Testing Kiln service support capabilities""" + self.assertTrue(self.service_class.supports_repositories) + self.assertTrue(self.service_class.needs_authorization) + self.assertFalse(self.service_class.supports_bug_trackers) + self.assertFalse(self.service_class.supports_post_commit) + self.assertFalse(self.service_class.supports_two_factor_auth) + + def test_repo_field_values_git(self): + """Testing Kiln repository field values for Git""" + fields = self._get_repository_fields('Git', fields={ + 'kiln_account_domain': 'mydomain', + 'kiln_project_name': 'myproject', + 'kiln_group_name': 'mygroup', + 'kiln_repo_name': 'myrepo', + }) + self.assertEqual( + fields['path'], + 'https://mydomain.kilnhg.com/Code/myproject/mygroup/myrepo.git') + self.assertEqual( + fields['mirror_path'], + 'ssh://mydomain@mydomain.kilnhg.com/myproject/mygroup/myrepo') + + def test_repo_field_values_mercurial(self): + """Testing Kiln repository field values for Mercurial""" + fields = self._get_repository_fields('Mercurial', fields={ + 'kiln_account_domain': 'mydomain', + 'kiln_project_name': 'myproject', + 'kiln_group_name': 'mygroup', + 'kiln_repo_name': 'myrepo', + }) + self.assertEqual( + fields['path'], + 'https://mydomain.kilnhg.com/Code/myproject/mygroup/myrepo') + self.assertEqual( + fields['mirror_path'], + 'ssh://mydomain@mydomain.kilnhg.com/myproject/mygroup/myrepo') + + def test_authorize(self): + """Testing Kiln authorization token storage""" + def _http_post(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://mydomain.kilnhg.com/Api/1.0/Auth/Login') + return '"my-token"', {} + + account = self._get_hosting_account() + service = account.service + + self.assertFalse(service.is_authorized()) + + self.spy_on(service.client.http_post, call_fake=_http_post) + + service.authorize('myuser', 'abc123', + kiln_account_domain='mydomain') + + self.assertIn('auth_token', account.data) + self.assertEqual(account.data['auth_token'], 'my-token') + self.assertTrue(service.is_authorized()) + + def test_check_repository(self): + """Testing Kiln check_repository""" + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://mydomain.kilnhg.com/Api/1.0/Project?token=my-token') + + data = json.dumps([{ + 'sSlug': 'myproject', + 'repoGroups': [{ + 'sSlug': 'mygroup', + 'repos': [{ + 'sSlug': 'myrepo', + }] + }] + }]) + + return data, {} + + account = self._get_hosting_account() + service = account.service + account.data.update({ + 'auth_token': 'my-token', + 'kiln_account_domain': 'mydomain', + }) + + self.spy_on(service.client.http_get, call_fake=_http_get) + + service.check_repository(kiln_account_domain='mydomain', + kiln_project_name='myproject', + kiln_group_name='mygroup', + kiln_repo_name='myrepo', + tool_name='Mercurial') + self.assertTrue(service.client.http_get.called) + + def test_check_repository_with_incorrect_repo_info(self): + """Testing Kiln check_repository with incorrect repo info""" + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://mydomain.kilnhg.com/Api/1.0/Project?token=my-token') + + data = json.dumps([{ + 'sSlug': 'otherproject', + 'repoGroups': [{ + 'sSlug': 'othergroup', + 'repos': [{ + 'sSlug': 'otherrepo', + }] + }] + }]) + + return data, {} + + account = self._get_hosting_account() + service = account.service + account.data.update({ + 'auth_token': 'my-token', + 'kiln_account_domain': 'mydomain', + }) + + self.spy_on(service.client.http_get, call_fake=_http_get) + + self.assertRaises( + RepositoryError, + lambda: service.check_repository( + kiln_account_domain='mydomain', + kiln_project_name='myproject', + kiln_group_name='mygroup', + kiln_repo_name='myrepo', + tool_name='Mercurial')) + self.assertTrue(service.client.http_get.called) + + def test_get_file(self): + """Testing Kiln get_file""" + def _http_get(service, url, *args, **kwargs): + if url == ('https://mydomain.kilnhg.com/Api/1.0/Project' + '?token=my-token'): + data = json.dumps([{ + 'sSlug': 'myproject', + 'repoGroups': [{ + 'sSlug': 'mygroup', + 'repos': [{ + 'sSlug': 'myrepo', + 'ixRepo': 123, + }] + }] + }]) + else: + self.assertEqual( + url, + 'https://mydomain.kilnhg.com/Api/1.0/Repo/123/Raw/File/' + '%s?rev=%s&token=my-token' + % (encoded_path, revision)) + + data = 'My data' + + return data, {} + + path = '/path' + encoded_path = '2F70617468' + revision = 123 + + account = self._get_hosting_account() + service = account.service + repository = Repository(hosting_account=account, + tool=Tool.objects.get(name='Mercurial')) + repository.extra_data = { + 'kiln_account_domain': 'mydomain', + 'kiln_project_name': 'myproject', + 'kiln_group_name': 'mygroup', + 'kiln_repo_name': 'myrepo', + } + repository.save() + + account.data.update({ + 'auth_token': 'my-token', + 'kiln_account_domain': 'mydomain', + }) + + self.spy_on(service.client.http_get, call_fake=_http_get) + + result = service.get_file(repository, path, revision) + self.assertTrue(service.client.http_get.called) + self.assertEqual(result, 'My data') + + def test_get_file_exists(self): + """Testing Kiln get_file_exists""" + def _http_get(service, url, *args, **kwargs): + if url == ('https://mydomain.kilnhg.com/Api/1.0/Project' + '?token=my-token'): + data = json.dumps([{ + 'sSlug': 'myproject', + 'repoGroups': [{ + 'sSlug': 'mygroup', + 'repos': [{ + 'sSlug': 'myrepo', + 'ixRepo': 123, + }] + }] + }]) + else: + self.assertEqual( + url, + 'https://mydomain.kilnhg.com/Api/1.0/Repo/123/Raw/File/' + '%s?rev=%s&token=my-token' + % (encoded_path, revision)) + + data = 'My data' + + return data, {} + + path = '/path' + encoded_path = '2F70617468' + revision = 123 + + account = self._get_hosting_account() + service = account.service + repository = Repository(hosting_account=account, + tool=Tool.objects.get(name='Mercurial')) + repository.extra_data = { + 'kiln_account_domain': 'mydomain', + 'kiln_project_name': 'myproject', + 'kiln_group_name': 'mygroup', + 'kiln_repo_name': 'myrepo', + } + repository.save() + + account.data.update({ + 'auth_token': 'my-token', + 'kiln_account_domain': 'mydomain', + }) + + self.spy_on(service.client.http_get, call_fake=_http_get) + + result = service.get_file_exists(repository, path, revision) + self.assertTrue(service.client.http_get.called) + self.assertTrue(result) diff --git a/reviewboard/hostingsvcs/tests/test_rbgateway.py b/reviewboard/hostingsvcs/tests/test_rbgateway.py new file mode 100644 index 0000000000000000000000000000000000000000..6e8e445dc6d397d1963bc9de78697ba7a58c914e --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_rbgateway.py @@ -0,0 +1,218 @@ +from __future__ import unicode_literals + +import json +from hashlib import md5 + +from reviewboard.hostingsvcs.models import HostingServiceAccount +from reviewboard.hostingsvcs.tests.testcases import ServiceTests +from reviewboard.scmtools.core import Branch +from reviewboard.scmtools.crypto_utils import encrypt_password +from reviewboard.scmtools.models import Repository + + +class ReviewBoardGatewayTests(ServiceTests): + """Unit tests for the ReviewBoardGateway hosting service.""" + + service_name = 'rbgateway' + + def test_service_support(self): + """Testing the ReviewBoardGateway service support capabilities""" + self.assertTrue(self.service_class.supports_repositories) + self.assertTrue(self.service_class.supports_post_commit) + self.assertFalse(self.service_class.supports_bug_trackers) + self.assertFalse(self.service_class.supports_ssh_key_association) + + def test_repo_field_values(self): + """Testing the ReviewBoardGateway repository field values""" + fields = self._get_repository_fields('Git', fields={ + 'hosting_url': 'https://example.com', + 'rbgateway_repo_name': 'myrepo', + }) + self.assertEqual(fields['path'], + 'https://example.com/repos/myrepo/path') + + def test_authorization(self): + """Testing that ReviewBoardGateway authorization sends expected data""" + http_post_data = {} + + def _http_post(self, *args, **kwargs): + http_post_data['args'] = args + http_post_data['kwargs'] = kwargs + + return json.dumps({ + 'private_token': 'abc123' + }), {} + + self.service_class._http_post = _http_post + + account = HostingServiceAccount(service_name=self.service_name, + username='myuser') + service = account.service + + self.spy_on(service.client.http_post, call_fake=_http_post) + + self.assertFalse(account.is_authorized) + + service.authorize('myuser', 'mypass', + hosting_url='https://example.com') + self.assertTrue(account.is_authorized) + + self.assertEqual(http_post_data['kwargs']['url'], + 'https://example.com/session') + self.assertIn('username', http_post_data['kwargs']) + self.assertIn('password', http_post_data['kwargs']) + + def test_check_repository(self): + """Testing that ReviewBoardGateway can find the repository""" + def _http_get(service, url, *args, **kwargs): + self.assertEqual(url, 'https://example.com/repos/myrepo/path') + return '{}', {} + + account = self._get_hosting_account(use_url=True) + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + account.data['private_token'] = encrypt_password('abc123') + + service.check_repository(path='https://example.com/repos/myrepo/path') + self.assertTrue(service.client.http_get.called) + + def test_get_branches(self): + """Testing ReviewBoardGateway get_branches implementation""" + branches_api_response = json.dumps([ + { + 'name': 'master', + 'id': 'c272edcac05b00e15440d6274723b639e3acbd7c', + }, + { + 'name': 'im_a_branch', + 'id': '83904e6acb60e7ec0dcaae6c09a579ab44d0cf38', + } + ]) + + def _http_get(self, *args, **kwargs): + return branches_api_response, None + + account = self._get_hosting_account() + account.data['private_token'] = encrypt_password('abc123') + + repository = Repository(hosting_account=account) + repository.extra_data = { + 'rbgateway_repo_name': 'myrepo', + } + + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + + branches = service.get_branches(repository) + + self.assertTrue(service.client.http_get.called) + + self.assertEqual(len(branches), 2) + + self.assertEqual( + branches, + [ + Branch(id='master', + commit='c272edcac05b00e15440d6274723b639e3acbd7c', + default=True), + Branch(id='im_a_branch', + commit='83904e6acb60e7ec0dcaae6c09a579ab44d0cf38', + default=False) + ]) + + def test_get_commits(self): + """Testing ReviewBoardGateway get_commits implementation""" + commits_api_response = json.dumps([ + { + 'author': 'myname', + 'id': 'bfdde95432b3af879af969bd2377dc3e55ee46e6', + 'date': '2015-02-13 22:34:01 -0700 -0700', + 'message': 'mymessage', + 'parent_id': '304c53c163aedfd0c0e0933776f09c24b87f5944', + }, + { + 'author': 'myname', + 'id': '304c53c163aedfd0c0e0933776f09c24b87f5944', + 'date': '2015-02-13 22:32:42 -0700 -0700', + 'message': 'mymessage', + 'parent_id': 'fa1330719893098ae397356e8125c2aa45b49221', + }, + { + 'author': 'anothername', + 'id': 'fa1330719893098ae397356e8125c2aa45b49221', + 'date': '2015-02-12 16:01:48 -0700 -0700', + 'message': 'mymessage', + 'parent_id': '', + } + ]) + + def _http_get(self, *args, **kwargs): + return commits_api_response, None + + account = self._get_hosting_account() + account.data['private_token'] = encrypt_password('abc123') + + repository = Repository(hosting_account=account) + repository.extra_data = { + 'rbgateway_repo_name': 'myrepo', + } + + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + + commits = service.get_commits( + repository, branch='bfdde95432b3af879af969bd2377dc3e55ee46e6') + + self.assertTrue(service.client.http_get.called) + + self.assertEqual(len(commits), 3) + self.assertEqual(commits[0].parent, commits[1].id) + self.assertEqual(commits[1].parent, commits[2].id) + self.assertEqual(commits[0].date, '2015-02-13 22:34:01 -0700 -0700') + self.assertEqual(commits[1].id, + '304c53c163aedfd0c0e0933776f09c24b87f5944') + self.assertEqual(commits[2].author_name, 'anothername') + self.assertEqual(commits[2].parent, '') + + def test_get_change(self): + """Testing ReviewBoardGateway get_change implementation""" + diff = (b'diff --git a/test b/test\n' + 'index 9daeafb9864cf43055ae93beb0afd6c7d144bfa4..' + 'dced80a85fe1e8f13dd5ea19923e5d2e8680020d 100644\n' + '--- a/test\n+++ b/test\n@@ -1 +1,3 @@\n test\n+\n+test\n') + + diff_encoding = md5(diff.encode('utf-8')).hexdigest() + + change_api_response = json.dumps( + { + 'author': 'myname', + 'id': 'bfdde95432b3af879af969bd2377dc3e55ee46e6', + 'date': '2015-02-13 22:34:01 -0700 -0700', + 'message': 'mymessage', + 'parent_id': '304c53c163aedfd0c0e0933776f09c24b87f5944', + 'diff': diff + } + ) + + def _http_get(self, *args, **kwargs): + return change_api_response, None + + account = self._get_hosting_account() + account.data['private_token'] = encrypt_password('abc123') + + repository = Repository(hosting_account=account) + repository.extra_data = { + 'rbgateway_repo_name': 'myrepo', + } + + service = account.service + self.spy_on(service.client.http_get, call_fake=_http_get) + + change = service.get_change( + repository, 'bfdde95432b3af879af969bd2377dc3e55ee46e6') + + self.assertTrue(service.client.http_get.called) + + self.assertEqual(change.message, 'mymessage') + self.assertEqual(md5(change.diff.encode('utf-8')).hexdigest(), + diff_encoding) diff --git a/reviewboard/hostingsvcs/tests/test_redmine.py b/reviewboard/hostingsvcs/tests/test_redmine.py new file mode 100644 index 0000000000000000000000000000000000000000..be2eb933c9fb79fc502c6756289b705b66bcaa7d --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_redmine.py @@ -0,0 +1,25 @@ +from __future__ import unicode_literals + +from reviewboard.hostingsvcs.tests.testcases import ServiceTests + + +class RedmineTests(ServiceTests): + """Unit tests for the Redmine hosting service.""" + + service_name = 'redmine' + fixtures = ['test_scmtools'] + + def test_service_support(self): + """Testing the Redmine service support capabilities""" + self.assertTrue(self.service_class.supports_bug_trackers) + self.assertFalse(self.service_class.supports_repositories) + + def test_bug_tracker_field(self): + """Testing the Redmine bug tracker field value""" + self.assertFalse( + self.service_class.get_bug_tracker_requires_username()) + self.assertEqual( + self.service_class.get_bug_tracker_field(None, { + 'redmine_url': 'http://redmine.example.com', + }), + 'http://redmine.example.com/issues/%s') diff --git a/reviewboard/hostingsvcs/tests/test_registration.py b/reviewboard/hostingsvcs/tests/test_registration.py new file mode 100644 index 0000000000000000000000000000000000000000..8dd88391560e1d5a274d165754ee957c5334f5ce --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_registration.py @@ -0,0 +1,102 @@ +from __future__ import unicode_literals + +from django.conf.urls import patterns, url +from django.core.urlresolvers import NoReverseMatch +from django.http import HttpResponse + +from reviewboard.hostingsvcs.service import (HostingService, + register_hosting_service, + unregister_hosting_service) +from reviewboard.site.urlresolvers import local_site_reverse +from reviewboard.testing import TestCase + + +def hosting_service_url_test_view(request, repo_id): + """View to test URL pattern addition when registering a hosting service""" + return HttpResponse(str(repo_id)) + + +class HostingServiceRegistrationTests(TestCase): + """Unit tests for Hosting Service registration.""" + + class DummyService(HostingService): + name = 'DummyService' + + class DummyServiceWithURLs(HostingService): + name = 'DummyServiceWithURLs' + + repository_url_patterns = patterns( + '', + + url(r'^hooks/pre-commit/$', hosting_service_url_test_view, + name='dummy-service-post-commit-hook'), + ) + + def tearDown(self): + super(HostingServiceRegistrationTests, self).tearDown() + + # Unregister the service, going back to a default state. It's okay + # if it fails. + # + # This will match whichever service we added for testing. + try: + unregister_hosting_service('dummy-service') + except KeyError: + pass + + def test_register_without_urls(self): + """Testing HostingService registration""" + register_hosting_service('dummy-service', self.DummyService) + + with self.assertRaises(KeyError): + register_hosting_service('dummy-service', self.DummyService) + + def test_unregister(self): + """Testing HostingService unregistration""" + register_hosting_service('dummy-service', self.DummyService) + unregister_hosting_service('dummy-service') + + def test_registration_with_urls(self): + """Testing HostingService registration with URLs""" + register_hosting_service('dummy-service', self.DummyServiceWithURLs) + + self.assertEqual( + local_site_reverse( + 'dummy-service-post-commit-hook', + kwargs={ + 'repository_id': 1, + 'hosting_service_id': 'dummy-service', + }), + '/repos/1/dummy-service/hooks/pre-commit/') + + self.assertEqual( + local_site_reverse( + 'dummy-service-post-commit-hook', + local_site_name='test-site', + kwargs={ + 'repository_id': 1, + 'hosting_service_id': 'dummy-service', + }), + '/s/test-site/repos/1/dummy-service/hooks/pre-commit/') + + # Once registered, should not be able to register again + with self.assertRaises(KeyError): + register_hosting_service('dummy-service', + self.DummyServiceWithURLs) + + def test_unregistration_with_urls(self): + """Testing HostingService unregistration with URLs""" + register_hosting_service('dummy-service', self.DummyServiceWithURLs) + unregister_hosting_service('dummy-service') + + with self.assertRaises(NoReverseMatch): + local_site_reverse( + 'dummy-service-post-commit-hook', + kwargs={ + 'repository_id': 1, + 'hosting_service_id': 'dummy-service', + }), + + # Once unregistered, should not be able to unregister again + with self.assertRaises(KeyError): + unregister_hosting_service('dummy-service') diff --git a/reviewboard/hostingsvcs/tests/test_sourceforge.py b/reviewboard/hostingsvcs/tests/test_sourceforge.py new file mode 100644 index 0000000000000000000000000000000000000000..dcc3a7a48af20d033e905e2f350a1427f1a675b3 --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_sourceforge.py @@ -0,0 +1,56 @@ +from __future__ import unicode_literals + +from reviewboard.hostingsvcs.tests.testcases import ServiceTests + + +class SourceForgeTests(ServiceTests): + """Unit tests for the SourceForge hosting service.""" + + service_name = 'sourceforge' + + def test_service_support(self): + """Testing the SourceForge service support capabilities""" + self.assertTrue(self.service_class.supports_bug_trackers) + self.assertTrue(self.service_class.supports_repositories) + + def test_repo_field_values_bazaar(self): + """Testing the SourceForge repository field values for Bazaar""" + fields = self._get_repository_fields('Bazaar', fields={ + 'sourceforge_project_name': 'myproj', + }) + self.assertEqual(fields['path'], + 'bzr://myproj.bzr.sourceforge.net/bzrroot/myproj') + self.assertEqual(fields['mirror_path'], + 'bzr+ssh://myproj.bzr.sourceforge.net/bzrroot/' + 'myproj') + + def test_repo_field_values_cvs(self): + """Testing the SourceForge repository field values for CVS""" + fields = self._get_repository_fields('CVS', fields={ + 'sourceforge_project_name': 'myproj', + }) + self.assertEqual(fields['path'], + ':pserver:anonymous@myproj.cvs.sourceforge.net:' + '/cvsroot/myproj') + self.assertEqual(fields['mirror_path'], + 'myproj.cvs.sourceforge.net/cvsroot/myproj') + + def test_repo_field_values_mercurial(self): + """Testing the SourceForge repository field values for Mercurial""" + fields = self._get_repository_fields('Mercurial', fields={ + 'sourceforge_project_name': 'myproj', + }) + self.assertEqual(fields['path'], + 'http://myproj.hg.sourceforge.net:8000/hgroot/myproj') + self.assertEqual(fields['mirror_path'], + 'ssh://myproj.hg.sourceforge.net/hgroot/myproj') + + def test_repo_field_values_svn(self): + """Testing the SourceForge repository field values for Subversion""" + fields = self._get_repository_fields('Subversion', fields={ + 'sourceforge_project_name': 'myproj', + }) + self.assertEqual(fields['path'], + 'http://myproj.svn.sourceforge.net/svnroot/myproj') + self.assertEqual(fields['mirror_path'], + 'https://myproj.svn.sourceforge.net/svnroot/myproj') diff --git a/reviewboard/hostingsvcs/tests/test_trac.py b/reviewboard/hostingsvcs/tests/test_trac.py new file mode 100644 index 0000000000000000000000000000000000000000..a7989d2ba159dcc7f06e43e4ab26126e3952e1ba --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_trac.py @@ -0,0 +1,25 @@ +from __future__ import unicode_literals + +from reviewboard.hostingsvcs.tests.testcases import ServiceTests + + +class TracTests(ServiceTests): + """Unit tests for the Trac hosting service.""" + + service_name = 'trac' + fixtures = ['test_scmtools'] + + def test_service_support(self): + """Testing the Trac service support capabilities""" + self.assertTrue(self.service_class.supports_bug_trackers) + self.assertFalse(self.service_class.supports_repositories) + + def test_bug_tracker_field(self): + """Testing the Trac bug tracker field value""" + self.assertFalse( + self.service_class.get_bug_tracker_requires_username()) + self.assertEqual( + self.service_class.get_bug_tracker_field(None, { + 'trac_url': 'http://trac.example.com', + }), + 'http://trac.example.com/ticket/%s') diff --git a/reviewboard/hostingsvcs/tests/test_unfuddle.py b/reviewboard/hostingsvcs/tests/test_unfuddle.py new file mode 100644 index 0000000000000000000000000000000000000000..918a836cb5ff6b70e745dc902e72e3456ca90d57 --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_unfuddle.py @@ -0,0 +1,263 @@ +from __future__ import unicode_literals + +from django.utils.six.moves.urllib.error import HTTPError + +from reviewboard.hostingsvcs.errors import RepositoryError +from reviewboard.hostingsvcs.tests.testcases import ServiceTests +from reviewboard.scmtools.crypto_utils import encrypt_password +from reviewboard.scmtools.errors import FileNotFoundError +from reviewboard.scmtools.models import Repository, Tool + + +class UnfuddleTests(ServiceTests): + """Unit tests for the Unfuddle hosting service.""" + + service_name = 'unfuddle' + fixtures = ['test_scmtools'] + + def test_service_support(self): + """Testing Unfuddle service support capabilities""" + self.assertTrue(self.service_class.supports_bug_trackers) + self.assertTrue(self.service_class.supports_repositories) + + def test_repo_field_values_git(self): + """Testing Unfuddle repository field values for Git""" + fields = self._get_repository_fields('Git', fields={ + 'unfuddle_account_domain': 'mydomain', + 'unfuddle_project_id': 1, + 'unfuddle_repo_name': 'myrepo', + }) + self.assertEqual( + fields['path'], + 'git@mydomain.unfuddle.com:mydomain/myrepo.git') + self.assertEqual( + fields['mirror_path'], + 'https://mydomain.unfuddle.com/git/mydomain_myrepo/') + + def test_repo_field_values_subversion(self): + """Testing Unfuddle repository field values for Subversion""" + fields = self._get_repository_fields('Subversion', fields={ + 'unfuddle_account_domain': 'mydomain', + 'unfuddle_project_id': 1, + 'unfuddle_repo_name': 'myrepo', + }) + self.assertEqual( + fields['path'], + 'https://mydomain.unfuddle.com/svn/mydomain_myrepo') + self.assertEqual( + fields['mirror_path'], + 'http://mydomain.unfuddle.com/svn/mydomain_myrepo') + + def test_authorize(self): + """Testing Unfuddle authorization password storage""" + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://mydomain.unfuddle.com/api/v1/account/') + return '{}', {} + + account = self._get_hosting_account() + service = account.service + + self.assertFalse(service.is_authorized()) + + self.spy_on(service.client.http_get, call_fake=_http_get) + + service.authorize('myuser', 'abc123', + unfuddle_account_domain='mydomain') + + self.assertIn('password', account.data) + self.assertNotEqual(account.data['password'], 'abc123') + self.assertTrue(service.is_authorized()) + + def test_check_repository(self): + """Testing Unfuddle check_repository""" + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://mydomain.unfuddle.com/api/v1/repositories/') + + return '[{"id": 2, "abbreviation": "myrepo", "system": "git"}]', {} + + account = self._get_hosting_account() + service = account.service + account.data['password'] = encrypt_password('password') + + self.spy_on(service.client.http_get, call_fake=_http_get) + + service.check_repository(unfuddle_account_domain='mydomain', + unfuddle_repo_name='myrepo', + tool_name='Git') + self.assertTrue(service.client.http_get.called) + + def test_check_repository_with_wrong_repo_type(self): + """Testing Unfuddle check_repository with wrong repo type""" + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://mydomain.unfuddle.com/api/v1/repositories/') + + return '[{"id": 1, "abbreviation": "myrepo", "system": "svn"}]', {} + + account = self._get_hosting_account() + service = account.service + account.data['password'] = encrypt_password('password') + + self.spy_on(service.client.http_get, call_fake=_http_get) + + self.assertRaises( + RepositoryError, + lambda: service.check_repository( + unfuddle_account_domain='mydomain', + unfuddle_repo_name='myrepo', + tool_name='Git')) + self.assertTrue(service.client.http_get.called) + + def test_get_file_with_svn_and_base_commit_id(self): + """Testing Unfuddle get_file with Subversion and base commit ID""" + self._test_get_file( + tool_name='Subversion', + revision='123', + base_commit_id='456', + expected_revision='456') + + def test_get_file_with_svn_and_revision(self): + """Testing Unfuddle get_file with Subversion and revision""" + self._test_get_file( + tool_name='Subversion', + revision='123', + base_commit_id=None, + expected_revision='123') + + def test_get_file_with_git_and_base_commit_id(self): + """Testing Unfuddle get_file with Git and base commit ID""" + self._test_get_file( + tool_name='Git', + revision='123', + base_commit_id='456', + expected_revision='456') + + def test_get_file_with_git_and_revision(self): + """Testing Unfuddle get_file with Git and revision""" + self._test_get_file( + tool_name='Git', + revision='123', + base_commit_id=None, + expected_revision=None, + expected_error=True) + + def test_get_file_exists_with_svn_and_base_commit_id(self): + """Testing Unfuddle get_file_exists with Subversion and base commit ID + """ + self._test_get_file_exists( + tool_name='Subversion', + revision='123', + base_commit_id='456', + expected_revision='456', + expected_found=True) + + def test_get_file_exists_with_svn_and_revision(self): + """Testing Unfuddle get_file_exists with Subversion and revision""" + self._test_get_file_exists( + tool_name='Subversion', + revision='123', + base_commit_id=None, + expected_revision='123', + expected_found=True) + + def test_get_file_exists_with_git_and_base_commit_id(self): + """Testing Unfuddle get_file_exists with Git and base commit ID""" + self._test_get_file_exists( + tool_name='Git', + revision='123', + base_commit_id='456', + expected_revision='456', + expected_found=True) + + def test_get_file_exists_with_git_and_revision(self): + """Testing Unfuddle get_file_exists with Git and revision""" + self._test_get_file_exists( + tool_name='Git', + revision='123', + base_commit_id=None, + expected_revision=None, + expected_found=False, + expected_error=True) + + def _test_get_file(self, tool_name, revision, base_commit_id, + expected_revision, expected_error=False): + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://mydomain.unfuddle.com/api/v1/repositories/2/' + 'download/?path=%s&commit=%s' + % (path, expected_revision)) + return 'My data', {} + + path = '/path' + account = self._get_hosting_account() + service = account.service + repository = Repository(hosting_account=account, + tool=Tool.objects.get(name=tool_name)) + repository.extra_data = { + 'unfuddle_account_domain': 'mydomain', + 'unfuddle_project_id': 1, + 'unfuddle_repo_id': 2, + 'unfuddle_repo_name': 'myrepo', + } + + account.data['password'] = encrypt_password('password') + + self.spy_on(service.client.http_get, call_fake=_http_get) + + if expected_error: + self.assertRaises( + FileNotFoundError, + lambda: service.get_file(repository, path, revision, + base_commit_id)) + self.assertFalse(service.client.http_get.called) + else: + result = service.get_file(repository, path, revision, + base_commit_id) + self.assertTrue(service.client.http_get.called) + self.assertEqual(result, 'My data') + + def _test_get_file_exists(self, tool_name, revision, base_commit_id, + expected_revision, expected_found=True, + expected_error=False): + def _http_get(service, url, *args, **kwargs): + self.assertEqual( + url, + 'https://mydomain.unfuddle.com/api/v1/repositories/2/' + 'history/?path=/path&commit=%s&count=0' + % expected_revision) + + if expected_found: + return '{}', {} + else: + raise HTTPError() + + account = self._get_hosting_account() + service = account.service + repository = Repository(hosting_account=account, + tool=Tool.objects.get(name=tool_name)) + repository.extra_data = { + 'unfuddle_account_domain': 'mydomain', + 'unfuddle_project_id': 1, + 'unfuddle_repo_id': 2, + 'unfuddle_repo_name': 'myrepo', + } + + account.data['password'] = encrypt_password('password') + + self.spy_on(service.client.http_get, call_fake=_http_get) + + result = service.get_file_exists(repository, '/path', revision, + base_commit_id) + + if expected_error: + self.assertFalse(service.client.http_get.called) + self.assertFalse(result) + else: + self.assertTrue(service.client.http_get.called) + self.assertEqual(result, expected_found) diff --git a/reviewboard/hostingsvcs/tests/test_version_one.py b/reviewboard/hostingsvcs/tests/test_version_one.py new file mode 100644 index 0000000000000000000000000000000000000000..68cd0a1fa877e925eb0e22e10477432023a6095d --- /dev/null +++ b/reviewboard/hostingsvcs/tests/test_version_one.py @@ -0,0 +1,25 @@ +from __future__ import unicode_literals + +from reviewboard.hostingsvcs.tests.testcases import ServiceTests + + +class VersionOneTests(ServiceTests): + """Unit tests for the VersionOne hosting service.""" + + service_name = 'versionone' + fixtures = ['test_scmtools'] + + def test_service_support(self): + """Testing the VersionOne service support capabilities""" + self.assertTrue(self.service_class.supports_bug_trackers) + self.assertFalse(self.service_class.supports_repositories) + + def test_bug_tracker_field(self): + """Testing the VersionOne bug tracker field value""" + self.assertFalse( + self.service_class.get_bug_tracker_requires_username()) + self.assertEqual( + self.service_class.get_bug_tracker_field(None, { + 'versionone_url': 'http://versionone.example.com', + }), + 'http://versionone.example.com/assetdetail.v1?Number=%s') diff --git a/reviewboard/hostingsvcs/tests/testcases.py b/reviewboard/hostingsvcs/tests/testcases.py new file mode 100644 index 0000000000000000000000000000000000000000..9493872c4294de852ded398f3df9315b4b33056a --- /dev/null +++ b/reviewboard/hostingsvcs/tests/testcases.py @@ -0,0 +1,75 @@ +from __future__ import unicode_literals + +from kgb import SpyAgency + +from reviewboard.hostingsvcs.models import HostingServiceAccount +from reviewboard.hostingsvcs.service import get_hosting_service +from reviewboard.testing import TestCase + + +class ServiceTests(SpyAgency, TestCase): + service_name = None + + def __init__(self, *args, **kwargs): + super(ServiceTests, self).__init__(*args, **kwargs) + + self.assertNotEqual(self.service_name, None) + self.service_class = get_hosting_service(self.service_name) + + def setUp(self): + super(ServiceTests, self).setUp() + self.assertNotEqual(self.service_class, None) + + def _get_repository_info(self, field, plan=None): + if plan: + self.assertNotEqual(self.service_class.plans, None) + result = None + + for plan_type, info in self.service_class.plans: + if plan_type == plan: + result = info[field] + break + + self.assertNotEqual(result, None) + return result + else: + self.assertEqual(self.service_class.plans, None) + self.assertTrue(hasattr(self.service_class, field)) + + return getattr(self.service_class, field) + + def _get_form(self, plan=None, fields={}): + form = self._get_repository_info('form', plan) + self.assertNotEqual(form, None) + + form = form(fields) + self.assertTrue(form.is_valid()) + + return form + + def _get_hosting_account(self, use_url=False, local_site=None): + if use_url: + hosting_url = 'https://example.com' + else: + hosting_url = None + + return HostingServiceAccount(service_name=self.service_name, + username='myuser', + hosting_url=hosting_url, + local_site=local_site) + + def _get_service(self): + return self._get_hosting_account().service + + def _get_repository_fields(self, tool_name, fields, plan=None, + with_url=False): + form = self._get_form(plan, fields) + account = self._get_hosting_account(with_url) + service = account.service + self.assertNotEqual(service, None) + + return service.get_repository_fields(username=account.username, + hosting_url='https://example.com', + plan=plan, + tool_name=tool_name, + field_vars=form.clean())