This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-0.9.x (aa76e12)

Summary

Add support for serializing django Models

Review Request #7821 — Created Dec. 22, 2015 and submitted 9 years, 6 months ago

Information

Owner

brennie*

Repository

Djblets

Branch

release-0.9.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description*

Django Models with a to_json method can now be serialized with the

DjbletsJSONEncoder. The to_json method should return a

JSON-serializable object (such a dict, list, or string) that will then

be serialized by the encoder. Unit tests have been added to test this

behaviour.

Testing Done


Ran unit tests.

Issues

Description	From	Last Updated
'Model' imported but unused	reviewbot	9 years, 6 months ago
Can we also add and callable(obj.to_json)?	david	9 years, 6 months ago
Docstring?	david	9 years, 6 months ago
Leftover debug output?	david	9 years, 6 months ago
This change is no longer necessary.	david	9 years, 6 months ago
local variable 'e' is assigned to but never used	reviewbot	9 years, 6 months ago
There are no open issues

Diff:

Revision 2 (+51 -6)

Show changes

	djblets/util/serializers.py
	djblets/util/tests.py
	djblets/webapi/encoders.py

djblets/util/serializers.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we also add and callable(obj.to_json)?
```
djblets/util/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Docstring?
```
djblets/webapi/encoders.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Leftover debug output?
```

Change Summary:

Address David's issues

Diff:

Revision 3 (+52 -6)

Show changes

	djblets/util/serializers.py
	djblets/util/tests.py
	djblets/webapi/encoders.py

Ship it!

djblets/webapi/encoders.py (Diff revision 3)
The issue has been resolved. Show all issues
```
This change is no longer necessary.
```

Tool: Pyflakes
Processed Files:
    djblets/util/tests.py
    djblets/util/serializers.py
    djblets/webapi/encoders.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/tests.py
    djblets/util/serializers.py
    djblets/webapi/encoders.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/tests.py
    djblets/util/serializers.py
    djblets/webapi/encoders.py



Tool: Pyflakes
Processed Files:
    djblets/util/tests.py
    djblets/util/serializers.py
    djblets/webapi/encoders.py

djblets/webapi/encoders.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'Model' imported but unused
```
djblets/webapi/encoders.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 local variable 'e' is assigned to but never used
```

Tool: PEP8 Style Checker
Processed Files:
    djblets/util/tests.py
    djblets/util/serializers.py
    djblets/webapi/encoders.py



Tool: Pyflakes
Processed Files:
    djblets/util/tests.py
    djblets/util/serializers.py
    djblets/webapi/encoders.py

Change Summary:

PEP8

Diff:

Revision 4 (+51 -5)

Show changes

	djblets/util/serializers.py
	djblets/util/tests.py

Branch:: release-0.9.x
release-0.8.x

Branch:: release-0.8.x
release-0.9.x

Status:: Completed
Change Summary:: Pushed to release-0.9.x (aa76e12)

Tool: Pyflakes
Processed Files:
    djblets/util/tests.py
    djblets/util/serializers.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/util/tests.py
    djblets/util/serializers.py

djblets/util/serializers.py (Diff revision 2)

djblets/util/tests.py (Diff revision 2)

djblets/webapi/encoders.py (Diff revision 2)

djblets/webapi/encoders.py (Diff revision 3)