Summary

Do not attempt to render uninstantiated fields

Review Request #7787 — Created Dec. 1, 2015 and submitted Dec. 3, 2015, 3:42 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

04ba860...

Reviewers

Groups

reviewboard

People

Description

Previously, an error in instantiating a ReviewRequestField would
lead to an error being logged, but the field would still be attempted to
be rendered. Since the instantiation failed, the variable would be
uninitialized leading to an UnboundLocalError.

Now, if the field cannot be insantiated, we skip to the next field in
the fieldset.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Dec. 1, 2015, 11:56 p.m.
You can use logging.exception instead, and skip the exc_info=1.	chipx86	Dec. 3, 2015, 2:18 p.m.
Swap these.	chipx86	Dec. 3, 2015, 2:18 p.m.
Missing a period.	chipx86	Dec. 3, 2015, 2:18 p.m.
No need for parens.	chipx86	Dec. 3, 2015, 2:18 p.m.
This will fail if the above raises an exception, since result won't be defined.	chipx86	Dec. 3, 2015, 2:21 p.m.
Can we verify the results of this, in case we ever get another logging call and somehow miss the intended …	chipx86	Dec. 3, 2015, 2:28 p.m.
'six' imported but unused	reviewbot	Dec. 3, 2015, 2:29 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/templatetags/tests.py
    reviewboard/reviews/templatetags/reviewtags.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/templatetags/tests.py
    reviewboard/reviews/templatetags/reviewtags.py

reviewboard/reviews/templatetags/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```

Diff:

Revision 2 (+61 -1)

Show changes

	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/reviews/templatetags/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/templatetags/tests.py
    reviewboard/reviews/templatetags/reviewtags.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/templatetags/tests.py
    reviewboard/reviews/templatetags/reviewtags.py

Ship it!

```
Ship It!
```

reviewboard/reviews/templatetags/reviewtags.py (Diff revision 2)
The issue has been resolved. Show all issues
```
You can use logging.exception instead, and skip the exc_info=1.
```
reviewboard/reviews/templatetags/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Swap these.
```
reviewboard/reviews/templatetags/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a period.
```
reviewboard/reviews/templatetags/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
No need for parens.
```
reviewboard/reviews/templatetags/tests.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This will fail if the above raises an exception, since result won't be defined.
```

reviewboard/reviews/templatetags/tests.py (Diff revision 2)

The issue has been resolved. Show all issues

Can we verify the results of this, in case we ever get another logging call and somehow miss the intended one?

Change Summary:

Address Christian's issues

Diff:

Revision 3 (+77 -5)

Show changes

	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/reviews/templatetags/tests.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/templatetags/tests.py
    reviewboard/reviews/templatetags/reviewtags.py



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/templatetags/tests.py
    reviewboard/reviews/templatetags/reviewtags.py

reviewboard/reviews/templatetags/tests.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 'six' imported but unused
```

Change Summary:

PEP8

Diff:

Revision 4 (+76 -5)

Show changes

	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/reviews/templatetags/tests.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/templatetags/tests.py
    reviewboard/reviews/templatetags/reviewtags.py



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/templatetags/tests.py
    reviewboard/reviews/templatetags/reviewtags.py

Commit:

04ba8608d50ad0bf5f3b7e2ea727c17c096eaa26

Diff:

Revision 5 (+76 -5)

Show changes

	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/reviews/templatetags/tests.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/templatetags/tests.py
    reviewboard/reviews/templatetags/reviewtags.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/templatetags/tests.py
    reviewboard/reviews/templatetags/reviewtags.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (c12a17e)