Summary

chown web-server files during installation

Review Request #7784 — Created Nov. 30, 2015 and discarded Sept. 14, 2021, 11:17 p.m.

Information

Owner

sgallagh

Repository

Review Board

Branch

master

Bugs

4033

Depends On

Reviewers

Groups

reviewboard

People

Description

If the user specifies --web-server-user on the `rb-site install`
CLI or a distribution packager has set a default web server user
in rb_platform.py, `rb-site install` will attempt to chown the
necessary web-facing directories and their contents to that user.

If it succeeds in chowning all such directories, `rb-site install`
will now suppress the summary lines telling the user what
directories need to be manually owned.

If it fails on one or more ownership changes (or if no ownership
change is attempted due to a lack of a user or running on Windows),
then the original notice of directories to update is displayed at
the end of installation.

Testing Done

I deployed several Review Board sites as root against a PostgreSQL database:

DEFAULT_WEB_SERVER_USER="" in rb_platform.py, --web-server-user=apache on the CLI
*- All appropriate directories were owned by apache:apache at the end of deployment. All other directories were owned by root.
DEFAULT_WEB_SERVER_USER="" in rb_platform.py, --web-server-user not on the CLI
*- All directories were owned by root at the end of deployment
DEFAULT_WEB_SERVER_USER="apache" in rb_platform.py, --web-server-user not on the CLI
*- All appropriate directories were owned by apache:apache at the end of deployment. All other directories were owned by root.

Issues

Description	From	Last Updated
Blank line between these.	chipx86	Dec. 10, 2015, 7:49 a.m.
I'd say "Change ownership of ...", plus a trailing period.	chipx86	Dec. 10, 2015, 7:49 a.m.
Sentence casing. Here and below.	chipx86	Dec. 10, 2015, 7:49 a.m.
This looks to be basically the same code. Can we iterate over itertools.chain(dirs, files)?	chipx86	Dec. 3, 2015, 5:31 p.m.
Blank line between these. Also, I'd prefer joined_path.	chipx86	Dec. 10, 2015, 7:52 a.m.
Blank line between these.	chipx86	Dec. 10, 2015, 7:53 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/cmdline/rbsite.py
    reviewboard/rb_platform.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/cmdline/rbsite.py
    reviewboard/rb_platform.py

Fix it!

reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been resolved. Show all issues
```
I'd say "Change ownership of ...", plus a trailing period.
```
reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Sentence casing. Here and below.
```

reviewboard/cmdline/rbsite.py (Diff revision 1)

An issue was opened. Show all issues

This looks to be basically the same code. Can we iterate over itertools.chain(dirs, files)?

sgallagh Dec. 10, 2015, 7:53 a.m.

Thanks, my python-foo is mediocre at best. Didn't know about that handy function.

reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
Also, I'd prefer joined_path.
```
reviewboard/cmdline/rbsite.py (Diff revision 1)
The issue has been dropped. Show all issues
```
Blank line between these.
```
1. sgallagh Dec. 10, 2015, 7:53 a.m.
  Dropped because this code was merged together with the earlier one.

Change Summary:

Changes requested during code-review.

Diff:

Revision 2 (+85 -10)

Show changes

	reviewboard/rb_platform.py
	reviewboard/cmdline/rbsite.py

Tool: Pyflakes
Processed Files:
    reviewboard/cmdline/rbsite.py
    reviewboard/rb_platform.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/cmdline/rbsite.py
    reviewboard/rb_platform.py