Fix a couple of bugs when using condensediffs.

Review Request #7773 — Created Nov. 17, 2015 and submitted

Information

Review Board
release-2.5.x

Reviewers

The condensediffs command had a couple of regressions that weren't
caught before release.

The first is that our loop to find RawFileDiffData objects was, upon
encountering an IntegrityError, attempting to look up the entry using
the wrong hash. We wanted to use the hash provided on that instance, but
were using a different value, leading to a DoesNotExist error.

The second is that our percentage for the progress bar was overly
accurate, showing the entire floating point number. It now shows an
integer value.

Ran condensediffs. Saw that the percentage was correct, and that we weren't
crashing anymore upon hitting IntegrityErrors.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/management/commands/condensediffs.py
        reviewboard/diffviewer/managers.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/management/commands/condensediffs.py
        reviewboard/diffviewer/managers.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.5.x (54ce471)