Summary

Correctly include "Ship It!" or "Fix it, then Ship it!" in e-mails

Review Request #7767 — Created Nov. 12, 2015 and submitted Nov. 13, 2015, 11:57 a.m.

Information

Owner

gmyers

Repository

Review Board

Branch

master

Bugs

4019

Depends On

Reviewers

Groups

reviewboard

People

Description

This patch resolves a regression introduced in 8f2dd35 which prevented
"Ship It!" and "Fix it, then Ship It!" headers from appearing in e-mails.

Testing Done


Prior to fix, confirmed lack of "Ship It!" and "Fix it, then Ship It!" in emails.  After fix, confirmed presence and correctness.  Also confirmed that reviews without a Ship It indication do not produce either header.
Ran units tests.

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/templates/notifications/review_email.txt
    reviewboard/templates/notifications/review_email.html



Tool: Pyflakes
Ignored Files:
    reviewboard/templates/notifications/review_email.txt
    reviewboard/templates/notifications/review_email.html

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (b4e0a36)