Add support for publishing with a message

Review Request #7763 — Created Nov. 9, 2015 and submitted

Information

RBTools
master
8854e97...

Reviewers

Both rbt post and rbt publish can now publish with a change
description. This change description supports markdown via the
--markdown flag used for summaries and descriptions.

Providing a change description before the review request is public will
not result in an error; instead the option will be ignored and an
informative message will be displayed to the user.

The publish command now also only fetches the required links and
fields when publishing to minimize the amount of data that is
transmitted.

  • Published with a message.
  • Verified that rbt publish -m provided an error message when the
    review request was not public.
Description From Last Updated

Can we have it so that this doesn't imply --publish, but just sets the text of the change description? I …

daviddavid

What happens if I specify this for a review request which is not yet public?

daviddavid

This could be much simpler: Publish the review request immediately after posting, but without sending an e-mail notification.

daviddavid

How about "The change description field can only be set when publishing an update. Use --description instead."

daviddavid

"Publish without sending an e-mail notification"?

daviddavid

Same here about recommending --description? Perhaps we should make these fail instead of just log?

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
        rbtools/commands/publish.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
        rbtools/commands/publish.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
        rbtools/commands/publish.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
        rbtools/commands/publish.py
    
    
  2. 
      
david
  1. 
      
  2. rbtools/commands/post.py (Diff revision 2)
     
     
     
     
     
     
     
     

    Can we have it so that this doesn't imply --publish, but just sets the text of the change description? I can see a use case for wanting to set it when posting but wanting to review before publishing, and it's easy enough to do -p -m XXX.

    It might make sense to also name the long option --change-description so that it matches up with the help for --markdown below.

  3. rbtools/commands/post.py (Diff revision 2)
     
     
     

    What happens if I specify this for a review request which is not yet public?

    1. It will end up as an API error.

    2. Can we show something nicer to the user?

  4. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
        rbtools/commands/publish.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
        rbtools/commands/publish.py
    
    
  2. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
        rbtools/commands/publish.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
        rbtools/commands/publish.py
    
    
  2. 
      
david
  1. 
      
  2. rbtools/commands/post.py (Diff revision 4)
     
     
     
     

    This could be much simpler:

    Publish the review request immediately after posting, but without sending an e-mail notification.
    
  3. rbtools/commands/post.py (Diff revision 4)
     
     
     

    How about "The change description field can only be set when publishing an update. Use --description instead."

  4. rbtools/commands/publish.py (Diff revision 4)
     
     
     

    "Publish without sending an e-mail notification"?

  5. rbtools/commands/publish.py (Diff revision 4)
     
     
     

    Same here about recommending --description? Perhaps we should make these fail instead of just log?

  6. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/commands/post.py
        rbtools/commands/publish.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/commands/post.py
        rbtools/commands/publish.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to master (673ca4e)
Loading...