• 
      

    Upgrade to CodeMirror 5.8

    Review Request #7745 — Created Oct. 29, 2015 and submitted

    Information

    Review Board
    release-2.6.x

    Reviewers

    This patch upgrades CodeMirror 5.8, which is the first released version
    to include the new custom style overrides for Markdown (see commit
    db3386f). This patch also brings in to line the requirements for using
    the landed version of the patch (instead of the original, unreviewed
    patch we were using before).

    Ran JS tests.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/staticbundles.py
      
      Ignored Files:
          reviewboard/static/lib/js/codemirror-5.5-custom.min.js
          reviewboard/static/lib/js/README.codemirror
          reviewboard/static/rb/js/ui/views/textEditorView.js
          reviewboard/static/lib/js/codemirror-5.8.min.js
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/staticbundles.py
      
      Ignored Files:
          reviewboard/static/lib/js/codemirror-5.5-custom.min.js
          reviewboard/static/lib/js/README.codemirror
          reviewboard/static/rb/js/ui/views/textEditorView.js
          reviewboard/static/lib/js/codemirror-5.8.min.js
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    david
    1. Oh, what branch are you intending this for?

    2. 
        
    brennie
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.6.x (e732406)