[WIP] Update accessibility for private review requests
Review Request #7705 — Created Oct. 16, 2015 and discarded
[WIP] Update accessibility for private review requests
| Description | From | Last Updated |
|---|---|---|
|
This is missing a "Returns" section. It should be like: """ ... Returns: bool: <description of the return type> """ |
|
|
|
Typo: "reviewers" should be "reviewer's". |
AD adriano | |
|
You don't really need this condition. If groups is empty, then Python will automatically avoid entering the body of the … |
AD adriano | |
|
undefined name 'silent' |
|
|
|
Col: 9 E303 too many blank lines (2) |
|
|
|
We usually surround our strings with single-quotes instead of double-quotes. |
AD adriano | |
|
The return is a conclusion. A new paragraph. It should have a blank line before it. |
|
|
|
Make this into a @property. |
|
|
|
Consider replacing this with: return not self.is_private() |
AD adriano | |
|
<li> is not allowed in a <span>. It needs to be the other way around. |
|
-
The design for this is going to need to change. It's not enough to stick the
privateflag inextra_data, because we can't query on it, and it's crucial that we can query on it, since otherwise private review requests will show up in the dashboard, All Review Requests page, search, etc.You'll need to make a new
privatefield on the model.You'll also need to update the
_queryfunction inreviewboard/reviews/managers.py(see theif filter_privatesection) to consider this field.
Tool: Pyflakes Processed Files: reviewboard/reviews/models/review_request.py Ignored Files: reviewboard/templates/reviews/review_detail.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/models/review_request.py Ignored Files: reviewboard/templates/reviews/review_detail.html