Enables the option for color to be displayed for warnings and errors.
Review Request #7704 — Created Oct. 16, 2015 and submitted — Latest diff uploaded
RBtools currently does not have the option for color to be displayed for warnings and errors.
I have changed the command-line UI, so that it defaults to color for warnings and errors, but
allows the user to disable the feature if they do not wish to use it.
I added logging.warning, logging.critical, and used a command that would give an error to see
if color would be displayed. After that I used the --no-color command to turn off the color off.
Also, I ran the unit tests and it passed them.
Diff Revision 5
This is not the most recent revision of the diff. The latest diff is revision 13. See what's changed.
orig
1
2
3
4
5
6
7
8
9
10
11
12
13
| setup.py | |||
|---|---|---|---|
| Revision 26c045a62096aa009f40b71b371a8c2fb44e5c3f | New Change | ||
| 43 lines | |||
| 44 |
(PACKAGE_NAME, VERSION[0], VERSION[1]) |
44 |
(PACKAGE_NAME, VERSION[0], VERSION[1]) |
| 45 |
else: |
45 |
else: |
| 46 |
download_url = "http://downloads.reviewboard.org/nightlies/" |
46 |
download_url = "http://downloads.reviewboard.org/nightlies/" |
| 47 | 47 | ||
| 48 | 48 | ||
| 49 |
install_requires = ['six>=1.8.0'] |
49 |
install_requires = ['colorlog', |
| 50 |
'six>=1.8.0'] |
||
| 50 | 51 | ||
| 51 | 52 | ||
| 52 |
# Make sure this is a version of Python we are compatible with. This should
|
53 |
# Make sure this is a version of Python we are compatible with. This should
|
| 53 |
# prevent people on older versions from unintentionally trying to install
|
54 |
# prevent people on older versions from unintentionally trying to install
|
| 54 |
# the source tarball, and failing.
|
55 |
# the source tarball, and failing.
|
| 77 lines | |||
| rbtools/commands/__init__.py |
|---|