• 
      

    Add support for Subversion and Perforce Assembla repositories.

    Review Request #7703 — Created Oct. 16, 2015 and submitted

    Information

    Review Board
    release-2.0.x

    Reviewers

    This introduces the ability to add Subversion and Perforce repositories
    hosted on Assembla. This service also offers Git, but lacks an API for
    properly communicating with Git repositories.
    
    Assembla requires a couple of specific Perforce settings, namely a
    P4HOST matching the given Assembla project name, and a P4CHARSET of
    "utf8".
    
    The Perforce support had to be updated to take a host, and the
    repository form had to be updated to give the hosting service more
    control of how data could be added to the repository.
    
    The Subversion support was updated to use the credentials from the
    hosting service, if available.

    Unit tests pass.

    Manually tested Perforce and Subversion repositories.

    Description From Last Updated

    local variable 'scmtool' is assigned to but never used

    reviewbotreviewbot

    local variable 'scmtool' is assigned to but never used

    reviewbotreviewbot
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/scmtools/tests.py
          reviewboard/scmtools/forms.py
          reviewboard/hostingsvcs/assembla.py
          setup.py
          reviewboard/scmtools/perforce.py
          reviewboard/scmtools/svn/__init__.py
          reviewboard/hostingsvcs/tests.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/scmtools/tests.py
          reviewboard/scmtools/forms.py
          reviewboard/hostingsvcs/assembla.py
          setup.py
          reviewboard/scmtools/perforce.py
          reviewboard/scmtools/svn/__init__.py
          reviewboard/hostingsvcs/tests.py
      
      
    2. reviewboard/hostingsvcs/tests.py (Diff revision 1)
       
       
      Show all issues
       local variable 'scmtool' is assigned to but never used
      
    3. reviewboard/hostingsvcs/tests.py (Diff revision 1)
       
       
      Show all issues
       local variable 'scmtool' is assigned to but never used
      
    4. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (4d37613)