Tool: PEP8 Style Checker
Processed Files:
    bot/reviewbot/tools/fbinfer.py
    bot/reviewbot/tools/cppcheck.py

Ignored Files:
    .idea/.name
    .idea/misc.xml
    .idea/ReviewBot.iml
    .idea/modules.xml
    .idea/vcs.xml
    .idea/workspace.xml

Col: 21
 E127 continuation line over-indented for visual indent

Col: 14
 E251 unexpected spaces around keyword / parameter equals

Col: 12
 E251 unexpected spaces around keyword / parameter equals

Col: 5
 E128 continuation line under-indented for visual indent

Col: 5
 E122 continuation line missing indentation or outdented

Col: 5
 E122 continuation line missing indentation or outdented

Col: 13
 E131 continuation line unaligned for hanging indent

Col: 15
 E251 unexpected spaces around keyword / parameter equals

Col: 13
 E251 unexpected spaces around keyword / parameter equals

Col: 17
 E251 unexpected spaces around keyword / parameter equals

Col: 15
 E251 unexpected spaces around keyword / parameter equals

Col: 9
 E123 closing bracket does not match indentation of opening bracket's line

Col: 1
 W391 blank line at end of file

Col: 1
 W391 blank line at end of file

You are going to want to add .idea to your global git ignore.

Unfortunately, this summary and description is difficult for us to work with, since we have to then look up or remember what your project is, and other students or contributors to Review Board will have no idea.
You should make sure that you have a detailed, informative review request. See https://www.reviewboard.org/docs/codebase/dev/writing-good-descriptions/

This shouldn't include any of the files under .idea.

Needs a docstring.

endswith can take a tuple of strings to check. I suggest defining a tuple of allowed file types on the class and passing that in. For example:

class FBINferTool(Tool):
    ...

    ALLOWED_EXTENSIONS = ('.java', '.c', '.h', '.m', '.mm')

    ...

    def handle_file(self, f):
        if not (f.dest_file.endswith(self.ALLOWED_EXTENSIONS)):
            ...

Blank line between these.

Looks like you're on the right path! The workers find installed tools through entry points, so you'll need to add a new entry-point for Infer in bot/setup.py before you can test it.

Can you revert this change? This typo is actually fixed already in master (but not release-0.2.x, which is why you're seeing this).

I believe the executable is actually just infer, instead of fbinfer.

infer instead of fbinfer.

Tool: PEP8 Style Checker
Processed Files:
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore
    .idea/misc.xml
    .idea/ReviewBot.iml
    .idea/modules.xml
    .idea/vcs.xml
    .idea/workspace.xml



Tool: Pyflakes
Processed Files:
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore
    .idea/misc.xml
    .idea/ReviewBot.iml
    .idea/modules.xml
    .idea/vcs.xml
    .idea/workspace.xml

Col: 21
 E127 continuation line over-indented for visual indent

Col: 1
 W391 blank line at end of file

The summary and description are going into the commit message, so they need to be self-describing and make sense independently of any code or other discussions taking place. You can reference this guide for some examples: https://www.reviewboard.org/docs/codebase/dev/writing-good-descriptions/

Looks like you should be ready to test the Infer tool this week!

The PyCharm-specific files should not be included in this review request. To remove the .idea/* files from this RR, you will probably need to do something like: 

git rm .idea/*
git commit -m "Removed IDEA files."
rbt post -r 7702

Can you remove the extra space between """ and Performs...?

Add a period at the end of this sentence.

Until you implement options for the infer executable, let's get rid of this variable altogether?

You can lose the outer parentheses here.

This can all be on one line.

This can be condensed down to a single statement:

line_num, col, msg = line.split(':', 3)[1:]

"Perform" (imperitive mood)
Also, this should read something like:

"""A ReviewBot tool for FBInfer.

FBInfer is a static analysis tool for mobile apps written in ObjC, Java, and C.
"""

Blank line between these.

... for mobile apps.

We don't wan't this running on all java, [obj]c[++] files, so there should probably be per-repository settings for the tool
(Forgive me if this is already a thing Review Bot does -- I'm not super familiar with it.)

We don't really need to coerce these to integers because we're not doing any processing with them.

Tool: Pyflakes
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore



Tool: PEP8 Style Checker
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore

Col: 21
 E127 continuation line over-indented for visual indent

Col: 1
 W391 blank line at end of file

Perhaps to avoid having to do all these repeated endswith() checks, we could instead get the extension and look it up in a precomputed dictionary. For example, something like:
import os

COMPILER_MAP = {
    '.java': 'javac',
    '.h': 'gcc',
    '.c': 'gcc',
    '.m': 'clang',
    '.mm': 'clang',
}

# ... other code goes here ...

def handle_file(self, f):
    extension = os.path.splitext(f.dest_file)[1]
    compiler = COMPILER_MAP.get(extension, None)

    if not compiler:
        return False

    path = f.get_patched_file_path()

    if not path:
        return False

    output = execute(
        [compiler, path],
        split_lines=True,
        ignore_errors=True
    )

    # ... rest of code goes here ...

"This tool performs..."

I would put this all on the next line.

This should be infer -- javac path

This should be infer -- gcc -c path

This should be infer -- clang path

This should not be in the project's .gitignore. This should be in your ~/.gitignore_global.

Remove this file.

Tool: Pyflakes
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore



Tool: PEP8 Style Checker
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore

Col: 21
 E127 continuation line over-indented for visual indent

Col: 1
 W391 blank line at end of file

Tool: PEP8 Style Checker
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore



Tool: Pyflakes
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore

 'logging' imported but unused

Col: 21
 E127 continuation line over-indented for visual indent

Col: 13
 E265 block comment should start with '# '

Col: 13
 E265 block comment should start with '# '

Col: 13
 E265 block comment should start with '# '

Col: 1
 W391 blank line at end of file

Tool: Pyflakes
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore



Tool: PEP8 Style Checker
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore

Col: 20
 W292 no newline at end of file

I think the addition of .idea to your .gitignore file shouldn't be commited to the repository and should instead remain only on your local setup.

One approach to doing this would be to revert this change, and once it's resolved, you can add both .idea to your ignore file, as well as .gitignore, that way changes done to it won't be tracked.

There may be a better way of doing this, but this is how I've done it before.

Tool: Pyflakes
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore



Tool: PEP8 Style Checker
Processed Files:
    bot/setup.py
    bot/reviewbot/tools/fbinfer.py

Ignored Files:
    .idea/.name
    .gitignore

 'logging' imported but unused

Col: 17
 E265 block comment should start with '# '

Col: 80
 E501 line too long (80 > 79 characters)

Col: 17
 E265 block comment should start with '# '