Change linenum color of diff viewer for better user visibility.
Review Request #7687 — Created Oct. 9, 2015 and submitted
I have changed the line number color of diff viewer for better user visibility. The color in diff viewer before was black by default and was a distraction to the actual code. I have made this line number color lighter and less noticable so that the code is easier to read.
Reloaded the page to see if the color had changed.
Fixed the order of code in diffviewer.less
Updated the diff-line-num to #444444
| Description | From | Last Updated |
|---|---|---|
|
Hmm. This color might still be too low contrast. Let's darken it a bit. |
 david
|
|
|
This is the same as after. I think you uploaded the wrong image because thats supposed to be black. |
 brennie
|
|
|
Instead of using transparency, can we just make this a medium grey color? Something like #777777? |
david
|
|
|
We should probably also add font-weight: normal to avoid the browser bolding everything. |
david
|
|
|
Should be in alphabetical order. |
 chipx86
|
-
Tool: Pyflakes Ignored Files: reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/diffviewer.less Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/diffviewer.less
-
Tool: Pyflakes Ignored Files: reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/diffviewer.less Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/diffviewer.less
-
Edward, I'm still waiting on you updating the description to be accurate (we're not using transparency anymore).
EK
- Description:
-
~ I change linenum color of diff viewer for better user visibility. Before, the line number color in diff viewer were all black and it wasn't as user friendly. I increased the transparency and made the color lighter.
~ I have changed the line number color of diff viewer for better user visibility. The color in diff viewer before was black by default and was not as user friendly. I have made this line number color lighter so that it is easier for the user to notice.
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/diffviewer.less Tool: Pyflakes Ignored Files: reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/diffviewer.less
-
I don't agree with this new description of the change. Making the line numbers lighter weight and a lighter color makes them less noticible, not more. The initial problem was that the heavy-weight numbers distracted from the real focus of the page, which should be the code itself.
EK
- Description:
-
~ I have changed the line number color of diff viewer for better user visibility. The color in diff viewer before was black by default and was not as user friendly. I have made this line number color lighter so that it is easier for the user to notice.
~ I have changed the line number color of diff viewer for better user visibility. The color in diff viewer before was black by default and was a distraction to the actual code. I have made this line number color lighter and less noticable so that the code is easier to read.
Tool: Pyflakes Ignored Files: reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/diffviewer.less Tool: PEP8 Style Checker Ignored Files: reviewboard/static/rb/css/defs.less reviewboard/static/rb/css/diffviewer.less