Summary

Handle case of no empty files

Review Request #7683 — Created Oct. 9, 2015 and submitted Oct. 9, 2015, 11:37 a.m.

Information

Owner

brennie

Repository

RBTools

Branch

release-0.7.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Mercurial's locate command will exit with status 1 when no files are
found. We use hg locate -r <REV> set:size(0) to locate empty files.
However, when there are no empty files, we will get None instead of
empty output because of Mercurial's status code. We now only try to
parse the list of files when there is output to avoid this issue.

Testing Done

Ran unit tests.

rbt post worked with this patch and didn't without it.

Tool: Pyflakes
Processed Files:
    rbtools/clients/mercurial.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/clients/mercurial.py

Ship it!

```
Ship It!
```

Description:: ~
Mercrial's locate command will return 1 if it finds no files for the sepcified query. This causes issues when looking for empty files because it is not guaranteed there are any. This patch will return an empty set of files instead of raising an exception.
~
Mercurial's locate command will exit with status 1 when no files are
+ found. We use hg locate -r <REV> set:size(0) to locate empty files.
+ However, when there are no empty files, we will get None instead of
+ empty output because of Mercurial's status code. We now only try to
+ parse the list of files when there is output to avoid this issue.
Testing Done:: ~
Ran hg locate -r <REV> set:size(n) for n = 0 and `
~
Ran unit tests.
+
+
rbt post worked with this patch and didn't without it.

Status:: Completed
Change Summary:: Pushed to release-0.7.x (6bbcecc)

~		Mercrial's locate command will return 1 if it finds no files for the sepcified query. This causes issues when looking for empty files because it is not guaranteed there are any. This patch will return an empty set of files instead of raising an exception.
	~	Mercurial's locate command will exit with status 1 when no files are
	+	found. We use `hg locate -r <REV> set:size(0)` to locate empty files.
	+	However, when there are no empty files, we will get `None` instead of
	+	empty output because of Mercurial's status code. We now only try to
	+	parse the list of files when there is output to avoid this issue.

~		Ran `hg locate -r <REV> set:size(n)` for `n = 0` and `
	~	Ran unit tests.
	+
	+	`rbt post` worked with this patch and didn't without it.