Summary

Allow extra_data__field_name params in update and create

Review Request #7669 — Created Oct. 1, 2015 and submitted Oct. 5, 2015, 1:09 p.m.

Information

Owner

brennie

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The resource create and update methods now accept keyword arguments
of the form extra_data__field_name which are rewritten to
extra_data.field_name so that Review Board can understand them. This
occurs because extra_data.field_name cannot be used as a keyword
argument, so all extra data field updates have to built into a dict,
which must then be splatted into the appropriate method.

Unit tests have been updated that cover both methods.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Blank line between these.	chipx86	Oct. 1, 2015, 6:31 p.m.
Hmm, we're repeating quite a bit of code here. Let's get all this moved into a utility function.	chipx86	Oct. 1, 2015, 6:31 p.m.

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/api/resource.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/api/resource.py

This will be a way more intuitive way to provide extra data. And the comment block is descriptive and easily understood.
Looks good to me. ^^

rbtools/api/resource.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between these.
```

rbtools/api/resource.py (Diff revision 1)

The issue has been resolved. Show all issues

Hmm, we're repeating quite a bit of code here. Let's get all this moved into a utility function.

Diff:

Revision 2 (+50 -2)

Show changes

	rbtools/api/resource.py
	rbtools/api/tests.py

Tool: Pyflakes
Processed Files:
    rbtools/api/tests.py
    rbtools/api/resource.py



Tool: PEP8 Style Checker
Processed Files:
    rbtools/api/tests.py
    rbtools/api/resource.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (e35445f)